Nick Ethier
c619e70d39
Merge pull request #5018 from hashicorp/f-executor-stats
...
executor: streaming stats api
2019-01-14 15:02:35 -05:00
Michael Schurter
1ca858fa92
Update client/allocrunner/taskrunner/stats_hook.go
...
Co-Authored-By: nickethier <ncethier@gmail.com>
2019-01-14 12:31:27 -05:00
Nick Ethier
fbd403df96
tr: stop stats collection on Exited hook
2019-01-14 12:30:14 -05:00
Nick Ethier
a4534779d3
qemu: missing gofmt
2019-01-13 16:06:56 -05:00
Michael Schurter
ff034ffbc9
Update drivers/qemu/driver_test.go
...
use t.Logf instead of fmt.Printf
Co-Authored-By: nickethier <ncethier@gmail.com>
2019-01-12 21:33:55 -05:00
Nick Ethier
597b7b751d
tr: add retry /w backoff to stats_hook failure
2019-01-12 12:18:24 -05:00
Nick Ethier
3b395d7100
drivers: plumb grpc client logger
2019-01-12 12:18:23 -05:00
Nick Ethier
7e306afde3
executor: fix failing stats related test
2019-01-12 12:18:23 -05:00
Nick Ethier
b0d9440474
docker: add test for stats collection
2019-01-12 12:18:22 -05:00
Nick Ethier
9fea54e0dc
executor: implement streaming stats API
...
plugins/driver: update driver interface to support streaming stats
client/tr: use streaming stats api
TODO:
* how to handle errors and closed channel during stats streaming
* prevent tight loop if Stats(ctx) returns an error
drivers: update drivers TaskStats RPC to handle streaming results
executor: better error handling in stats rpc
docker: better control and error handling of stats rpc
driver: allow stats to return a recoverable error
2019-01-12 12:18:22 -05:00
Preetha
f562a1d169
Merge pull request #5164 from hashicorp/b-client-addalloc-errhandle
...
Handle client initialization errors when adding/restoring allocs
2019-01-12 10:40:41 -06:00
Preetha Appan
9e8dbf6a4b
linting fixes
2019-01-12 10:38:20 -06:00
Preetha Appan
c94179578d
Make unit test for allocrunner failure much nicer
2019-01-12 10:38:20 -06:00
Preetha Appan
da0d083b03
Add unit test to simulate alloc runner creation failure
2019-01-12 10:38:20 -06:00
Preetha Appan
e7b59ac08c
Only set deployment health if not already set
2019-01-12 10:38:20 -06:00
Michael Schurter
dbf4c3a3c8
Apply suggestions from code review
...
Co-Authored-By: preetapan <preetha@hashicorp.com>
2019-01-12 10:38:20 -06:00
Preetha Appan
7bd1440710
REfactor statedb factory config to set it directly in client config
2019-01-12 10:38:20 -06:00
Preetha Appan
e237f19b38
Remove invalid allocs
2019-01-12 10:38:20 -06:00
Preetha Appan
f059ef8a47
Modified destroy failure handling to rely on allocrunner's destroy method
...
Added a unit test with custom statedb implementation that errors, to
use to verify destroy errors
2019-01-12 10:37:12 -06:00
Preetha Appan
6c95da8f67
Add back code to mark alloc as failed when restore fails
...
Also modify restore such that any handled errors don't propagate
back to the client
2019-01-12 10:37:12 -06:00
Preetha Appan
5fde0b0f5c
Revert code that made an alloc update when restore fails
...
Restore currently shuts down the client so the alloc update cant
always make it to the server
2019-01-12 10:37:12 -06:00
Preetha Appan
41bfdd764b
Handle client initialization errors when adding allocs or restoring allocs
...
We mark the alloc as failed and track failed allocs so that we don't send
updates after the first time
2019-01-12 10:37:12 -06:00
Danielle Tomlinson
6c0d30caa0
Merge pull request #5025 from hashicorp/dani/allocLockCleanup
...
client: Cleanup allocrunner access
2019-01-11 23:35:02 +01:00
Preetha
588e3401d0
Merge pull request #5181 from hashicorp/b-spread-weight
...
Make spread weight a pointer with default value if unset
2019-01-11 13:17:00 -06:00
Danielle Tomlinson
3e586e93da
client: Cleanup allocrunner access
2019-01-11 18:39:18 +01:00
Preetha Appan
b46728a88b
Make spread weight a pointer with default value if unset
2019-01-11 10:31:21 -06:00
Mahmood Ali
d2aeeee200
Merge pull request #5175 from hashicorp/c-re-enable-tests
...
Re-enable client and java skipped tests
2019-01-11 10:08:16 -05:00
Preetha
746aa14bf5
Merge pull request #5179 from hashicorp/b-fix-deprecated-resources
...
Remove unnecessary usage of alloc.Resource
2019-01-10 17:31:00 -06:00
Preetha
2c358b4078
Merge pull request #5144 from hashicorp/f-spread-docs
...
Docs for spread stanza
2019-01-10 16:38:39 -06:00
Preetha Appan
3b054d6135
Remove unnecessary usage of alloc.Resource
2019-01-10 16:36:47 -06:00
Preetha
67c37623f5
Merge pull request #5178 from hashicorp/blalor-patch-1
...
Oxford comma in variable interpolation summary
2019-01-10 16:11:18 -06:00
Preetha Appan
602db06fad
Address review comments
2019-01-10 15:46:03 -06:00
Brian Lalor
337a6befa1
Oxford comma in variable interpolation summary
...
This improves the readability of this section.
2019-01-10 16:15:41 -05:00
Mahmood Ali
b7d421a149
tests: WaitForRunning checks for pending only
...
WaitForRunning risks a race condition where the allocation succeeds and
completes before WaitForRunning is called (or while it is running).
Here, I made the behavior match the function documentation.
I considered making it stricter, but callers need to account for
allocation terminating immediately after WaitForRunning terminates
anyway.
2019-01-10 15:36:57 -05:00
Mahmood Ali
fc216d9bad
Merge pull request #5176 from hashicorp/r-rm-validation-tests
...
tests: remove tests for unsupported features
2019-01-10 12:41:48 -05:00
Preetha Appan
7614f841b0
Spread json docs
2019-01-10 11:10:04 -06:00
Preetha Appan
12dddcc525
Initial spread docs
2019-01-10 11:10:04 -06:00
Mahmood Ali
4414a2ce1c
tests: remove tests for unsupported features
...
With switching to driver plugins, driver validation is quite tricky and
we need to do some design thinking before supporting it against.
2019-01-10 10:21:48 -05:00
Mahmood Ali
614f63f40d
drivers/java: use libcontainer executor on java linux
2019-01-10 10:10:40 -05:00
Mahmood Ali
9740443703
tests: ignore _JAVA_OPTIONS line
...
ignore _JAVA_OPTIONS line in `java -version`, as it's relevant.
2019-01-10 10:10:40 -05:00
Mahmood Ali
c3eaa0f4c8
tests: enable and fix tests requiring mock driver
2019-01-10 10:10:11 -05:00
Chris Baker
1c2fec824f
Merge pull request #5158 from hashicorp/f-1157-validate-node-meta-variables
...
added validation on client metadata keys
2019-01-09 16:37:57 -05:00
Alex Dadgar
bd12e0b1f7
Merge pull request #5168 from hashicorp/b-kill-race
...
Improve Kill handling on task runner
2019-01-09 12:05:10 -08:00
Alex Dadgar
069e181e8f
add more comments
2019-01-09 12:04:22 -08:00
Michael Schurter
e5ddff861c
Spelling fix
...
Co-Authored-By: dadgar <alex@hashicorp.com>
2019-01-09 11:42:40 -08:00
Chris Baker
e9db2ae822
Merge branch 'master' of github.com:hashicorp/nomad into f-1157-validate-node-meta-variables
2019-01-09 18:56:49 +00:00
Chris Baker
d5b1a56f3b
increased config validation coverage for dev mode
2019-01-09 18:56:40 +00:00
Michael Schurter
ac169008f0
Merge pull request #5045 from hashicorp/b-drivermanager-tests-drain
...
drain: fix node drain monitoring
2019-01-09 10:23:28 -08:00
Mahmood Ali
5389ebae41
Merge pull request #5166 from hashicorp/b-docker-tests-mac
...
tests: run docker tests in macOS out of box
2019-01-09 13:07:37 -05:00
Mahmood Ali
b08f59cdda
Merge pull request #5162 from hashicorp/f-extract-lxc
...
Extract LXC from nomad
2019-01-09 13:07:05 -05:00