luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Make unit test for allocrunner failure much nicer

This commit is contained in:
Preetha Appan 2019-01-11 10:58:43 -06:00
parent da0d083b03
commit c94179578d
No known key found for this signature in database
GPG Key ID: 9F7C19990A50EAFC
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
client/client_test.go
View File

@ -754,6 +754,10 @@ func TestClient_AddAllocError(t *testing.T) {
}
alloc1.ClientStatus = structs.AllocClientStatusPending
// Set these two fields to nil to cause alloc runner creation to fail
alloc1.AllocatedResources = nil
alloc1.TaskResources = nil
state := s1.State()
err := state.UpsertJob(100, job)
require.Nil(err)
@ -764,9 +768,13 @@ func TestClient_AddAllocError(t *testing.T) {
err = state.UpsertAllocs(102, []*structs.Allocation{alloc1})
require.Nil(err)
// Manipulate state store alloc to make its task group invalid
stateStoreAlloc, _ := s1.State().AllocByID(nil, alloc1.ID)
stateStoreAlloc.TaskGroup = "invalid"
// Push this alloc update to the client
allocUpdates := &allocUpdates{
pulled: map[string]*structs.Allocation{
alloc1.ID: alloc1,
},
}
c1.runAllocs(allocUpdates)
// Ensure the allocation has been marked as invalid and failed on the server
testutil.WaitForResult(func() (bool, error) {
@ -780,8 +788,6 @@ func TestClient_AddAllocError(t *testing.T) {
if !isInvalid {
return false, fmt.Errorf("expected alloc to be marked as invalid")
}
// Make the task group name valid again so that the client update to mark it failed works
stateStoreAlloc.TaskGroup = "web"
alloc, err := s1.State().AllocByID(nil, alloc1.ID)
require.Nil(err)
failed := alloc.ClientStatus == structs.AllocClientStatusFailed