8513b3cccb
Comment public functions and batch write txn
2018-11-12 16:09:39 -05:00
7ef126a027
Smaller methods, and added tests for RPC layer
2018-11-10 17:37:33 -06:00
75662b50d1
Use response object/querymeta/writemeta in scheduler config API
2018-11-10 10:31:10 -06:00
9c0a15f3ce
Run job deregistering in a single transaction
...
Fixes https://github.com/hashicorp/nomad/issues/4299
Upon investigating this case further, we determined the issue to be a race between applying `JobBatchDeregisterRequest` fsm operation and processing job-deregister evals.
Processing job-deregister evals should wait until the FSM log message finishes applying, by using the snapshot index. However, with `JobBatchDeregister`, any single individual job deregistering was applied accidentally incremented the snapshot index and resulted into processing job-deregister evals. When a Nomad server receives an eval for a job in the batch that is yet to be deleted, we accidentally re-run it depending on the state of allocation.
This change ensures that we delete deregister all of the jobs and inserts all evals in a single transactions, thus blocking processing related evals until deregistering complete.
2018-11-09 22:35:26 -05:00
3739713ce1
Merge pull request #4839 from hashicorp/b-gc-alloc-jobversion
...
Remove terminal allocations associated with older job modify index
2018-11-09 12:21:42 -06:00
39072977d6
Use create index as trigger condition to gc old terminal allocs
2018-11-09 11:44:21 -06:00
2f06d88f47
Merge pull request #4847 from hashicorp/b-blocked-eval
...
Blocked evaluation fixes
2018-11-08 13:40:01 -08:00
98398a8a44
Merge pull request #4842 from hashicorp/b-deployment-progress-deadline
...
Fix multiple bugs with progress deadline handling
2018-11-08 13:31:54 -08:00
991791a513
typo fix
2018-11-08 13:28:27 -08:00
be54e56570
review fixes
2018-11-08 09:48:36 -08:00
5f0a9d2cfd
Show preemption output in plan CLI
2018-11-08 09:48:43 -06:00
dbb05357bc
fix test
2018-11-07 11:59:24 -08:00
36abd3a3d8
review comments
2018-11-07 10:33:22 -08:00
e3cbb2c82e
allocs fit checks if devices get oversubscribed
2018-11-07 10:33:22 -08:00
4f9b3ede87
Split device accounter and allocator
2018-11-07 10:32:03 -08:00
6fa893c801
affinities
2018-11-07 10:32:03 -08:00
feb83a2be3
assign devices
2018-11-07 10:32:03 -08:00
2d2248e209
Add devices to allocated resources
2018-11-07 10:32:03 -08:00
b1c5d52817
Track jobs by namespace
2018-11-07 10:22:08 -08:00
6d8bb3a7bd
Duplicate blocked evals cancelling improved
...
The old logic for cancelling duplicate blocked evaluations by job id had
the issue where the newer evaluation could have additional node classes
that it is (in)eligible for that we would not capture. This could make
it such that cluster state could change such that the job would make
progress but no evaluation was unblocked.
2018-11-07 10:08:23 -08:00
a9aec7e628
Fix failing resource subtraction test
2018-11-06 12:26:26 -06:00
261aae32b1
more robust merging of the deployment status when getting updates from the client
2018-11-05 16:39:09 -08:00
1c31970464
Fix multiple tgs with progress deadline handling
...
Fix an issue in which the deployment watcher would fail the deployment
based on the earliest progress deadline of the deployment regardless of
if the task group has finished.
Further fix an issue where the blocked eval optimization would make it
so no evals were created to progress the deployment. To reproduce this
issue, prior to this commit, you can create a job with two task groups.
The first group has count 1 and resources such that it can not be
placed. The second group has count 3, max_parallel=1, and can be placed.
Run this first and then update the second group to do a deployment. It
will place the first of three, but never progress since there exists a
blocked eval. However, that doesn't capture the fact that there are two
groups being deployed.
2018-11-05 16:06:17 -08:00
6fdc84cce3
add comment
2018-11-02 18:11:36 -05:00
a6b714b81c
update preemption tests to use new node resource structs
...
also includes a fix to remove unnecessary subtraction of network mbits
2018-11-02 17:59:53 -05:00
b2b52b1ada
Merge pull request #4794 from hashicorp/f-preemption-systemjobs
...
Preemption for system jobs
2018-11-02 16:28:06 -05:00
c33469157d
unit test plan apply with preemptions
2018-11-01 20:06:32 -05:00
57fe5050f0
more minor review feedback
2018-11-01 17:05:17 -05:00
fd60e66f86
Plumb alloc resource cache in a few more places.
...
also removed now unused method
2018-11-01 16:44:43 -05:00
e586817ce7
batch jobs GC removes terminal allocs if job modifyindex is older than running job
2018-11-01 00:05:31 -05:00
9da19c6450
address review comments
2018-10-30 13:58:52 -04:00
4937095389
Allow artifacts checksum interpolation
...
Fixes https://github.com/hashicorp/nomad/issues/4814
2018-10-30 13:24:30 -04:00
f1c3eb2792
Introduce interface with multiple implementations for resource distance
2018-10-30 11:06:32 -05:00
8f7eb61823
Introduce a response object for scheduler configuration
2018-10-30 11:06:32 -05:00
1a5421f5d7
more minor cleanup
2018-10-30 11:06:32 -05:00
0494a098ce
More style and readablity fixes from review
2018-10-30 11:06:32 -05:00
1415032c13
More review comments
2018-10-30 11:06:32 -05:00
b97f85e3e0
style fixes
2018-10-30 11:06:32 -05:00
12278527c7
make default config a variable
2018-10-30 11:06:32 -05:00
32cc764072
Add fsm layer tests
2018-10-30 11:06:32 -05:00
7b8156fc47
Restore/Snapshot plus unit tests for scheduler configuration
2018-10-30 11:06:32 -05:00
8807c25b11
Modify preemption code to use new style of resource structs
2018-10-30 11:06:32 -05:00
c1c1c230e4
Make preemption config a struct to allow for enabling based on scheduler type
2018-10-30 11:06:32 -05:00
bd34cbb1f7
Support for new scheduler config API, first use case is to disable preemption
2018-10-30 11:06:32 -05:00
3190a2c29b
Fix linting
2018-10-30 11:06:32 -05:00
eb38488d08
Fix logic bug, unit test for plan apply method in state store
2018-10-30 11:06:32 -05:00
9e4a35fff0
Fix comment
2018-10-30 11:06:32 -05:00
cc295b90de
Implement preemption for system jobs.
...
This commit implements an allocation selection algorithm for finding
allocations to preempt. It currently special cases network resource asks
from others (cpu/memory/disk/iops).
2018-10-30 11:06:32 -05:00
d11064d6ba
structs and API changes to plan and alloc structs needed for preemption
2018-10-30 11:06:32 -05:00
9257387a69
Add number of evictions to DesiredUpdates struct to use in CLI/API
2018-10-30 11:06:32 -05:00
5ff4b8e36f
REview feedback
2018-10-30 11:06:32 -05:00
5b3bfb63eb
structs and API changes to plan and alloc structs needed for preemption
2018-10-30 11:06:32 -05:00
5d49832de4
tests: fix usages of TestClient cleanup and mock driver
2018-10-29 14:21:05 -07:00
e060174130
ar: fix leader handling, state restoring, and destroying unrun ARs
...
* Migrated all of the old leader task tests and got them passing
* Refactor and consolidate task killing code in AR to always kill leader
tasks first
* Fixed lots of issues with state restoring
* Fixed deadlock in AR.Destroy if AR.Run had never been called
* Added a new in memory statedb for testing
2018-10-19 09:45:45 -07:00
6f0ed6184b
Fix client reloading and pass the plugin loaders to server and client
2018-10-16 16:56:55 -07:00
a4b4d7b266
consul service hook
...
Deregistration works but difficult to test due to terminal updates not
being fully implemented in the new client/ar/tr.
2018-10-16 16:53:29 -07:00
e401c660e7
Implement lifecycle hooks on the task runner
2018-10-16 16:53:29 -07:00
a78cefec18
use int64
2018-10-16 15:34:32 -07:00
7c0d8c646c
Change CPU/Disk/MemoryMB to int everywhere in new resource structs
2018-10-16 16:21:42 -05:00
f5a76d8411
review comments
2018-10-15 15:31:13 -07:00
f9b056e1d1
Replace attributes map with new Attribute object
2018-10-13 14:08:58 -07:00
04ba425dd5
validate constraints/affinities
2018-10-13 12:27:49 -07:00
9b5aaac410
Device feasability checker
2018-10-13 12:27:49 -07:00
bfb4caa2e7
node devices
2018-10-13 12:27:49 -07:00
5a07f9f96e
parse affinities and constraints on devices
2018-10-11 14:05:19 -07:00
a2a56a930c
Diff
2018-10-08 17:02:58 -07:00
6b08b9d6b6
Define device request structs
2018-10-08 15:38:03 -07:00
01f8e5b95f
renames
2018-10-04 14:57:25 -07:00
52f9cd7637
fixing tests
2018-10-04 14:26:19 -07:00
bac5cb1e8b
Scheduler uses allocated resources
2018-10-02 17:08:25 -07:00
147d2430a1
allocated resources structs
2018-09-29 18:47:28 -07:00
5c8697667e
Node reserved resources
2018-09-29 18:44:55 -07:00
3183153315
Node resources on client
2018-09-29 17:23:41 -07:00
9b793531d6
Merge pull request #4720 from hashicorp/b-jet-fixes
...
Series of scheduler fixes / debugging enhancements
2018-09-25 13:25:11 -07:00
bd420692f3
fix logging
2018-09-25 10:49:55 -07:00
86e725e84c
Added logging around nacked evals in the scheduler worker
2018-09-25 10:49:02 -07:00
6a21f9fe96
Unique TriggerBy for blocked evals
...
Give blocked evals a unique triggerby reason to make debugging a chain
of evaluations easier.
2018-09-24 14:47:49 -07:00
e1a102f58c
test allocs fit
2018-09-24 13:59:01 -07:00
d7f5be9148
Better comment on snapshotindex
2018-09-24 13:53:43 -07:00
99498da6ed
Denormalize jobs in plan and ignore resources of terminal allocs
...
Denormalize jobs in AppendAllocs:
AppendAlloc was originally only ever called for inplace upgrades and new
allocations. Both these code paths would remove the job from the
allocation. Now we use this to also add fields such as FollowupEvalID
which did not normalize the job. This is only a performance enhancement.
Ignore terminal allocs:
Failed allocations are annotated with the followup Eval ID when one is
created to replace the failed allocation. However, in the plan applier,
when we check if allocations fit, these terminal allocations were not
filtered. This could result in the plan being rejected if the node would
be overcommited if the terminal allocations resources were considered.
2018-09-24 13:53:43 -07:00
de442226ae
Fix other instances of blocking queries
2018-09-24 13:52:39 -07:00
7f0d241ef4
always handle failed allocation
2018-09-21 15:13:54 -07:00
b2449ae1ce
Fix deployment watcher index usage
...
Fixes three issues:
1. Retrieving the latest evaluation index was not properly selecting the
greatest index. This would undermine checks we had to reduce the number
of evaluations created when the latest eval index was greater than any
alloc change
2. Fix an issue where the blocking query code was using the incorrect
index such that the index was higher than necassary.
3. Special case handling of blocked evaluation since the create/snapshot
index is no particularly useful since they can be reblocked.
2018-09-21 13:59:11 -07:00
5009566503
do not bootstrap with non voters
2018-09-19 17:17:39 -07:00
e8f89597f5
fix rpc test
2018-09-19 10:17:54 -07:00
9971b3393f
yamux
2018-09-17 14:22:40 -07:00
b2f500b48c
Serf/Raft/Memberlist logger
2018-09-17 13:57:52 -07:00
ca28afa3b2
small fixes
2018-09-15 16:42:38 -07:00
3c19d01d7a
server
2018-09-15 16:23:13 -07:00
7739ef51ce
agent + consul
2018-09-13 10:43:40 -07:00
996484981c
Fix panic when reschedule policy for allocation can't be looked up
...
because its task group changed
2018-09-05 17:01:02 -05:00
4f89cabd34
Merge pull request #4631 from hashicorp/f-plugin-config
...
Parse plugin configs
2018-09-04 17:04:13 -07:00
cc92cd92cd
Merge pull request #4642 from hashicorp/b-vet
...
Fix vet errors and use newer go version in travis
2018-09-04 17:04:02 -07:00
c6576ddac1
Fix make check errors
2018-09-04 16:03:52 -07:00
26288b9522
Fix more review feedback
2018-09-04 16:10:11 -05:00
751c0eb5a5
code review feedback
2018-09-04 16:10:11 -05:00
4f8e925b54
Move topk and delay heap to separate packages under lib
2018-09-04 16:10:11 -05:00
9bc0962527
Track top k nodes by norm score rather than top k nodes per scorer
2018-09-04 16:10:11 -05:00
6ed527c636
Use heap to store top K scoring nodes.
...
Scoring metadata is now aggregated by scorer type to make it easier
to parse when reading it in the CLI.
2018-09-04 16:10:11 -05:00
dd5fe6373f
Fix scoring logic for uneven spread to incorporate current alloc count
...
Also addressed other small code review comments
2018-09-04 16:10:11 -05:00
e72c0fe527
more cleanup
2018-09-04 16:10:11 -05:00
92d37acc2a
comment and formatting cleanup
2018-09-04 16:10:11 -05:00
5812f906c8
Allow empty spread targets, and validate target percentages.
2018-09-04 16:10:11 -05:00
71bff00326
validate spread from job/task group validate methods
2018-09-04 16:10:11 -05:00
fbd0004707
Fix warnings
2018-09-04 16:10:11 -05:00
5eb82b6260
Validate method, and rename ratio field to percent
2018-09-04 16:10:11 -05:00
0037d72fa8
Structs and validation for spread
2018-09-04 16:10:11 -05:00
c407e3626f
More review comments
2018-09-04 16:10:11 -05:00
dbbb4a957a
Fail validation if system job has affinities
2018-09-04 16:10:11 -05:00
0bc030c6fb
Treat set_contains as a synonym of set_contains_all
2018-09-04 16:10:11 -05:00
e85a721cfb
Include affinities in job and task diff, and more test cases
2018-09-04 16:10:11 -05:00
f06c7ab2ad
Fix Copy method for job and task to include affinities
2018-09-04 16:10:11 -05:00
9f0caa9c3d
Affinity parsing, api and structs
2018-09-04 16:10:11 -05:00
9e29cfee76
Use readlock
2018-09-04 11:45:05 -05:00
062e5f1898
Use eval broker lock when reading/modifying delay heap
2018-08-31 10:59:48 -05:00
bff1669ee4
Plugin config parsing
2018-08-29 17:06:01 -07:00
0a69cdb304
Merge pull request #4565 from hashicorp/b-compare-cert-alg
...
Error if TLS Certificate signature algorithm isn't supported in cipher suites
2018-08-15 16:09:46 -04:00
8d747578e8
Close multiplexer when context is cancelled
...
Multiplexer continues to create rpc connections even when
the context which is passed to the underlying rpc connections
is cancelled by the server.
This was causing #4413 - when a SIGHUP causes everything to reload,
it uses context to cancel the underlying http/rpc connections
so that they may come up with the new configuration.
The multiplexer was not being cancelled properly so it would
continue to create rpc connections and constantly fail,
causing communication issues with other nomad agents.
Fixes #4413
2018-08-13 19:32:49 -04:00
31d6d00381
add simple getter for certificate
2018-08-10 12:37:21 -04:00
444ee45aff
Parametrized/periodic jobs per child tagged metric emmision
2018-06-21 10:40:56 +03:00
b61051b3cd
Merge pull request #4409 from hashicorp/r-client-packages
...
Refactor client packages
2018-06-13 17:32:25 -07:00
300b1a7a15
Tests only use testlog package logger
2018-06-13 15:40:56 -07:00
03075b603a
Merge pull request #4399 from hashicorp/r-reload-refactor
...
Refactor logic for dynamic reloading
2018-06-13 13:35:12 -04:00
d0043691fb
remove structs + bump version
2018-06-11 13:52:19 -07:00
af5753d2cd
bump version + generated files
2018-06-11 13:39:42 -07:00
e75e3ae665
nomad: use require pkg for tests
2018-06-11 13:50:50 -04:00
50c72adbd7
nomad: code review comments
2018-06-11 13:27:48 -04:00
a581cc9c01
nomad/structs: fix job diff test
2018-06-11 13:06:49 -04:00
41e010cdc2
nomad: add 'Dispatch' field to Job
...
New -bash: Dispatch: command not found field is used to denote if the Job is a child dispatched job of
a parameterized job.
2018-06-11 11:59:03 -04:00
de03ce8070
move logic to determine whether to reload tls configuration to tlsutil helper
2018-06-08 14:33:58 -04:00
d738976234
Merge pull request #4395 from hashicorp/b-vault-second
...
Fix for dynamically reloading vault
2018-06-07 18:03:00 -04:00
dcc9cdfeb7
fixup! comment and move to always log server reload operation
2018-06-07 17:12:36 -04:00
41e35edf0c
fix test that now requires different config for test assertions
2018-06-07 17:07:06 -04:00
9f6bd7bf3a
move logic for testing equality for vault config
2018-06-07 16:23:50 -04:00
282f37b1ee
fix for dynamically reloading vault
2018-06-07 15:34:18 -04:00
2555bff4f5
nomad: add error check in test
2018-06-06 14:08:42 -04:00
d35bf6d184
nomad: handle edge case where node drain event shouldn't be emitted
2018-06-06 14:02:10 -04:00
23cd56dc78
remove generated structs
2018-06-01 16:11:28 -07:00
c0386819b3
bump version/lint/generated files
2018-06-01 15:23:10 -07:00
4134fcd2c7
Fix test setup for FSMSnapshotRestore_Deployments to use a valid job that exists
2018-05-31 14:39:39 -05:00
7f25fcc1bd
Merge pull request #4354 from hashicorp/b-job-modify
...
Deployment adds JobSpecModifyIndex
2018-05-31 17:57:38 +00:00
f2b2e0482b
code review fixes
2018-05-31 10:57:08 -07:00
c2291a4cf7
Merge pull request #4349 from hashicorp/b-reconcile-raft-upgrade
...
Remove an unnecessary check in nomad member reconciliation
2018-05-30 13:17:38 -07:00
92777a8018
Merge pull request #4329 from hashicorp/b-leaked-deployments
...
Clean up leaked deployments on restoration
2018-05-30 20:06:03 +00:00
6ec6bcdd87
Merge pull request #4352 from hashicorp/b-update-drain-no-drainstrategy
...
fix bug with node eligibility staying disabled even after drain is disabled
2018-05-30 11:48:48 -07:00
195e19827b
Deployment adds JobSpecModifyIndex
...
Deployment tracks the Job.JobModifyIndex so that PUTS against /v1/jobs
can be more easily coorelated with the created deployment.
Fixes https://github.com/hashicorp/nomad/issues/4301
2018-05-30 11:33:56 -07:00
c896a85a96
better test comment
2018-05-30 13:05:15 -05:00
647ccc2dc3
fix bug where disabling a node drain when there is no drain strategy set causes scheduling eligibility to stay ineligible
2018-05-30 12:28:46 -05:00
ad3dbe8ed0
Merge pull request #4338 from hashicorp/tls_prefer_server_cipher_suites
...
Add support for tls PreferServerCipherSuites
2018-05-30 17:25:17 +00:00
2fd20310ea
Remove checks in member reconcile that was causing servers in protocol 3 to not change their ID in raft forever
2018-05-30 11:34:45 -05:00
19e4a5489b
add support for tls PreferServerCipherSuites
...
add further tests for tls configuration
2018-05-25 13:20:00 -04:00
15a71cc16e
Merge pull request #4331 from capone212/b-3595-fix-heartbeat
...
Fixed #3595
2018-05-25 00:57:03 +00:00
a0d4d4a336
Fixed #3595 ( https://github.com/hashicorp/nomad/issues/3595 )
...
Stopping heartbeat timer before remove
2018-05-24 13:15:06 +00:00
352f2e03b5
Clean up leaked deployments on restoration
...
This PR cancels deployments that are active but do not have a job
associated with them. This is a broken invariant that causes issues in
the deployment watcher since it will not track them. Thus they are
objects that can't be operated on or cleaned up.
Fixes https://github.com/hashicorp/nomad/issues/4286
2018-05-23 16:44:21 -07:00
38f611a7f2
refactor NewTLSConfiguration to pass in verifyIncoming/verifyOutgoing
...
add missing fields to TLS merge method
2018-05-23 18:35:30 -04:00
c268640c02
Fix noisy log
2018-05-22 14:45:34 -07:00
21c5ed850d
Register events
2018-05-22 14:06:33 -07:00
17aac1c9de
node heartbeat missed event
2018-05-22 14:05:46 -07:00
1fe9cb4f00
update error message
2018-05-22 14:04:59 -07:00
5f2080bc26
Emit events based on eligibility
2018-05-22 14:04:59 -07:00
86be50fa05
Merge pull request #4284 from hashicorp/f-drain-event
...
Emit Node Events for draining
2018-05-22 21:04:18 +00:00
b6ecb75af9
update error message
2018-05-22 14:01:43 -07:00
b409a3ed5b
Merge pull request #4313 from hashicorp/b-alloc-gc-desiredstate
...
Check allocation's desired state in GC eligibility logic
2018-05-21 16:49:49 -07:00
159888a856
Merge pull request #4274 from hashicorp/f-force-rescheduling
...
Add CLI and API support for forcing rescheduling of failed allocs
2018-05-21 16:24:22 -07:00
a9d63c0df3
Check allocation's desired state in GC eligibility logic in core scheduler
2018-05-21 13:28:31 -05:00
687c26093c
Merge pull request #4269 from hashicorp/f-tls-remove-weak-standards
...
Configurable TLS cipher suites and versions; disallow weak ciphers
2018-05-11 08:11:46 -04:00
9a2237bdab
Drain complete
2018-05-10 17:22:06 -07:00
0cb31feb1f
Add node event when draining is set/removed/updated
2018-05-10 16:54:43 -07:00
a35248d1d8
Plumb event via FSM
2018-05-10 16:30:54 -07:00
bfa0937bbb
Code review feedback
2018-05-10 14:42:24 -05:00
ca5758741b
Update serf to pick up graceful leave fix
2018-05-10 11:16:24 -05:00
620558c107
log error if unable to create TLS configuration
2018-05-10 11:51:54 -04:00
44f536f18e
add support for configurable TLS minimum version
2018-05-09 18:07:12 -04:00
796bae6f1b
allow configurable cipher suites
...
disallow 3DES and RC4 ciphers
add documentation for tls_cipher_suites
2018-05-09 17:15:31 -04:00
b12df3c64b
Added CLI for evaluating job given ID, and modified client API for evaluate to take a request payload
2018-05-09 15:04:27 -05:00
ef531b0f34
Add unit tests for forced rescheduling
2018-05-09 11:30:42 -05:00
d51611040f
Add driver health information to node list stub
2018-05-09 11:21:54 -04:00
1b8d8b2186
Fix logic inversion in force rescheduling
2018-05-08 20:00:06 -05:00
c1b92c284e
Work in progress - force rescheduling of failed allocs
2018-05-08 17:26:57 -05:00
c7edbd5f41
newlines in test
2018-05-07 14:55:01 -05:00
4e75456beb
Fix deadlock in deadline timer logic when progress deadline is passed and the deployment is updated.
2018-05-07 14:55:01 -05:00
cba13e4ec5
Fix test set up to set ModifyTime for alloc
2018-05-07 14:55:01 -05:00
19b096d203
Set modify time for allocs in unit test, and define current time in one spot
2018-05-07 14:55:01 -05:00
4c377b112e
Fix panic in deployment watcher when deployment is not in the state store due to a gc
2018-05-07 14:55:01 -05:00
02d63432b4
Fix typo
2018-05-07 14:55:01 -05:00
738056634e
Fix the initial progress deadline calculation when the alloc is inplace updated to be part of a new deployment
2018-05-07 14:55:01 -05:00
e90d051c43
consul: change hashed canary bytes
2018-05-07 14:55:01 -05:00
768fec8505
Allow healthy canary deployment to skip progress deadline
2018-05-07 14:55:01 -05:00
8626c1b94a
Reschedule when we have canaries properly
2018-05-07 14:55:01 -05:00
50e04c976e
consul: support canary tags for services
...
Also refactor Consul ServiceClient to take a struct instead of a massive
set of arguments. Meant updating a lot of code but it should be far
easier to extend in the future as you will only need to update a single
struct instead of every single call site.
Adds an e2e test for canary tags.
2018-05-07 14:55:01 -05:00
a3038cefb4
typo: transistion -> transition
2018-05-07 14:50:01 -05:00
bd38675365
Fix tests
2018-05-07 14:50:01 -05:00
319763a5d8
remove unnessary merge of DeploymentStatus.Timestamp
2018-05-07 14:50:01 -05:00
f4af30fbb5
Canary tags structs
2018-05-07 14:50:01 -05:00
f95ab4ade8
Mark canaries on creation, and unmark on promotion
2018-05-07 14:50:01 -05:00
b2b773e696
better comments and remove commented code
2018-05-07 14:50:01 -05:00
90a2311cef
Fix deadlock in deployment watcher when deployment starts with no allocations and eventually has failed allocations
2018-05-07 14:50:01 -05:00
224b3092ae
change default to 10m and docs
2018-05-07 14:50:01 -05:00
c91ce5cc38
Fix not enqueuing eval
2018-05-07 14:50:01 -05:00
8d50955054
Fix typos
2018-05-07 14:50:01 -05:00
641ef81cbf
Test fixes
2018-05-07 14:50:01 -05:00
8a81038cdb
Set Reschedule from deployment watcher
2018-05-07 14:50:01 -05:00
a510774451
Use UpdateAllocDesiredTransistion instead of UpsertEval but no transistions yet
2018-05-07 14:50:01 -05:00
fcf4f582d0
small review feedback fixes
2018-05-07 14:50:01 -05:00
e5caaf3358
Small test fix
2018-05-07 14:50:01 -05:00
9bff9024b3
add latest eval back
2018-05-07 14:50:01 -05:00
99e00fb774
Pass through timestamp
2018-05-07 14:50:01 -05:00
c49b5f9949
Handle progressed deployments and tests
2018-05-07 14:50:01 -05:00
9e75ea0a11
Deployment watcher based on deployment having progress deadline
2018-05-07 14:50:01 -05:00
1336002255
Progress deadline in deployment state
2018-05-07 14:50:01 -05:00
55b483709f
Fix tests
2018-05-07 14:50:01 -05:00
ee50789c22
Initial implementation
2018-05-07 14:50:01 -05:00
a4caf8208b
tests: fix grpc fields in task diff
2018-05-04 11:08:45 -07:00
f6a4713141
consul: make grpc checks more like http checks
2018-05-04 11:08:11 -07:00
382caec1e1
consul: initial grpc implementation
...
Needs to be more like http.
2018-05-04 11:08:11 -07:00
52b3b53181
Update ModifyIndex of alloc when setting NextAllocation value
2018-05-03 17:04:36 -05:00
274bed1892
Add RescheduleTracker to allocs list stub struct
2018-05-01 14:53:47 -05:00
de4af37249
version bump and remove generated
2018-04-27 11:10:00 -07:00
845a43864a
generated files
2018-04-27 10:45:40 -07:00
d03c881802
small cleanup and logging
2018-04-27 10:36:28 -07:00
da3a552d8d
Fix issue where node connection map wasn't being pruned
2018-04-27 10:16:03 -07:00
35e06ddb31
Remove generated and version bump
2018-04-26 16:49:19 -07:00
43192cefae
generated files
2018-04-26 16:28:58 -07:00
265a6d4f8b
Merge pull request #4224 from hashicorp/b-cron-parse
...
Handle potential panic in cron parsing
2018-04-26 16:22:37 -07:00
05eccb063f
Merge branch 'b-cron-parse' of github.com:hashicorp/nomad into b-cron-parse
2018-04-26 15:51:56 -07:00
ea24513d38
Allow nomad to restore bad periodic job
2018-04-26 15:51:47 -07:00
ce1c3e0c2d
add unit tests for panic cron parsing bug
...
add comments for cron parsing wrapper
2018-04-26 18:47:08 -04:00
15ad3f94af
Fix command line
2018-04-26 15:46:22 -07:00
dc2907c2c9
Codecgen full package
2018-04-26 15:24:53 -07:00
d0f237086b
UX touchups
2018-04-26 15:24:27 -07:00
fca0169dbc
handle potential panic in cron parsing
2018-04-26 16:57:45 -04:00
ff7e2b960f
Add test
2018-04-26 13:28:24 -07:00
4a23307baf
Track all client connections
2018-04-26 13:22:09 -07:00
5320205853
Sort signals in implicit constraint
...
Fixes https://github.com/hashicorp/nomad/issues/4212
2018-04-26 10:12:47 -07:00
79844f1d01
Safety guard
2018-04-25 16:00:56 -07:00
d45f39f24e
Fix detecting drain strategy on GC'd node
2018-04-25 16:00:56 -07:00
2e6c95f511
Merge pull request #4138 from hashicorp/i-hcl-json-endpoint
...
HCL to JSON api endpoint
2018-04-19 14:18:34 -04:00
eeb85299ff
gofmt -s nomad/structs/structs_test.go
2018-04-17 13:39:32 -07:00
788b23e17e
add test for node copy
2018-04-17 12:58:07 -04:00
31da01856a
command/agent: add HCL mock for parse endpoint
2018-04-16 19:21:09 -04:00
4f2a7b6949
Fix copying drivers
2018-04-16 15:45:51 -07:00
adaf4fa7e0
Remove generated structs
2018-04-12 16:35:31 -07:00
663c4d0433
Version bump and generated files
2018-04-12 16:21:50 -07:00
bdc17ebf10
Merge pull request #4139 from hashicorp/b-reschedule-invalid-system-jobs
...
Make system jobs fail validation if they contain a reschedule stanza
2018-04-11 20:01:19 -05:00
9f84e17bfd
dont print reschedule policy in error message
2018-04-11 17:07:14 -05:00
fa90f036c6
Fix more tests
2018-04-11 15:51:24 -05:00
81f856e7c9
Fix one more failing test
2018-04-11 15:49:23 -05:00
0b6fbb8e16
Merge pull request #4131 from hashicorp/b-rescheduling-fix-gc
...
Update garbage collection logic to make sure allocs with pending evals are not GCed
2018-04-11 15:44:36 -05:00
1da4d88f3d
Make test descriptions better
2018-04-11 15:12:23 -05:00
a7b7b662ed
Make system jobs fail validation if they contain a reschedule stanza
2018-04-11 14:56:20 -05:00
688fd9ee37
Update alloc GC eligility logic to not rely on follow up evals
2018-04-11 13:58:02 -05:00
ba88f00ccb
Changed "til" to "until"
...
Should be "till" or "until"; chose "until" because it is unambiguous as to meaning.
2018-04-11 12:36:28 -05:00
dec5b99478
Merge pull request #4120 from hashicorp/b-rescheduling-minimize-evals
...
Batch evals for rescheduling failed allocs correctly
2018-04-10 17:18:35 -05:00
59cce1d620
Fix unit test for core scheduler GC
2018-04-10 17:12:06 -05:00
7040884002
Simplify and update allocation gc eligibility logic
2018-04-10 16:08:37 -05:00
c88fef4c4b
Merge pull request #4127 from hashicorp/b-autopilot-removepeer-fixes
...
Add node id persistence
2018-04-10 16:05:00 -05:00
a569d34f25
Add custom status description for rescheduling follow up evals, and make unit test robust
2018-04-10 15:30:15 -05:00
d17bfd8045
Make leader election test run on all three protocol versions
2018-04-10 14:20:02 -05:00
b3402efd0b
Adds a new custom description for update alloc triggered evals to make it easier to unit test.
2018-04-10 14:00:07 -05:00
6d0e1c9fea
Use preconfigured nodeID if there isn't a persisted node ID, and persist it if its not persisted.
2018-04-10 08:47:33 -05:00
216c053742
Remove debug print statements
2018-04-10 08:16:50 -05:00
d179a09b83
WIP: Not setting node id properlperly
2018-04-09 18:01:28 -07:00
868f4f19f4
Unit tests for rolling upgrade and killing a leader
2018-04-09 17:42:30 -05:00
24203ae2f7
Remove duplicate commit
2018-04-09 15:08:09 -05:00
d1cb5df477
Batch evals for rescheduling failed allocs correctly and group them by job ID
2018-04-09 14:05:31 -05:00
d086f17708
rpc: wrap up old version check in a helper
...
DRY it up
2018-04-09 11:09:05 -07:00
e1cbcf0b3c
rpc: give min rpc version variable a better name
2018-04-09 11:09:05 -07:00
88a9409f8e
rpc: only attempt NodeRpc for nodes>=0.8
...
Attempting NodeRpc (or streaming node rpc) for clients that do not
support it causes it to hang indefinitely because while the TCP
connection exists, the client will never respond.
2018-04-09 11:08:06 -07:00
6254d75eee
Merge pull request #4101 from hashicorp/b-rescheduling-edge-fixes
...
Fixes edge cases around timing/ task finish time being set more than once
2018-04-04 16:18:21 -05:00
5e4525bd30
Moves setting finishedAt to the right place and adds two unit tests.
2018-04-04 14:38:15 -05:00
b1a90462a8
Merge pull request #4094 from hashicorp/b-drain-panic
...
drain: fix double-close panic on drain future
2018-04-04 10:31:14 -07:00
4c9c6decd3
Merge pull request #4100 from hashicorp/b-vault-no-auth
...
Improve handling of Vault errors
2018-04-03 17:23:43 -07:00
af1b185ce4
Fix flaky deadline tests
2018-04-03 16:51:57 -07:00
ba6628a1b6
drain: return on first error
...
If one error is encountered it is unlikely any further attempts will
succeed, so fail fast.
2018-04-03 16:46:35 -07:00
2b14371db5
Fix spelling
2018-04-03 15:58:03 -07:00
9617a13a2b
Correctly handle the upgrade path of a node being drained when applying Raft logs
2018-04-03 15:32:44 -07:00
00537c739b
Fixes edge cases around timing and task finish time being set more than once
2018-04-03 16:34:59 -05:00
58a3ec3fb2
Improve Vault error handling
2018-04-03 14:29:22 -07:00
edc4891283
drain: improve tests and fix spelling
...
* transistion -> transition
* don't t.Fatal in goroutines
* don't mutate global state
2018-04-02 16:40:47 -07:00
6840becf46
drain: refactor batch_future into its own file
...
aka What If structs.go Wasn't So Big?
2018-04-02 16:40:06 -07:00
44a749a7cc
drain: fix double-close panic on drain future
2018-04-02 16:39:18 -07:00
86f9044676
remove generated files
2018-03-30 16:52:49 -07:00
af81349dbe
Generated files
2018-03-30 16:14:40 -07:00
23ec54a372
Merge pull request #4089 from hashicorp/tls-error-fix
...
Check for nil for RPC listener; prevent double closing of listener channel
2018-03-30 16:08:13 -07:00
7f28cfcdfe
small cleanup
2018-03-30 15:49:56 -07:00
a77dd08dd9
prevent double close due to error in creating listener
2018-03-30 17:15:56 -04:00
402a026c88
add further error handling for rpc connection handling
2018-03-30 17:03:36 -04:00
e8809f40dc
Test transistion from both infinite and a future deadline to force
2018-03-30 11:24:39 -07:00
32a673a7e1
Fix force deadline notification
2018-03-30 09:58:29 -07:00
1aa415b0d8
Integration test
2018-03-30 09:33:23 -07:00
dc03fab29b
Canonicalize migrate
2018-03-29 17:42:58 -07:00
e458ab9031
Merge branch 'master' into b-drain-batch
2018-03-29 17:10:34 -07:00
62e9553333
Merge pull request #4069 from hashicorp/f-hashealth
...
add HasHealth helper for nil checks
2018-03-29 17:03:20 -07:00
301704091b
Handle upgrade where Node doesn't have eligiblity
...
This PR handles upgrading a node that has no scheduling eligiblity set.
2018-03-29 16:52:23 -07:00
7d2aae2c11
test handleTaskGroup
2018-03-29 16:38:47 -07:00
049a9213d2
Watch batch jobs
2018-03-29 16:07:51 -07:00
9a732c4acb
Merge pull request #4071 from hashicorp/b-handle-missing-finishedat
...
handle missing finishedAt
2018-03-29 17:11:34 -05:00
f12194328c
Integration test for batch complete case
2018-03-29 13:51:04 -07:00
81d48fc7cf
Merge pull request #4079 from hashicorp/b-filter-desiredstop
...
Filter desired status stop allocs correctly
2018-03-29 15:36:22 -05:00
c8317532ff
Use time from task events if task state does not have FinishedAt set
2018-03-29 14:05:56 -05:00
b194f93f2f
Disallow Update stanza on Batch
2018-03-29 11:28:56 -07:00
91b5bb58d9
add HasHealth helper for nil checks
...
We performed the DeploymentStatus nil checks a couple different ways, so
hopefully this helper will consoldiate them and make it more clear what
the code is doing.
2018-03-29 09:29:19 -07:00
607e631714
Merge pull request #4046 from hashicorp/tls-same-file-reload
...
Check file contents when determining if agent should reload TLS confi…
2018-03-29 10:51:32 -04:00
5090fefe96
Filter out allocs with DesiredState = stop, and unit tests
2018-03-29 09:28:52 -05:00
8776f4b942
Fix failing test
2018-03-29 07:59:38 -05:00
2da661595d
If FinishedAt is not set use alloc's modify time for rescheduling logic
2018-03-29 07:42:58 -05:00
b18f789020
Unmark drain when nodes hit their deadline and only batch/system left and add all job type integration test
2018-03-28 17:25:58 -07:00
b33d909bf9
add test to assert invalid files return error
2018-03-28 18:31:35 -04:00
58ada9bc42
return error when setting checksum; don't reload
2018-03-28 18:15:50 -04:00
2d5af7ff4d
set TLS checksum when parsing config
...
Refactor checksum comparison, always set checksum if it is empty
2018-03-28 09:56:11 -04:00
65ddae86f8
Merge pull request #4054 from hashicorp/b-drainer-index-fix
...
drainer: reset index when new job registered
2018-03-27 16:28:25 -07:00
79a2781585
Merge pull request #4053 from hashicorp/b-drain-sys-jobs-2
...
drain: fix draining of system jobs
2018-03-27 16:26:45 -07:00
de4b3772f1
Create evals for system jobs when drain is unset
...
This PR creates evals for system jobs when:
* Drain is unset and mark eligible is true
* Eligibility is restored to the node
2018-03-27 15:53:24 -07:00
dd5f627feb
set server configuration checksum on reload
2018-03-27 18:03:52 -04:00
ec60a1d3e3
drain: improve comments
2018-03-27 14:27:09 -07:00
e5dfb7e487
drain: unittest draining node logic
2018-03-27 14:24:01 -07:00
a1ed305a24
test: add mock batch and system allocs
...
Since the BatchJob helper had a different task group than the Alloc
helper, it was difficult to create a valid batch alloc.
2018-03-27 14:24:01 -07:00
77bddc7941
drain: stop sys jobs after drain completes
...
System allocs should be drained when a node's deadline is hit or when
all other allocs on the node have stopped/migrated.
2018-03-27 14:24:01 -07:00
fae77b874b
drainer: reset index when new job registered
2018-03-27 14:12:59 -07:00
b522a0fadc
fix up to string to use time.Time
2018-03-27 15:43:57 -04:00
31557cc44f
move tests to use time.Time
2018-03-27 15:43:57 -04:00
003bc209b9
use time.Time for node events for compatibility
2018-03-27 15:43:57 -04:00
6e6d6b7e33
check file contents when determining if agent should reload TLS configuration
2018-03-27 15:42:20 -04:00
59005d1d26
Merge pull request #4049 from hashicorp/b-tunnel
...
Only track nodes if the conn is from the node
2018-03-27 12:39:34 -07:00
5dacb057b7
Only track nodes if the conn is from the node
...
Fixes a bug in which a connection to a Nomad server was treated as a
connection to a node because the server forwarded a node specific RPC.
2018-03-27 09:59:31 -07:00
57e2cd04bd
Merge pull request #4025 from hashicorp/reload-http-tls
...
Allow TLS configurations for HTTP and RPC connections to be reloaded …
2018-03-26 18:00:30 -04:00
539114124e
Fix too long token test case
2018-03-26 16:28:33 -05:00
33e170c15d
s/linear/constant/g
2018-03-26 14:45:09 -05:00
7db930b3c3
Extra test case and better error message for ambiguous config
2018-03-26 13:30:09 -05:00
c2a95f9d7d
add test for upgrading only RPC connections
2018-03-26 10:55:27 -04:00
fbd56c35a8
Adds additional validation for ambigous settings (having both unlimited and attempts set)
2018-03-24 10:29:20 -05:00
39987d5236
Merge branch 'master' into b-acl-name
2018-03-22 14:51:40 -07:00
a7f627e34c
eligbile -> eligible
2018-03-21 16:55:22 -07:00
a4f346abeb
remove spurious TODOs and FIXMEs
2018-03-21 16:55:22 -07:00
9f3086a268
test: must initialize jobResults with new func
2018-03-21 16:51:45 -07:00
e432c9af55
test: disable node drainer during tests
...
Node drainer would throw off the index checks
2018-03-21 16:51:45 -07:00
5c8c4bce2a
test: disable drain during fsm test
...
drainer was unsetting drain before fsm could read written value
2018-03-21 16:51:45 -07:00
341d87aa48
tests: use mock.BatchJob to fix tests
2018-03-21 16:51:45 -07:00
8b107acc06
mock: add BatchJob() helper
2018-03-21 16:51:45 -07:00
cb61a4bdc7
Fix linting errors
2018-03-21 16:51:45 -07:00
640ebdaef6
fix race in drain integration tests
2018-03-21 16:51:45 -07:00
c401d5a098
Refactor assertOps into a helper func
2018-03-21 16:51:45 -07:00
187b0e1a48
Remove debug prints
2018-03-21 16:51:45 -07:00
f67eca48ac
Deregister garbage collected jobs
2018-03-21 16:51:45 -07:00
922842546c
JobNs -> NamespacedID
...
Also drop the New func as it's easy to swap the order of arguments since
they're both strings.
2018-03-21 16:51:45 -07:00
8dc7d9fb6a
drainer: RegisterJob -> RegisterJobs
...
Test job watcher
2018-03-21 16:51:45 -07:00
3116897099
Fix deadline heap triggering
...
Chan must be buffered to avoid skipping triggering altogether
Also made timing in a test a bit more lenient
2018-03-21 16:51:45 -07:00
9d23c965da
fix comment
2018-03-21 16:51:45 -07:00
fb4badf1bc
sharding
2018-03-21 16:51:44 -07:00
2d91b9dfba
Batch drain update
2018-03-21 16:51:44 -07:00
92b636dd32
Fix deadline handling
2018-03-21 16:51:44 -07:00
9898edfa90
Switch to drainerv2 impl
2018-03-21 16:51:44 -07:00
7b2bad8c5e
Toggle Drain allows resetting eligibility
...
This PR allows marking a node as eligible for scheduling while toggling
drain. By default the `nomad node drain -disable` commmand will mark it
as eligible but the drainer will maintain in-eligibility.
2018-03-21 16:51:44 -07:00
ad80e655cc
code review
2018-03-21 16:51:44 -07:00
11f9fe4960
spelling fixes
2018-03-21 16:51:44 -07:00
bc7385812d
Comments
2018-03-21 16:51:44 -07:00
e87c677a42
handle empty node case
2018-03-21 16:51:44 -07:00
405dab2253
integration test and basic fixes
2018-03-21 16:51:44 -07:00
e63bcb474d
Drainer
2018-03-21 16:51:44 -07:00
4754366640
job watcher
2018-03-21 16:51:44 -07:00
504bfabb4d
Node's being untracked or having updated deadlines, updates the deadliner
2018-03-21 16:51:44 -07:00
66eaaa6a4d
node watcher
2018-03-21 16:51:44 -07:00
527ac0b39d
drain heap
2018-03-21 16:51:44 -07:00
2d4c193a0a
Initial design
2018-03-21 16:51:44 -07:00
33ca319080
System test runs on mac
2018-03-21 16:51:44 -07:00
f8d4a3a9e6
Fix file names
2018-03-21 16:51:44 -07:00
32a7649359
refactor main drainloop into 2 more methods
2018-03-21 16:51:44 -07:00
5e52f84bb7
drainer: refactor newStopAllocs, applyMigrations
2018-03-21 16:51:44 -07:00
62960ed7bd
client: don't monitor health of non-service jobs
...
Also fix system job draining; won't work without deadline fixes
2018-03-21 16:51:44 -07:00
a37329189a
Improve DeadlineTime helper
2018-03-21 16:51:44 -07:00
b7c993f0e5
drainer: convert fsm errors to go errors
2018-03-21 16:51:44 -07:00
ab0de41884
drainer: factor job & node watchers out of drainer.go
2018-03-21 16:51:44 -07:00
5922aef623
Restart every time SetEnabled(true) is called
2018-03-21 16:51:44 -07:00
959d447d38
Remove unused context
2018-03-21 16:51:44 -07:00
8b41e9b2e1
drainer: drainer should shutdown with server
2018-03-21 16:51:44 -07:00
0a17076ad2
refactor drainer into a subpkg
2018-03-21 16:51:44 -07:00
93871c18f8
Fix retaining the drain
2018-03-21 16:51:44 -07:00
010a6b8ca5
Unblock evals once eligible
2018-03-21 16:51:44 -07:00
8289cc3c6f
HTTP and API
2018-03-21 16:51:44 -07:00
0fba0101b6
RPC/FSM/State Store for Eligibility
2018-03-21 16:51:44 -07:00
b3d2346419
Upgrade path
2018-03-21 16:51:43 -07:00
2f5309d82a
Remove update time
2018-03-21 16:51:43 -07:00
0965c9ed28
Fix tests
2018-03-21 16:51:43 -07:00
010228577e
Drain cli, api, http
2018-03-21 16:51:43 -07:00
e459a666ed
Node.Drain takes strategy
2018-03-21 16:49:48 -07:00
03d0e5b8a0
improve drain fsm/statestore tests
2018-03-21 16:49:48 -07:00
d1ec65d765
switch to new raft DesiredTransition message
2018-03-21 16:49:48 -07:00
acf59ee75e
drainer: switch to job based watching
2018-03-21 16:49:48 -07:00
db4a634072
RPC, FSM, State Store for marking DesiredTransistion
...
fix build tag
2018-03-21 16:49:48 -07:00
c0542474db
drain: initial drainv2 structs and impl
2018-03-21 16:49:48 -07:00
6fc9231dac
Merge pull request #3856 from hashicorp/f-client-add-health-checks
...
Client driver health checks for Docker
2018-03-21 18:05:00 -04:00
66e44cdb73
Allow TLS configurations for HTTP and RPC connections to be reloaded separately
2018-03-21 17:51:08 -04:00
01898b2c25
Merge pull request #4007 from hashicorp/f-show-rescheduling-cli-job-status
...
Show a section on upcoming delayed evaluations when applicable
2018-03-21 14:37:38 -05:00
f801709a0a
fix issue when updating node events
2018-03-21 15:15:26 -04:00
86b7b3d2d9
fix up health check logic comparison; add node events to client driver checks
2018-03-21 15:15:26 -04:00
d8f68e5ef8
fix up codereview feedback
2018-03-21 15:15:26 -04:00
c7fd0bd8a1
fix up scheduler mocks
2018-03-21 15:15:25 -04:00
c50d02ae93
go style; update comments
2018-03-21 15:15:25 -04:00
a522da6994
fix up gofmt
2018-03-21 15:15:25 -04:00
3aa726baab
fix scheduler driver name; create node structs file
2018-03-21 15:15:25 -04:00
Mahmood Ali