2019-03-10 21:16:49 +00:00
|
|
|
Thank you for contributing to pyo3!
|
|
|
|
|
2020-08-02 00:09:52 +00:00
|
|
|
Please consider adding the following to your pull request:
|
|
|
|
- an entry in CHANGELOG.md
|
|
|
|
- docs to all new functions and / or detail in the guide
|
|
|
|
- tests for all new or changed functions
|
2019-03-10 21:16:49 +00:00
|
|
|
|
2020-08-02 09:43:28 +00:00
|
|
|
Be aware the CI pipeline will check your pull request for the following:
|
|
|
|
- Rust tests (Just `cargo test` or `make test` if you need to test examples)
|
|
|
|
- Rust lints (`make clippy`)
|
2020-08-02 00:09:52 +00:00
|
|
|
- Rust formatting (`cargo fmt`)
|
2020-08-02 09:43:28 +00:00
|
|
|
- Python formatting (`black . --check`. You can install black with `pip install black`)
|
2020-08-02 00:09:52 +00:00
|
|
|
- Compatibility with all supported Python versions for all examples. This uses `tox`; you can do run it using `make test_py`.
|
2019-03-10 21:16:49 +00:00
|
|
|
|
2020-08-02 00:09:52 +00:00
|
|
|
You can run a similar set of checks as the CI pipeline using `make test`.
|