luxolus/pyo3
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Create pull_request_template.md

Browse source
This commit is contained in:
konstin 2019-03-10 22:16:49 +01:00 committed by GitHub
parent 25f14d37a5
commit b60b3395f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
.github/pull_request_template.md vendored Normal file
View file

@ -0,0 +1,11 @@
Thank you for contributing to pyo3!
Here are some things you should check for submitting your pull request:
- Run `cargo fmt` (This is checked by travis ci)
- Run `cargo clippy` and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)
- If applicable, add an entry in the changelog.
- If applicable, add documentation to all new items and extend the guide.
- If applicable, add tests for all new or fixed functions
You might want to run `tox` (`pip install tox`) locally to check compatibility with all supported python versions. If you're using linux or mac you might find the Makefile helpful for testing.