open-nomad/contributing/checklist-jobspec.md
2019-10-08 10:55:53 -07:00

1.1 KiB

New jobspec Entry Checklist

Code

  • Parse in jobspec/parse.go
  • Test in jobspec/parse_test.go (preferably with a jobspec/text-fixtures/<feature>.hcl test file)
  • Add structs/fields to api/ package
    • structs usually have Canonicalize, Copy, and Merge methods
    • New fields should be added to existing Canonicalize, Copy, and Merge methods
    • Test the struct/field via all methods mentioned above
  • Add structs/fields to nomad/structs package
    • Validation happens in this package and must be implemented
    • Implement other methods and tests from api/ package
  • Add conversion between api/ and nomad/structs in command/agent/job_endpoint.go
  • Test conversion

Docs