Commit graph

9542 commits

Author SHA1 Message Date
Michael Schurter f86f0bd9ea Handle leader task being dead in RestoreState
Fixes the panic mentioned in
https://github.com/hashicorp/nomad/issues/3420#issuecomment-341666932

While a leader task dying serially stops all follower tasks, the
synchronizing of state is asynchrnous. Nomad can shutdown before all
follower tasks have updated their state to dead thus saving the state
necessary to hit this panic: *have a non-terminal alloc with a dead
leader.*

The actual fix is a simple nil check to not assume non-terminal allocs
leader's have a TaskRunner.
2017-11-15 10:36:13 -08:00
Preetha Appan 2cee27ea31 Update Changelog 2017-11-15 08:28:27 -06:00
Preetha Appan bb3fd9fb7f Update CHANGELOG.md to mention consul template version 2017-11-15 08:25:57 -06:00
Preetha 2856c78284
Merge pull request #3550 from hashicorp/b-pretty-diff-0s
Handle edge case when allocation create/modify time difference is les…
2017-11-14 20:33:05 -06:00
Preetha Appan 23e08f17a6 Declare time.Now once to prevent flakiness 2017-11-14 20:32:02 -06:00
Chelsea Komlo 2dfda33703 Nomad agent reload TLS configuration on SIGHUP (#3479)
* Allow server TLS configuration to be reloaded via SIGHUP

* dynamic tls reloading for nomad agents

* code cleanup and refactoring

* ensure keyloader is initialized, add comments

* allow downgrading from TLS

* initalize keyloader if necessary

* integration test for tls reload

* fix up test to assert success on reloaded TLS configuration

* failure in loading a new TLS config should remain at current

Reload only the config if agent is already using TLS

* reload agent configuration before specific server/client

lock keyloader before loading/caching a new certificate

* introduce a get-or-set method for keyloader

* fixups from code review

* fix up linting errors

* fixups from code review

* add lock for config updates; improve copy of tls config

* GetCertificate only reloads certificates dynamically for the server

* config updates/copies should be on agent

* improve http integration test

* simplify agent reloading storing a local copy of config

* reuse the same keyloader when reloading

* Test that server and client get reloaded but keep keyloader

* Keyloader exposes GetClientCertificate as well for outgoing connections

* Fix spelling

* correct changelog style
2017-11-14 17:53:23 -08:00
Alex Dadgar ec5e23065c bump go 2017-11-14 15:06:41 -08:00
Preetha Appan 03ac677dc8 Handle edge case when allocation create/modify time difference is less than a second ago. 2017-11-14 16:40:34 -06:00
Michael Lange e8bb3318ff
Merge pull request #3472 from hashicorp/f-ui-task-hierarchy
Task route hierarchy in the UI
2017-11-14 11:15:32 -08:00
Michael Lange 71bc408f6c Remold the allocation detail and task detail pages
Now that there is a task detail page, some of the content from
the allocation detail page is better suited there.
2017-11-14 11:08:51 -08:00
Michael Lange 9c58c30496 Update allocation detail page to look like job and node 2017-11-14 11:05:29 -08:00
Michael Lange 6a7bbe8afa Create a new task route hierarchy
Drilling into a task from an allocation transitions to the task
heirarchy.
2017-11-14 11:04:40 -08:00
Preetha 8e20aba14a
Merge pull request #3543 from hashicorp/b-consul-template-vendor-update
Vendor update to consul template 0.19.4
2017-11-14 09:35:33 -06:00
Alex Dadgar 09bde9a7fc
Merge pull request #3500 from hashicorp/b-vendor
Clean vendored packages
2017-11-13 15:36:38 -08:00
Charlie Voiselle 8a14fb5e88
Merge pull request #3541 from angrycub/b-makefile-typo
Makefile typos
2017-11-13 18:08:01 -05:00
Preetha 0e6484a397
Merge pull request #3536 from angrycub/b-resource-memory-test-fix
Fixed test and moved constants into standalone func
2017-11-13 17:00:14 -06:00
Preetha Appan c60b7d45ed Vendor update to consul template 0.19.4 2017-11-13 14:58:36 -06:00
Charlie Voiselle 7da73ce878 Makefile typos 2017-11-13 14:57:17 -05:00
Alex Dadgar cb476f2f8c
Merge pull request #3537 from hashicorp/d-docker-endpoints
Better docs for docker.endpoint option
2017-11-13 11:00:57 -08:00
Alex Dadgar 7112c21508
Merge pull request #3538 from hashicorp/d-serf-name
Clarify Name config
2017-11-13 11:00:48 -08:00
Preetha Appan 84dcdcf2bf Update CHANGELOG.md 2017-11-13 12:46:42 -06:00
Michael Schurter 61970f8468
unix -> Unix
I'm not going to leave a review comment just to uppercase one dumb letter
2017-11-13 10:45:21 -08:00
Alex Dadgar 83f25f4926 Clarify Name config
Fixes https://github.com/hashicorp/nomad/issues/3517
2017-11-13 10:37:55 -08:00
Preetha f8eeee06a4
Merge pull request #3512 from hashicorp/b-docker-device-option
Add support for passing device into docker driver
2017-11-13 12:37:14 -06:00
Alex Dadgar ba32088634 Better docs for docker.endpoint option
Fixes https://github.com/hashicorp/nomad/issues/3533
2017-11-13 10:20:40 -08:00
Preetha 54aba49035
Merge pull request #3535 from hashicorp/b-alloc-status-message-bugfix
Fixes bug with display message logic due to deprecating GenericSource…
2017-11-13 12:17:53 -06:00
Alex Dadgar acee89ed2a fix vault grace docs 2017-11-13 09:59:20 -08:00
Charlie Voiselle eda764c0ca Review feedback + re-add dropped import 2017-11-13 12:51:19 -05:00
Charlie Voiselle 4b186861a9 gofmt and goimports nomad/structs/structs.go 2017-11-13 12:32:52 -05:00
Charlie Voiselle 1419e7a1c3 gofmt and goimports 2017-11-13 12:25:02 -05:00
Preetha Appan be5fd87b9a Fixes bug with display message logic due to deprecating GenericSource. Also added more test cases to cover a bunch more edge cases 2017-11-13 11:14:57 -06:00
Charlie Voiselle 26acd7f025 Fixed test and moved constants into standalone func
In #3520, work was done to true up the defaults for Nomad resource
stanzas with the documentation.  This fixes the tests that I
accidentally broke in the process.  Some questions were raised about
using dynamic elements as part of expects, which is why I opted to
copy the MinResources pattern.   During this refactor I also noticed
that structs.go had a similar issue and an inconsistent minium for CPU.
2017-11-13 12:05:30 -05:00
Preetha Appan 926c9ed997 Make device mounting unit test verify configuration via docker inspect 2017-11-13 09:56:54 -06:00
Preetha Appan dc2d5fb5a4 Unit test (linux only) that tests mounting a device in the docker driver 2017-11-13 09:56:54 -06:00
Preetha Appan 4834710e45 Add default value for cgroup permissions for device if not set 2017-11-13 09:56:54 -06:00
Preetha Appan 9cdee6991c Remove unnecessary check since validate method already checks this 2017-11-13 09:56:54 -06:00
Preetha Appan 110c1fd4f0 Add support for passing device into docker driver 2017-11-13 09:56:54 -06:00
Alex Dadgar 82a891c0e6
Merge pull request #3531 from hashicorp/vault-nomad-docs-update
Updated Troubleshooting section of Vault Integration docs
2017-11-11 14:23:21 -08:00
Laura Uva bf23e75ca1 Updated Troubleshooting section of Vault Integration docs to mention the policy requirements for certain version combinations of Vault and Nomad, due to changes in Vault default policy and Nomad's vendored Vault lease renewal API. 2017-11-10 16:36:43 -08:00
Michael Lange 41b9aae4b7
Merge pull request #3530 from hashicorp/b-allow-cross-origin-connections-in-ui
Allow cross origin connections in ui
2017-11-10 14:33:16 -08:00
Michael Lange eb42e6d219 generated UI routes 2017-11-10 13:29:17 -08:00
Michael Lange 157abf2c76 Remove the connect-src self restriction for the UI 2017-11-10 13:28:11 -08:00
Michael Lange 1845fa4711 Make make dev-ui work as expected 2017-11-10 13:27:48 -08:00
Alex Dadgar 8f6f9e9e49 Clean vendored packages
This PR removes unused packages from the vendor folder.
2017-11-10 13:00:32 -08:00
Alex Dadgar c44f94fbd0
Merge pull request #3529 from hashicorp/b-env-ct
Handle multiple environment templates
2017-11-10 12:56:02 -08:00
Alex Dadgar 8324ef3bc4 format 2017-11-10 12:47:59 -08:00
Alex Dadgar ea57850b6d changelog 2017-11-10 12:44:36 -08:00
Alex Dadgar b68f18bcc5
Merge pull request #3520 from hashicorp/b-memory-default-incorrect
`memory` default is 10, not 300
2017-11-10 12:43:37 -08:00
Alex Dadgar d1358ec1b6 alway load all templates 2017-11-10 12:35:51 -08:00
Alex Dadgar 491fce5dcb changelog 2017-11-10 11:10:34 -08:00