These are based on the source code for selectChoose. I would have liked
to have used selectChoose, but the implementation has two await
settled()s in it which prevented me from writing the tests I needed to
write.
These new extension helpers separate selectChoose into two pieces so
logic can be placed between the two async actions.
* Add massaged results of class codemod
Manual interventions:
• decorators on the same line for service and controller
injections and most computed property macros
• preserving import order when possible, both per-line
and intra-line
• moving new imports to the bottom
• removal of classic decorator for trivial cases
• conversion of init to constructor when appropriate
* Add fixes for ESLint getter-return
…I GUESS
* Remove unnecessary fetch-setting
Originally this was failing because it only had a getter.
I tried replacing it with a computed property and that
succeeded, but since we have already stopped using
jQuery, we might as well remove it.
* Change with-namespace-ids mixin to a base class
This is a merge of 5d9fce5.
* Change URL-generation for job-updating
The id-processing in the WatchableNamespaceIds adapter was
happening twice; this removes urlForUpdate record so it
only happens once. @DingoEatingFuzz figured it out! 🥳
* Fix query parameters structures
I’d think the codemod would handle this if it’s a requirement
but apparently not, is it a bug?
* Add manually-converted classes
I don’t know why the codemod ignored these files 🧐
* Remove problem field
It appears this gets turned into a getter-only computed property
somehow, which causes problems when subclasses override it.
* Rename clashing action
* Convert field to overridable computed property
StatsTimeSeries defines description as a computed property,
which isn’t possible when this is a class field.
* Rename clashing property
* Remove superfluous uses of Object.freeze
This is no longer needed!
https://guides.emberjs.com/release/upgrading/current-edition/native-classes/#toc_properties-and-fields
* Data cannot be a field in the base class and a CP in the child classes
* Remove stray commented-out line
Co-authored-by: Michael Lange <dingoeatingfuzz@gmail.com>
The id-processing in the WatchableNamespaceIds adapter was
happening twice; this removes urlForUpdate record so it
only happens once. @DingoEatingFuzz figured it out! 🥳
Originally this was failing because it only had a getter.
I tried replacing it with a computed property and that
succeeded, but since we have already stopped using
jQuery, we might as well remove it.
Michael Lange