Alex Dadgar
dbd9d22a32
Device job stanza
2019-01-23 10:58:45 -08:00
Mahmood Ali
698f0a1575
Merge pull request #5229 from hashicorp/r-grabbag-201901019
...
Grab bag of small changes
2019-01-23 13:06:51 -05:00
Mahmood Ali
8d76bb0e82
tests: avoid assertion in goroutine
2019-01-23 12:34:16 -05:00
Mahmood Ali
651bbe5330
spell check
2019-01-23 10:54:52 -05:00
Mahmood Ali
d696143da7
ci: run checkscripts
...
`travis.sh` contained some bash-ism despite it being invoked with `sh`.
2019-01-23 10:54:52 -05:00
Mahmood Ali
464a70fda6
tests: deflake TestRktDriver_StartWaitRecoverWaitStop
2019-01-23 10:54:49 -05:00
Mahmood Ali
08db847aa8
drivers/rkt: Remove unused github.com/rkt/rkt
2019-01-23 10:53:49 -05:00
Mahmood Ali
a64ad99b94
drivers/rkt: allow development on non-linux
...
Avoid depending on OS-specific library for some simple structs.
2019-01-23 10:53:49 -05:00
Danielle Tomlinson
4f63925667
Merge pull request #5230 from hashicorp/dani/b-hide-docker_logger-command
...
cli: Hide `nomad docker_logger` from help output
2019-01-23 16:46:11 +01:00
Danielle Tomlinson
92ebe06d77
cli: Hide nomad docker_logger
from help output
2019-01-23 16:27:05 +01:00
Mahmood Ali
d2ef657abc
api: test api and structs are in sync
...
Add some tests to ensure that api/structs values are in sync.
Given that vendoring libraries prune tests by default, test dependencies
aren't leaked to clients of the package - so it should be safe to add
such dependency without affecting api clients.
2019-01-23 10:00:17 -05:00
Michael Schurter
13f061a83f
Merge pull request #5196 from hashicorp/f-plugin-utils
...
Make plugins/shared external and make pluginutls/
2019-01-23 06:59:32 -08:00
Preetha
05bf183ba3
Merge pull request #5225 from hashicorp/b-notaskevent-terminalallocs
...
Don't emit task events after alloc is in a terminal DesiredState
2019-01-23 08:54:10 -06:00
Preetha
8963b029d0
Merge pull request #5226 from hashicorp/b-node-status-panic
...
nil check node resources to prevent panic
2019-01-23 08:30:14 -06:00
Michael Schurter
32daa7b47b
goimports until make check is happy
2019-01-23 06:27:14 -08:00
Preetha Appan
5f1d467ed2
nil check node resources to prevent panic
2019-01-22 19:34:02 -06:00
Michael Schurter
be0bab7c3f
move pluginutils -> helper/pluginutils
...
I wanted a different color bikeshed, so I get to paint it
2019-01-22 15:50:08 -08:00
Alex Dadgar
80c6eb1bc5
vet
2019-01-22 15:44:31 -08:00
Alex Dadgar
4bdccab550
goimports
2019-01-22 15:44:31 -08:00
Alex Dadgar
b7a65676fe
gofmt
2019-01-22 15:43:34 -08:00
Alex Dadgar
2ca0e97361
Split hclspec
2019-01-22 15:43:34 -08:00
Alex Dadgar
5ca6dd7988
move hclutils
2019-01-22 15:43:34 -08:00
Alex Dadgar
72a5691897
Driver tests do not use hcl2/hcl, hclspec, or hclutils
2019-01-22 15:43:34 -08:00
Alex Dadgar
b2c7268843
move reattach config
2019-01-22 15:11:58 -08:00
Alex Dadgar
cdcd3c929c
loader and singleton
2019-01-22 15:11:57 -08:00
Alex Dadgar
6c2782f037
move catalog + grpcutils
2019-01-22 15:11:57 -08:00
Preetha Appan
38422642cb
Use DesiredState to determine whether to stop sending task events
2019-01-22 16:43:32 -06:00
Preetha Appan
862c9b7de5
dont emit events for terminal allocs
2019-01-22 16:26:33 -06:00
Alex Dadgar
f3a2d05e11
increase log level
2019-01-22 14:20:54 -08:00
Michael Schurter
1fa376cac6
Merge pull request #5211 from hashicorp/test-porting-08
...
Port some 0.8 TaskRunner tests
2019-01-22 14:05:53 -08:00
Michael Lange
be150abde7
CHANGELOG: added 0.9 ui changes
2019-01-22 09:59:46 -08:00
Michael Schurter
8ced0adb67
test: port TestTaskRunner_CheckWatcher_Restart
...
Added ability to adjust the number of events the TaskRunner keeps as
there's no way to observe all events otherwise.
Task events differ slightly from 0.8 because 0.9 emits Terminated every
time a task exits instead of only when it exits on its own (not due to
restart or kill).
0.9 does not emit Killing/Killed for restarts like 0.8 which seems fine
as `Restart Signaled/Terminated/Restarting` is more descriptive.
Original v0.8 events emitted:
```
expected := []string{
"Received",
"Task Setup",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Not Restarting",
}
```
2019-01-22 09:46:46 -08:00
Preetha
2cf82d7336
Merge pull request #5207 from hashicorp/b-rename-hooks
...
Rename TaskKillHook to TaskPreKillHook to more closely match usage
2019-01-22 10:29:53 -06:00
Michael Schurter
1719752a9d
test: port RestartTask from 0.8
2019-01-22 08:08:08 -08:00
Michael Schurter
9edff19625
test: port SignalFailure test from 0.8
...
Also fix signal error handling in mock_driver.
2019-01-22 08:08:08 -08:00
Preetha Appan
299a5fc821
Rename TaskKillRequest/Response to TaskPreKillRequest/Response
2019-01-22 09:54:02 -06:00
Preetha Appan
5a5b9c5666
Fix log comments
2019-01-22 09:45:58 -06:00
Preetha Appan
06e15f8381
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:56 -06:00
Michael Schurter
3b02af9386
Fix comment
...
Co-Authored-By: preetapan <preetha@hashicorp.com>
2019-01-22 09:41:21 -06:00
Preetha Appan
09291c689b
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:21 -06:00
Mahmood Ali
a9b73e6b86
Merge pull request #5216 from hashicorp/b-fix-tests-20180118
...
tests: deflake client TestFS_Logs_TaskPending test
2019-01-21 09:54:15 -05:00
Preetha
4f3334c1ca
Update CHANGELOG.md
2019-01-19 11:15:04 -06:00
Mahmood Ali
e1803b685b
tests: deflake TestClientAllocations_GarbageCollect_Remote
...
Use the same strategy as one in f2f383b07543a09ca989b82738926f7248e1ab28
2019-01-19 09:07:27 -05:00
Nick Ethier
6da4a38e00
Merge pull request #5198 from hashicorp/f-driver-upgradepath
...
0.9 Upgrade path for drivers and executors
2019-01-19 00:06:21 -05:00
Mahmood Ali
d19ba5bd8e
tests: deflake client TestFS_Logs_TaskPending test
2019-01-18 21:26:48 -05:00
Mahmood Ali
b2203a3a22
Merge pull request #5215 from hashicorp/test-fix-garbagecollect
...
test: fix flaky garbage collect test
2019-01-18 21:10:01 -05:00
Mahmood Ali
05e32fb525
Merge pull request #5213 from hashicorp/b-api-separate
...
Slimmer /api package
2019-01-18 20:52:53 -05:00
Preetha
6998b7e57b
Update CHANGELOG.md
2019-01-18 18:15:11 -06:00
Preetha
2e71168e5f
Merge pull request #5205 from hashicorp/b-queuedallocs-bugfix
...
Reconcile child summaries correctly
2019-01-18 18:13:19 -06:00
Michael Schurter
0cd35ba335
test: fix flaky garbage collect test
...
This seems to fix TestClientAllocations_GarbageCollectAll_Remote being
flaky.
This test confuses me. It joins 2 servers, but then goes out of its way
to make sure the test client only interacts with one. There are not
enough comments for me to figure out the precise assertions this test is
trying to make.
A good old fashioned wait-for-the-client-to-register seems to fix the
flakiness though. The error was that the node could not be found, so
this makes some sense. However, lots of other tests seem to use the same
"wait for node" logic and don't appear to be flaky, so who knows why
waiting fixes this one.
Passes with -race.
2019-01-18 16:01:30 -08:00