Commit graph

16551 commits

Author SHA1 Message Date
Tim Gross c9d92f845f
e2e: add a Windows client to test runner (#6735)
* Adds a constraint to prevent tests from landing on Windows
* Improve Terraform output for mixed windows/linux clients
* Makes some Windows client config fixes from 0.10.2 testing
2019-11-25 13:31:00 -05:00
Mahmood Ali f0378a2050
Merge pull request #6771 from hashicorp/b-deflake-TestHTTP_FreshClientAllocMetrics-test
tests: deflake TestHTTP_FreshClientAllocMetrics
2019-11-25 08:33:03 -05:00
Mahmood Ali 7b8cfee162 tests: deflake TestHTTP_FreshClientAllocMetrics
The test asserts that alloc counts get reported accurately in metrics by
inspecting the metrics endpoint directly.  Sadly, the metrics as
collected by `armon/go-metrics` seem to be stateful and may contain info
from other tests.

This means that the test can fail depending on the order of returned
metrics.

Inspecting the metrics output of one failing run, you can see the
duplicate guage entries but for different node_ids:

```
    {
      "Name": "service-name.default-0a3ba4b6-2109-485e-be74-6864228aed3d.client.allocations.terminal",
      "Value": 10,
      "Labels": {
        "datacenter": "dc1",
        "node_class": "none",
        "node_id": "67402bf4-00f3-bd8d-9fa8-f4d1924a892a"
      }
    },
    {
      "Name": "service-name.default-0a3ba4b6-2109-485e-be74-6864228aed3d.client.allocations.terminal",
      "Value": 0,
      "Labels": {
        "datacenter": "dc1",
        "node_class": "none",
        "node_id": "a2945b48-7e66-68e2-c922-49b20dd4e20c"
      }
    },
```
2019-11-22 18:41:21 -05:00
Mahmood Ali f819d406ff
Merge pull request #6767 from hashicorp/c-ci-tweaks-20191122
Further tweaks to CircleCI build scripts
2019-11-22 15:52:43 -05:00
Mahmood Ali e8dc686019 ci: avoid building binaries in stable-website
This speeds up building and pushing releases
2019-11-22 15:40:22 -05:00
Mahmood Ali 500fb6f8ce ci: verify .circleci/config.yml is up to date 2019-11-22 14:50:49 -05:00
Michael Schurter 603773b22f
Merge pull request #6765 from hashicorp/docs-connect-bugs
docs: update connect limitations
2019-11-22 11:18:31 -08:00
Mahmood Ali a8d706db46
Merge pull request #6766 from hashicorp/docs-docker-dangling-containers-followup
docs: address more GH-6762 review comments
2019-11-22 13:24:59 -05:00
Mahmood Ali d9e7599ced docs: address more GH-6762 review comments
Incorporate suggestions in https://github.com/hashicorp/nomad/pull/6762#pullrequestreview-321716747

[ci skip]
2019-11-22 13:22:14 -05:00
Michael Schurter 18534b12a2 docs: update connect limitations 2019-11-22 10:18:10 -08:00
Mahmood Ali cfd78c266d
Merge pull request #6762 from hashicorp/d-docker-dangling-containers
document docker dangling container reaper
2019-11-22 13:10:59 -05:00
Mahmood Ali 12e65c054d address more review comments 2019-11-22 13:10:10 -05:00
Mahmood Ali eda18fff76
Apply suggestions from code review
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
2019-11-22 13:03:20 -05:00
Mahmood Ali 57ff36df5c ci: avoid paging 2019-11-22 11:52:01 -05:00
Mahmood Ali 5c17bf36b8 ci: ignore docs only changes
Skip running backend and UI changes for docs/website updates, as
indicated by branch name.
2019-11-22 11:51:57 -05:00
Mahmood Ali e85886d33c git: only .circleci/config.yml is a generated one 2019-11-22 11:24:13 -05:00
Mahmood Ali 6b90a179f1
Merge pull request #6763 from hashicorp/b-handle-initialize-logger
drivers: always initialize taskHandle.logger
2019-11-22 11:04:54 -05:00
Mahmood Ali 51a8b21cc6 changelog
[ci skip]
2019-11-22 11:04:24 -05:00
Mahmood Ali aa1c83871b drivers: always initialize taskHandle.logger
Looks like the RecoverTask doesn't set taskHandle.logger field causing
a panic when the handle attempts to log (e.g. when Shutdown or Signaling
fails).
2019-11-22 10:44:59 -05:00
Mahmood Ali d694f1d61c document docker dangling container repeaper 2019-11-22 09:58:00 -05:00
Chris Baker ee066bdaca
Merge pull request #6755 from hashicorp/docs-device-plugin-guide
cherry-pick: device plugin authoring guide
2019-11-21 18:39:57 -06:00
Chris Baker bde82d7d0e added the device plugin authoring guide, made minor formatting changes to task driver plugin authoring guide. 2019-11-22 00:38:46 +00:00
Michael Schurter 9cd6aa24da
Merge pull request #6754 from hashicorp/docs-0.10.2
Changelog updates and download link for 0.10.2-rc1
2019-11-21 15:19:32 -08:00
Michael Schurter ae61a80de5 docs: add Nomad v0.10.2-rc1 download link 2019-11-21 15:05:29 -08:00
Michael Schurter 9c4a96358b docs: reformat changelog for 0.10.2-rc1 2019-11-21 15:05:29 -08:00
Drew Bailey 0e0e985cc4
Merge pull request #6753 from hashicorp/monitor-add-server-id-help
add server-id to -h output
2019-11-21 16:03:33 -05:00
Drew Bailey b3765b06ea
add server-id to -h output 2019-11-21 16:01:09 -05:00
Mahmood Ali 54b22ae3a6 changelog GH-6580 2019-11-21 15:49:49 -05:00
Drew Bailey 95e017c56d
Merge pull request #6750 from hashicorp/nomad-monitor-node-id-prefix
Allows a node uuid prefix to be passed in
2019-11-21 15:14:20 -05:00
Drew Bailey 7ca6dbe61e
Allows a node uuid prefix to be passed in 2019-11-21 14:51:48 -05:00
Lang Martin 850ca88635 CHANGELOG quota network 2019-11-21 10:34:05 -05:00
Mahmood Ali 5e3dbe7a42
Merge pull request #6749 from hashicorp/b-test-tweaks-20191120
CI and Test tweaks
2019-11-21 08:29:42 -05:00
Mahmood Ali e89108fb01 fixup! tests: don't assume eth0 network is available 2019-11-21 08:28:20 -05:00
Mahmood Ali 07fe93da3c ci: match ci timeout to go test timeout
make test-nomad sets 15 minute time out for build.  Increase the ci
timeout to 20m, so we can get meaningful output and goroutine stack
traces rather than have test be simply killed by CircleCI.

The extra 5 minutes is a buffer for generating-structs and some
unnecessary padding.
2019-11-20 20:39:23 -05:00
Mahmood Ali 443804b5c7 tests: don't assume eth0 network is available
TestClient_UpdateNodeFromFingerprintKeepsConfig checks a test node
network interface, which is hardcoded to `eth0` and is updated
asynchronously.  This causes flakiness when eth0 isn't available.

Here, we hardcode the value to an arbitrary network interface.
2019-11-20 20:37:30 -05:00
Mahmood Ali ed3f1957e7 tests: run TestClient_WatchAllocs in non-linux environments 2019-11-20 20:37:29 -05:00
Mahmood Ali 521f51a929 testS: fix TestClient_RestoreError
When spinning a second client, ensure that it uses new driver
instances, rather than reuse the already shutdown unhealthy drivers from
first instance.

This speeds up tests significantly, but cutting ~50 seconds or so, the
timeout in NewClient until drivers fingerprints.  They never do because
drivers were shutdown already.
2019-11-20 20:37:28 -05:00
Mahmood Ali 4efb71cf0c tests: remove TestClient_RestoreError test
TestClient_RestoreError is very slow, taking ~81 seconds.

It has few problematic patterns.  It's unclear what it tests, it
simulates a failure condition where all state db lookup fails and
asserts that alloc fails.  Though starting from
https://github.com/hashicorp/nomad/pull/6216 , we don't fail allocs in
that condition but rather restart them.

Also, the drivers used in second client `c2` are the same singleton
instances used in `c1` and already shutdown.  We ought to start healthy
new driver instances.
2019-11-20 20:37:27 -05:00
Mahmood Ali 0947155ddb
Merge pull request #6745 from hashicorp/c-circleci-tweaks-20191120
ci: Revamp CircleCI config
2019-11-20 20:37:12 -05:00
Lang Martin def417a33a docs: update quota docs to include network limits 2019-11-20 18:44:06 -05:00
Lang Martin f45bebdb66 command: quota init writes files with a network limit 2019-11-20 18:44:06 -05:00
Lang Martin 2e2c662977 command: quota status reports network usage 2019-11-20 18:44:06 -05:00
Michael Schurter 5e2ee1e237 docs: added #6021 to changelog 2019-11-20 15:34:25 -08:00
Michael Schurter 4b6762511d
Merge pull request #6021 from hashicorp/f-anonymous-policy-access
api: Update policy endpoint to permit anonymous access
2019-11-20 15:33:45 -08:00
Michael Schurter 48239d7f2e
Merge pull request #6017 from hashicorp/f-policy-json
api: Add parsed rules to policy response
2019-11-20 15:31:03 -08:00
Mahmood Ali be6c60455e
Merge pull request #6669 from hashicorp/b-cors-allow-credentials
Allow UI to query client directly for task logs/state
2019-11-20 15:14:01 -05:00
Mahmood Ali 7514658039 simply link to vault .circleci README 2019-11-20 15:02:10 -05:00
Mahmood Ali 52af6e973b Refactor circleci CI scripts
This adopts pattern used by Vault, where we split CircleCI yaml config
into multiple files that get packed and translated to 2.0.

This has two motivations: First, to ease translating config to CircleCI
2.0 so it can run on Enterprise private repository.  Second and most
importantly, it also adding Enterprise specific jobs in separate files
with reduced config file merging conflict resolution.
2019-11-20 15:02:08 -05:00
Mahmood Ali 45e91394ae build-deps-image no longer runs
This is a remenant of the time we used a custom hashicorp docker image for CI.
Currently, we use the official golang image, so no longer need the job
or manage the dockerhub credentials.
2019-11-20 14:57:48 -05:00
Mahmood Ali 29a457cbdd Ignore ci workflow in stable-website
`stable-website` branch is only meant for updating the nomadproject.io
website, and the backend tests are irrelevant.  Also, the ci workflow
uses up the plans containers and may delay website deployments by 20
minutes or more while we are cutting a release.
2019-11-20 14:57:45 -05:00