db4a634072
RPC, FSM, State Store for marking DesiredTransistion
...
fix build tag
2018-03-21 16:49:48 -07:00
bb0ff44fb4
mock_driver: improve Kill() logging
2018-03-21 16:49:48 -07:00
c0542474db
drain: initial drainv2 structs and impl
2018-03-21 16:49:48 -07:00
f329e45e03
always set initial health status for every driver
2018-03-21 15:15:26 -04:00
bbaffe3eca
set driver to unhealthy once if it cannot be detected in periodic check
2018-03-21 15:15:26 -04:00
5df4b3728d
Docker driver doesn't return errors but injects into the DriverInfo
2018-03-21 15:15:26 -04:00
4365bb7f59
Only run health check if driver is detected
2018-03-21 15:15:26 -04:00
f801709a0a
fix issue when updating node events
2018-03-21 15:15:26 -04:00
285729aee2
function rename and re-arrange functions in fingerprint_manager
2018-03-21 15:15:26 -04:00
60f12d206f
improve comments; update watchDriver
2018-03-21 15:15:26 -04:00
739784736a
remove unused function
2018-03-21 15:15:26 -04:00
d92703617c
simplify logic
...
bump log level
2018-03-21 15:15:26 -04:00
86b7b3d2d9
fix up health check logic comparison; add node events to client driver checks
2018-03-21 15:15:26 -04:00
53a5bc2bb3
Code review feedback
2018-03-21 15:15:26 -04:00
34dc58421c
notes from walk through
2018-03-21 15:15:26 -04:00
44b6951dda
improve tests
2018-03-21 15:15:26 -04:00
d740a6a46e
refresh driver information for non-health checking drivers periodically
2018-03-21 15:15:26 -04:00
d8f68e5ef8
fix up codereview feedback
2018-03-21 15:15:26 -04:00
d5f6c940c4
fix up racy tests
2018-03-21 15:15:26 -04:00
0425be8f48
updating comments; locking concurrent node access
2018-03-21 15:15:26 -04:00
c50d02ae93
go style; update comments
2018-03-21 15:15:25 -04:00
3aa726baab
fix scheduler driver name; create node structs file
2018-03-21 15:15:25 -04:00
3cba95e8a7
allow nomad to schedule based on the status of a client driver health check
...
Slight updates for go style
2018-03-21 15:15:25 -04:00
0bde357731
add concept of health checks to fingerprinters and nodes
...
fix up feedback from code review
add driver info for all drivers to node
2018-03-21 15:15:25 -04:00
1022170bf3
executor: increase level for helpful log lines
...
Should help with debugging issues like #3971
2018-03-21 11:53:58 -07:00
6019a88824
Make raw_exec processes cleanup function more precise.
2018-03-20 13:40:21 +01:00
bb36c122e2
Fix errors when trying to kill whole process group.
2018-03-20 13:40:21 +01:00
86d650d7b0
Make starting & cleaning process group Windows compatible.
2018-03-20 13:40:21 +01:00
79c139f2ef
Create new process group on process startup.
...
Clean up by sending SIGKILL to the whole process group.
2018-03-20 13:40:21 +01:00
1044bc0feb
Merge pull request #3984 from hashicorp/f-loosen-consul-skipverify
...
Replace Consul TLSSkipVerify handling
2018-03-16 11:21:28 -07:00
32ee5e0d53
Merge pull request #3990 from hashicorp/f-rkt-groups
...
rkt: allow specifying --group
2018-03-16 11:19:53 -07:00
bd78cfb039
rkt: allow specifying --group
2018-03-16 11:08:22 -07:00
fb10ec9c01
docker: make volume errors recoverable
...
The interface+mock just to test this one little error handling may seem
like overkill but there was just no other way to write an automated test
around this logic as there's no way to simluate this error with stock
Docker.
2018-03-15 17:52:43 -07:00
0971114f0c
Replace Consul TLSSkipVerify handling
...
Instead of checking Consul's version on startup to see if it supports
TLSSkipVerify, assume that it does and only log in the job service
handler if we discover Consul does not support TLSSkipVerify.
The old code would break TLSSkipVerify support if Nomad started before
Consul (such as on system boot) as TLSSkipVerify would default to false
if Consul wasn't running. Since TLSSkipVerify has been supported since
Consul 0.7.2, it's safe to relax our handling.
2018-03-14 17:43:06 -07:00
3c38eededd
Fix spelling in comment
2018-03-14 15:54:25 -05:00
bef4a8ee09
fix clearing node events
2018-03-14 09:48:59 -07:00
810eedfa2a
Merge pull request #3945 from hashicorp/f-add-node-events
...
Add node events
2018-03-14 08:42:55 -04:00
360d6e5a92
Merge pull request #3968 from hashicorp/f-nicer-vault-error
...
Make server side error messages from vault more clearer
2018-03-13 20:49:39 -05:00
de6ebb6e6c
small cleanup
2018-03-13 18:08:22 -07:00
b41501e442
code review feedback
2018-03-13 18:08:21 -07:00
1488b076d1
code review feedback
2018-03-13 18:08:21 -07:00
a8655320fd
fix up go check warnings
2018-03-13 18:08:21 -07:00
0934769b04
add client side emitting of node events
...
Changelog
2018-03-13 18:08:21 -07:00
914eaed64f
Address some code review comments
2018-03-13 18:19:16 -05:00
09c231ce43
Return the err from server correctly
2018-03-13 18:10:14 -05:00
9618f52746
Remove error wrapping and make vault connection server side errors clearer.
2018-03-13 17:09:03 -05:00
79df90acb0
Merge pull request #3958 from simplesurance/swappiness
...
fix: disable swap for executor_linux allocations
2018-03-13 10:10:22 -07:00
e6af051c93
fix: disable swap for executor_linux allocations
...
A comment in the nomad source code states that swapping for
executor_linux allocations is disabled but it wasn't.
Nomad wrote -1 to the memsw.limit_in_bytes cgroup file to disable
swapping.
This has the following problems:
1.) Writing -1 to the file does not disable swapping. It sets
the limit for memory and swap to unlimited.
2.) On common Linux distributions like Ubuntu 16.04 LTS the
memsw.limit_in_bytes cgroup file does not exist by default.
The memsw.limit_in_bytes file only exist if the Linux kernel is
build with CONFIG_MEMCG_SWAP=yes and either
CONFIG_MEMCG_SWAP_ENABLED=yes or when the kernel parameter
swapaccount=1 is passed during boot.
Most Linux distributions disable swap accounting by default because
of higher memory usage.
Nomad silently ignores if writing to the memsw.limit_in_bytes file
fails. The allocation succeeds, no message is logged to notify the
user.
To ensure that disabling swap works on common Linux kernels, disable
swapping by writing 0 to the memory.swappiness file.
Using the memory.swappiness file only requires that the kernel is
compiled with CONFIG_MEMCG=yes. This is the default in common Linux
kernels.
2018-03-13 10:52:50 +01:00
4844317cc2
Merge pull request #3890 from hashicorp/b-heartbeat
...
Heartbeat improvements and handling failures during establishing leadership
2018-03-12 14:41:59 -07:00
7dd7fbcda2
non-Existent -> nonexistent
...
Reverting from #3963
https://www.merriam-webster.com/dictionary/existent
2018-03-12 11:59:33 -07:00
18c5659474
spelling: version
2018-03-11 19:13:25 +00:00
6222bd564e
spelling: verify
2018-03-11 19:13:32 +00:00
1359fd2c3d
spelling: unexpected
2018-03-11 19:08:07 +00:00
173ce63fe9
spelling: transition
2018-03-11 19:06:05 +00:00
782c704de6
spelling: thresholds
2018-03-11 19:03:47 +00:00
ac6d3767da
spelling: terminated
2018-03-11 19:01:49 +00:00
2dda6abab9
spelling: templates
2018-03-11 19:01:39 +00:00
8978caea28
spelling: shutdown
2018-03-11 18:55:49 +00:00
8d191c9273
spelling: severity
2018-03-11 18:53:52 +00:00
a79eccaa58
spelling: service
2018-03-11 18:53:47 +00:00
8149694f3a
spelling: server
2018-03-11 18:55:30 +00:00
3787d8141e
spelling: serialize
2018-03-11 18:53:39 +00:00
e37626561c
spelling: semantics
2018-03-11 19:00:26 +00:00
e4639ac62f
spelling: secrets
2018-03-11 18:53:26 +00:00
cec45c6bc8
spelling: safety
2018-03-11 18:52:54 +00:00
de9d0c7180
spelling: retrieved
2018-03-11 18:51:40 +00:00
e949d23e1b
spelling: resource
2018-03-11 18:51:03 +00:00
82221f9a2b
spelling: represents
2018-03-11 18:42:29 +00:00
1c3b60ae70
spelling: replace
2018-03-11 18:41:53 +00:00
b47ab9ab8c
spelling: removes
2018-03-11 18:41:43 +00:00
db166c6cf6
spelling: remnants
2018-03-11 18:41:26 +00:00
258d76ec13
spelling: registry
2018-03-11 18:41:13 +00:00
7ad77f568b
spelling: purposes
2018-03-11 18:39:35 +00:00
6fa892a463
spelling: propagated
2018-03-11 18:39:26 +00:00
1a8204fa11
spelling: previous
2018-03-11 18:38:23 +00:00
f764e5552a
spelling: periodically
2018-03-11 18:36:59 +00:00
96e47bd4c1
spelling: parallelism
2018-03-11 18:35:54 +00:00
3c1ce6d16d
spelling: otherwise
2018-03-11 18:34:27 +00:00
96dba3e267
spelling: mount
2018-03-11 18:27:18 +00:00
13e5fb8221
spelling: malicious
2018-03-11 18:26:25 +00:00
1ef6d6319e
spelling: labels
2018-03-11 18:21:44 +00:00
b6ec60fb5f
spelling: isolation
2018-03-11 18:19:02 +00:00
337ac13f0a
spelling: interpolation
2018-03-11 18:16:36 +00:00
75d1240446
spelling: interface
2018-03-11 18:15:37 +00:00
c1a0ae3161
spelling: inspect
2018-03-11 18:15:27 +00:00
2a1cf2f216
spelling: initialization
2018-03-11 18:18:37 +00:00
b293b48287
spelling: idempotent
2018-03-11 18:14:50 +00:00
52b83328fc
spelling: heartbeating
2018-03-11 18:12:19 +00:00
3ad579930e
spelling: fingerprint
2018-03-11 18:07:37 +00:00
7f6e4012a0
spelling: existent
2018-03-11 18:30:37 +00:00
7cd95f6eb3
spelling: executor
2018-03-11 18:05:31 +00:00
b9ce8b9e37
spelling: each
2018-03-11 17:56:19 +00:00
0fc23b0ba3
spelling: down
2018-03-11 17:55:47 +00:00
e8478c4065
spelling: documentation
2018-03-11 17:55:21 +00:00
4241ffc5ab
spelling: disable
2018-03-11 17:55:12 +00:00
858b9e809f
spelling: directory
2018-03-11 17:55:06 +00:00
09970343b5
spelling: destruction
2018-03-11 17:54:39 +00:00
2f135f0ed7
spelling: destroy
2018-03-11 17:54:13 +00:00
97dc9a00c0
spelling: default
2018-03-11 17:52:58 +00:00
aaa6e104ed
spelling: could
2018-03-11 17:51:47 +00:00
c9b86bbc2f
spelling: controls
2018-03-11 17:50:39 +00:00
f2a7c95379
spelling: constraints
2018-03-11 17:50:28 +00:00
cb1303e47a
spelling: conjunction
2018-03-11 17:48:37 +00:00
42fa13bbc6
spelling: cancelled
2018-03-11 17:45:47 +00:00
7077386916
spelling: cancelable
2018-03-11 17:45:34 +00:00
a70fe97556
spelling: assert
2018-03-11 17:41:33 +00:00
58b794875f
spelling: artifact
2018-03-11 17:41:02 +00:00
e78cf9c81a
spelling: already
2018-03-11 17:39:04 +00:00
b8b46d3f74
spelling: allocation
2018-03-11 17:37:22 +00:00
e87b0a4d86
spelling: alloc
2018-03-11 17:36:34 +00:00
b67449796a
spelling: added
2018-03-11 17:34:28 +00:00
bd88877249
Merge pull request #3909 from hashicorp/b-node-attributes-concurrent-access
...
Fingerprinters accessing node information should be thread safe
2018-03-06 11:57:46 -05:00
7c7e2f4d0b
Merge pull request #3873 from hashicorp/r-edge-trigger-node-watcher
...
Edge trigger node updates
2018-03-01 15:18:59 -05:00
122d1c4e4a
simplify retry logic
2018-03-01 09:48:26 -05:00
557a70f78d
Merge pull request #3917 from jaininshah9/master
...
changing the formula to correctly pass the CPUQota to docker
2018-02-28 20:00:37 -08:00
39e1fc06e5
adding comments to the change
2018-02-28 16:19:51 -08:00
eaedffc7f7
Fix go vet errors
2018-02-28 12:21:27 -06:00
355805db56
reset timer after updating node copy
2018-02-27 17:18:10 -05:00
6eb7da002f
changing the formula to correctly pass the CPUQota to docker
2018-02-27 12:32:23 -08:00
a72aaaf47f
add network resources equal method, use time ticker
...
remove impossible test case
2018-02-27 12:42:53 -05:00
e736e31820
use time ticker, update how network resources are compared
2018-02-26 18:47:11 -05:00
5059065b52
improved testing; node networks comparison
2018-02-26 15:55:38 -05:00
b7bcd0b59f
fingerprinters accessing node information should be thread safe
2018-02-26 15:25:54 -05:00
1f31b39fe8
code review fixups
2018-02-26 12:36:30 -05:00
ed8c8afbcd
edge trigger node update
...
test update config copy trigger
2018-02-26 12:36:04 -05:00
49a47483d1
Registering back to initializing
...
Fix a bug in which if the node attributes/meta changed, we would
re-register the node in status initializing. This would incorrectly
trigger the client to log that it missed its heartbeat.
It would change the status of the Node to initializing until the next
heartbeat occured.
2018-02-16 17:49:31 -08:00
eff4455c68
Fix original client server list behavior
2018-02-15 16:04:53 -08:00
0ebf7f3b7f
remove tmp file
2018-02-15 15:51:27 -08:00
f9cf642436
Client tls
2018-02-15 15:22:57 -08:00
0e85ae77b4
fix flaky gc tests
2018-02-15 13:59:03 -08:00
38b695b69c
feedback and rebasing
2018-02-15 13:59:03 -08:00
9117ef4650
HTTP agent
2018-02-15 13:59:03 -08:00
d7029965ca
Server side impl + touch ups
2018-02-15 13:59:02 -08:00
ce0caccad2
client implementation of alloc gc and stats
2018-02-15 13:59:02 -08:00
e685211892
Code review feedback
2018-02-15 13:59:02 -08:00
a9c4f8a4c8
clarify force
2018-02-15 13:59:02 -08:00
dc75501c69
Respond to comments
2018-02-15 13:59:02 -08:00
cea77df6a7
Add Streaming RPC ack
...
This PR introduces an ack allowing the receiving end of the streaming
RPC to return any error that may have occured during the establishment
of the streaming RPC.
2018-02-15 13:59:02 -08:00
2f9d33f479
vet
2018-02-15 13:59:02 -08:00
f5f43218f5
HTTP and tests
2018-02-15 13:59:02 -08:00
6546b43a17
Client implementation of stream
2018-02-15 13:59:02 -08:00
9a5569678c
Client Stat/List impl
2018-02-15 13:59:02 -08:00
8854b35b34
Agent logs
2018-02-15 13:59:02 -08:00
857b0ab6c7
client tests
2018-02-15 13:59:02 -08:00
69def2ff22
Server tests of logs
2018-02-15 13:59:02 -08:00
9479cb7f25
Remove logging
2018-02-15 13:59:01 -08:00
14f57024b7
test stream framer
2018-02-15 13:59:01 -08:00
ddd67f5f11
Server streaming
2018-02-15 13:59:01 -08:00
ca9379be09
Logs over RPC w/ lots to touch up
2018-02-15 13:59:01 -08:00
2c0ad26374
New RPC Modes and basic setup for streaming RPC handlers
2018-02-15 13:59:01 -08:00
fea0e69d4f
wip fs endpoint
2018-02-15 13:59:01 -08:00
b5037f20db
Remove circular dependency
2018-02-15 13:59:01 -08:00
9bc75f0ad4
Fix manager tests and make testagent recover from port conflicts
2018-02-15 13:59:01 -08:00
feb943c873
Fix lint/comments
2018-02-15 13:59:01 -08:00
ac67da3b06
Unjankify the pkg
2018-02-15 13:59:01 -08:00
3f1f8604bb
initial round of comment review
2018-02-15 13:59:01 -08:00
e03b074650
Plumb config
2018-02-15 13:59:01 -08:00
05c4fe8675
Change defaults for min use duration
2018-02-15 13:59:01 -08:00
c8c1284bc3
SetServer command actually returns an error if given an invalid server
2018-02-15 13:59:01 -08:00
3f786b904b
use server manager
2018-02-15 13:59:01 -08:00
b24b05e025
Remove testing
2018-02-15 13:59:01 -08:00
4e1cb1d96e
Test RPC from server
2018-02-15 13:59:00 -08:00
6dd1c9f49d
Refactor
2018-02-15 13:59:00 -08:00
a6dfffa4fa
Add testing interfaces
2018-02-15 13:59:00 -08:00
d918f9bd5c
RPC Listener
2018-02-15 13:59:00 -08:00
1472b943d6
Stats Endpoint
2018-02-15 13:59:00 -08:00
0c0b56a1a4
Merge pull request #3807 from hashicorp/f-client-add-fingerprint-manager
...
Add fingerprint manager to manage fingerprinting node
2018-02-13 11:22:50 -05:00
b321287712
extract test helper
...
lock concurrent accesses to node
comment exported method
2018-02-12 18:30:10 -05:00
101e85f078
Merge pull request #3819 from schmichael/qemu-graceful-shutdown-alpine
...
Test QEMU graceful shutdown
2018-02-12 12:32:14 -08:00
ed6bce2ccf
Improve test logging
2018-02-12 11:25:52 -08:00
06397ba59d
Merge pull request #3825 from jaininshah9/master
...
add a flag for cpu_hard_limit
2018-02-08 20:40:38 -08:00
6e6915e7f5
Merge branch 'master' into f-cpu_hard_limit
2018-02-08 20:14:29 -08:00
eee7144643
drivers: use ctx.TaskEnv for mount points
2018-02-08 12:59:20 -06:00
a4516aa71a
removing underscore in variable name
2018-02-07 16:28:43 -08:00
4a26959825
code review feedback
2018-02-07 18:10:55 -05:00
d626d24488
remove dependency on client for fingerprint manager
2018-02-07 18:10:45 -05:00
e012e5ab8a
add fingerprint manager
2018-02-07 18:10:33 -05:00
8149587abe
clearing the confusion between microsecond,nanosecond and millisecond
2018-02-06 19:11:39 -08:00
d3087d6069
using d.node.Resources.CPU as suggested
2018-02-06 14:52:15 -08:00
279a3b3f28
Merge pull request #3790 from 42wim/dockerv6
...
Service registration for IPv6 docker addresses (Fixes #3785 )
2018-02-05 17:07:53 -08:00
25f0ad050f
docker: Skip IPv6 test if IPv6 disabled
2018-02-05 16:24:30 -08:00
42d20234a3
Merge pull request #3781 from hashicorp/f-client-fingerprint-refactor
...
Refactor client fingerprinters to return a diff of node attributes
2018-02-01 20:13:44 -05:00
b21233fe23
update log message
2018-02-01 19:46:57 -05:00
6f9c0ab361
req/resp should be within config locks; rename for detected fingerprints
...
changelog
2018-02-01 19:00:39 -05:00
a1a2ca8e33
Add AdvertiseIPv6Address test
2018-02-01 23:21:47 +01:00
94d0ce6006
wrapping the line to less than 80 characters
2018-02-01 14:16:38 -08:00
0d99f256de
changes after running go fmt
2018-02-01 12:07:05 -08:00
04c14b3cb2
add a flag for cpu_hard_limit
2018-02-01 10:09:12 -08:00
d889e471a2
fix up linting
2018-02-01 12:26:38 -05:00
b54203eddc
add detected to more drivers where the driver is found but unusable
2018-02-01 11:28:17 -05:00
0ac43a7622
Skip QEMU graceful shutdown test except on Travis
...
Hopefully we can reuse the SkipSlow helper elsewhere.
2018-01-31 15:47:26 -08:00
b8e8064835
code review fixup
2018-01-31 18:34:03 -05:00
24d060bbb4
Test graceful shutdown
...
Uses an Alpine image which supports ACPI poweroff signal handling.
Handling is only enabled after the VM has booted, so this test blocks
until sshd starts before issuing the command.
2018-01-31 15:05:02 -08:00
db3bdfe898
* Change use_ipv6_address to advertise_ipv6_address.
...
* Set autoadvertise to true.
* Update documentation.
2018-02-01 00:01:25 +01:00
7b53474a6e
add applicable boolean to fingerprint response
...
public fields and remove getter functions
2018-01-31 13:21:45 -05:00
cc54e36f91
Merge pull request #3798 from simar7/qemu-graceful-shutdown-bug
...
[QEMU] Fixing an unintentional variable shadowing
2018-01-30 17:43:44 -08:00
c662cc0172
Merge pull request #3773 from mikemccracken/2018-01-18/destroy-container-on-err
...
lxc: cleanup partially configured containers after errors in Start
2018-01-30 14:52:29 -08:00
9482c322b7
locks for fingerprint reads/writes
2018-01-30 11:32:45 -05:00
76f09db067
Service registration for IPv6 docker addresses
2018-01-30 17:07:47 +01:00
3ad5916f72
Merge pull request #3799 from mikemccracken/2018-01-25/lxc-log-outside-container
...
lxc: move lxc log file out of container-visible alloc dir
2018-01-29 14:32:22 -08:00
14147c8496
remove attributes from periodic fingerprints when state changes
...
write test for client periodic fingerprinters
2018-01-29 13:48:54 -05:00
3d28774f74
Merge pull request #3802 from filipochnik/docker-readonly-rootfs
...
Add ReadonlyRootfs option to the Docker driver
2018-01-29 09:47:27 -08:00
7db4ee1122
rkt_test.go: Remove underscore from variable names
2018-01-29 11:39:50 +01:00
80a17ee8dd
Add ReadonlyRootfs option to the Docker driver
2018-01-27 14:38:29 +01:00
7c19de797c
create safe getters and setters for fingerprint response
2018-01-26 11:22:05 -05:00
896d6f8058
fixups from code review
2018-01-26 07:04:32 -05:00
ac720b84f0
qemu: Make the driver debugging output more indicative
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2018-01-25 16:40:16 -08:00
8b058f7570
qemu: Fix unintentional shadowing of monitorPath variable
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2018-01-25 16:24:10 -08:00
09c9ca23f5
lxc: move lxc log file out of container-visible alloc dir
...
The LXC runtime's log file is currently written to TaskDir.LogDir,
which is mounted as alloc/logs inside the containers in the task
group.
This file is not intended to be visible to containers, and depending
on the log level, may have information about the host that a container
should not be allowed to see.
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-25 14:41:37 -08:00
88e3063717
fix speling in log
...
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-25 13:56:14 -08:00
3d38868b88
add test case for available cgroups
2018-01-25 06:08:07 -05:00
9a8344333b
refactor Fingerprint to request/response construct
2018-01-24 11:54:02 -05:00
f8fe2ea8cb
review cleanup
...
don't export an internal function, and simplify some code
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-23 15:03:09 -08:00
a43e0a7b08
Allow overriding an image's entrypoint in Docker
...
Fixes https://github.com/hashicorp/nomad/issues/2219
2018-01-23 14:05:00 -08:00
98a03ad689
Merge pull request #3754 from filipochnik/docker-caps
...
Add an option to add and drop capabilities in the Docker driver
2018-01-23 12:02:50 -08:00
d09cc2a69f
Merge pull request #3492 from hashicorp/f-client-tls-reload
...
Client/Server TLS dynamic reload
2018-01-23 05:51:32 -05:00
4abd269a68
Merge branch 'master' into docker-caps
2018-01-21 12:18:22 +01:00
558812350d
Finish implementation of the capabilities whitelist
2018-01-21 12:14:24 +01:00
00dcfa6db9
lxc: cleanup partially configured containers after errors in Start
...
If there are any errors in container setup after c.Create() in
Start(), the container will be left around, with no way to clean it up
because the handle will not be created or returned from Start.
Added a wrapper that checks for errors and performs appropriate
cleanup. Returning a cleanup function from a wrapped function instead
of just doing the cleanup before returning the error helps to ensure
that future changes that might add or change error exits can't forget
to consider a cleanup function.
Adds a check to the invalid config test case to check that a container
created with an invalid config doesn't get left behind.
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 16:03:03 -08:00
38182bebea
Drop log level to TRACE
...
For people not using driver networks these log lines would just be
confusing.
2018-01-18 15:35:24 -08:00
9d410c88a7
Improve driver network logging
2018-01-18 15:35:24 -08:00
583e17fad5
Always advertise driver IP when in driver mode
...
Fixes #3681
When in drive address mode Nomad should always advertise the driver's IP
in Consul even when no network exists. This matches the 0.6 behavior.
When in host address mode Nomad advertises the alloc's network's IP if
one exists. Otherwise it lets Consul determine the IP.
I also added some much needed logging around Docker's network discovery.
2018-01-18 15:35:24 -08:00
70817f728c
lxc_test: add test for contents of file in bind-mounted dir
...
Ensure that bind mounting via the volumes config really did work.
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 05:36:45 -08:00
fd44bdee37
Simplify with gofmt -s
...
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 04:17:42 -08:00
f176e02a64
lxc: add tests for volume support
...
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 04:17:42 -08:00
c78c00a2d2
lxc: Add config flag to disable volume support
...
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 04:17:42 -08:00
d694a8921f
Add volumes config to LXC driver
...
Allow lxc driver to accept bind mount config similarly to the docker
driver.
Includes some static sanity checks in Validate step
Signed-off-by: Michael McCracken <mikmccra@cisco.com>
2018-01-18 04:17:42 -08:00
649f86f094
refactor creating a new tls configuration
2018-01-16 08:02:39 -05:00
6c9f9c8ac3
adding additional test assertions; differentiate reloading agent and http server
2018-01-16 07:34:39 -05:00
4eeb552a4f
Add a sketch of capabilities whitelist logic for the Docker driver
2018-01-14 20:01:47 +01:00
8ee3ce7a26
Add an option to add and drop capabilities in the Docker driver
2018-01-14 19:56:57 +01:00
bec9a72eec
Remove networking from basic resources
2018-01-12 14:33:42 -08:00
867bb6f7f9
Found more priviledge.
...
priviledge -> privilege
2018-01-12 09:44:53 -05:00
9e1e04c6f1
Merge pull request #3727 from filipochnik/fix-gh-2832
...
Recognize renewing non-renewable Vault lease as fatal
2018-01-10 11:47:10 -08:00
189ce7f991
Merge pull request #3723 from hashicorp/b-3702-chown-dirs
...
chown dirs when migrating ephemeral_disk data
2018-01-09 09:27:26 -08:00
e6c27256b7
Test streamed directory ownership
2018-01-08 16:00:07 -08:00
2c79ffb213
chown dirs when migrating ephemeral_disk data
...
Fixes #3702
Added missing chown call and made it conditional on running as root and
not on Windows as we do with files.
2018-01-08 15:31:12 -08:00
1bb1ab5069
fix typo
...
Priviledge -> privilege
2018-01-08 15:56:07 -05:00
214d128eb9
reload raft transport layer
...
fix up linting
2018-01-08 14:52:28 -05:00
d265e11c36
Recognize renewing non-renewable Vault lease as fatal
2018-01-08 20:32:31 +01:00
0708d34135
call reload on agent, client, and server separately
2018-01-08 09:56:31 -05:00
9741097406
reloading tls config should be atomic for clients/servers
2018-01-08 09:21:06 -05:00
ae7fc4695e
fixups from code review
...
Revert "close raft long-lived connections"
This reverts commit 3ffda28206fcb3d63ad117fd1d27ae6f832b6625.
reload raft connections on changing tls
2018-01-08 09:21:06 -05:00
acd3d1b162
fix up downgrading client to plaintext
...
add locks around changing server configuration
2018-01-08 09:21:06 -05:00
c0ad9a4627
add ability to upgrade/downgrade nomad agents tls configurations via sighup
2018-01-08 09:21:06 -05:00
ef76c65da1
Lookup euid outside of loop
2017-12-13 11:50:12 -08:00
5032bf4f5a
Skip tests that require root when not root
...
Also skip Chown on allocdir migration on Windows and when non-root.
Windows doesn't support it, and it will always fail as a non-root user.
2017-12-12 16:58:27 -08:00
f0b0697b57
Keyify struct
2017-12-11 17:23:14 -08:00
c4d4ead199
Fix test broken by mock updates
2017-12-08 16:45:25 -08:00
4b20441eef
Validate port label for host address mode
...
Also skip getting an address for script checks which don't use them.
Fixed a weird invalid reserved port in a TaskRunner test helper as well
as a problem with our mock Alloc/Job. Hopefully the latter doesn't cause
other tests to fail, but we were referencing an invalid PortLabel and
just not catching it before.
2017-12-08 12:03:43 -08:00
Alex Dadgar