87be233aca
test: improve readability of duration
...
Co-Authored-By: schmichael <michael.schurter@gmail.com>
2019-02-14 08:12:06 -08:00
16d3414842
test: improve failure message
...
Co-Authored-By: schmichael <michael.schurter@gmail.com>
2019-02-14 08:11:37 -08:00
4814f0fb0b
tests: port TestTaskRunner_Download_List from 0.8
2019-02-12 15:48:04 -08:00
a152e3ef17
consul: fix task deregistration hook
...
Broke ShutdownDelay but the test was timing dependent so it just
appeared flaky. Made the test slower so that it should never incorrectly
pass.
2019-02-12 15:36:02 -08:00
4ad879e75e
tests: port TaskRunner_DeriveToken tests from 0.8
2019-02-12 15:36:02 -08:00
6743ed9fdc
tests: port TestTaskRunner_BlockForVault from 0.8
...
Also fix race conditions in the mock vault client.
2019-02-12 13:46:09 -08:00
6c0cc65b2e
simplify hcl2 parsing helper
...
No need to pass in the entire eval context
2019-02-04 11:07:57 -08:00
5062c54874
Fix usage of fsi variable
2019-01-29 14:07:55 -08:00
6f418ebaf0
Always populate task dir environment variables
...
Fixes an issue where if a task was restarted after restating the client,
the task dir environment variables would not be populated. This PR fixes
this for both upgrades from 0.8.X and for normal 0.9 restarts.
2019-01-29 13:17:10 -08:00
5da21635fb
Fix env templates having interpolated destinations
...
Fixes an issue where env templates that had interpolated destinations
would not work.
Fixes https://github.com/hashicorp/nomad/issues/5250
2019-01-28 10:28:53 -08:00
d6412fd8e7
Fix double restart counting for templates
...
This PR fixes an issue where template restarts would count twice since
it was emitting a restarting event.
2019-01-25 15:38:13 -08:00
a36c4320ff
Merge pull request #5227 from hashicorp/b-client-highcpu-usage
...
Fix bug related to high cpu usage
2019-01-23 14:27:51 -05:00
13f061a83f
Merge pull request #5196 from hashicorp/f-plugin-utils
...
Make plugins/shared external and make pluginutls/
2019-01-23 06:59:32 -08:00
05bf183ba3
Merge pull request #5225 from hashicorp/b-notaskevent-terminalallocs
...
Don't emit task events after alloc is in a terminal DesiredState
2019-01-23 08:54:10 -06:00
32daa7b47b
goimports until make check is happy
2019-01-23 06:27:14 -08:00
bcc3935228
tr: use context in as select statement
2019-01-22 20:11:39 -05:00
be0bab7c3f
move pluginutils -> helper/pluginutils
...
I wanted a different color bikeshed, so I get to paint it
2019-01-22 15:50:08 -08:00
2ca0e97361
Split hclspec
2019-01-22 15:43:34 -08:00
5ca6dd7988
move hclutils
2019-01-22 15:43:34 -08:00
72a5691897
Driver tests do not use hcl2/hcl, hclspec, or hclutils
2019-01-22 15:43:34 -08:00
38422642cb
Use DesiredState to determine whether to stop sending task events
2019-01-22 16:43:32 -06:00
862c9b7de5
dont emit events for terminal allocs
2019-01-22 16:26:33 -06:00
1fa376cac6
Merge pull request #5211 from hashicorp/test-porting-08
...
Port some 0.8 TaskRunner tests
2019-01-22 14:05:53 -08:00
8ced0adb67
test: port TestTaskRunner_CheckWatcher_Restart
...
Added ability to adjust the number of events the TaskRunner keeps as
there's no way to observe all events otherwise.
Task events differ slightly from 0.8 because 0.9 emits Terminated every
time a task exits instead of only when it exits on its own (not due to
restart or kill).
0.9 does not emit Killing/Killed for restarts like 0.8 which seems fine
as `Restart Signaled/Terminated/Restarting` is more descriptive.
Original v0.8 events emitted:
```
expected := []string{
"Received",
"Task Setup",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Not Restarting",
}
```
2019-01-22 09:46:46 -08:00
1719752a9d
test: port RestartTask from 0.8
2019-01-22 08:08:08 -08:00
9edff19625
test: port SignalFailure test from 0.8
...
Also fix signal error handling in mock_driver.
2019-01-22 08:08:08 -08:00
299a5fc821
Rename TaskKillRequest/Response to TaskPreKillRequest/Response
2019-01-22 09:54:02 -06:00
5a5b9c5666
Fix log comments
2019-01-22 09:45:58 -06:00
06e15f8381
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:56 -06:00
3b02af9386
Fix comment
...
Co-Authored-By: preetapan <preetha@hashicorp.com>
2019-01-22 09:41:21 -06:00
09291c689b
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:21 -06:00
47127de671
ar: return error from hooks if occured
2019-01-18 18:31:02 -05:00
5df63fda7c
Merge pull request #5190 from hashicorp/f-memory-usage
...
Track Basic Memory Usage as reported by cgroups
2019-01-18 16:46:02 -05:00
290c3f36ad
set TaskGroupName in task_runner
2019-01-18 20:25:11 +00:00
8917961caa
documenting test for task runner failure to set TaskGroupName
2019-01-18 20:00:49 +00:00
cfadacfd95
Merge pull request #5203 from hashicorp/b-terminated
...
client: restore Terminated event on every exit
2019-01-18 08:54:15 -08:00
e0b68a19c6
Fix one more place that should be using taskResources
...
taskResources handles new resource fields in a backwards compatible way
2019-01-17 15:52:51 -06:00
a20ac7c1de
client: restore Terminated event on every exit
...
v0.9.0-dev started emitting a Terminated event every time a task process
exited. While this wasn't true in previous versions, it's a useful task
event because it's the only place for job operators to view the task's
exit code.
This behavior is asserted in the e2e/taskevents tests.
2019-01-17 10:02:25 -08:00
a695b3562c
Merge pull request #5193 from hashicorp/dani/logmon-reattach
...
logmon: Reattach to existing loggers
2019-01-16 17:34:13 +01:00
99da4c780d
logmon: Reattach to existing loggers
...
This commit prevents us from creating duplicate logmon hooks when
restoring allocations by persisting the logmon reattach config using
HookData.
2019-01-16 14:56:10 +01:00
daa7d029a1
test: porting TestTaskRunner_SimpleRun_Dispatch
...
Porting test from 0.8 to 0.9.
2019-01-15 15:22:13 -08:00
48afda786b
Merge pull request #5187 from hashicorp/test-consul
...
Port a bunch of pre-0.9 Consul tests to 0.9
2019-01-15 07:41:50 -08:00
9909d98bee
Track Basic Memory Usage as reported by cgroups
...
Track current memory usage, `memory.usage_in_bytes`, in addition to
`memory.max_memory_usage_in_bytes` and friends. This number is closer
what Docker reports.
Related to https://github.com/hashicorp/nomad/issues/5165 .
2019-01-14 18:47:52 -05:00
c619e70d39
Merge pull request #5018 from hashicorp/f-executor-stats
...
executor: streaming stats api
2019-01-14 15:02:35 -05:00
4e7ea460e8
test: port some pre-0.9 DeploymentHealth tests
...
Skipping a failing one as I need to move to some other work and don't
want to leave this work orphaned on my machine.
2019-01-14 09:56:53 -08:00
ff2f23f5f9
test: assert service interpolation behavior
...
Ported from pre-0.9 tests.
2019-01-14 09:56:53 -08:00
e877bb6370
test: assert shutdown delay deregs first
...
Restore a pre-0.9 test that asserts Consul services are deregistered
before a task's shutdown delay.
2019-01-14 09:56:53 -08:00
1ca858fa92
Update client/allocrunner/taskrunner/stats_hook.go
...
Co-Authored-By: nickethier <ncethier@gmail.com>
2019-01-14 12:31:27 -05:00
fbd403df96
tr: stop stats collection on Exited hook
2019-01-14 12:30:14 -05:00
597b7b751d
tr: add retry /w backoff to stats_hook failure
2019-01-12 12:18:24 -05:00
Mahmood Ali