luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Fix double restart counting for templates 

This PR fixes an issue where template restarts would count twice since
it was emitting a restarting event.
This commit is contained in:
Alex Dadgar 2019-01-25 15:38:13 -08:00
parent a9a336a65f
commit d6412fd8e7
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/allocrunner/taskrunner/template/template.go
View File

@ -441,7 +441,7 @@ func (tm *TaskTemplateManager) handleTemplateRerenders(allRenderedTime time.Time
if restart {
tm.config.Lifecycle.Restart(context.Background(),
structs.NewTaskEvent(structs.TaskRestarting).
structs.NewTaskEvent(structs.TaskRestartSignal).
SetDisplayMessage("Template with change_mode restart re-rendered"), false)
} else if len(signals) != 0 {
var mErr multierror.Error

7
e2e/consultemplate/consultemplate.go
View File

@ -96,7 +96,7 @@ func (tc *ConsulTemplateTest) TestUpdatesRestartTasks(f *framework.F) {
}
first := allocs[0]
return first.TaskStates["test"].Restarts
}, 5*time.Second, time.Second).Should(Equal(count), "Incorrect restart count")
}, 10*time.Second, time.Second).Should(Equal(count), "Incorrect restart count")
}
// Wrap in retry to wait until placement
@ -132,10 +132,7 @@ func (tc *ConsulTemplateTest) TestUpdatesRestartTasks(f *framework.F) {
require.Nil(err)
// Wrap in retry to wait until restart
// TODO(dani): FIXME: This restart counter should only be 1. This is
// likely an accounting bug in restart tracking from
// template hooks.
waitForRestartCount(2)
waitForRestartCount(1)
}
func (tc *ConsulTemplateTest) AfterEach(f *framework.F) {