Commit graph

15190 commits

Author SHA1 Message Date
Danielle Lancashire ae8bb7365a
alloc-lifecycle: Fix restart with empty body
Currently when you submit a manual request to the alloc lifecycle API
with a version of Curl that will submit empty bodies, the alloc restart
api will fail with an EOF error.

This behaviour is undesired, as it is reasonable to not submit a body at
all when restarting an entire allocation rather than an individual task.

This fixes it by ignoring EOF (not unexpected EOF) errors and treating
them as entire task restarts.
2019-06-12 15:35:00 +02:00
Mahmood Ali 2fb8cdd484
Merge pull request #5818 from hashicorp/b-consul-stanza
fix consul stanza parsing when multiple -config arguments are used
2019-06-12 06:29:24 -04:00
Lang Martin 3837c9b021 command add comments re: defaults to LoadConfig 2019-06-11 22:35:43 -04:00
Lang Martin 02aae678be config_parse_test update comment for accuracy 2019-06-11 22:30:20 -04:00
Lang Martin 7aa95ebd6f config_parse get rid of ParseConfigDefault 2019-06-11 22:00:23 -04:00
Lang Martin 9b0411af6a Revert "config explicitly merge defaults once when using a config directory"
This reverts commit 006a9a1d454739eee21b7d8abb8b7aef1353b648.
2019-06-11 22:00:23 -04:00
Mahmood Ali 1fcb1567bc correct GH-5812 changelog 2019-06-11 19:46:50 -04:00
Mahmood Ali 4993252601 changelog GH-5817 2019-06-11 19:44:18 -04:00
Mahmood Ali fbf226bd25
Merge pull request #5817 from hashicorp/b-consul-stanza
fix consul stanza parsing when a configuration directory is used
2019-06-11 19:17:32 -04:00
Lang Martin 1e2f87a11e agent/testdata add a configuration directory for testing 2019-06-11 16:34:04 -04:00
Lang Martin fe8a4781d8 config merge maintains *HCL string fields used for duration conversion 2019-06-11 16:34:04 -04:00
Lang Martin 3bd153690b config_parse_test, handle defaults 2019-06-11 16:34:04 -04:00
Lang Martin c97dd512f4 config explicitly merge defaults once when using a config directory 2019-06-11 15:42:27 -04:00
Lang Martin ad56434472 config_parse split out defaults from ParseConfig 2019-06-11 15:42:27 -04:00
Buck Doyle 93e7f60be5
Change Netlify site id (#5814)
The Netlify site now belongs to the Hashicorp organisation
rather than the hc-nomad user.
2019-06-11 14:25:55 -05:00
Mahmood Ali 6f2bcb8775 scripts: use /dev/null when verifying s3 2019-06-11 13:30:54 -04:00
Mahmood Ali 165a4ea868 update changelog for 0.9.3 2019-06-11 13:25:27 -04:00
Mahmood Ali 79698489dc
Merge pull request #5806 from hashicorp/b-systemd-cgroups-path
drivers/exec: use an independent name=systemd cgroup path
2019-06-11 13:00:44 -04:00
Mahmood Ali 5734c8a648 update comment 2019-06-11 13:00:26 -04:00
Mahmood Ali d16f9df59b
Merge pull request #5812 from hashicorp/fix-allocresources-reference
Fallback to `alloc.TaskResources` for old allocs
2019-06-11 11:33:25 -04:00
Mahmood Ali 2acf30fdd3 Fallback to alloc.TaskResources for old allocs
When a client is running against an old server (e.g. running 0.8),
`alloc.AllocatedResources` may be nil, and we need to check the
deprecated `alloc.TaskResources` instead.

Fixes https://github.com/hashicorp/nomad/issues/5810
2019-06-11 10:32:53 -04:00
Lang Martin a476cff2ba
Merge pull request #5802 from hashicorp/b-config-meta-parsing
config meta parsing
2019-06-11 09:12:36 -04:00
Mahmood Ali 3dd9b939e3
Merge pull request #5805 from hashicorp/b-tg-rename-panic
Fix a panic related to updating alloc taskgroups
2019-06-11 08:53:55 -04:00
Mahmood Ali f7608c4cef exec: use an independent name=systemd cgroup path
We aim for containers to be part of a new cgroups hierarchy independent
from nomad agent.  However, we've been setting a relative path as
libcontainer `cfg.Cgroups.Path`, which makes libcontainer concatinate
the executor process cgroup with passed cgroup, as set in [1].

By setting an absolute path, we ensure that all cgroups subsystem
(including `name=systemd` get a dedicated one).  This matches behavior
in Nomad 0.8, and behavior of how Docker and OCI sets CgroupsPath[2]

Fixes #5736

[1] d7edf9b2e4/vendor/github.com/opencontainers/runc/libcontainer/cgroups/fs/apply_raw.go (L326-L340)
[2] 238f8eaa31/vendor/github.com/containerd/containerd/oci/spec.go (L229)
2019-06-10 22:00:12 -04:00
Mahmood Ali 7a4900aaa4 client/allocrunner: depend on internal task state
Alloc runner already tracks tasks associated with alloc.  Here, we
become defensive by relying on the alloc runner tracked tasks, rather
than depend on server never updating the job unexpectedly.
2019-06-10 18:42:51 -04:00
Mahmood Ali 392f5bac44 Stop updating allocs.Job on stopping or preemption 2019-06-10 18:30:20 -04:00
Mahmood Ali 6c8e329819 test that stopped alloc jobs aren't modified
When an alloc is stopped, test that we don't update the job found in
alloc with new job  that is no longer relevent for this alloc.
2019-06-10 17:14:26 -04:00
Lang Martin a337488b5c config parse update hcl with support for decoding bool to string 2019-06-10 13:12:38 -04:00
Lang Martin 28cf8eddfe config parse_test check for string coercion in client.meta 2019-06-10 13:12:38 -04:00
Mahmood Ali 6742ef5d73 changelog GH-5794 2019-06-10 09:56:23 -04:00
Buck Doyle 16a5681e8a
Add PR previews with Netlify (#5787)
It would be preferable to only generate these for UI PRs but Netlify appears to
not have that flexibility. I tried setting up manual deployments in a Travis
environment but gave up the experiment; it could probably eventually work if
deployment failures become a nuisance.
2019-06-10 08:51:58 -05:00
Mahmood Ali 8f2308d070
Merge pull request #5794 from hashicorp/b-preemption-network-panic
Only preempt for network when there is a network
2019-06-10 07:10:29 -04:00
Mahmood Ali 5dc404ecab Only preempt for network when there is a network
When examining preemption for networks, only consider allocs that have
networks.

Fixes https://github.com/hashicorp/nomad/issues/5793
2019-06-07 18:55:55 -04:00
Mahmood Ali 98575f5788 test: add tests for network devices and preemption 2019-06-07 18:55:02 -04:00
Mahmood Ali d70e328b77
Merge pull request #5776 from hashicorp/b-flaky-e2e-test
flaky e2e test
2019-06-06 20:26:17 -04:00
Mahmood Ali e6cec7984a
Merge pull request #5788 from hashicorp/b-fix-node-down-test
tests: Migrated allocs aren't lost
2019-06-06 16:58:35 -04:00
Mahmood Ali 3eda42d027 tests: Migrated allocs aren't lost
Fix `TestServiceSched_NodeDown` for checking that the migrated allocs
are actually marked to be stopped.

The boolean logic in test made it skip actually checking client status
as long as desired status was stop.

Here, we mark some jobs for migration while leaving others as running,
and we check that lost flag is only set for non-migrated allocs.
2019-06-06 16:05:07 -04:00
Charlie Voiselle 1f05d6b39c
Merge pull request #5785 from john-lay/website-link-for-port-host-label
Fix a website link under `Runtime Environment`
2019-06-06 14:11:03 -04:00
john-lay e6c947e83a Update the link to point to #mapped-ports 2019-06-06 17:44:01 +01:00
john-lay 7f6e8d3229 Fix a website link under Runtime Environment
Under the `Network-related Variables` the `NOMAD_HOST_PORT_<label>` has
a incorrect link.
2019-06-06 14:28:30 +01:00
Mahmood Ali eb022e90c7
Merge pull request #5760 from hashicorp/f_improve_tfvars
Proposing new tfvars with additional inline docs
2019-06-06 09:09:21 -04:00
Mahmood Ali d30c3d10b0
Merge pull request #5747 from hashicorp/b-test-fixes-20190521-1
More test fixes
2019-06-05 19:09:18 -04:00
Mahmood Ali 87173111de
Merge pull request #5746 from hashicorp/b-no-updating-inmem-node
set node.StatusUpdatedAt in raft
2019-06-05 19:05:21 -04:00
Mahmood Ali 935ee86e92
Merge pull request #5737 from fwkz/fix-restart-attempts
Fix restart attempts of `restart` stanza in `delay` mode.
2019-06-05 19:05:07 -04:00
Preetha 72bfbe15b7
Merge pull request #5781 from hashicorp/b-revert-release-sup
Revert 0.9.2 release super script tags
2019-06-05 20:46:50 +05:30
Preetha Appan 503db78789
Update release version to 0.9.2 2019-06-05 20:45:17 +05:30
Preetha Appan 5d4a8d3b11
remove 0.9.2 rc1 download link 2019-06-05 20:41:11 +05:30
Preetha Appan 16f422589a
revert 0.9.2 super script tags 2019-06-05 20:39:22 +05:30
Mahmood Ali 97957fbf75 Prepare for 0.9.3 dev cycle 2019-06-05 14:54:00 +00:00
Mahmood Ali e620508e47
Release v0.9.2 2019-06-05 14:49:29 +00:00