0934769b04
add client side emitting of node events
...
Changelog
2018-03-13 18:08:21 -07:00
914eaed64f
Address some code review comments
2018-03-13 18:19:16 -05:00
09c231ce43
Return the err from server correctly
2018-03-13 18:10:14 -05:00
9618f52746
Remove error wrapping and make vault connection server side errors clearer.
2018-03-13 17:09:03 -05:00
4844317cc2
Merge pull request #3890 from hashicorp/b-heartbeat
...
Heartbeat improvements and handling failures during establishing leadership
2018-03-12 14:41:59 -07:00
173ce63fe9
spelling: transition
2018-03-11 19:06:05 +00:00
782c704de6
spelling: thresholds
2018-03-11 19:03:47 +00:00
8149694f3a
spelling: server
2018-03-11 18:55:30 +00:00
258d76ec13
spelling: registry
2018-03-11 18:41:13 +00:00
3c1ce6d16d
spelling: otherwise
2018-03-11 18:34:27 +00:00
1ef6d6319e
spelling: labels
2018-03-11 18:21:44 +00:00
52b83328fc
spelling: heartbeating
2018-03-11 18:12:19 +00:00
c9b86bbc2f
spelling: controls
2018-03-11 17:50:39 +00:00
e78cf9c81a
spelling: already
2018-03-11 17:39:04 +00:00
b8b46d3f74
spelling: allocation
2018-03-11 17:37:22 +00:00
122d1c4e4a
simplify retry logic
2018-03-01 09:48:26 -05:00
355805db56
reset timer after updating node copy
2018-02-27 17:18:10 -05:00
a72aaaf47f
add network resources equal method, use time ticker
...
remove impossible test case
2018-02-27 12:42:53 -05:00
e736e31820
use time ticker, update how network resources are compared
2018-02-26 18:47:11 -05:00
5059065b52
improved testing; node networks comparison
2018-02-26 15:55:38 -05:00
1f31b39fe8
code review fixups
2018-02-26 12:36:30 -05:00
ed8c8afbcd
edge trigger node update
...
test update config copy trigger
2018-02-26 12:36:04 -05:00
49a47483d1
Registering back to initializing
...
Fix a bug in which if the node attributes/meta changed, we would
re-register the node in status initializing. This would incorrectly
trigger the client to log that it missed its heartbeat.
It would change the status of the Node to initializing until the next
heartbeat occured.
2018-02-16 17:49:31 -08:00
eff4455c68
Fix original client server list behavior
2018-02-15 16:04:53 -08:00
f9cf642436
Client tls
2018-02-15 15:22:57 -08:00
e685211892
Code review feedback
2018-02-15 13:59:02 -08:00
2c0ad26374
New RPC Modes and basic setup for streaming RPC handlers
2018-02-15 13:59:01 -08:00
9bc75f0ad4
Fix manager tests and make testagent recover from port conflicts
2018-02-15 13:59:01 -08:00
3f1f8604bb
initial round of comment review
2018-02-15 13:59:01 -08:00
c8c1284bc3
SetServer command actually returns an error if given an invalid server
2018-02-15 13:59:01 -08:00
3f786b904b
use server manager
2018-02-15 13:59:01 -08:00
6dd1c9f49d
Refactor
2018-02-15 13:59:00 -08:00
1472b943d6
Stats Endpoint
2018-02-15 13:59:00 -08:00
4a26959825
code review feedback
2018-02-07 18:10:55 -05:00
d626d24488
remove dependency on client for fingerprint manager
2018-02-07 18:10:45 -05:00
e012e5ab8a
add fingerprint manager
2018-02-07 18:10:33 -05:00
b21233fe23
update log message
2018-02-01 19:46:57 -05:00
6f9c0ab361
req/resp should be within config locks; rename for detected fingerprints
...
changelog
2018-02-01 19:00:39 -05:00
b8e8064835
code review fixup
2018-01-31 18:34:03 -05:00
7b53474a6e
add applicable boolean to fingerprint response
...
public fields and remove getter functions
2018-01-31 13:21:45 -05:00
9482c322b7
locks for fingerprint reads/writes
2018-01-30 11:32:45 -05:00
7c19de797c
create safe getters and setters for fingerprint response
2018-01-26 11:22:05 -05:00
896d6f8058
fixups from code review
2018-01-26 07:04:32 -05:00
9a8344333b
refactor Fingerprint to request/response construct
2018-01-24 11:54:02 -05:00
649f86f094
refactor creating a new tls configuration
2018-01-16 08:02:39 -05:00
6c9f9c8ac3
adding additional test assertions; differentiate reloading agent and http server
2018-01-16 07:34:39 -05:00
214d128eb9
reload raft transport layer
...
fix up linting
2018-01-08 14:52:28 -05:00
0708d34135
call reload on agent, client, and server separately
2018-01-08 09:56:31 -05:00
9741097406
reloading tls config should be atomic for clients/servers
2018-01-08 09:21:06 -05:00
ae7fc4695e
fixups from code review
...
Revert "close raft long-lived connections"
This reverts commit 3ffda28206fcb3d63ad117fd1d27ae6f832b6625.
reload raft connections on changing tls
2018-01-08 09:21:06 -05:00
acd3d1b162
fix up downgrading client to plaintext
...
add locks around changing server configuration
2018-01-08 09:21:06 -05:00
c0ad9a4627
add ability to upgrade/downgrade nomad agents tls configurations via sighup
2018-01-08 09:21:06 -05:00
91ffbbb517
Review feedback
2017-12-07 16:10:57 -08:00
02baa6c52b
Handle race between fingerprinters and registration
2017-12-07 13:09:37 -08:00
4409fdacc0
Drop trace logging
2017-12-06 18:02:24 -08:00
cd9a7f14b8
Add logging around heartbeats
2017-12-06 17:57:50 -08:00
2dfda33703
Nomad agent reload TLS configuration on SIGHUP ( #3479 )
...
* Allow server TLS configuration to be reloaded via SIGHUP
* dynamic tls reloading for nomad agents
* code cleanup and refactoring
* ensure keyloader is initialized, add comments
* allow downgrading from TLS
* initalize keyloader if necessary
* integration test for tls reload
* fix up test to assert success on reloaded TLS configuration
* failure in loading a new TLS config should remain at current
Reload only the config if agent is already using TLS
* reload agent configuration before specific server/client
lock keyloader before loading/caching a new certificate
* introduce a get-or-set method for keyloader
* fixups from code review
* fix up linting errors
* fixups from code review
* add lock for config updates; improve copy of tls config
* GetCertificate only reloads certificates dynamically for the server
* config updates/copies should be on agent
* improve http integration test
* simplify agent reloading storing a local copy of config
* reuse the same keyloader when reloading
* Test that server and client get reloaded but keep keyloader
* Keyloader exposes GetClientCertificate as well for outgoing connections
* Fix spelling
* correct changelog style
2017-11-14 17:53:23 -08:00
1769db98b7
Fix regression by returning error on unknown alloc
2017-11-01 15:16:38 -05:00
73e9b57908
Trigger GCs after alloc changes
...
GC much more aggressively by triggering GCs when allocations become
terminal as well as after new allocations are added.
2017-11-01 15:16:38 -05:00
2a81160dcd
Fix GC'd alloc tracking
...
The Client.allocs map now contains all AllocRunners again, not just
un-GC'd AllocRunners. Client.allocs is only pruned when the server GCs
allocs.
Also stops logging "marked for GC" twice.
2017-11-01 15:16:38 -05:00
4831380e57
Node access is done using locked Node copy
...
Fixes https://github.com/hashicorp/nomad/issues/3454
Reliably reproduced the data race before by having a fingerprinter
change the nodes attributes every millisecond and syncing at the same
rate. With fix, did not ever panic.
2017-10-27 13:27:24 -07:00
15b991e039
base64 migrate token
...
HTTP header values must be ASCII.
Also constant time compare tokens and test the generate and compare
helper functions.
2017-10-13 10:59:13 -07:00
e1c4701a43
fix up build warnings
2017-10-11 17:11:57 -07:00
b018ca4d46
fixing up code review comments
2017-10-11 17:09:20 -07:00
410adaf726
Add functionality for authenticated volumes
2017-10-11 17:09:20 -07:00
a66c53d45a
Remove `structs` import from `api`
...
Goes a step further and removes structs import from api's tests as well
by moving GenerateUUID to its own package.
2017-09-29 10:36:08 -07:00
4173834231
Enable more linters
2017-09-26 15:26:33 -07:00
b26454cf99
Move setGaugeForAllocationStats to emitClientMetrics
2017-09-25 16:05:49 +00:00
d306da846c
changelog and feedback
2017-09-14 14:08:58 -07:00
07ed83fdd5
Non-locked accessors to common Node fields
...
This PR removes locking around commonly accessed node attributes that do
not need to be locked. The locking could cause nodes to TTL as the
heartbeat code path was acquiring a lock that could be held for an
excessively long time. An example of this is when Vault is inaccessible,
since the fingerprint is run with a lock held but the Vault
fingerprinter makes the API calls with a large timeout.
Fixes https://github.com/hashicorp/nomad/issues/2689
2017-09-14 14:08:26 -07:00
848af92183
fix panic in emitting tagged metrics
2017-09-11 15:32:37 +00:00
0ef43c3c5f
final code review fixups
2017-09-05 18:47:44 +00:00
a8cbd0b559
fixups from code review
2017-09-05 14:13:34 +00:00
f72e4aad13
labels depend on full setup of client beforehand
2017-09-05 14:13:34 +00:00
87a814397d
refactor to use baseLabels
2017-09-05 14:13:34 +00:00
b2953d905a
pass in commonly used values
2017-09-05 14:13:34 +00:00
c634043069
create base labels to be used in every metric
2017-09-05 14:13:34 +00:00
f5ea83da8d
emit metrics using labels, add option for backwards compatibility
2017-09-05 14:12:57 +00:00
76a03f2d8e
Address @dadgar feedback
2017-09-04 13:05:53 -07:00
688897561b
client: adding token cache for ACL resolution
2017-09-04 13:05:36 -07:00
c2e72e8a9c
client: create ACL and Policy cache
2017-09-04 13:05:35 -07:00
7342e23669
Move migrating state into prevAllocWatcher
2017-08-14 16:02:28 -07:00
e41a654917
switch from alloc blocker to new interface
...
interface has 3 implementations:
1. local for blocking and moving data locally
2. remote for blocking and moving data from another node
3. noop for allocs that don't need to block
2017-08-11 16:21:35 -07:00
ee04717a0b
initial attempt at refactoring blocked/migrating
2017-08-11 16:21:35 -07:00
ecee5e370e
initial watcher
2017-07-07 12:07:08 -07:00
644f0cfaa4
Consistently quote alloc ids in client logs
2017-07-06 10:24:52 -07:00
4fd9ef6a8c
Tiny client race condition fix
...
Plus some logging improvements that may help with #2563
2017-07-05 16:15:19 -07:00
596727230b
Suggest wiping out alloc dir too
2017-07-03 12:29:21 -07:00
11f68bfca2
Add more logging to restore state errors
2017-07-03 11:58:41 -07:00
c196d320f8
Add tests for migrating symlinks in alloc and local directories
2017-06-04 15:56:22 +09:30
236f24c9a4
Include symlinks in snapshots when migrating disks
...
Fixes #2685
2017-06-04 00:36:18 +09:30
b1eea2269a
Fix deadlock
2017-05-31 14:05:47 -07:00
ffc2b36dc7
Merge pull request #2636 from hashicorp/f-gc-alloc-limit
...
Add new gc_max_allocs tuneable
2017-05-30 16:14:09 -07:00
dd51aa1cb9
Merge pull request #2654 from hashicorp/f-env-consul
...
Add envconsul-like support and refactor environment handling
2017-05-30 14:40:14 -07:00
28aef447e9
Fix perms to just set exec bit
2017-05-25 14:44:13 -07:00
fd9bef768f
Move task env into execcontext
...
Also inject PATH into rkt commands since we're no longer appending host
env vars for it.
2017-05-23 13:53:34 -07:00
3841692138
gc_max_allocs should include blocked & migrating
2017-05-12 16:03:22 -07:00
0453c2709c
Add new gc_max_allocs tuneable
...
More than gc_max_allocs may be running on a node, but terminal allocs
will be garbage collected to try to keep the total number below the
limit.
2017-05-11 17:18:02 -07:00
68c3a2bd98
Fix vet errors
2017-05-11 13:08:08 -07:00
843bc26e5d
Respond to comments
2017-05-09 10:50:24 -07:00
Chelsea Holland Komlo