Commit graph

20248 commits

Author SHA1 Message Date
Buck Doyle 8348576473
Fix job recommendation test flakiness (#9591)
Instead of creating recommendations for all the jobs used
across these tests, this creates a specific job with
a higher group count, which reduces the likelihood
of having no recommendations to 0.0001%.

It was incorrect to assume that each task group would always
have recommendations, since there’s a 1% chance that a task
won’t have a recommendation. (10% chance for CPU and memory.)
This uses the number of groups with recommendations instead.
2020-12-10 10:10:25 -06:00
Kris Hicks 0cf9cae656
Apply some suggested fixes from staticcheck (#9598) 2020-12-10 07:29:18 -08:00
Kris Hicks 54a8b49c5e
pluginmanager: WaitForFirstFingerprint times out (#9597)
As pointed out by @tgross[1], prior to this change we would have been blocking
until all managers waited for first fingerprint rather than timing out as
intended.

1: https://github.com/hashicorp/nomad/pull/9590#discussion_r539534906
2020-12-10 07:27:15 -08:00
André Peters 29adb132e2 Update index.mdx
"Invalid argument name; Argument names must not be quoted."
2020-12-10 08:21:47 -05:00
Mahmood Ali fd420eadec
Tweak early return website workflow (#9593)
* ci: only spin up a docker engine if necessary

Halt the website-docker-image job early if no changes are detected. We
halt early before spinning up the remote docker engine, as the remote
docker engine step can add some delay (seconds to minutes) and is more
likely to suffer circleci instability.

* ci: Only run website workflow in OSS repo

Add a CircleCI conditional to avoid running website worklows on forks.
2020-12-09 17:54:36 -05:00
Seth Hoenig b3d744fea3
Merge pull request #9586 from hashicorp/f-connect-interp
consul/connect: interpolate connect block
2020-12-09 13:21:50 -06:00
Mahmood Ali 9a3da14a57
actually honor var files (#9592)
Apparently, we missed passing VarFile argument, so var files were
ignored.

Fixes #9588
2020-12-09 14:12:48 -05:00
Kris Hicks 0a3a748053
Add gosimple linter (#9590) 2020-12-09 11:05:18 -08:00
Kris Hicks c4ae5aab9a
circleci: Allow expanding Makefile in enterpise (#9587)
OSS no longer needs the multi-file config Makefile content, so it was
removed. However, enterprise does benefit from having that around. We
can allow enterprise to expand on OSS' CircleCI Makefile by adding an
include directive in OSS. This will allow the Makefile to be the same on
both OSS and Enterprise, so merge conflicts cannot occur.
2020-12-09 09:53:26 -08:00
Seth Hoenig cc70ce64ce consul/connect: avoid extra copy of connect stanza while interpolating 2020-12-09 11:44:07 -06:00
Seth Hoenig ead89d3a2b
docs: fixup changelog
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2020-12-09 11:27:12 -06:00
Seth Hoenig 526130ba12
Merge pull request #9589 from hashicorp/f-aws-graviton
client/fingerprint/cpu: use fallback total compute value if cpu not detected
2020-12-09 11:19:44 -06:00
Seth Hoenig eb7cdce52b client/fingerprint/cpu: use fallback total compute value if cpu not detected
Previously, Nomad would fail to startup if the CPU fingerprinter could
not detect the cpu total compute (i.e. cores * mhz). This is common on
some EC2 instance types (graviton class), where the env_aws fingerprinter
will override the detected CPU performance with a more accurate value
anyway.

Instead of crashing on startup, have Nomad use a low default for available
cpu performance of 1000 ticks (e.g. 1 core * 1 GHz). This enables Nomad
to get past the useless cpu fingerprinting on those EC2 instances. The
crashing error message is now a log statement suggesting the setting of
cpu_total_compute in client config.

Fixes #7989
2020-12-09 10:35:58 -06:00
Seth Hoenig b51459a879 consul/connect: interpolate connect block
This PR enables job submitters to use interpolation in the connect
block of jobs making use of consul connect. Before, only the name of
the connect service would be interpolated, and only for a few select
identifiers related to the job itself (#6853). Now, all connect fields
can be interpolated using the full spectrum of runtime parameters.

Note that the service name is interpolated at job-submission time,
and cannot make use of values known only at runtime.

Fixes #7221
2020-12-09 09:10:00 -06:00
Kris Hicks a841e3f7fa
circleci: Remove GO_TAGS from build-binaries job (#9579)
These tags default to the same value in GNUMakefile. This will also help
fix a discrepancy between the build-binaries job in OSS and Ent.
2020-12-09 06:56:56 -08:00
Drew Bailey 2f5710a3b7
use concrete type helper instead of interface surfing (#9585)
* use concrete type helper instead of interface surfing

* wrap err
2020-12-09 09:02:37 -05:00
Kris Hicks e97d9d7d00
Remove multi-file CircleCI config (#9571) 2020-12-08 13:18:11 -08:00
Kris Hicks 93155ba3da
Add gocritic to golangci-lint config (#9556) 2020-12-08 12:47:04 -08:00
Michael Schurter 48c150ec6c
Merge pull request #9574 from hashicorp/docs-20-to-1
docs: fix cpu comment for 10->1 to 20->1
2020-12-08 11:10:28 -08:00
Michael Schurter b70f5f2ff3 docs: fix cpu comment for 10->1 to 20->1
Reported by https://github.com/hashicorp/nomad/pull/8996/files#r538702174
2020-12-08 10:59:19 -08:00
Michael Schurter e2a8dc8f53
Merge pull request #9573 from hashicorp/docs-alert-100
docs: add an announcement for 1.0
2020-12-08 10:29:40 -08:00
Dennis Schön 038f2cce57
return 405 on non-GET requests to /v1/event/stream (fixes #9526) (#9564) 2020-12-08 13:09:20 -05:00
Michael Schurter 7d02f51494 docs: add an announcement for 1.0 2020-12-08 09:59:49 -08:00
Kris Hicks 62972cc839
scheduler: Fix always-false sort func (#9547)
Co-authored-by: Mahmood Ali <mahmood@hashicorp.com>
2020-12-08 09:57:47 -08:00
Michael Schurter c0b0c7ba2c
Merge pull request #9572 from hashicorp/docs-100-date
docs: add the release date for 1.0
2020-12-08 09:28:31 -08:00
Michael Schurter acd607ee68 docs: add the release date for 1.0 2020-12-08 09:27:26 -08:00
Michael Schurter ddea65f8c9
Merge pull request #9569 from hashicorp/docs-100
docs: 1.0.0 download link
2020-12-08 09:09:29 -08:00
Mike Wickett 0be0fb54b7
website: Update k8s comparison docs, ecosystem and community (#9557)
* website: add k8s vs callout to homepage

* website: move resources to community

* website: add k8s comparison, ecosytem to docs

* website: update redirects

* website: fix homepage link

* website: fix sidebar data

* Update website/pages/docs/nomad-vs-kubernetes/index.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>
2020-12-08 12:09:15 -05:00
Michael Schurter 5df1780bd7 docs: 1.0.0 download link 2020-12-08 08:00:21 -08:00
Mahmood Ali 020f6268b1
Remove Beta tag from 1.0 features (#9562)
* docs: Remove 1.0 beta warning about HCL2.0 docs

* docs: multiregion is not beta anymore either

* docs: scaling isn't beta

* docs: neither is events api
2020-12-08 09:39:25 -05:00
Tim Gross 82aad26330 changelog entry for #9495 2020-12-08 09:21:52 -05:00
davemay99 36022c9c59 nomad operator debug changelog / doc updates 2020-12-08 08:51:45 -05:00
davemay99 52c8a0f37d Update golang version table 2020-12-08 08:51:34 -05:00
Charlie Voiselle 02e09b673a Upgade links to guides 2020-12-08 08:51:21 -05:00
Dave May be0a14d70b
fix AgentHostRequest panic found in GH-9546 (#9554)
* debug: refactor nodeclass test
* debug: add case to track down SIGSEGV on client to server Agent.Host RPC
* verify server to avoid panic on AgentHostRequest RPC call, fixes GH-9546
* simplify Agent.Host RPC lookup logic
2020-12-07 17:34:40 -05:00
Michael Lange a01d6e95ea
Merge pull request #9553 from hashicorp/b-ui/missing-scale-events
UI: Guard against null Meta on scale events
2020-12-07 14:10:13 -08:00
Shishir a1b5c60bce
Update containerd task driver docs. (#9550) 2020-12-07 16:51:19 -05:00
Mark Lewis 80a3b87ec7
docs: grammatical fixes in service jobspec 2020-12-07 15:41:44 -05:00
Michael Lange 27c16d1f0a Test coverage for the scale event serializer 2020-12-07 12:28:47 -08:00
Michael Lange 58ecacc710 Guard against a null Meta property in the scale event API 2020-12-07 12:28:23 -08:00
Mahmood Ali d0495e1b56
document some hcl2 quarks (#9545)
Mainly note that block labels need to be string literals, and that decimals without a leading significant digits aren't acceptable anymore (e.g. .9 are required to be 0.9).

Dynamic blocks can be used here, but feels too much of a hack, or a hammer to highlight it here, specially given the error reporting and debugging isn't so straightforward. I'd advocate internally for relaxing the restriction and allowing expressions in block labels instead.

Related to https://github.com/hashicorp/nomad/issues/9522
2020-12-07 12:31:25 -05:00
Tim Gross ead6f801d8 changelog entry for #8822 2020-12-07 11:25:37 -05:00
Luiz Aoqui 20796e5815
docs: update autoscaling docs for the new query interface (#8917)
* update autoscaling docs for the new query interface
* update default value for query_window in scaling policy
2020-12-07 10:43:08 -05:00
Dennis Schön a9c97d9257
use os.ErrDeadlineExceeded in tests 2020-12-07 10:40:28 -05:00
Seth Hoenig 051a655d5b
Merge pull request #9541 from hashicorp/docs-cni-note-conflist
docs: note conflist extension for cni plugin configuration files
2020-12-07 09:40:00 -06:00
Seth Hoenig 07568b6a7e docs: note conflist extension for cni plugin configuration files 2020-12-07 09:36:39 -06:00
Buck Doyle 543fb24764
Fix allocation count in CSI volumes table (#9515)
This closes #9495. As detailed in there, the collection query GET
/v1/volumes?type=csi doesn’t return ReadAllocs and WriteAllocs, so the #
Allocs cell was always showing 0 upon first load because it was derived
from the lengths of those arrays. This uses the heretofore-ignored
CurrentReaders and CurrentWriters values to calculate the total instead.

The single-resource query GET /v1/volume/csi%2F:id doesn’t return
CurrentReaders and CurrentWriters that absence doesn’t override the
stored values when visiting an individual item.

Thanks to @apollo13 for reporting this and to @tgross for the API logs
and suggestion.
2020-12-07 08:51:41 -06:00
Buck Doyle 2d344179d3
Migrate preview deployments from Netlify to Vercel (#9471)
This adds:

* a script for building and deploying the Ember UI and Storybook to
  Vercel
* configuration for that deployment
* a header link to the UI to link to Storybook when built with
  STORYBOOK_LINK=true

It also removes a file used to configure Netlify redirects.

The Netlify setup had two “sites”: nomad-storybook and nomad-ui. I
attempted to replicate that here but ran into some platform limitations
with Vercel: two “projects” cannot share the same root directory without
also sharing the same vercel.json that lets us specify configuration
such as the rewrite needed to handle deep linking into the Ember UI. I
tried having Storybook use /ui/storybook as the root directory (and
adding a symbolically-linked package.json to bypass Vercel’s refusal
to build without it) but that produced broken Storybook deployments.

This instead combines the two projects into one
(nomad-storybook-and-ui), defaults to forwarding / to /ui/, and
adds the header link to the UI to navigate to Storybook.

Rather than have a complex build script in the Vercel configuration UI,
this delegates to a script in the repository.
2020-12-07 08:33:49 -06:00
Drew Bailey c0bd238eb2
fix allocation spelling error, update docs (#9527)
* fix allocation spelling error, update docs

* assign TopicACLPolicy and TopicACLToken properly
2020-12-04 12:04:58 -05:00
James Rasell 3934d3daca
Merge pull request #9520 from hashicorp/b-fix-nullchar-error-msg
core: fix typo msg used when job ID/name contains a null char.
2020-12-04 17:40:08 +01:00