f8a23bc54a
fix test comment
2018-05-09 16:01:34 -05:00
ef531b0f34
Add unit tests for forced rescheduling
2018-05-09 11:30:42 -05:00
c1b92c284e
Work in progress - force rescheduling of failed allocs
2018-05-08 17:26:57 -05:00
555d14fd92
Add test
2018-05-07 14:55:01 -05:00
cf44670d56
Make sure that task group has a deployment state before using it
2018-05-07 14:55:01 -05:00
c6478d9469
clarify comment
2018-05-07 14:55:01 -05:00
768fec8505
Allow healthy canary deployment to skip progress deadline
2018-05-07 14:55:01 -05:00
8626c1b94a
Reschedule when we have canaries properly
2018-05-07 14:55:01 -05:00
8dee3ab068
canary reschedule test
2018-05-07 14:50:01 -05:00
deb93dc7b7
Test for rescheduling when there are canaries
2018-05-07 14:50:01 -05:00
550f5e31f8
Allow canary count greater than desired
2018-05-07 14:50:01 -05:00
f95ab4ade8
Mark canaries on creation, and unmark on promotion
2018-05-07 14:50:01 -05:00
5329900f6d
Only use DesiredTransition.Reschedule in reconciler when its an active deployment
2018-05-07 14:50:01 -05:00
e7444c3873
Add test where deployment is marked as complete when done even with failed allocs
2018-05-07 14:50:01 -05:00
57969b4ee0
fix reconcile tests
2018-05-07 14:50:01 -05:00
5547974f35
Only reschedule allowed deployment allocs
2018-05-07 14:50:01 -05:00
fcf4f582d0
small review feedback fixes
2018-05-07 14:50:01 -05:00
1336002255
Progress deadline in deployment state
2018-05-07 14:50:01 -05:00
ee50789c22
Initial implementation
2018-05-07 14:50:01 -05:00
a569d34f25
Add custom status description for rescheduling follow up evals, and make unit test robust
2018-04-10 15:30:15 -05:00
e5b5803265
Only mark allocs as part of deployment if deployment is active
2018-04-05 15:40:49 -07:00
7e17bc231f
remove unnecessary check and other fixes from code review
2018-04-04 07:35:20 -05:00
00537c739b
Fixes edge cases around timing and task finish time being set more than once
2018-04-03 16:34:59 -05:00
3aa4ee9d75
Fix lost handling of not actually down nodes
2018-03-30 14:17:41 -07:00
d87e528059
rename skip->ignore and improve comment formatting
2018-03-29 15:11:10 -05:00
38a7614776
Refactored for readability, pair programmed with @dadgar
2018-03-29 13:28:37 -05:00
5090fefe96
Filter out allocs with DesiredState = stop, and unit tests
2018-03-29 09:28:52 -05:00
b18f789020
Unmark drain when nodes hit their deadline and only batch/system left and add all job type integration test
2018-03-28 17:25:58 -07:00
d2899728fd
Fix linting
2018-03-28 12:26:28 -05:00
9d60e2cebf
Correct status desc on draining system allocs
2018-03-26 17:54:46 -07:00
33e170c15d
s/linear/constant/g
2018-03-26 14:45:09 -05:00
5668c3c38e
Merge pull request #4037 from hashicorp/b-fix-terminal-filtering-service-allocs
...
Fix edge case in reconciler
2018-03-26 13:14:51 -05:00
1b9e413a1a
one field per line in struct definition
2018-03-26 13:13:21 -05:00
e106da84de
name and test
2018-03-26 11:06:21 -07:00
e2a6e64fca
Don't create unnecessary deployments
2018-03-23 16:55:21 -07:00
cbfd69ce7a
Fix edge case in reconciler where service jobs with ClientstatusComplete were not replaced
2018-03-23 18:41:00 -05:00
3b72dd94ba
Do not mark an allocation as an inplace update if specification hasn't changed
2018-03-23 14:36:05 -07:00
cb61a4bdc7
Fix linting errors
2018-03-21 16:51:45 -07:00
92b636dd32
Fix deadline handling
2018-03-21 16:51:44 -07:00
9263cc2ed7
scheduler: migrate non-terminal migrating allocs
...
filterByTainted node should always migrate non-terminal migrating allocs
2018-03-21 16:49:48 -07:00
d1ec65d765
switch to new raft DesiredTransition message
2018-03-21 16:49:48 -07:00
db4a634072
RPC, FSM, State Store for marking DesiredTransistion
...
fix build tag
2018-03-21 16:49:48 -07:00
c0542474db
drain: initial drainv2 structs and impl
2018-03-21 16:49:48 -07:00
329605b7cc
fix up scheduling test
2018-03-21 15:54:03 -04:00
60f12d206f
improve comments; update watchDriver
2018-03-21 15:15:26 -04:00
d92703617c
simplify logic
...
bump log level
2018-03-21 15:15:26 -04:00
d8f68e5ef8
fix up codereview feedback
2018-03-21 15:15:26 -04:00
c7fd0bd8a1
fix up scheduler mocks
2018-03-21 15:15:25 -04:00
3aa726baab
fix scheduler driver name; create node structs file
2018-03-21 15:15:25 -04:00
3cba95e8a7
allow nomad to schedule based on the status of a client driver health check
...
Slight updates for go style
2018-03-21 15:15:25 -04:00
56e60e5840
Fix linting warning
2018-03-14 16:12:22 -05:00
9a5e6edf1f
Rename DelayCeiling to MaxDelay
2018-03-14 16:10:32 -05:00
3e96c6c4e0
Address more code review feedback
2018-03-14 16:10:32 -05:00
9fed0d2103
Get reschedule policy from the alloc directly
2018-03-14 16:10:32 -05:00
e89bbf7289
Update comment about WaitTime
2018-03-14 16:10:32 -05:00
e2656ef546
Cleaner handling of batched evals
2018-03-14 16:10:32 -05:00
47e0280d96
More small review feedback
2018-03-14 16:10:32 -05:00
2ba976dec8
Remove unnecessary check against 5 second window for determining immediate scheduling eligibility
2018-03-14 16:10:32 -05:00
5373ade731
Scheduler and Reconciler changes to support delayed rescheduling
2018-03-14 16:10:32 -05:00
e0f6a33fe5
spelling: system
2018-03-11 19:01:19 +00:00
a89e1b8395
spelling: strategy
2018-03-11 18:58:19 +00:00
f8eb766fb5
spelling: reschedulable
2018-03-11 18:48:12 +00:00
ed8db9992e
spelling: feasibility
2018-03-11 18:07:09 +00:00
bf9283c606
spelling: corresponding
2018-03-11 17:51:41 +00:00
ca4ceb0e5c
spelling: commits
2018-03-11 17:47:45 +00:00
7b6ba7a1f4
Fixes bug in reconciler where previously rescheduled allocs are rescheduled again. Simplified logic and added test case to catch this.
2018-02-20 12:07:56 -06:00
7c57303dd2
Clarify comment
2018-02-05 16:37:07 -06:00
d48c411692
Reconciler should consider failed allocs when marking deployment as failed.
2018-02-02 19:40:25 -06:00
a1237d627a
code review feedback
2018-01-31 09:58:05 -06:00
5ad892026a
Add a field to track the next allocation during a replacement
2018-01-31 09:58:05 -06:00
2ed4de7e7b
Track previous node id correctly, plus unit test
2018-01-31 09:58:05 -06:00
dd4917c2f0
Add more clarification in comment
2018-01-31 09:58:05 -06:00
09bef7d1ce
Preallocate slice for skipped nodes
2018-01-31 09:58:05 -06:00
237beb49ae
Better score threshold
2018-01-31 09:58:05 -06:00
fa18c0def4
Add one more unit test
2018-01-31 09:58:05 -06:00
a75540cec6
Limit iterator uses a score threshold and a maxSkip value to be able to skip lower scoring nodes
2018-01-31 09:58:05 -06:00
b6268a5fab
Beef up unit test for rescheduling batch jobs
2018-01-31 09:56:53 -06:00
ea4a889e28
Address more code review feedback
2018-01-31 09:56:53 -06:00
bd89d2b39e
Make sure that reschedule trackers are not added for node drain replacements
2018-01-31 09:56:53 -06:00
a662b38801
Improve reconciler unit tests
2018-01-31 09:56:53 -06:00
fee4ccf154
Prevent side effect modification of select options when preferred nodes are set
2018-01-31 09:56:53 -06:00
21b7b79d5d
Add helper methods, use require and other code review feedback
2018-01-31 09:56:53 -06:00
d0f9d59abb
Reconile with changes to structs for reschedule tracking
2018-01-31 09:56:53 -06:00
fbb1936dee
Fix some comments and lint warnings, remove unused method
2018-01-31 09:56:53 -06:00
031c566ada
Reschedule previous allocs and track their reschedule attempts
2018-01-31 09:56:53 -06:00
fd2fbefa4c
Add a field to track the next allocation during a replacement
2018-01-24 17:55:05 -06:00
6dda0ebaed
gofmt
2018-01-04 14:45:15 -08:00
2f561609b7
Fix detection of successful batch allocations
...
This PR restores older behavior of detecting successful batch
allocations (04d86ffd1006fde9dfb2ca8c1237fe60b995b0e3). This has the
side effect that we correctly filter desired status stop but not
successful batch allocations and create their replacements.
2018-01-04 14:20:32 -08:00
1712b03705
Merge branch 'master' into 0.8
2018-01-03 16:06:38 -06:00
51bd0b59c7
Return an error if evaluation doesn't exist in state store at plan apply time.
2017-12-18 14:55:36 -06:00
3c36abfe14
Update eval modify index as part of plan apply.
2017-12-18 10:03:55 -06:00
3b4d7ac2a3
Fix some typos
2017-12-14 13:29:27 -06:00
45494f7304
Fix port labels on mock Alloc/Job/Node
2017-12-08 14:50:06 -08:00
44240ce440
Merge pull request #3375 from hashicorp/b-batch
...
Allow batch jobs to be rerun if purged
2017-10-13 17:11:45 -07:00
c1cc51dbee
sync
2017-10-13 14:36:02 -07:00
746cd7403f
Allow batch jobs to be rerun if purged
...
This PR allows batch jobs to be rerun if they have been purged.
2017-10-13 12:40:37 -07:00
a66c53d45a
Remove `structs` import from `api`
...
Goes a step further and removes structs import from api's tests as well
by moving GenerateUUID to its own package.
2017-09-29 10:36:08 -07:00
4173834231
Enable more linters
2017-09-26 15:26:33 -07:00
3904bde9a3
Fix batch handling of complete allocs/node drains
...
This PR fixes:
* An issue in which a node-drain that contains a complete batch alloc
would cause a replacement
* An issue in which allocations with the same name during a scale
down/stop event wouldn't be properly stopped.
* An issue in which batch allocations from previous job versions may not
have been stopped properly.
Fixes https://github.com/hashicorp/nomad/issues/3210
2017-09-14 15:08:57 -07:00
84d06f6abe
Sync namespace changes
2017-09-07 17:04:21 -07:00
0aef02a4f9
fix test
2017-08-21 14:07:54 -07:00
27256ebcc6
Placing allocs counts towards placement limit
...
This PR makes placing new allocations count towards the limit. We do not
restrict how many new placements are made by the limit but we still
count towards the limit. This has the nice affect that if you have a
group with count = 5 and max_parallel = 1 but only 3 allocs exist for it
and a change is made, you will create 2 more at the new version but not
destroy one, taking you down to two running as you would have
previously.
Fixes https://github.com/hashicorp/nomad/issues/3053
2017-08-21 12:41:19 -07:00
2453f13fc5
fixes
2017-08-15 12:27:05 -07:00
0570e09feb
Fix panic occuring from improper bitmap size
...
This PR fixes an allignment calculation when determining the bitmap
size.
Fixes https://github.com/hashicorp/nomad/issues/3008
2017-08-12 15:37:02 -07:00
f0ced87b95
fixed all spelling mistakes for goreport
2017-08-07 17:13:05 -04:00
7b13c0d702
Lost allocs replaced even if deployment failed
...
This PR allows the scheduler to replace lost allocations even if the job
has a failed or paused deployment. The prior behavior was confusing to
users.
Fixes https://github.com/hashicorp/nomad/issues/2958
2017-08-03 17:42:14 -07:00
7d2b84ab01
Review fixes
2017-08-01 14:18:52 -07:00
2650bb1d12
Distinct Property supports arbitrary limit
...
This PR enhances the distinct_property constraint such that a limit can
be specified in the RTarget/value parameter. This allows constraints
such as:
```
constraint {
distinct_property = "${meta.rack}"
value = "2"
}
```
This restricts any given rack from running more than 2 allocations from
the task group.
Fixes https://github.com/hashicorp/nomad/issues/1146
2017-07-31 16:52:13 -07:00
4f69355a66
Fix incorrect destructive update with distinct_property constraint
...
This PR fixes an issue in which an update to a task group with a
distinct property constraint would result in an incorrect destructive
update.
2017-07-31 11:17:35 -07:00
5f1f91a46c
Use go-testing-interface instead of testing
...
This drops the testings stdlib pkg from our dependencies. Saves a
whopping 46kb on our binary (was really hoping for more of a win there),
but also avoids potential ugliness with how testing sets flags.
2017-07-25 15:35:19 -07:00
492239d3ee
Improve multiple group handling in a deployment
...
This PR resolves a bug in which a job with multiple task groups would
create new deployment objects each, thus clearing out all other task
groups deployment state.
2017-07-25 11:27:47 -07:00
184bfd4836
Better comment
2017-07-20 12:31:08 -07:00
248315a2d9
Handle destructive changes before placements
...
This PR updates the generic scheduler to handle destructive changes
before handling placements. This is important because the destructive
change may be due to a lowering of resources. If this is the case, the
handling of the destructive changes first may make it possible for the
placement to happen.
To reason about this imagine there is one node with CPU = 500.
If the group originally had:
* `count = 1`
* `cpu = 400`
And then the job was updated such that the group had:
* `count = 4`
* `cpu = 120`
If the original alloc isn't discounted first, nothing would be able to
place.
2017-07-20 12:24:27 -07:00
ce265e0aff
Update full node test to test more advanced case
2017-07-20 12:23:40 -07:00
a9ec1d6ca7
Fix update limit calculation to avoid panic
...
This PR fixes the rolling update limit calculation to avoid a panic when
there are more allocations for a deployment that haven't determined
their health than the max_parallel count of the task group.
Fixes https://github.com/hashicorp/nomad/issues/2820
2017-07-19 11:11:47 -07:00
22e84d00ab
Fix deep copy of driver config
2017-07-17 17:53:21 -07:00
641e178416
Stop before trying to place
2017-07-17 17:18:12 -07:00
66a90326e1
Treat destructive updates atomically
2017-07-16 10:35:38 -07:00
f86760db3c
Basic logs
2017-07-07 16:49:08 -07:00
20005f925a
Rolling node drains using max_parallel and stagger
...
This PR adds rolling node drains done at max_parallel and stagger of the
update spec. It brings it inline with old behavior.
2017-07-07 12:12:48 -07:00
3a29b38108
Status description shows requiring promotion
2017-07-07 12:12:48 -07:00
9f016606aa
Fix some tests, eval monitor shows deployment id and deployment cancels based on version
2017-07-07 12:12:48 -07:00
9aa1f2fea2
Respond to comments
2017-07-07 12:10:04 -07:00
454083ba1b
Remove canary
2017-07-07 12:10:04 -07:00
d352d85bb9
Test scheduler's handling of canaries/inplace updates
2017-07-07 12:10:04 -07:00
83c60483f2
Test marking as complete
2017-07-07 12:10:04 -07:00
477c713df5
Plan apply handles canaries and success is set via update
2017-07-07 12:10:04 -07:00
1e8b5e75a5
Fix handling of failed job
2017-07-07 12:10:04 -07:00
e229d3650b
Attach eval id
2017-07-07 12:10:04 -07:00
af1935e1e1
Mark complete
2017-07-07 12:10:04 -07:00
8424a3b380
Change canary handling
2017-07-07 12:10:04 -07:00
c10d7ab871
Remove promoted bit from allocation
2017-07-07 12:10:04 -07:00
09dfa2fc10
Rename CreateDeployments and remove cancelling behavior in state_store
2017-07-07 12:10:04 -07:00
067ed86a47
Client watches for allocation health using task state and Consul checks
...
This PR adds watching of allocation health at the client. The client can
watch for health based on the tasks running on time and also based on
the consul checks passing.
2017-07-07 12:10:04 -07:00
e7034691ea
deployment status
2017-07-07 12:07:07 -07:00
d04877d23c
initial impl
2017-07-07 12:03:11 -07:00
27a6e6b6d1
update description of the alloc update factory function
2017-07-07 12:03:11 -07:00
ce2319be9b
cleanup limit detection
2017-07-07 12:03:11 -07:00
b2573b01f9
Fix canary handling
2017-07-07 12:03:11 -07:00
7952240d69
Deployment tests
2017-07-07 12:03:11 -07:00
ce55559f12
Non-Canary/Deployment Tests
2017-07-07 12:03:11 -07:00
d111dd5c10
Pull out in-place updating into a passed in function; reduce inputs to reconciler
2017-07-07 12:03:11 -07:00
c77944ed29
assign names
2017-07-07 12:03:11 -07:00
ecacd44888
handle batch filtering
2017-07-07 12:03:11 -07:00
4c123500ee
Remove old
2017-07-07 12:03:11 -07:00
270e26c600
Populate desired state per tg
2017-07-07 12:03:11 -07:00
23dcd175ef
Show canaries on plan
2017-07-07 12:03:11 -07:00
cf5baba808
handle annotations
2017-07-07 12:03:11 -07:00
a46f7c3eb8
Todos
2017-07-07 12:03:11 -07:00
00d962b8b5
Some comments and cleanup
2017-07-07 12:03:11 -07:00
994ad285b7
Split reconcile file
2017-07-07 12:03:11 -07:00
07b1c3e5db
Only upsert a job if the spec changes and push deployment creation into reconciler
2017-07-07 12:03:11 -07:00
0d42b5d421
initial reconciler
2017-07-07 12:01:17 -07:00
b3f4db0930
cancel deployments
2017-07-07 12:01:17 -07:00
8169590d76
Fix tests
2017-05-01 13:54:26 -07:00
5a2449d236
Respond to review comments
2017-04-19 10:54:03 -07:00
3145086a42
non-purge deregisters
2017-04-15 17:08:05 -07:00
2c31d4036b
Skip inplace update on terminal batch allocation
...
This PR skips adding an inplace update to a successfully terminal batch
job to the plan. This avoids extra data in the plan and avoids
triggering updates on all clients that have the terminal allocation.
This is matching behavior of the service scheduler.
/cc @armon for review
2017-03-11 17:19:22 -08:00
bb12ff69a6
Fix in-place update
2017-03-09 22:03:10 -08:00
601cbd7784
Feedback addressed
2017-03-09 21:36:27 -08:00
b65d248dee
Fix filtering issue and add a test that would catch it
2017-03-09 16:20:39 -08:00
7945e4564c
Refactor
2017-03-09 15:26:46 -08:00
60c42f745a
Split distinct property and host iterator and add iterator to system stack
2017-03-08 19:00:10 -08:00
319b24081f
cleanup
2017-03-08 17:57:31 -08:00
a439bf709d
Property Set
2017-03-08 17:50:40 -08:00
d83a8fe9f2
Unoptimized implementation + testing
2017-03-07 14:48:54 -08:00
87d971a6b8
Double the anti-affinity for placing same task group on node
2017-03-06 11:52:53 -08:00
5be806a3df
Fix vet script and fix vet problems
...
This PR fixes our vet script and fixes all the missed vet changes.
It also fixes pointers being printed in `nomad stop <job>` and `nomad
node-status <node>`.
2017-02-27 16:00:19 -08:00
04862ca10e
Tests compile
2017-02-07 21:30:57 -08:00
b69b357c7f
Nomad builds
2017-02-07 20:31:23 -08:00
302a0cf382
Fix adjust test
2017-01-08 14:14:35 -08:00
2c838a80f6
Detect newly created allocation's properly
2017-01-08 13:55:03 -08:00
8d5f0fea69
Merge pull request #2128 from hashicorp/f-dispatch
...
Nomad Constructor Jobs and Dispatch
2017-01-06 05:22:49 +08:00
9cdd576720
Updated changelog and fixed tests
2016-12-20 11:32:17 -08:00
a1dd78c24b
Scheduler combines meta from job > group > task
2016-12-15 17:08:38 -08:00
5191b4d33a
Making the status command return the allocs of currently registered job
2016-11-24 16:31:30 +01:00
a1d08c2aba
Add scheduler version enforcement
2016-10-26 14:52:48 -07:00
989827e402
Add set contains
2016-10-19 13:06:28 -07:00
36cfe6e89e
Large refactor of task runner and Vault token rehandling
2016-10-18 11:24:20 -07:00
83f647ed84
Replace "the the" with "the" in documentation and comments
2016-10-11 15:31:40 -04:00
dae7f88118
Not setting a drained node as preferred node ( #1740 )
2016-09-23 21:15:50 -07:00
45afc0b4e1
Added logic to ensure scheduler knows job defn has been updated when ephemeral disks has been updated ( #1725 )
2016-09-21 14:00:02 -07:00
bc500a536c
tasks updated
2016-09-21 11:31:09 -07:00
36edabb487
Fixed the logic of calculating queued allocation in sys sched ( #1724 )
2016-09-20 12:05:19 -07:00
683380c25c
Merge pull request #1715 from hashicorp/b-dead-system-nodes
...
Fix bug where dead nodes weren't properly handled by system scheduler
2016-09-19 11:49:44 -07:00
47551e93b4
Fix bug in which dead nodes weren't being properly handled by system scheduler
2016-09-19 11:49:27 -07:00
1b3c5e98c8
Renaming LocalDisk to EphemeralDisk ( #1710 )
...
Renaming LocalDisk to EphemeralDisk
2016-09-14 15:43:42 -07:00
d94bb45ad3
Added some more comments
2016-08-31 14:06:31 -07:00
52e9946da9
Implemented SetPrefferingNodes in stack
2016-08-30 16:17:50 -07:00
bfee7b30a3
Introducing shared resources in alloc
2016-08-29 13:49:25 -07:00
13497913f9
Ensuring resources are re-calculated properly in fsm
2016-08-26 20:13:11 -07:00
e79cb67391
Changing implementation of AllocsFit
2016-08-26 17:28:29 -05:00
3447658bba
Added scheduler tests to ensure disk constraints are honored
2016-08-25 15:31:56 -05:00
ffaf6c6299
Fixed some tests
2016-08-25 13:56:39 -05:00
ec73c768f1
Making the scheduler use LocalDisk instead of Resources.DiskMB
2016-08-25 12:27:42 -05:00
c1a455983d
Added the chained alloc for system scheduler
2016-08-16 10:49:45 -07:00
1de89776d7
Marking an allocation chained if we are creating this to replace an old one
2016-08-15 17:52:41 -07:00
64f7eff612
Plan on system scheduler doesn't count nodes who don't meet constraints
2016-08-11 15:26:25 -07:00
23fcb9f5c9
Ensuring system sched doesn't increment queued count when nodes are filtered
2016-08-10 14:33:13 -07:00
13bab5b1ad
Added scheduler tests
2016-08-09 14:52:25 -07:00
Preetha Appan