Commit graph

16452 commits

Author SHA1 Message Date
Michael Schurter 6f64e52d61
Merge pull request #6699 from hashicorp/f-semver-constraints
Add new "semver" constraint
2019-11-19 12:18:43 -08:00
Drew Bailey cd6d71914a
Merge pull request #6732 from hashicorp/inplace-update-constraint
Removes checking constraints for inplace update
2019-11-19 14:06:22 -05:00
Michael Schurter be00d0cc41 test: assert semvers are *not* compared lexically 2019-11-19 10:59:40 -08:00
Drew Bailey 876618b5d2
Removes checking constraints for inplace update 2019-11-19 13:34:41 -05:00
Michael Schurter 260c26e9c4 docs: document semver constraint operator 2019-11-19 10:26:25 -08:00
Buck Doyle 676b84c735
Docs: correct that exec task flag is not optional (#6729)
The task is required, not optional, there’s no default as was described.
2019-11-19 11:20:07 -06:00
Michael Schurter 796758b8a5 core: add semver constraint
The existing version constraint uses logic optimized for package
managers, not schedulers, when checking prereleases:

- 1.3.0-beta1 will *not* satisfy ">= 0.6.1"
- 1.7.0-rc1 will *not* satisfy ">= 1.6.0-beta1"

This is due to package managers wishing to favor final releases over
prereleases.

In a scheduler versions more often represent the earliest release all
required features/APIs are available in a system. Whether the constraint
or the version being evaluated are prereleases has no impact on
ordering.

This commit adds a new constraint - `semver` - which will use Semver
v2.0 ordering when evaluating constraints. Given the above examples:

- 1.3.0-beta1 satisfies ">= 0.6.1" using `semver`
- 1.7.0-rc1 satisfies ">= 1.6.0-beta1" using `semver`

Since existing jobspecs may rely on the old behavior, a new constraint
was added and the implicit Consul Connect and Vault constraints were
updated to use it.
2019-11-19 08:40:19 -08:00
Michael Schurter 98321f9729 vendor: update go-version to include NewSemver 2019-11-19 08:40:18 -08:00
Tim Gross e012c2b5bf
Infrastructure for Windows e2e testing (#6584)
Includes:
* baseline Windows AMI
* initial pass at Terraform configurations
* OpenSSH for Windows

Using OpenSSH is a lot nicer for Nomad developers than winrm would be,
plus it lets us avoid passing around the Windows password in the
clear.

Note that now we're copying up all the provisioning scripts and
configs as a zipped bundle because TF's file provisioner dies in the
middle of pushing up multiple files (whereas `scp -r` works fine).

We're also running all the provisioning scripts inside the userdata by
polling for the zip file to show up (gross!). This is because
`remote-exec` provisioners are failing on Windows with the same symptoms as:

https://github.com/hashicorp/terraform/issues/17728

If we can't fix this, it'll prevent us from having multiple Windows
clients running until TF supports count interpolation in the
`template_file`, which is planned for a later 0.12 release.
2019-11-19 11:06:10 -05:00
Tim Gross 1829f437a7
doc: clarify that gcc-go is not supported (#6726) 2019-11-19 11:02:55 -05:00
Tim Gross 1210261fe2
hclfmt nomad jobspecs (#6724) 2019-11-19 10:36:41 -05:00
Chris Baker 926d2f8e78
Merge pull request #6725 from hashicorp/bug-plugin-launcher-setconfig-error
SetConfig bug in plugin launcher tool
2019-11-19 09:22:19 -06:00
Chris Baker 943c4f083e the plugin launcher tool was passing the wrong byte array into
SetConfig, resulting in msgpack decoding errors
2019-11-19 14:53:34 +00:00
Lang Martin 85bedfde3c CHANGELOG: gcs support 2019-11-19 09:18:26 -05:00
Lang Martin aa985ebe21
getter: allow the gcs download scheme (#6692) 2019-11-19 09:10:56 -05:00
Drew Bailey be040f85f5
Merge pull request #6703 from hashicorp/b-affinity-constraint-inplace-update
Check for changes to affinity, constraints and spread during update
2019-11-19 08:48:58 -05:00
Drew Bailey 4f06d60c92
update changelog 2019-11-19 08:29:43 -05:00
Drew Bailey e44a66d7fc
DOCS: Spread stanza does not exist on task
Fixes documentation inaccuracy for spread stanza placement. Spreads can
only exist on the top level job struct or within a group.

comment about nil assumption
2019-11-19 08:26:36 -05:00
Drew Bailey 07e3164bf9
Check for changes to affinity and constraints
Adds checks for affinity and constraint changes when determining if we
should update inplace.

refactor to check all levels at once

check for spread changes when checking inplace update
2019-11-19 08:26:34 -05:00
Nick Ethier bd454a4c6f
client: improve group service stanza interpolation and check_re… (#6586)
* client: improve group service stanza interpolation and check_restart support

Interpolation can now be done on group service stanzas. Note that some task runtime specific information
that was previously available when the service was registered poststart of a task is no longer available.

The check_restart stanza for checks defined on group services will now properly restart the allocation upon
check failures if configured.
2019-11-18 13:04:01 -05:00
Luiz Aoqui a046a96d5e
update CHANGELOG 2019-11-15 15:45:38 -05:00
Luiz Aoqui e499c5bddc
Merge pull request #6698 from hashicorp/f-add-drain-start-time
api: add `StartedAt` in `Node.DrainStrategy`
2019-11-15 15:38:38 -05:00
Charlie Voiselle 100526c4d1
Merge pull request #6705 from hashicorp/docs-index-redir
Update redirects.txt
2019-11-14 16:47:03 -05:00
Charlie Voiselle bc7ce08dcf
a few more redirects 2019-11-14 16:38:24 -05:00
Charlie Voiselle 40e0305958
Update redirects.txt 2019-11-14 16:29:06 -05:00
Luiz Aoqui e862b61daa
api: use the same initial time for all drain properties 2019-11-14 16:06:09 -05:00
Drew Bailey 25b7f31ca8
Merge pull request #6691 from hashicorp/f-nomad-monitor-leader
Nomad monitor - target remote servers
2019-11-14 11:47:43 -05:00
Drew Bailey 9b63828658
serverID to target remote leader or server
handle the case where we request a server-id which is this current server

update docs, error on node and server id params

more accurate names for tests

use shared no leader err, formatting

rm bad comment

remove redundant variable
2019-11-14 10:07:35 -05:00
Drew Bailey b644e1f47d
add server-id to monitor specific server 2019-11-14 09:53:41 -05:00
Drew Bailey 2185c1a89e
Allows monitor to target leader server
Allows user to pass in node-id=leader to forward monitor request to
remote a remote leader.
2019-11-14 09:53:40 -05:00
Drew Bailey a7f5372cd0
Merge pull request #6693 from hashicorp/update-consul-template-0.22.1
updates consul template deps to v0.22.1
2019-11-14 09:47:43 -05:00
Drew Bailey 37de02c8f7
updates consul template deps to v0.22.1
pin to v0.22.1
2019-11-14 08:58:34 -05:00
Luiz Aoqui 5bd7cdd5c3
api: add StartedAt in Node.DrainStrategy 2019-11-13 17:54:40 -05:00
Drew Bailey 3a4beeb6d9
Merge pull request #6696 from alrs/nomad-fix-dropped-test-error
nomad: fix dropped test error
2019-11-13 16:12:43 -05:00
Lars Lehtonen 22a3c21dd0
nomad: fix dropped test error 2019-11-13 12:49:41 -08:00
Drew Bailey acd97d0731
Merge pull request #6670 from hashicorp/api/fallthrough-test
test rootfallthrough handler
2019-11-13 10:51:31 -05:00
Charlie Voiselle 637a0c003e
Merge pull request #6688 from hashicorp/docs-fix-constraint-link
[docs] Fix link; discuss meta; lint fixes
2019-11-13 09:34:42 -05:00
Lars Lehtonen 1dbf44bc40 command/agent: Prune Dead Code (#6682)
* remove unused MockPeriodicJob() from tests
* remove unused getIndex() from tests
* remove unused checkIndex() from tests
* remove unused assertIndex() from tests
* remove unused Agent.findLoopbackDevice()
2019-11-13 08:20:01 -05:00
Lars Lehtonen e85509c466 command: error handling before file close (#6681) 2019-11-13 08:18:20 -05:00
Charlie Voiselle 8b6ff61372 Fix link; discuss meta; lint fixes 2019-11-12 17:32:21 -05:00
Michael Schurter 1e906768dd
Merge pull request #6687 from hashicorp/f-override-vault-constraint
vault: allow overriding implicit vault constraint
2019-11-12 12:47:57 -08:00
Michael Schurter 9cb4ff3ffb
Merge branch 'master' into f-override-vault-constraint 2019-11-12 12:47:41 -08:00
Michael Schurter 08afb7d605 vault: allow overriding implicit vault constraint
There's a bug in version parsing that breaks this constraint when using
a prerelease enterprise version of Vault (eg 1.3.0-beta1+ent). While
this does not fix the underlying bug it does provide a workaround for
future issues related to the implicit constraint. Like the implicit
Connect constraint: *all* implicit constraints should be overridable to
allow users to workaround bugs or other factors should the need arise.
2019-11-12 12:26:36 -08:00
Drew Bailey f5310ff63f
fix so assertions are test case driven 2019-11-12 14:28:21 -05:00
Mahmood Ali 6958045622 backfill Mahmood's changelog items 2019-11-12 13:50:32 -05:00
Mahmood Ali 801466f5d9
Merge pull request #6685 from hashicorp/b-api-separation-20191112
remove accidental project leakage in api/ package
2019-11-12 13:47:06 -05:00
Mahmood Ali 9e211ce16f tests appear as github.com/hashicorp/nomad/api.test 2019-11-12 11:33:20 -05:00
Mahmood Ali 46b3d39697
Merge pull request #6680 from hashicorp/b-gh-6570-explicit_max_ttl
vault: check token_explicit_max_ttl as well
2019-11-12 16:03:06 +00:00
Mahmood Ali 90d81fcd55 api: go-uuid is no longer needed 2019-11-12 11:02:33 -05:00
Mahmood Ali d4514c7b73 api: avoid depending on helper internal package 2019-11-12 11:02:33 -05:00