ba71757dfb
handled the logic of task group count going up
2016-07-12 11:41:13 -06:00
67953b1583
Added a test to ensure correctness of job summary when client updates alloc
2016-07-12 11:41:13 -06:00
837b70f285
Added test to make sure summary gets deleted when job gets deleted
2016-07-12 11:41:13 -06:00
0606840080
Implemented logic to update the job summary when allocs are inserted
2016-07-12 11:41:13 -06:00
083f81d17f
Implemented job state accounting logic for upsert job
2016-07-12 11:41:13 -06:00
ebf9fbf1d6
Added a schema for summarizing status of jobs
2016-07-12 11:41:13 -06:00
4ea9ceee38
Handling allocations with client state pending
2016-07-12 11:29:23 -06:00
2cf2ed6758
Changing the state of an allocation to lost if the node on which it was running was marked as down
2016-07-11 18:24:04 -06:00
bc0bfc3ae5
Merge pull request #1398 from hashicorp/b-check-timeout
...
Fixed the validation logic for check timeout and interval
2016-07-10 12:16:50 -07:00
51ae7ace25
initial tail impl
2016-07-10 13:57:04 -04:00
75abbc74a5
nomad: modify forward RPC to hold when no known leader
2016-07-10 13:36:55 -04:00
699c4fc68c
nomad: Add RPCHoldTimeout to tune RPC hold interval
2016-07-10 13:35:48 -04:00
b4fe764f07
Added a test
2016-07-08 22:33:04 -07:00
19f0867816
Fixed the validation logic for check timeout
2016-07-08 22:26:03 -07:00
48b9684b1e
Using net.JoinHostPort instead of handcrafting addrs
2016-07-08 16:45:14 -07:00
b180223f4b
Allowing ports to be overriden in check definitions
2016-07-08 14:14:25 -07:00
099cee067d
comments
2016-06-28 10:02:06 -07:00
3f0a47f9e4
Disallow EvalGC to reap batch jobs evals/allocs and make JobGC only oneshot GCs everything
2016-06-27 22:54:03 -07:00
6ca552c451
Reblock test
2016-06-24 10:26:13 -07:00
fd3e469d5e
Remove requeue because it is a subset of EnqueueAll now
2016-06-24 10:14:34 -07:00
2f8bb4b235
When enqueuing into eval broker always pass blocked eval's token
2016-06-23 22:40:22 -07:00
ccf93d7e44
UnblockFailed needs to untrack the job
2016-06-23 15:35:21 -07:00
b1c2a9ddb9
UnblockFailed needs to untrack the job
2016-06-23 15:26:26 -07:00
3a8a27bcff
refresh index eval id in log
2016-06-22 13:48:41 -07:00
e43c460534
Fixed name of a test
2016-06-22 13:04:54 -07:00
0fe8746692
GC-ing dead batch jobs
2016-06-22 11:40:27 -07:00
8ceb7ead20
Do not use snapshot
2016-06-22 09:33:15 -07:00
91f6976423
tighter index bound when creating GC evals
2016-06-22 09:11:25 -07:00
25decca3ca
Worker waitForIndex uses StateStore index, not Raft Applied Index
2016-06-22 09:04:22 -07:00
8bdb38d016
Code golf
...
Pointed out by: @dadgar
2016-06-21 14:26:01 -07:00
df4fe2e502
Fix the shuffling of remote datacenters.
...
Pointed out by: @ryanuber
2016-06-21 13:37:22 -07:00
9e287858de
Merge pull request #1310 from hashicorp/b-logger
...
Create and pass only one `logger` object around per Agent
2016-06-17 12:16:35 -07:00
46e2d54acf
Provide `nomad.Config` with a default `LogOutput` of `os.StdErr`
2016-06-17 06:44:10 -07:00
9a60999100
Pass a logger arg to `NewClient` and `NewServer`
2016-06-16 23:29:23 -07:00
871a31a8ec
Teach config.ConsulConfig how to construct a consulapi TLS client.
...
Said differently, centralize the creation of consul's client config
in one place and use it everywhere.
2016-06-16 22:51:06 -07:00
d17af396ca
Create config.DefaultConsulConfig()
2016-06-16 20:41:05 -07:00
a658299235
Misc typos
2016-06-16 16:17:17 -07:00
ec77a1869e
Test for errors
2016-06-16 14:43:46 -07:00
31313b68cf
Don't assign to an atomic w/o using atomic setter func
2016-06-16 14:43:46 -07:00
af55b74114
Merge pull request #1276 from hashicorp/f-consul-server-autojoin
...
Teach Nomad servers how to fall back to Consul.
2016-06-16 14:40:45 -07:00
7c24487850
Fix up various error handling
2016-06-16 14:40:09 -07:00
71cd9984ae
Immediately query Consul upon initialization if we have no peers.
...
Also don't attempt to join the Server with itself.
2016-06-16 14:27:10 -07:00
65319252b9
Rework `server_auto_join` to use a timer instead of the peer count.
...
It is perfectly viable for an admin to downsize a Nomad Server cluster
down to 1, 2, or `num % 2 == 0` (however ill-advised such activities
may be). And instead of using `bootstrap_expect`, use a timeout-based
strategy. If the `bootstrapFn` hasn't observed a leader in 15s it will
fall back to Consul and will poll every ~60s until it sees a leader.
2016-06-16 12:14:03 -07:00
b0fecbefc1
Define `BootstrapExepct` as an `int32` so it can be manipulated atomically.
2016-06-16 12:00:15 -07:00
ea5d11e628
remove consul reference
2016-06-15 17:23:02 -07:00
bf14fd355f
plan displays launch time of periodic jobs
2016-06-15 13:34:45 -07:00
14f9d2a947
Use the config's log output
2016-06-15 12:40:51 -07:00
5b0def194a
Namespace the log messages
2016-06-15 12:40:51 -07:00
bffc82d668
Do not consider the number of Serf members when considering falling back to Consul.
2016-06-15 12:40:51 -07:00
324af8d7f1
Guard the auto-join functionality behind its `consul.server_auto_join` tunable
2016-06-15 12:40:51 -07:00
5e0ced2ae7
Shuffle all datacenters vs only the nearest N datacenters.
...
Per discussion, we want to be aggressive about fanning out vs possibly
fixating on only local DCs. With RPC forwarding in place, a random walk
may be less optimal from a network latency perspective, but it is guaranteed
to eventually result in a converged state because all DCs are candidates
during the bootstrapping process.
2016-06-15 12:40:51 -07:00
2123460cf0
Bump various Consul search limits
...
Client: Search limit increased from 4 random DCs to 8 random DCs, plus nearest.
Server: Search factor increased from 3 to 5 times the bootstrap_expect.
This should allow for faster convergence in large environments (e.g.
sub-5min for 10K Consul DCs).
2016-06-15 12:40:51 -07:00
e8d1264dbc
Short-circuit the bootstrapFn if we have a leader
2016-06-15 12:40:51 -07:00
f05514335b
Teach Nomad servers how to fall back to Consul.
2016-06-15 12:40:51 -07:00
aea21affdb
Document consul configuration
2016-06-14 15:21:57 -07:00
6e22b680ce
Disambiguate `auto_join` from `auto_register`, rename reg to `auto_advertise`.
...
Provide an option that describes the value to the user vs the
operation performed by the software. Momentarily introducing
`auto_join`
2016-06-14 12:11:38 -07:00
4f14d51013
Fix up validation and allow existing unset timeouts to continue to be unset
2016-06-13 18:55:15 -07:00
c3a3fdc230
Upon further review, the Timeout needs to be validate for more than script checks.
...
This value is used for Consul HTTP and TCP checks.
2016-06-13 18:28:27 -07:00
baac19cad6
Remove diff check for ServiceID, may it R.I.P.
2016-06-13 18:22:53 -07:00
79c675cf72
Guard against an interval and timeout being less than 1s
2016-06-13 18:19:40 -07:00
af8db7ec18
Don't export ServiceCheck validate
2016-06-13 18:17:43 -07:00
08c88102a7
There is no "docker" check type
2016-06-13 18:15:07 -07:00
8bbf4a55e5
Fix IDs and domain scoping
2016-06-13 16:30:58 -07:00
8e231fa382
Rename ConsulService back to Service
2016-06-12 16:36:49 -07:00
3024c080e8
Removing artifact check for java and qemu drivers
2016-06-12 12:57:35 +02:00
480a281031
Merge pull request #1243 from hashicorp/f-run-modify-index
...
Add check-index flag to nomad run
2016-06-11 16:12:53 -07:00
2f036231e5
Merge pull request #1201 from hashicorp/f-dyn-server-list
...
Dynamic Server Lists/Client Bootstrapping via consul.
2016-06-11 18:58:25 -04:00
59b0a7b3f6
Merge pull request #1256 from hashicorp/b-node-gc
...
Improve partial garbage collection of allocations
2016-06-11 15:41:00 -07:00
bbd8dfa798
goling(1) compliance pass (e.g. Rpc* -> RPC)
2016-06-10 23:38:28 -04:00
98bf249625
Partial GC allocations
2016-06-10 18:32:37 -07:00
7ccc7d20a0
test
2016-06-10 15:48:59 -07:00
b064b392fc
Only unblock if missed class was added after eval snapshot index
2016-06-10 15:24:06 -07:00
948663c89a
Fix another unit test not expecting ServiceID
2016-06-10 16:50:35 -04:00
d99467ef5e
Always create a consul.Syncer. Use a default Consul Config if necessary.
2016-06-10 15:55:27 -04:00
3d64daafd9
Fold RaftPeers() into its only call site now
2016-06-10 15:54:39 -04:00
0ba1da9c9c
Always pass in a snapshot before calling constructNodeServerInfoResponse()
2016-06-10 15:54:39 -04:00
1df6fc253f
Rename `updateNodeUpdateResponse` to `constructNodeServerInfoResponse`
2016-06-10 15:54:39 -04:00
077203fe93
Update the structure of ConsulService to match reality.
...
ConsulService is the configuration for a Consul Service
2016-06-10 15:54:39 -04:00
197feae679
Sync services with Consul by comparing the AgentServiceReg w/ ConsulService
...
The source of truth is the local Nomad Agent. Any services not local that
have a matching prefix are removed. Changed services are re-registered
and missing services are re-added.
2016-06-10 15:54:39 -04:00
9a223936bb
Generate and sync Consul ServiceIDs consistently
2016-06-10 15:54:39 -04:00
95c9d1a63e
Per-comment, remove structs.Allocation's Services attribute.
...
Nuke PopulateServiceIDs() now that it's also no longer needed.
2016-06-10 15:54:39 -04:00
7956eb0c80
Rename structs.Task's `Service` attribute to `ConsulService`
2016-06-10 15:54:39 -04:00
fda03c5c9e
Change the signature of the PeriodicCallback to return an error
...
I *KNEW* I should have done this when I wrote it, but didn't want to
go back and audit the handlers to include the appropriate return
handling, but now that the code is taking shape, make this change.
2016-06-10 15:54:39 -04:00
4973ec32bb
Rename structs.Services to structs.ConsulServices
2016-06-10 15:54:39 -04:00
060300007e
Use a monotonically incrementing number to create unique node names.
...
Also remove the space from the "name" of the node
2016-06-10 15:50:11 -04:00
1ec7d6c266
Push down the server list even on node registration and evaluation
...
Be mindful of the cost of taking a snapshot from the statestore and
reuse the snapshot if one has already been taken.
2016-06-10 15:50:11 -04:00
bff57a0dce
Reconcile, clean up, and centralize API version numbers (major and minor).
...
Reduce future confusion by introducing a minor version that is gossiped out
via the `mvn` Serf tag (Minor Version Number, `vsn` is already being used for
to communicate `Major Version Number`).
Background: hashicorp/consul/issues/1346#issuecomment-151663152
2016-06-10 15:50:11 -04:00
dde6a4074d
Nuke trace-level logging in heartbeats
2016-06-10 15:50:11 -04:00
d76c042a13
Invert error handling logic
2016-06-10 15:50:11 -04:00
1fe979a5e4
Remove types.ShutdownChannel and replace with `chan struct{}`
2016-06-10 15:50:11 -04:00
438becb28b
Pass the datacenter name in the heartbeat
...
Servers that are part of a different datacenter are added as backup
servers instead of primary servers.
2016-06-10 15:50:11 -04:00
89168b0c51
Invert check definition so the error is first
2016-06-10 15:50:11 -04:00
dc78baedfd
Fix typo in the comment to reflect the actual function name.
2016-06-10 15:50:11 -04:00
410d85cc78
Rename the package from `client/rpc_proxy` to `client/rpcproxy`
...
Also rename `NewRpcProxy()` to just `New()` to avoid package stutter.
2016-06-10 15:50:11 -04:00
1aefdb1e15
Use the correctly typed `rand.Int*` variant
2016-06-10 15:50:11 -04:00
3a1dc9a194
Use `rand.Int*n()` where appropriate
2016-06-10 15:50:11 -04:00
e727fd8c3c
Centralize the creation of a consul/api.Config struct.
...
While documented, the consul.timeout parameter wasn't ever set
except one-off in the Consul fingerprinter.
2016-06-10 15:50:11 -04:00
f695d6d70d
Reconcile consul's address configuration section.
...
There were conflicting directives previously, both consul.addr and
consul.address were required to achieve the desired behavior. The
documentation said `consul.address` was the canonical name for the
parameter, so consolidate configuration parameters to `consul.address`.
2016-06-10 15:50:11 -04:00
e60580b279
Define a type for the PeriodicCallback handlers and ShutdownChannel
2016-06-10 15:50:11 -04:00
17116fc5a7
Rebalance Nomad client RPCs among different Nomad servers.
...
Implement client/rpc_proxy.RpcProxy.
2016-06-10 15:50:11 -04:00
b509da2d0c
Create a `nomad/structs/config` to break an import cycle.
...
Flattening and normalizing the various Consul config structures and
services has led to an import cycle. Break this by creating a new package
that is intended to be terminal in the import DAG.
2016-06-10 15:48:36 -04:00
6d162e1e03
Fix copy pasta comment.
...
These parameters are used to bootstrap Nomad servers, not Consul servers.
2016-06-10 15:48:36 -04:00
4e2835d5ff
Use the correctly typed `rand.Int*` variant
2016-06-10 15:48:36 -04:00
49deaae2ae
Seed random once in main
2016-06-10 15:48:36 -04:00
db97a88f94
Fix small typo
2016-06-10 15:48:36 -04:00
66b4b2a99f
Use `rand.Int*n()` where appropriate
2016-06-10 15:48:36 -04:00
e36686a17d
Use consul/lib's RandomStagger
...
Removes four redundant copies of the method in the process.
2016-06-10 15:48:36 -04:00
e0e7d94450
Use consul/lib's RateScaledInterval
2016-06-10 15:48:36 -04:00
527afa5119
Merge pull request #1244 from hashicorp/b-eval-reblock-test-hardening
...
Don't dequeue requeued evals in tests
2016-06-09 11:35:42 -07:00
5d181d203c
Add check-index flag to nomad run
2016-06-08 17:56:32 -07:00
b7e3a45fef
fix channel being nil on restore
2016-06-07 15:03:08 -07:00
ecdce9a641
don't dequeue
2016-06-07 09:51:20 -07:00
cc95d5d332
GC Nodes even if they have terminal allocations
2016-06-03 16:24:41 -07:00
5f3e27ecd8
Fix case in periodic dispatch and blocked evals where lock was not released
2016-06-03 13:46:57 -07:00
3100b4a086
Change eval_endpoint test to not retry but block longer
2016-06-03 12:02:49 -07:00
299a0bb4b3
up timeout for dequeue in test
2016-06-03 11:36:50 -07:00
0f84d8968b
Merge pull request #1221 from hashicorp/b-nil-wait
...
fix wait result being nil and some panics in the cli
2016-05-31 16:50:38 -07:00
629542f64e
flaky test
2016-05-31 23:50:14 +00:00
7196133f0a
Merge pull request #1220 from hashicorp/f-plan-failure-reasons
...
plan shows failure reasons and ordered annotations
2016-05-31 15:32:22 -07:00
b1298bb658
plan shows failure reasons and ordered annotations
2016-05-31 21:51:23 +00:00
13f0ff03c1
Merge pull request #1209 from hashicorp/b-blocked-eval-fixes
...
Fix race condition in which a reblocked evaluation could be dropped
2016-05-31 13:26:58 -07:00
060318845f
Comments addressed
2016-05-31 11:39:03 -07:00
75bd7a50f7
changelog
2016-05-27 17:43:20 -07:00
cc00a66e38
validate that tasks don't contain slashes
2016-05-27 17:17:10 -07:00
1f9f015c1b
Fix race condition in which a reblocked evaluation could be dropped
2016-05-27 16:53:10 -07:00
6a236872b4
address comment
2016-05-25 10:30:47 -07:00
a3336b7761
test fixes and delete
2016-05-24 20:20:06 -07:00
3fd51ecece
Periodically unblock failed evaluations
2016-05-24 20:10:56 -07:00
bfdd5846e1
Track unblock indexes and check evals on block to see if they missed an update while in the scheduler
2016-05-24 20:10:56 -07:00
15936822a4
Worker annotates evals with their snapshot index
2016-05-24 20:10:56 -07:00
18d9e89065
Reuse the same evaluation and reblock it until there is no more work to do
2016-05-24 20:10:56 -07:00
3cbb89c61e
Merge pull request #1188 from hashicorp/f-no-failed-allocs
...
Failed Allocation Metrics stored in Evaluation
2016-05-24 20:06:28 -07:00
fcc57fbc66
rename SpawnedBlockedEval and simplify map safety check
2016-05-24 18:12:59 -07:00
b5ad18a7ea
Dont restart successfully finished batch allocations
2016-05-24 17:23:18 -07:00
1feb57b047
Evals track blocked evals they create
2016-05-19 13:09:52 -07:00
8f5f12ae81
Scheduler no longer produces failed allocations; failed alloc metrics stored in evaluation
2016-05-18 18:11:40 -07:00
1c6d3e129a
EnqueueAll inserts all evaluations before unblocking dequeue calls
2016-05-18 12:13:59 -07:00
045f7807e0
eval_broker.Enqueue no longer returns an error
2016-05-18 11:35:15 -07:00
0c653c3c8f
Fix determining whether a job is edited
2016-05-17 15:48:35 -07:00
a5ab96d40e
Merge pull request #1168 from hashicorp/f-plan-endpoint
...
Job.Plan endpoint
2016-05-16 13:15:40 -07:00
a231f6f998
Switch to using the harness
2016-05-16 12:49:18 -07:00
5085c25f8b
Rename Cas to JobModifyIndex
2016-05-16 11:48:44 -07:00
dc28ab0cb5
Speling police
2016-05-15 09:41:34 -07:00
2e2e2e500e
Using a helper method to create service identifiers
2016-05-14 00:43:25 -07:00
d94e651c6e
Merge branches 'master' and 'f-config-consul-block' of github.com:hashicorp/nomad into f-config-consul-block
2016-05-13 13:05:11 -07:00
bed4cb7a9f
Fixes
2016-05-13 11:53:11 -07:00
7a44ec5ccc
Remove plan from the response
2016-05-12 11:29:38 -07:00
b634486ebd
Plan api
2016-05-11 18:51:48 -07:00
2bd962ca0d
add endpoint tests
2016-05-11 17:02:14 -07:00
347cb890d2
Removed allocID and task name from consul service
2016-05-11 16:26:41 -07:00
ab4c184916
Undo testing.go
2016-05-11 15:44:27 -07:00
81f0286dd8
Merge branch 'master' into f-plan-endpoint
2016-05-11 15:39:36 -07:00
724d0ab489
Merge pull request #1166 from hashicorp/f-job-diff2
...
Job Diff structure
2016-05-11 15:38:56 -07:00
24bfaa70ac
Fix switching diff structures
2016-05-11 15:36:28 -07:00
3a4f99c976
Merge branch 'f-job-diff2' into f-plan-endpoint
2016-05-11 15:28:07 -07:00
59e244d18e
Add service diff
2016-05-11 15:25:59 -07:00
2f74bd9a74
remove old diff
2016-05-11 11:27:00 -07:00
ccc3caae4a
Merge branch 'f-job-diff2' into f-plan-endpoint
2016-05-11 11:25:25 -07:00
967011e25c
contextual diff
2016-05-11 11:11:26 -07:00
b4bb28c425
Job diff using generic structures
2016-05-10 22:23:34 -07:00
8b45e2c474
Check if network asks have changed when checking task updates
2016-05-05 21:32:01 -07:00
ab0b57a9a1
Initial plan endpoint implementation - WIP
2016-05-05 11:21:58 -07:00
789722bf3f
Index fields using a map
2016-05-04 14:29:08 -07:00
11289526b5
change the packages
2016-05-03 18:53:12 -07:00
d41939fefd
Merge pull request #1144 from hashicorp/unique-service-names
...
Ensuring check names are unique
2016-05-03 14:36:49 -07:00
bea01efa5d
Diff Task Configs, handle the nil cases, better type setting and more tests
2016-05-03 14:23:44 -07:00
8a582c1b6c
Ensuring check names are unique
2016-05-03 13:16:02 -07:00
082d6901f7
visitor
2016-05-03 09:50:49 -07:00
26a823873a
Merge pull request #1143 from hashicorp/unique-service-names
...
Ensuring service names are unique
2016-05-03 01:15:31 -07:00
fa042c45b9
flatmap for walking the task config
2016-05-02 22:25:06 -07:00
e7b1c309ef
Job diff infrastructure
2016-05-02 18:32:23 -07:00
506ea1a206
Ensuring service names are unique
2016-05-02 13:43:07 -07:00
ff0dd9b81c
Task is not eligible for update if User, Meta, or Resources change
2016-04-25 17:20:25 -07:00
de2b26650f
Merge pull request #1097 from hashicorp/service-no-port
...
Invalidating services when they contain check of type tcp and http bu…
2016-04-19 09:18:52 -07:00
fce63bdc5c
Ensure the label exists on checks and small enhancements
2016-04-18 19:38:47 -07:00
ea08b45c70
Always trigger evals on drain update
2016-04-18 18:43:52 -07:00
f617fb89fd
Invalidating services when they contain check of type tcp and http but no ports
2016-04-15 12:50:55 +04:00
d94204554f
Merge pull request #1012 from hashicorp/f-partition-gc
...
core: Limit GC size
2016-04-14 13:00:53 -07:00
b34ab80c93
Address comments
2016-04-14 11:41:04 -07:00
f38ed64938
Validate driver config on job register
2016-04-13 15:55:46 -07:00
2d4b3f3d46
Merge pull request #1070 from hashicorp/f-interpret-artifacts
...
Interpret artifact source
2016-04-13 14:58:55 -07:00
273dfaf2c7
Periodic jobs always are evaluated in UTC TZ
2016-04-12 09:47:25 -07:00
dc63c24e59
interpet the artifact source
2016-04-11 18:46:16 -07:00
034bae90bb
Revert "Remove client status from allocation TerminalStatus"
...
This reverts commit 819e1e4b3967c7029ee8221144666ff460fdd7ed.
2016-04-08 14:22:06 -07:00
ca938f205c
Force GC garbage collects nodes last and fix eval GC to cleanup deregistered batch jobs
2016-04-08 11:42:02 -07:00
26d1b60369
Adding raft peers in agent info
2016-04-05 10:30:46 -07:00
d472dc2988
Adding the raft leader addr to server stats
2016-04-03 16:38:39 -07:00
778167e26f
Using the node in the req to unblock evals
2016-03-31 18:19:01 -07:00
fd3c05a2be
Making driver fingerprinters run periodically and unblocking evals when node registration happens
2016-03-31 18:11:27 -07:00
066d006868
Limit GC size
2016-03-30 15:17:13 -07:00
802844397d
Supporting interpolation in service name, check name/protocol/path
2016-03-28 15:52:57 -07:00
b791c91c6f
Added support for interpolation in check cmd and args
2016-03-28 15:02:00 -07:00
5439d4c23c
Interpolating service tags
2016-03-28 15:02:00 -07:00
2963c3f1f4
Renamed checks cmd to command to be consistent with exec driver config
2016-03-28 14:05:12 -07:00
c872711d01
Merge pull request #986 from hashicorp/scripts
...
Implement script checks
2016-03-25 18:22:35 -07:00
b9a80f14f1
Limit garbage collection of batch jobs
2016-03-25 16:46:48 -07:00
5fc83bd868
Dead->Complete
2016-03-25 12:56:54 -07:00
09f63fd3c0
Remove client status from allocation TerminalStatus
2016-03-25 12:53:37 -07:00
25dc8a0dcb
Explain restart decision and display in alloc-status
2016-03-25 12:47:14 -07:00
647c20e465
Merge pull request #978 from hashicorp/f-enforce-user
...
Operator specifiable blacklist for task's using certain users
2016-03-25 12:44:05 -07:00
Diptanu Choudhury