357641c364
persist alloc state on changes, not periodically
...
Allow alloc and task runners to persist their own state when something
changes instead of periodically syncing all state.
2018-10-16 16:53:30 -07:00
820af27171
wrap boltdb in a write deduplicator
...
Saves a tiny bit of cpu and some IO. Sadly doesn't prevent all IO on
duplicate writes as the transactions are still created and committed.
$ go test -bench=. -benchmem
goos: linux
goarch: amd64
pkg: github.com/hashicorp/nomad/helper/boltdd
BenchmarkWriteDeduplication_On-4 500 4059591 ns/op 23736 B/op 56 allocs/op
BenchmarkWriteDeduplication_Off-4 300 4115319 ns/op 25942 B/op 55 allocs/op
2018-10-16 16:53:30 -07:00
990228a6e2
wip wrap boltdb to get path information
...
finished but doesn't handle deleting deeply nested buckets
2018-10-16 16:53:30 -07:00
a3fe0510d1
Move all encoding and put deduping into state db
...
Still WIP as it does not handle deletions.
2018-10-16 16:53:30 -07:00
533bc93b3a
implement all boltdb interactions behind StateDB
2018-10-16 16:53:30 -07:00
d890de036a
tr: persist hook state whenever it changes
2018-10-16 16:53:30 -07:00
fae5e89a0e
artifacts: don't emit event when there's no artifacts
2018-10-16 16:53:30 -07:00
5383d20505
removing old restoration path before api change
2018-10-16 16:53:30 -07:00
a5d3e3fb0a
Implement alloc updates in arv2
...
Updates are applied asynchronously but sequentially
2018-10-16 16:53:30 -07:00
39b3f3a85b
call handle.Network() instead of storing it
2018-10-16 16:53:30 -07:00
7132b67c1e
Add Network method to Handle interface
...
Should probably be moved to an Inspect method in the Driver Plugin world
2018-10-16 16:53:30 -07:00
a4b4d7b266
consul service hook
...
Deregistration works but difficult to test due to terminal updates not
being fully implemented in the new client/ar/tr.
2018-10-16 16:53:29 -07:00
5be982e674
restore vault client
2018-10-16 16:53:29 -07:00
ce04915c9f
log before killing tasks
2018-10-16 16:53:29 -07:00
a2bf851805
no need to TaskStateUpdated to return an error
...
also updated comments
2018-10-16 16:53:29 -07:00
fd3bc1bd39
Update state with server
2018-10-16 16:53:29 -07:00
bc905cc61d
Define and thread through state updating interface
2018-10-16 16:53:29 -07:00
9a63d6103d
tr: add validate task hook
2018-10-16 16:53:29 -07:00
7f4ec50906
missed locking around c.allocs access
2018-10-16 16:53:29 -07:00
c93cfc89c0
wip
2018-10-16 16:53:29 -07:00
7ddc0eb65c
Fix deadlock
2018-10-16 16:53:29 -07:00
3779077052
Remove SetState from interface
2018-10-16 16:53:29 -07:00
e1ba73b515
compile
2018-10-16 16:53:29 -07:00
6ebdf532ea
wip split event emitting and state transitions
2018-10-16 16:53:29 -07:00
516d641db0
client: implement all-or-nothing alloc restoration
...
Restoring calls NewAR -> Restore -> Run
NewAR now calls NewTR
AR.Restore calls TR.Restore
AR.Run calls TR.Run
2018-10-16 16:53:29 -07:00
e401c660e7
Implement lifecycle hooks on the task runner
2018-10-16 16:53:29 -07:00
89b4ba9cc8
comments
2018-10-16 16:53:29 -07:00
86e81947b4
Hook renames
2018-10-16 16:53:29 -07:00
2599cf9d74
remove comment
2018-10-16 16:53:29 -07:00
88aa0299a9
Template hook
2018-10-16 16:53:29 -07:00
c9765deff1
address comments
2018-10-16 16:53:29 -07:00
80f6ce50c0
vault hook
2018-10-16 16:53:29 -07:00
30d377eba4
tr: improve skip log line
2018-10-16 16:53:29 -07:00
ef213b864b
tr: pass context to hooks
2018-10-16 16:53:29 -07:00
3a4f387fd3
tr: fix setting done in existing hooks
2018-10-16 16:53:29 -07:00
b360f6f96e
fix hclog level
2018-10-16 16:53:29 -07:00
ae89b7da95
reimplement success state for tr hooks and state persistence
...
splits apart local and remote persistence
removes some locking *for now*
2018-10-16 16:53:29 -07:00
4f43ff5c51
pass statedb into allocrunnerv2
2018-10-16 16:53:29 -07:00
582c76a420
remove unused allocrunner shim
2018-10-16 16:53:29 -07:00
c5504bd939
tr: cleanup main loop and shutdown hook impl
2018-10-16 16:53:29 -07:00
561260d6fe
tr: skip error/success saving
...
All hooks only need to be run once.
Since only one hook can fail per run there's no need to
track errors on a per hook basis.
2018-10-16 16:53:29 -07:00
67874e761f
tr: don't lock for immutable fields
2018-10-16 16:53:29 -07:00
f473cd03d6
tr: start update/shutdown logic
2018-10-16 16:53:29 -07:00
637ef264ae
Copy TR.Config vals to TR
...
I think I like this pattern better as some Config vals are mutable
(Alloc) and some aren't and some are used to derive other values and
never used directly.
Promoting them onto the TR struct is a little more work but is hopefully
more clear as to how each value is used.
2018-10-16 16:53:29 -07:00
0f7dcfdc9a
example redis job "runs" on arv2! see below
...
Tons left to do and lots of churn:
1. No state saving
2. No shutdown or gc
3. Removed AR factory *for now*
4. Made all "Config" structs local to the package they configure
5. Added allocID to GC to avoid a lookup
Really hating how many things use *structs.Allocation. It's not bad
without state saving, but if AllocRunner starts updating its copy things
get racy fast.
2018-10-16 16:53:29 -07:00
9a6aa38b0f
begin adding AllocRunner.Update
2018-10-16 16:53:29 -07:00
eae54e2954
artifact task hook
2018-10-16 16:53:29 -07:00
b9bed81e6e
Initial V2 alloc runner
2018-10-16 16:53:28 -07:00
dddde8445e
Merge pull request #4791 from hashicorp/f-fix-resource-type
...
Change CPU/Disk/MemoryMB to int everywhere in new resource structs
2018-10-16 19:44:51 -04:00
22aee7294e
Merge branch 'f-fix-resource-type' of github.com:hashicorp/nomad into f-fix-resource-type
2018-10-16 18:30:12 -05:00
Michael Schurter