4173834231
Enable more linters
2017-09-26 15:26:33 -07:00
3904bde9a3
Fix batch handling of complete allocs/node drains
...
This PR fixes:
* An issue in which a node-drain that contains a complete batch alloc
would cause a replacement
* An issue in which allocations with the same name during a scale
down/stop event wouldn't be properly stopped.
* An issue in which batch allocations from previous job versions may not
have been stopped properly.
Fixes https://github.com/hashicorp/nomad/issues/3210
2017-09-14 15:08:57 -07:00
84d06f6abe
Sync namespace changes
2017-09-07 17:04:21 -07:00
0aef02a4f9
fix test
2017-08-21 14:07:54 -07:00
27256ebcc6
Placing allocs counts towards placement limit
...
This PR makes placing new allocations count towards the limit. We do not
restrict how many new placements are made by the limit but we still
count towards the limit. This has the nice affect that if you have a
group with count = 5 and max_parallel = 1 but only 3 allocs exist for it
and a change is made, you will create 2 more at the new version but not
destroy one, taking you down to two running as you would have
previously.
Fixes https://github.com/hashicorp/nomad/issues/3053
2017-08-21 12:41:19 -07:00
2453f13fc5
fixes
2017-08-15 12:27:05 -07:00
0570e09feb
Fix panic occuring from improper bitmap size
...
This PR fixes an allignment calculation when determining the bitmap
size.
Fixes https://github.com/hashicorp/nomad/issues/3008
2017-08-12 15:37:02 -07:00
f0ced87b95
fixed all spelling mistakes for goreport
2017-08-07 17:13:05 -04:00
7b13c0d702
Lost allocs replaced even if deployment failed
...
This PR allows the scheduler to replace lost allocations even if the job
has a failed or paused deployment. The prior behavior was confusing to
users.
Fixes https://github.com/hashicorp/nomad/issues/2958
2017-08-03 17:42:14 -07:00
7d2b84ab01
Review fixes
2017-08-01 14:18:52 -07:00
2650bb1d12
Distinct Property supports arbitrary limit
...
This PR enhances the distinct_property constraint such that a limit can
be specified in the RTarget/value parameter. This allows constraints
such as:
```
constraint {
distinct_property = "${meta.rack}"
value = "2"
}
```
This restricts any given rack from running more than 2 allocations from
the task group.
Fixes https://github.com/hashicorp/nomad/issues/1146
2017-07-31 16:52:13 -07:00
4f69355a66
Fix incorrect destructive update with distinct_property constraint
...
This PR fixes an issue in which an update to a task group with a
distinct property constraint would result in an incorrect destructive
update.
2017-07-31 11:17:35 -07:00
5f1f91a46c
Use go-testing-interface instead of testing
...
This drops the testings stdlib pkg from our dependencies. Saves a
whopping 46kb on our binary (was really hoping for more of a win there),
but also avoids potential ugliness with how testing sets flags.
2017-07-25 15:35:19 -07:00
492239d3ee
Improve multiple group handling in a deployment
...
This PR resolves a bug in which a job with multiple task groups would
create new deployment objects each, thus clearing out all other task
groups deployment state.
2017-07-25 11:27:47 -07:00
184bfd4836
Better comment
2017-07-20 12:31:08 -07:00
248315a2d9
Handle destructive changes before placements
...
This PR updates the generic scheduler to handle destructive changes
before handling placements. This is important because the destructive
change may be due to a lowering of resources. If this is the case, the
handling of the destructive changes first may make it possible for the
placement to happen.
To reason about this imagine there is one node with CPU = 500.
If the group originally had:
* `count = 1`
* `cpu = 400`
And then the job was updated such that the group had:
* `count = 4`
* `cpu = 120`
If the original alloc isn't discounted first, nothing would be able to
place.
2017-07-20 12:24:27 -07:00
ce265e0aff
Update full node test to test more advanced case
2017-07-20 12:23:40 -07:00
a9ec1d6ca7
Fix update limit calculation to avoid panic
...
This PR fixes the rolling update limit calculation to avoid a panic when
there are more allocations for a deployment that haven't determined
their health than the max_parallel count of the task group.
Fixes https://github.com/hashicorp/nomad/issues/2820
2017-07-19 11:11:47 -07:00
22e84d00ab
Fix deep copy of driver config
2017-07-17 17:53:21 -07:00
641e178416
Stop before trying to place
2017-07-17 17:18:12 -07:00
66a90326e1
Treat destructive updates atomically
2017-07-16 10:35:38 -07:00
f86760db3c
Basic logs
2017-07-07 16:49:08 -07:00
20005f925a
Rolling node drains using max_parallel and stagger
...
This PR adds rolling node drains done at max_parallel and stagger of the
update spec. It brings it inline with old behavior.
2017-07-07 12:12:48 -07:00
3a29b38108
Status description shows requiring promotion
2017-07-07 12:12:48 -07:00
9f016606aa
Fix some tests, eval monitor shows deployment id and deployment cancels based on version
2017-07-07 12:12:48 -07:00
9aa1f2fea2
Respond to comments
2017-07-07 12:10:04 -07:00
454083ba1b
Remove canary
2017-07-07 12:10:04 -07:00
d352d85bb9
Test scheduler's handling of canaries/inplace updates
2017-07-07 12:10:04 -07:00
83c60483f2
Test marking as complete
2017-07-07 12:10:04 -07:00
477c713df5
Plan apply handles canaries and success is set via update
2017-07-07 12:10:04 -07:00
1e8b5e75a5
Fix handling of failed job
2017-07-07 12:10:04 -07:00
e229d3650b
Attach eval id
2017-07-07 12:10:04 -07:00
af1935e1e1
Mark complete
2017-07-07 12:10:04 -07:00
8424a3b380
Change canary handling
2017-07-07 12:10:04 -07:00
c10d7ab871
Remove promoted bit from allocation
2017-07-07 12:10:04 -07:00
09dfa2fc10
Rename CreateDeployments and remove cancelling behavior in state_store
2017-07-07 12:10:04 -07:00
067ed86a47
Client watches for allocation health using task state and Consul checks
...
This PR adds watching of allocation health at the client. The client can
watch for health based on the tasks running on time and also based on
the consul checks passing.
2017-07-07 12:10:04 -07:00
e7034691ea
deployment status
2017-07-07 12:07:07 -07:00
d04877d23c
initial impl
2017-07-07 12:03:11 -07:00
27a6e6b6d1
update description of the alloc update factory function
2017-07-07 12:03:11 -07:00
ce2319be9b
cleanup limit detection
2017-07-07 12:03:11 -07:00
b2573b01f9
Fix canary handling
2017-07-07 12:03:11 -07:00
7952240d69
Deployment tests
2017-07-07 12:03:11 -07:00
ce55559f12
Non-Canary/Deployment Tests
2017-07-07 12:03:11 -07:00
d111dd5c10
Pull out in-place updating into a passed in function; reduce inputs to reconciler
2017-07-07 12:03:11 -07:00
c77944ed29
assign names
2017-07-07 12:03:11 -07:00
ecacd44888
handle batch filtering
2017-07-07 12:03:11 -07:00
4c123500ee
Remove old
2017-07-07 12:03:11 -07:00
270e26c600
Populate desired state per tg
2017-07-07 12:03:11 -07:00
23dcd175ef
Show canaries on plan
2017-07-07 12:03:11 -07:00
cf5baba808
handle annotations
2017-07-07 12:03:11 -07:00
a46f7c3eb8
Todos
2017-07-07 12:03:11 -07:00
00d962b8b5
Some comments and cleanup
2017-07-07 12:03:11 -07:00
994ad285b7
Split reconcile file
2017-07-07 12:03:11 -07:00
07b1c3e5db
Only upsert a job if the spec changes and push deployment creation into reconciler
2017-07-07 12:03:11 -07:00
0d42b5d421
initial reconciler
2017-07-07 12:01:17 -07:00
b3f4db0930
cancel deployments
2017-07-07 12:01:17 -07:00
8169590d76
Fix tests
2017-05-01 13:54:26 -07:00
5a2449d236
Respond to review comments
2017-04-19 10:54:03 -07:00
3145086a42
non-purge deregisters
2017-04-15 17:08:05 -07:00
2c31d4036b
Skip inplace update on terminal batch allocation
...
This PR skips adding an inplace update to a successfully terminal batch
job to the plan. This avoids extra data in the plan and avoids
triggering updates on all clients that have the terminal allocation.
This is matching behavior of the service scheduler.
/cc @armon for review
2017-03-11 17:19:22 -08:00
bb12ff69a6
Fix in-place update
2017-03-09 22:03:10 -08:00
601cbd7784
Feedback addressed
2017-03-09 21:36:27 -08:00
b65d248dee
Fix filtering issue and add a test that would catch it
2017-03-09 16:20:39 -08:00
7945e4564c
Refactor
2017-03-09 15:26:46 -08:00
60c42f745a
Split distinct property and host iterator and add iterator to system stack
2017-03-08 19:00:10 -08:00
319b24081f
cleanup
2017-03-08 17:57:31 -08:00
a439bf709d
Property Set
2017-03-08 17:50:40 -08:00
d83a8fe9f2
Unoptimized implementation + testing
2017-03-07 14:48:54 -08:00
87d971a6b8
Double the anti-affinity for placing same task group on node
2017-03-06 11:52:53 -08:00
5be806a3df
Fix vet script and fix vet problems
...
This PR fixes our vet script and fixes all the missed vet changes.
It also fixes pointers being printed in `nomad stop <job>` and `nomad
node-status <node>`.
2017-02-27 16:00:19 -08:00
04862ca10e
Tests compile
2017-02-07 21:30:57 -08:00
b69b357c7f
Nomad builds
2017-02-07 20:31:23 -08:00
302a0cf382
Fix adjust test
2017-01-08 14:14:35 -08:00
2c838a80f6
Detect newly created allocation's properly
2017-01-08 13:55:03 -08:00
8d5f0fea69
Merge pull request #2128 from hashicorp/f-dispatch
...
Nomad Constructor Jobs and Dispatch
2017-01-06 05:22:49 +08:00
9cdd576720
Updated changelog and fixed tests
2016-12-20 11:32:17 -08:00
a1dd78c24b
Scheduler combines meta from job > group > task
2016-12-15 17:08:38 -08:00
5191b4d33a
Making the status command return the allocs of currently registered job
2016-11-24 16:31:30 +01:00
a1d08c2aba
Add scheduler version enforcement
2016-10-26 14:52:48 -07:00
989827e402
Add set contains
2016-10-19 13:06:28 -07:00
36cfe6e89e
Large refactor of task runner and Vault token rehandling
2016-10-18 11:24:20 -07:00
83f647ed84
Replace "the the" with "the" in documentation and comments
2016-10-11 15:31:40 -04:00
dae7f88118
Not setting a drained node as preferred node ( #1740 )
2016-09-23 21:15:50 -07:00
45afc0b4e1
Added logic to ensure scheduler knows job defn has been updated when ephemeral disks has been updated ( #1725 )
2016-09-21 14:00:02 -07:00
bc500a536c
tasks updated
2016-09-21 11:31:09 -07:00
36edabb487
Fixed the logic of calculating queued allocation in sys sched ( #1724 )
2016-09-20 12:05:19 -07:00
683380c25c
Merge pull request #1715 from hashicorp/b-dead-system-nodes
...
Fix bug where dead nodes weren't properly handled by system scheduler
2016-09-19 11:49:44 -07:00
47551e93b4
Fix bug in which dead nodes weren't being properly handled by system scheduler
2016-09-19 11:49:27 -07:00
1b3c5e98c8
Renaming LocalDisk to EphemeralDisk ( #1710 )
...
Renaming LocalDisk to EphemeralDisk
2016-09-14 15:43:42 -07:00
d94bb45ad3
Added some more comments
2016-08-31 14:06:31 -07:00
52e9946da9
Implemented SetPrefferingNodes in stack
2016-08-30 16:17:50 -07:00
bfee7b30a3
Introducing shared resources in alloc
2016-08-29 13:49:25 -07:00
13497913f9
Ensuring resources are re-calculated properly in fsm
2016-08-26 20:13:11 -07:00
e79cb67391
Changing implementation of AllocsFit
2016-08-26 17:28:29 -05:00
3447658bba
Added scheduler tests to ensure disk constraints are honored
2016-08-25 15:31:56 -05:00
ffaf6c6299
Fixed some tests
2016-08-25 13:56:39 -05:00
ec73c768f1
Making the scheduler use LocalDisk instead of Resources.DiskMB
2016-08-25 12:27:42 -05:00
c1a455983d
Added the chained alloc for system scheduler
2016-08-16 10:49:45 -07:00
1de89776d7
Marking an allocation chained if we are creating this to replace an old one
2016-08-15 17:52:41 -07:00
64f7eff612
Plan on system scheduler doesn't count nodes who don't meet constraints
2016-08-11 15:26:25 -07:00
23fcb9f5c9
Ensuring system sched doesn't increment queued count when nodes are filtered
2016-08-10 14:33:13 -07:00
13bab5b1ad
Added scheduler tests
2016-08-09 14:52:25 -07:00
ab94c8eed9
Marking allocations which are not terminal and are on down nodes as lost
2016-08-09 13:11:58 -07:00
e33bda76bf
test sched doesn't mark complete as lost + core_sched tests
2016-08-04 11:24:17 -07:00
ac3328e812
Make scheduler mark allocations as lost
2016-08-03 15:57:46 -07:00
3a9f3a31bc
KillTimeout can be modified in place
2016-08-01 20:19:12 -07:00
e661c09898
fix filter logic
2016-07-28 15:57:56 -07:00
ddbd9261c1
Merge pull request #1471 from hashicorp/b-handle-old-batch-allocs
...
filterCompleteAllocs filters replaced batch allocs
2016-07-28 14:31:19 -07:00
eb08405467
Updated tests and added logic to system sched
2016-07-28 14:02:50 -07:00
2e84d246f9
fixed a comment
2016-07-28 12:22:44 -07:00
48eda99dd9
Setting the queued count as zero if there is nothing to place
2016-07-28 12:13:35 -07:00
4a8636cb61
Added a test
2016-07-27 17:49:53 -07:00
c132952ba2
filterCompleteAllocs filters replaced batch allocs
2016-07-27 11:54:55 -07:00
d1a6bdb4ba
Making the queued allocations bind late
2016-07-25 22:11:11 -07:00
d1682e052a
Added a test for adjustQueuedAllocations
2016-07-25 17:31:40 -07:00
51cb201a09
Initializing the queued allocations late
2016-07-25 17:26:38 -07:00
09aa867cc2
Added a test to ensure we record the queued allocations correctly when the plan made partial progress
2016-07-25 17:26:38 -07:00
8f0d2a2775
Fixed some more tests
2016-07-25 17:26:38 -07:00
4a17d8e6d6
Added a test to ensure failed batch allocations are being added to the number of queued allocations
2016-07-25 17:26:38 -07:00
39bcfcd1c6
Added a test to ensure system scheduler records the correct number of queued allocations
2016-07-25 17:26:38 -07:00
cce5f483ae
Added some more tests
2016-07-25 17:26:38 -07:00
dabb83063b
Review comments
2016-07-25 17:26:38 -07:00
50842b88c7
Fixed some bugs
2016-07-25 17:26:38 -07:00
804ef1e932
Not setting the desired and client status of an allocation during in-place updates
2016-07-25 17:26:38 -07:00
a64785417d
Fixed the logic for decrementing the count of queued based on plan result
2016-07-25 17:26:38 -07:00
1cc0bc392b
Setting the number of queued allocations per task group
2016-07-25 17:26:38 -07:00
487c66b84d
Removing the queued state of Job Summary and alloc desired status false
2016-07-13 13:20:46 -06:00
e90529afc9
test for max plan
2016-06-20 17:56:49 -07:00
67c0816726
Handle max plans
2016-06-20 17:43:02 -07:00
a658299235
Misc typos
2016-06-16 16:17:17 -07:00
d44c4761f6
track failed allocations properly
2016-06-15 12:58:19 -07:00
8e231fa382
Rename ConsulService back to Service
2016-06-12 16:36:49 -07:00
2f036231e5
Merge pull request #1201 from hashicorp/f-dyn-server-list
...
Dynamic Server Lists/Client Bootstrapping via consul.
2016-06-11 18:58:25 -04:00
b064b392fc
Only unblock if missed class was added after eval snapshot index
2016-06-10 15:24:06 -07:00
95c9d1a63e
Per-comment, remove structs.Allocation's Services attribute.
...
Nuke PopulateServiceIDs() now that it's also no longer needed.
2016-06-10 15:54:39 -04:00
7956eb0c80
Rename structs.Task's `Service` attribute to `ConsulService`
2016-06-10 15:54:39 -04:00
4973ec32bb
Rename structs.Services to structs.ConsulServices
2016-06-10 15:54:39 -04:00
57770de1fc
Add eval-status and remove eval-monitor
2016-05-27 11:50:15 -07:00
fb8d79a908
Blocked evals don't store TG alloc metrics
2016-05-27 11:26:14 -07:00
6a236872b4
address comment
2016-05-25 10:30:47 -07:00
3fd51ecece
Periodically unblock failed evaluations
2016-05-24 20:10:56 -07:00
18d9e89065
Reuse the same evaluation and reblock it until there is no more work to do
2016-05-24 20:10:56 -07:00
3cbb89c61e
Merge pull request #1188 from hashicorp/f-no-failed-allocs
...
Failed Allocation Metrics stored in Evaluation
2016-05-24 20:06:28 -07:00
958d677248
comment
2016-05-24 18:18:10 -07:00
fcc57fbc66
rename SpawnedBlockedEval and simplify map safety check
2016-05-24 18:12:59 -07:00
7167b93ba9
Add test to verify drain doesn't restart successful batch and add to ignore list
2016-05-24 17:47:03 -07:00
b5ad18a7ea
Dont restart successfully finished batch allocations
2016-05-24 17:23:18 -07:00
1feb57b047
Evals track blocked evals they create
2016-05-19 13:09:52 -07:00
8f5f12ae81
Scheduler no longer produces failed allocations; failed alloc metrics stored in evaluation
2016-05-18 18:11:40 -07:00
Alex Dadgar