Michael Schurter
0d8995fb83
Improve validation and testing of service/check ports
2017-12-08 13:52:23 -08:00
Michael Schurter
0d472b6a41
Expand port and address_mode docs
2017-12-08 12:39:50 -08:00
Michael Schurter
4f1002c1a8
Be more defensive in port checks
2017-12-08 12:27:57 -08:00
Michael Schurter
d613e0aaf5
Move service hash logic to Service.Hash method
2017-12-08 12:03:43 -08:00
Michael Schurter
b71edf846f
Hash fields used in task service IDs
...
Fixes #3620
Previously we concatenated tags into task service IDs. This could break
deregistration of tag names that contained double //s like some Fabio
tags.
This change breaks service ID backward compatibility so on upgrade all
users services and checks will be removed and re-added with new IDs.
This change has the side effect of including all service fields in the
ID's hash, so we no longer have to track PortLabel and AddressMode
changes independently.
2017-12-08 12:03:43 -08:00
Michael Schurter
af8964e896
Improve port label validation and diff testing
2017-12-08 12:03:43 -08:00
Michael Schurter
91282315d1
Prevent using port 0 with address_mode=driver
2017-12-08 12:03:43 -08:00
Michael Schurter
4b20441eef
Validate port label for host address mode
...
Also skip getting an address for script checks which don't use them.
Fixed a weird invalid reserved port in a TaskRunner test helper as well
as a problem with our mock Alloc/Job. Hopefully the latter doesn't cause
other tests to fail, but we were referencing an invalid PortLabel and
just not catching it before.
2017-12-08 12:03:43 -08:00
Michael Schurter
f88f587ce1
Add Using Driver Address Mode
docs
2017-12-08 12:03:43 -08:00
Michael Schurter
e930057e4a
Document service/check address_mode/port changes
2017-12-08 12:03:43 -08:00
Michael Schurter
30dd570061
Fix interpolation bug with service/check updates
...
Previously if only an interpolated variable used in a service or check
was changed we interpolated the old and new services and checks with the
new variable, so nothing appeared to have changed.
2017-12-08 12:03:00 -08:00
Michael Schurter
4347026f83
Test Consul from TaskRunner thoroughly
...
Rely less on the mockConsulServiceClient because the real
consul.ServiceClient needs all the testing it can get!
2017-12-08 12:03:00 -08:00
Michael Schurter
4ae115dc59
Allow custom ports for services and checks
...
Fixes #3380
Adds address_mode to checks (but no auto) and allows services and checks
to set literal port numbers when using address_mode=driver.
This allows SDNs, overlays, etc to advertise internal and host addresses
as well as do checks against either.
2017-12-08 12:03:00 -08:00
Michael Schurter
1dd5b3822c
Merge pull request #3608 from hashicorp/b-3342-windows-log-leak
...
Fix bug in log framer only affecting Windows
2017-12-08 10:59:26 -08:00
Preetha
b758832e0e
Merge pull request #3635 from hashicorp/clarify_node_vs_task_vars
...
Clarify difference between node and task metadata interpolated vars.
2017-12-08 11:50:20 -06:00
Preetha Appan
e652956496
Clarify difference between node and task metadata interpolated vars.
2017-12-08 11:44:15 -06:00
Alex Dadgar
a0d6b6a121
Merge pull request #3630 from hashicorp/b-periodic
...
Handle race between fingerprinters and registration
2017-12-07 16:11:13 -08:00
Alex Dadgar
91ffbbb517
Review feedback
2017-12-07 16:10:57 -08:00
Michael Lange
b7048179dd
Adds UI changes to the changelog
2017-12-07 15:44:12 -08:00
Michael Lange
c1efbabce6
Merge pull request #3631 from hashicorp/b-ui-expand-definition
...
UI Show full job definition by default
2017-12-07 14:42:01 -08:00
Michael Lange
bfaf81df31
Merge pull request #3607 from hashicorp/f-ui-modify-time-over-modify-index
...
UI Use ModifyTime instead of ModifyIndex in allocation lists
2017-12-07 14:25:28 -08:00
Michael Lange
aeddd4d717
Expand the entire job definition by default
2017-12-07 14:06:51 -08:00
Chelsea Komlo
c8e0cb3044
Merge pull request #3591 from hashicorp/b-1755-stop
...
Allow controlling the stop signal for drivers
2017-12-07 17:06:43 -05:00
Alex Dadgar
02baa6c52b
Handle race between fingerprinters and registration
2017-12-07 13:09:37 -08:00
Chelsea Holland Komlo
61fa8ad4ba
code review fixes
2017-12-07 13:46:25 -05:00
Rob Genova
ad89f608b9
Update README.md
2017-12-07 10:35:46 -08:00
Alex Dadgar
f2dbcc7972
Merge pull request #3628 from hashicorp/b-heartbeat
...
Add logging around heartbeats
2017-12-07 10:12:02 -08:00
Chelsea Holland Komlo
54ec80adb0
add documention
2017-12-07 12:35:02 -05:00
Chelsea Holland Komlo
3f231a0856
add test for kill signal in required signals
...
update changelog
2017-12-07 11:40:15 -05:00
Chelsea Holland Komlo
77ab41124b
set default kill signal on executor shutdown
2017-12-07 11:40:15 -05:00
Chelsea Holland Komlo
6cae8fe6e6
extend configurable kill signal to java driver
2017-12-07 11:40:10 -05:00
Alex Dadgar
4409fdacc0
Drop trace logging
2017-12-06 18:02:24 -08:00
Alex Dadgar
cd9a7f14b8
Add logging around heartbeats
2017-12-06 17:57:50 -08:00
Chelsea Holland Komlo
350319239c
change location of default kill signal
2017-12-06 17:48:25 -05:00
Alex Dadgar
6a33bdb343
Merge pull request #3624 from hashicorp/v-go-getter
...
Update go-getter
2017-12-06 14:25:56 -08:00
Michael Lange
a2b9c2ee60
Merge pull request #3621 from hashicorp/b-ui-timezones
...
UI: Drop timezones from timestamps
2017-12-06 14:16:08 -08:00
Michael Lange
305b058a85
Merge pull request #3623 from hashicorp/f-ui-warn-uncaught-exceptions
...
UI: Warn uncaught exceptions to console
2017-12-06 14:11:22 -08:00
Michael Lange
1af06e882c
Merge pull request #3627 from hashicorp/b-ui-logs-horizontal-scrollbar
...
UI: Make sure the code element within a cli-window takes the full height
2017-12-06 14:09:15 -08:00
Chelsea Holland Komlo
2ea8e43214
code review fixups
2017-12-06 16:37:47 -05:00
Michael Lange
a833248a9d
Make sure the code element within a cli-window takes the full height
2017-12-06 13:36:18 -08:00
Chelsea Holland Komlo
021336eaee
fix up test fixture to properly parse
2017-12-06 16:23:55 -05:00
Michael Lange
03680ec180
A short guide for proxying to a different nomad cluster
...
when developing the UI
2017-12-06 12:38:38 -08:00
Chelsea Holland Komlo
2f22442370
use assert library
2017-12-06 15:03:02 -05:00
Chelsea Holland Komlo
a010db084b
fix up basic test
...
add conversion for KillSignal for api/struct representation of task
2017-12-06 14:36:45 -05:00
Chelsea Holland Komlo
69e4d03694
add missing new file
2017-12-06 14:36:45 -05:00
Chelsea Holland Komlo
7dfb64f941
extract signal helper into utils
2017-12-06 14:36:44 -05:00
Chelsea Holland Komlo
b08611cfac
move kill_signal to task level, extend to docker
2017-12-06 14:36:39 -05:00
Alex Dadgar
5c9e4a5321
Update go-getter
2017-12-06 11:16:17 -08:00
Rob Genova
b81df5503c
Update README.md
2017-12-06 10:51:39 -08:00
Michael Lange
3b6a084a1d
Warn errors in prod
2017-12-06 10:33:03 -08:00