44a749a7cc
drain: fix double-close panic on drain future
2018-04-02 16:39:18 -07:00
86f9044676
remove generated files
2018-03-30 16:52:49 -07:00
af81349dbe
Generated files
2018-03-30 16:14:40 -07:00
23ec54a372
Merge pull request #4089 from hashicorp/tls-error-fix
...
Check for nil for RPC listener; prevent double closing of listener channel
2018-03-30 16:08:13 -07:00
7f28cfcdfe
small cleanup
2018-03-30 15:49:56 -07:00
a77dd08dd9
prevent double close due to error in creating listener
2018-03-30 17:15:56 -04:00
402a026c88
add further error handling for rpc connection handling
2018-03-30 17:03:36 -04:00
e8809f40dc
Test transistion from both infinite and a future deadline to force
2018-03-30 11:24:39 -07:00
32a673a7e1
Fix force deadline notification
2018-03-30 09:58:29 -07:00
1aa415b0d8
Integration test
2018-03-30 09:33:23 -07:00
dc03fab29b
Canonicalize migrate
2018-03-29 17:42:58 -07:00
e458ab9031
Merge branch 'master' into b-drain-batch
2018-03-29 17:10:34 -07:00
62e9553333
Merge pull request #4069 from hashicorp/f-hashealth
...
add HasHealth helper for nil checks
2018-03-29 17:03:20 -07:00
301704091b
Handle upgrade where Node doesn't have eligiblity
...
This PR handles upgrading a node that has no scheduling eligiblity set.
2018-03-29 16:52:23 -07:00
7d2aae2c11
test handleTaskGroup
2018-03-29 16:38:47 -07:00
049a9213d2
Watch batch jobs
2018-03-29 16:07:51 -07:00
9a732c4acb
Merge pull request #4071 from hashicorp/b-handle-missing-finishedat
...
handle missing finishedAt
2018-03-29 17:11:34 -05:00
f12194328c
Integration test for batch complete case
2018-03-29 13:51:04 -07:00
81d48fc7cf
Merge pull request #4079 from hashicorp/b-filter-desiredstop
...
Filter desired status stop allocs correctly
2018-03-29 15:36:22 -05:00
c8317532ff
Use time from task events if task state does not have FinishedAt set
2018-03-29 14:05:56 -05:00
b194f93f2f
Disallow Update stanza on Batch
2018-03-29 11:28:56 -07:00
91b5bb58d9
add HasHealth helper for nil checks
...
We performed the DeploymentStatus nil checks a couple different ways, so
hopefully this helper will consoldiate them and make it more clear what
the code is doing.
2018-03-29 09:29:19 -07:00
607e631714
Merge pull request #4046 from hashicorp/tls-same-file-reload
...
Check file contents when determining if agent should reload TLS confi…
2018-03-29 10:51:32 -04:00
5090fefe96
Filter out allocs with DesiredState = stop, and unit tests
2018-03-29 09:28:52 -05:00
8776f4b942
Fix failing test
2018-03-29 07:59:38 -05:00
2da661595d
If FinishedAt is not set use alloc's modify time for rescheduling logic
2018-03-29 07:42:58 -05:00
b18f789020
Unmark drain when nodes hit their deadline and only batch/system left and add all job type integration test
2018-03-28 17:25:58 -07:00
b33d909bf9
add test to assert invalid files return error
2018-03-28 18:31:35 -04:00
58ada9bc42
return error when setting checksum; don't reload
2018-03-28 18:15:50 -04:00
2d5af7ff4d
set TLS checksum when parsing config
...
Refactor checksum comparison, always set checksum if it is empty
2018-03-28 09:56:11 -04:00
65ddae86f8
Merge pull request #4054 from hashicorp/b-drainer-index-fix
...
drainer: reset index when new job registered
2018-03-27 16:28:25 -07:00
79a2781585
Merge pull request #4053 from hashicorp/b-drain-sys-jobs-2
...
drain: fix draining of system jobs
2018-03-27 16:26:45 -07:00
de4b3772f1
Create evals for system jobs when drain is unset
...
This PR creates evals for system jobs when:
* Drain is unset and mark eligible is true
* Eligibility is restored to the node
2018-03-27 15:53:24 -07:00
dd5f627feb
set server configuration checksum on reload
2018-03-27 18:03:52 -04:00
ec60a1d3e3
drain: improve comments
2018-03-27 14:27:09 -07:00
e5dfb7e487
drain: unittest draining node logic
2018-03-27 14:24:01 -07:00
a1ed305a24
test: add mock batch and system allocs
...
Since the BatchJob helper had a different task group than the Alloc
helper, it was difficult to create a valid batch alloc.
2018-03-27 14:24:01 -07:00
77bddc7941
drain: stop sys jobs after drain completes
...
System allocs should be drained when a node's deadline is hit or when
all other allocs on the node have stopped/migrated.
2018-03-27 14:24:01 -07:00
fae77b874b
drainer: reset index when new job registered
2018-03-27 14:12:59 -07:00
b522a0fadc
fix up to string to use time.Time
2018-03-27 15:43:57 -04:00
31557cc44f
move tests to use time.Time
2018-03-27 15:43:57 -04:00
003bc209b9
use time.Time for node events for compatibility
2018-03-27 15:43:57 -04:00
6e6d6b7e33
check file contents when determining if agent should reload TLS configuration
2018-03-27 15:42:20 -04:00
59005d1d26
Merge pull request #4049 from hashicorp/b-tunnel
...
Only track nodes if the conn is from the node
2018-03-27 12:39:34 -07:00
5dacb057b7
Only track nodes if the conn is from the node
...
Fixes a bug in which a connection to a Nomad server was treated as a
connection to a node because the server forwarded a node specific RPC.
2018-03-27 09:59:31 -07:00
57e2cd04bd
Merge pull request #4025 from hashicorp/reload-http-tls
...
Allow TLS configurations for HTTP and RPC connections to be reloaded …
2018-03-26 18:00:30 -04:00
539114124e
Fix too long token test case
2018-03-26 16:28:33 -05:00
33e170c15d
s/linear/constant/g
2018-03-26 14:45:09 -05:00
7db930b3c3
Extra test case and better error message for ambiguous config
2018-03-26 13:30:09 -05:00
c2a95f9d7d
add test for upgrading only RPC connections
2018-03-26 10:55:27 -04:00
fbd56c35a8
Adds additional validation for ambigous settings (having both unlimited and attempts set)
2018-03-24 10:29:20 -05:00
39987d5236
Merge branch 'master' into b-acl-name
2018-03-22 14:51:40 -07:00
a7f627e34c
eligbile -> eligible
2018-03-21 16:55:22 -07:00
a4f346abeb
remove spurious TODOs and FIXMEs
2018-03-21 16:55:22 -07:00
9f3086a268
test: must initialize jobResults with new func
2018-03-21 16:51:45 -07:00
e432c9af55
test: disable node drainer during tests
...
Node drainer would throw off the index checks
2018-03-21 16:51:45 -07:00
5c8c4bce2a
test: disable drain during fsm test
...
drainer was unsetting drain before fsm could read written value
2018-03-21 16:51:45 -07:00
341d87aa48
tests: use mock.BatchJob to fix tests
2018-03-21 16:51:45 -07:00
8b107acc06
mock: add BatchJob() helper
2018-03-21 16:51:45 -07:00
cb61a4bdc7
Fix linting errors
2018-03-21 16:51:45 -07:00
640ebdaef6
fix race in drain integration tests
2018-03-21 16:51:45 -07:00
c401d5a098
Refactor assertOps into a helper func
2018-03-21 16:51:45 -07:00
187b0e1a48
Remove debug prints
2018-03-21 16:51:45 -07:00
f67eca48ac
Deregister garbage collected jobs
2018-03-21 16:51:45 -07:00
922842546c
JobNs -> NamespacedID
...
Also drop the New func as it's easy to swap the order of arguments since
they're both strings.
2018-03-21 16:51:45 -07:00
8dc7d9fb6a
drainer: RegisterJob -> RegisterJobs
...
Test job watcher
2018-03-21 16:51:45 -07:00
3116897099
Fix deadline heap triggering
...
Chan must be buffered to avoid skipping triggering altogether
Also made timing in a test a bit more lenient
2018-03-21 16:51:45 -07:00
9d23c965da
fix comment
2018-03-21 16:51:45 -07:00
fb4badf1bc
sharding
2018-03-21 16:51:44 -07:00
2d91b9dfba
Batch drain update
2018-03-21 16:51:44 -07:00
92b636dd32
Fix deadline handling
2018-03-21 16:51:44 -07:00
9898edfa90
Switch to drainerv2 impl
2018-03-21 16:51:44 -07:00
7b2bad8c5e
Toggle Drain allows resetting eligibility
...
This PR allows marking a node as eligible for scheduling while toggling
drain. By default the `nomad node drain -disable` commmand will mark it
as eligible but the drainer will maintain in-eligibility.
2018-03-21 16:51:44 -07:00
ad80e655cc
code review
2018-03-21 16:51:44 -07:00
11f9fe4960
spelling fixes
2018-03-21 16:51:44 -07:00
bc7385812d
Comments
2018-03-21 16:51:44 -07:00
e87c677a42
handle empty node case
2018-03-21 16:51:44 -07:00
405dab2253
integration test and basic fixes
2018-03-21 16:51:44 -07:00
e63bcb474d
Drainer
2018-03-21 16:51:44 -07:00
4754366640
job watcher
2018-03-21 16:51:44 -07:00
504bfabb4d
Node's being untracked or having updated deadlines, updates the deadliner
2018-03-21 16:51:44 -07:00
66eaaa6a4d
node watcher
2018-03-21 16:51:44 -07:00
527ac0b39d
drain heap
2018-03-21 16:51:44 -07:00
2d4c193a0a
Initial design
2018-03-21 16:51:44 -07:00
33ca319080
System test runs on mac
2018-03-21 16:51:44 -07:00
f8d4a3a9e6
Fix file names
2018-03-21 16:51:44 -07:00
32a7649359
refactor main drainloop into 2 more methods
2018-03-21 16:51:44 -07:00
5e52f84bb7
drainer: refactor newStopAllocs, applyMigrations
2018-03-21 16:51:44 -07:00
62960ed7bd
client: don't monitor health of non-service jobs
...
Also fix system job draining; won't work without deadline fixes
2018-03-21 16:51:44 -07:00
a37329189a
Improve DeadlineTime helper
2018-03-21 16:51:44 -07:00
b7c993f0e5
drainer: convert fsm errors to go errors
2018-03-21 16:51:44 -07:00
ab0de41884
drainer: factor job & node watchers out of drainer.go
2018-03-21 16:51:44 -07:00
5922aef623
Restart every time SetEnabled(true) is called
2018-03-21 16:51:44 -07:00
959d447d38
Remove unused context
2018-03-21 16:51:44 -07:00
8b41e9b2e1
drainer: drainer should shutdown with server
2018-03-21 16:51:44 -07:00
0a17076ad2
refactor drainer into a subpkg
2018-03-21 16:51:44 -07:00
93871c18f8
Fix retaining the drain
2018-03-21 16:51:44 -07:00
010a6b8ca5
Unblock evals once eligible
2018-03-21 16:51:44 -07:00
8289cc3c6f
HTTP and API
2018-03-21 16:51:44 -07:00
0fba0101b6
RPC/FSM/State Store for Eligibility
2018-03-21 16:51:44 -07:00
b3d2346419
Upgrade path
2018-03-21 16:51:43 -07:00
2f5309d82a
Remove update time
2018-03-21 16:51:43 -07:00
0965c9ed28
Fix tests
2018-03-21 16:51:43 -07:00
010228577e
Drain cli, api, http
2018-03-21 16:51:43 -07:00
e459a666ed
Node.Drain takes strategy
2018-03-21 16:49:48 -07:00
03d0e5b8a0
improve drain fsm/statestore tests
2018-03-21 16:49:48 -07:00
d1ec65d765
switch to new raft DesiredTransition message
2018-03-21 16:49:48 -07:00
acf59ee75e
drainer: switch to job based watching
2018-03-21 16:49:48 -07:00
db4a634072
RPC, FSM, State Store for marking DesiredTransistion
...
fix build tag
2018-03-21 16:49:48 -07:00
c0542474db
drain: initial drainv2 structs and impl
2018-03-21 16:49:48 -07:00
6fc9231dac
Merge pull request #3856 from hashicorp/f-client-add-health-checks
...
Client driver health checks for Docker
2018-03-21 18:05:00 -04:00
66e44cdb73
Allow TLS configurations for HTTP and RPC connections to be reloaded separately
2018-03-21 17:51:08 -04:00
01898b2c25
Merge pull request #4007 from hashicorp/f-show-rescheduling-cli-job-status
...
Show a section on upcoming delayed evaluations when applicable
2018-03-21 14:37:38 -05:00
f801709a0a
fix issue when updating node events
2018-03-21 15:15:26 -04:00
86b7b3d2d9
fix up health check logic comparison; add node events to client driver checks
2018-03-21 15:15:26 -04:00
d8f68e5ef8
fix up codereview feedback
2018-03-21 15:15:26 -04:00
c7fd0bd8a1
fix up scheduler mocks
2018-03-21 15:15:25 -04:00
c50d02ae93
go style; update comments
2018-03-21 15:15:25 -04:00
a522da6994
fix up gofmt
2018-03-21 15:15:25 -04:00
3aa726baab
fix scheduler driver name; create node structs file
2018-03-21 15:15:25 -04:00
3cba95e8a7
allow nomad to schedule based on the status of a client driver health check
...
Slight updates for go style
2018-03-21 15:15:25 -04:00
0bde357731
add concept of health checks to fingerprinters and nodes
...
fix up feedback from code review
add driver info for all drivers to node
2018-03-21 15:15:25 -04:00
17f2f52f08
Merge pull request #3979 from hashicorp/b_update_compat_delete
...
Delete compatibility code for job level update stanza
2018-03-21 09:17:01 -05:00
70c370c6fe
Merge pull request #4003 from jrasell/f_gh_3988
...
Allow Nomads Consul health check names to be configurable.
2018-03-20 16:44:08 -07:00
121c3bc997
Update Consul check params from using health-check to check.
2018-03-20 16:03:58 +01:00
31a3c81c3b
Show a section on upcoming delayed evaluations when applicable
2018-03-19 21:42:37 -05:00
33a5a72323
Make suggested interval round to seconds, and more end to end test cases
2018-03-19 14:56:52 -05:00
15afef9b77
Allow Nomads Consul health checks to be configurable.
...
This change allows the client HTTP and the server HTTP, Serf and
RPC health check names within Consul to be configurable with the
defaults as previous. The configuration can be done via either a
config file or using CLI flags.
Closes #3988
2018-03-19 19:37:56 +01:00
9e05c9a50e
Merge pull request #3997 from hashicorp/b-serf-addr
...
RPC Advertise used exclusively for Clients
2018-03-19 09:30:20 -07:00
2baa1c38f2
clarify comment
2018-03-16 16:47:08 -07:00
b8607ad6d6
Heartbeat uses client rpc advertise and server defaults server rpc advertise addr
2018-03-16 16:47:08 -07:00
52b7fb5361
Separate client and server rpc advertise addresses
2018-03-16 16:47:08 -07:00
c3e8f6319c
gofmt -s (simplify) files
2018-03-16 16:31:16 -07:00
b3ab063132
Merge pull request #3992 from hashicorp/f-vault-orphan
...
Allow and recommend Orphaned Vault tokens
2018-03-16 10:59:54 -07:00
6a44e6092f
Pull snapshotting out of loop
2018-03-16 10:54:26 -07:00
7545c0053e
job gc uses batch endpoint
2018-03-16 10:53:03 -07:00
586ae36d13
Batch Deregister RPC
2018-03-16 10:53:03 -07:00
c152774997
Allow and recommend Orphaned Vault tokens
...
This PR removes enforcement that the Vault token role disallows orphaned
tokens and recommends orphaned tokens to simplify the
bootstrapping/upgrading of Nomad clusters. The requirement that Nomad's
Vault token never expire and be shared by all instances of Nomad servers
is not operationally friendly.
2018-03-15 15:32:08 -07:00
fc782d5942
List unblocks on summary changes
2018-03-15 10:22:03 -07:00
85be2d99b3
Drop ACL todo
2018-03-14 16:41:46 -07:00
3537c73289
Merge pull request #3978 from hashicorp/b-core-sched
...
Always add core scheduler
2018-03-14 16:13:15 -07:00
56e60e5840
Fix linting warning
2018-03-14 16:12:22 -05:00
9a5e6edf1f
Rename DelayCeiling to MaxDelay
2018-03-14 16:10:32 -05:00
4193015e48
Update comment
2018-03-14 16:10:32 -05:00
3e96c6c4e0
Address more code review feedback
2018-03-14 16:10:32 -05:00
9749b7a05c
Avoids unnecessary timer object creation
2018-03-14 16:10:32 -05:00
9fed0d2103
Get reschedule policy from the alloc directly
2018-03-14 16:10:32 -05:00
4d5e9bcb45
Extra comments, remove unnecessary if condition
2018-03-14 16:10:32 -05:00
c6f333c90f
Move delayheap to lib package
2018-03-14 16:10:32 -05:00
1ab8f2b57a
Address some code review comments
2018-03-14 16:10:32 -05:00
7887f39ff4
Added a delay heap to track evals with WaitUntil set, and use in eval broker
2018-03-14 16:10:32 -05:00
342c3fb961
Added FollowupEvalID field and helper methods to calculate reschedule eligibility based on delay
2018-03-14 16:10:32 -05:00
87538fc87d
Fix formatting
2018-03-14 16:10:32 -05:00
51ec6ec15e
Formatting and linting fixes
2018-03-14 16:10:32 -05:00
5f50c3d618
Add new reschedule options to API layer and unit tests
2018-03-14 16:10:32 -05:00
10c9662222
New delayed rescheduling options, validation function and unit tests
2018-03-14 16:10:32 -05:00
92cb552ff6
Always add core scheduler and detect invalid schedulers
2018-03-14 10:53:27 -07:00
55e4f5cdc4
Require core scheduler
2018-03-14 10:37:49 -07:00
948d917a60
lint warning fixed
2018-03-14 11:30:09 -05:00
a924183604
Remove compat code for upgrade stanza that copied state from job level update stanza
2018-03-14 10:21:46 -05:00
810eedfa2a
Merge pull request #3945 from hashicorp/f-add-node-events
...
Add node events
2018-03-14 08:42:55 -04:00
360d6e5a92
Merge pull request #3968 from hashicorp/f-nicer-vault-error
...
Make server side error messages from vault more clearer
2018-03-13 20:49:39 -05:00
7b5955826d
Fix lint warning
2018-03-13 20:49:01 -05:00
de6ebb6e6c
small cleanup
2018-03-13 18:08:22 -07:00
63e14b7d63
nodeevents -> events
2018-03-13 18:08:22 -07:00
d3c3deffad
fixes
2018-03-13 18:08:22 -07:00
b41501e442
code review feedback
2018-03-13 18:08:21 -07:00
8f109c344c
make check fixes
2018-03-13 18:08:21 -07:00
1488b076d1
code review feedback
2018-03-13 18:08:21 -07:00
19ef872769
keep state store functions in one file
2018-03-13 18:08:21 -07:00
a8655320fd
fix up go check warnings
2018-03-13 18:08:21 -07:00
a8bcbd81e6
batch submitting node events
2018-03-13 18:05:40 -07:00
d30c269fbe
code review feedback
2018-03-13 18:05:40 -07:00
0f306aa0dd
move all structs to structs file
2018-03-13 18:05:40 -07:00
311cb857ac
add node id to tests; check for node events in state store
2018-03-13 18:05:40 -07:00
00d9923454
Ensure node updates don't strip node events
...
Add node events to CLI
2018-03-13 18:05:40 -07:00
ae7a2d6eb1
code review feedback
2018-03-13 18:05:40 -07:00
93b732f97e
move adding node registration event to the state store
2018-03-13 18:05:40 -07:00
e7e4a31f5d
fix up error logging
2018-03-13 18:05:40 -07:00
4ede27a3c8
RPC, FSM, state store for Node.EmitEvent
...
add node event when registering a node for the first time
2018-03-13 18:05:40 -07:00
9e10e26387
NodeEvents struct
2018-03-13 18:05:40 -07:00
e08ecb7da2
Fix incorrect comment
2018-03-13 18:25:41 -05:00
be4c30112d
Code review comment
2018-03-13 17:52:33 -05:00
9618f52746
Remove error wrapping and make vault connection server side errors clearer.
2018-03-13 17:09:03 -05:00
9a4fcaaf34
Fix bug with not including namespace in indexing blocked evals
2018-03-13 13:23:11 -05:00
93b0e42e6c
Fix merge change
2018-03-12 16:25:49 -07:00
4844317cc2
Merge pull request #3890 from hashicorp/b-heartbeat
...
Heartbeat improvements and handling failures during establishing leadership
2018-03-12 14:41:59 -07:00
7dd7fbcda2
non-Existent -> nonexistent
...
Reverting from #3963
https://www.merriam-webster.com/dictionary/existent
2018-03-12 11:59:33 -07:00
18c5659474
spelling: version
2018-03-11 19:13:25 +00:00
0ced826ed3
spelling: usage
2018-03-11 19:11:59 +00:00
001f664ab1
spelling: update
2018-03-11 17:44:04 +00:00
173ce63fe9
spelling: transition
2018-03-11 19:06:05 +00:00
c4c4645f46
spelling: summary
2018-03-11 19:00:07 +00:00
6aa0a05998
spelling: scheduling
2018-03-11 18:53:11 +00:00
f28efbbc79
spelling: sanitize
2018-03-11 18:52:59 +00:00
f78d5685ee
spelling: routines
2018-03-11 18:52:35 +00:00
3140a5dcf9
spelling: response
2018-03-11 18:48:24 +00:00
4e40338cfa
spelling: rescheduling
2018-03-11 18:40:32 +00:00
fdd7b5ee9d
spelling: reschedule
2018-03-11 18:50:50 +00:00
6f06f0e6f2
spelling: requeuing
2018-03-11 18:43:05 +00:00
9f2732f405
spelling: requested
2018-03-11 18:43:21 +00:00
c384e14f3d
spelling: request
2018-03-11 18:42:43 +00:00
258d76ec13
spelling: registry
2018-03-11 18:41:13 +00:00
64546b4f99
spelling: referenced
2018-03-11 18:40:45 +00:00
052623bda1
spelling: primitive
2018-03-11 18:38:46 +00:00
eb127482a4
spelling: policies
2018-03-11 18:37:37 +00:00
7ab998803b
spelling: periodic
2018-03-11 18:37:05 +00:00
88537de497
spelling: passed
2018-03-11 18:36:49 +00:00
e4b6eed49b
spelling: only
2018-03-11 18:33:52 +00:00
3c72f0208e
spelling: needed
2018-03-11 18:30:06 +00:00
822a4178d5
spelling: namespace
2018-03-11 18:29:24 +00:00
fb5beb664d
spelling: monotonically
2018-03-11 18:28:31 +00:00
33a0a04941
spelling: missing
2018-03-11 18:27:02 +00:00
7da15e6ee5
spelling: minimum
2018-03-11 18:26:53 +00:00
2c79e590ec
spelling: maintenance
2018-03-11 18:26:20 +00:00
b56ebdf350
spelling: invoke
2018-03-11 18:00:32 +00:00
bc4320df3a
spelling: incremented
2018-03-11 18:15:17 +00:00
69af44e69e
spelling: identifying
2018-03-11 18:15:05 +00:00
b9d1b98756
spelling: healthy
2018-03-11 18:12:57 +00:00
85fabc63c8
spelling: expected
2018-03-11 17:57:01 +00:00
7f6e4012a0
spelling: existent
2018-03-11 18:30:37 +00:00
444341a278
spelling: example
2018-03-11 18:05:59 +00:00
d300623abe
spelling: evaluation
2018-03-11 18:01:35 +00:00
a0452dd7f5
spelling: evaluate
2018-03-11 18:01:29 +00:00
f1d21bfdfe
spelling: enqueuing
2018-03-11 18:00:07 +00:00
d9ce1f7882
spelling: deregister
2018-03-11 17:53:22 +00:00
0869d9c4ee
spelling: deployments
2018-03-11 17:53:43 +00:00
bf05f146cd
spelling: deployment
2018-03-11 17:57:49 +00:00
f7e09cbecf
spelling: correlate
2018-03-11 17:51:05 +00:00
24c76dbcca
spelling: cores
2018-03-11 17:51:20 +00:00
c9b86bbc2f
spelling: controls
2018-03-11 17:50:39 +00:00
95f8098e99
spelling: configuration
2018-03-11 17:48:04 +00:00
d0a76b328d
spelling: captures
2018-03-11 17:46:35 +00:00
ef07cc63d3
spelling: autorevert
2018-03-11 17:42:45 +00:00
5180b04d39
spelling: arguments
2018-03-11 17:40:28 +00:00
b8b46d3f74
spelling: allocation
2018-03-11 17:37:22 +00:00
fb608094ef
spelling: admitting
2018-03-11 17:35:27 +00:00
3232f6f27e
spelling: abandoned
2018-03-11 17:34:16 +00:00
0b3754c05e
Fix error message string in test
2018-03-09 15:07:52 -06:00
f1c2a37f57
Update error message
2018-03-09 14:25:53 -06:00
9d3980b253
update comment
2018-03-09 08:56:54 -06:00
c6b975428b
Always retry on token validation instead of special casing vault sealing
2018-03-08 20:27:49 -06:00
4421025372
Retry when vault is sealed
2018-03-08 16:53:54 -06:00
7c7e2f4d0b
Merge pull request #3873 from hashicorp/r-edge-trigger-node-watcher
...
Edge trigger node updates
2018-03-01 15:18:59 -05:00
eaedffc7f7
Fix go vet errors
2018-02-28 12:21:27 -06:00
b4b0c7cdcf
fix up linting
2018-02-28 12:58:44 -05:00
a72aaaf47f
add network resources equal method, use time ticker
...
remove impossible test case
2018-02-27 12:42:53 -05:00
e6ca70b9af
logging
2018-02-21 10:23:49 -08:00
354faf2820
Fix flaky test
2018-02-20 16:05:43 -08:00
f10ff54d21
add a revoke leadership test
2018-02-20 15:49:03 -08:00
64a45a1603
Need to revoke leadership to clean up in case there was a failure during leadership establishment
2018-02-20 12:52:00 -08:00
040599dae9
Fix leaking time.After function
2018-02-20 12:47:43 -08:00
9a54abd3a8
timers
2018-02-20 10:23:11 -08:00
601177c250
Add escape hatches when non-leader
2018-02-20 10:22:15 -08:00
ab57db1fad
Increase maximum ACL token length
...
This mitigates issues when generating Nomad ACL tokens from Vault.
2018-02-20 09:52:40 -08:00
e916940cfb
vet
2018-02-15 17:08:58 -08:00
6810c66bd8
Fix autopilot tests
2018-02-15 15:48:32 -08:00
f9fd1ce98c
fix unknown rpc tests
2018-02-15 15:29:31 -08:00
a1faab0e58
Server TLS
2018-02-15 15:03:12 -08:00
5b9806590b
add logging
2018-02-15 13:59:03 -08:00
4c60a7ea40
improve test
2018-02-15 13:59:03 -08:00
a8908ad380
Fix incorrect deletion of node conn
...
This PR fixes an issue where if the client has multiple connections to a
server, a single connection closing would cause the routing to the node
to be lost.
2018-02-15 13:59:03 -08:00
0e85ae77b4
fix flaky gc tests
2018-02-15 13:59:03 -08:00
38b695b69c
feedback and rebasing
2018-02-15 13:59:03 -08:00
c5e9ebb656
Use helper for forwarding
2018-02-15 13:59:03 -08:00
9117ef4650
HTTP agent
2018-02-15 13:59:03 -08:00
d7029965ca
Server side impl + touch ups
2018-02-15 13:59:02 -08:00
e685211892
Code review feedback
2018-02-15 13:59:02 -08:00
317485e4f7
Streaming helper
2018-02-15 13:59:02 -08:00
dc75501c69
Respond to comments
2018-02-15 13:59:02 -08:00
64ad3119d0
Implement MultiplexV2 RPC handling
...
Implements and tests the V2 multiplexer. This will not be used until
several versions of Nomad have been released to mitigate upgrade
concerns.
2018-02-15 13:59:02 -08:00
cea77df6a7
Add Streaming RPC ack
...
This PR introduces an ack allowing the receiving end of the streaming
RPC to return any error that may have occured during the establishment
of the streaming RPC.
2018-02-15 13:59:02 -08:00
2f9d33f479
vet
2018-02-15 13:59:02 -08:00
6b74c8b49e
move error
2018-02-15 13:59:02 -08:00
be081b461f
Server implementation of stream
2018-02-15 13:59:02 -08:00
ce3674ea17
Server stat/list impl
2018-02-15 13:59:02 -08:00
8854b35b34
Agent logs
2018-02-15 13:59:02 -08:00
857b0ab6c7
client tests
2018-02-15 13:59:02 -08:00
69def2ff22
Server tests of logs
2018-02-15 13:59:02 -08:00
6c1fa878ea
Forwarding
2018-02-15 13:59:02 -08:00
c6827dc63d
Refactor client RPCs from server
2018-02-15 13:59:02 -08:00
9479cb7f25
Remove logging
2018-02-15 13:59:01 -08:00
ddd67f5f11
Server streaming
2018-02-15 13:59:01 -08:00
ca9379be09
Logs over RPC w/ lots to touch up
2018-02-15 13:59:01 -08:00
2c0ad26374
New RPC Modes and basic setup for streaming RPC handlers
2018-02-15 13:59:01 -08:00
b5037f20db
Remove circular dependency
2018-02-15 13:59:01 -08:00
3f786b904b
use server manager
2018-02-15 13:59:01 -08:00
63d8b42620
code review
2018-02-15 13:59:01 -08:00
46770d57e5
Forwarding
2018-02-15 13:59:01 -08:00
401a510643
Add RPC for querying for Node connections
2018-02-15 13:59:01 -08:00
cfe9afc567
Store connection time
2018-02-15 13:59:01 -08:00
4e1cb1d96e
Test RPC from server
2018-02-15 13:59:00 -08:00
6dd1c9f49d
Refactor
2018-02-15 13:59:00 -08:00
a6dfffa4fa
Add testing interfaces
2018-02-15 13:59:00 -08:00
ad7bc0c6bd
Server can forward ClientStats.Stats
2018-02-15 13:59:00 -08:00
940a2df8a1
Pull inmem codec to helper
2018-02-15 13:59:00 -08:00
7a23659ea8
Conn Pool can emit new connections to listeners.
...
This PR enables the client to listen for new connections and then bind
an RPC listener to each connection in an upcoming PR.
2018-02-15 13:59:00 -08:00
8058ab039f
Store the whole verified certificate chain
2018-02-15 13:59:00 -08:00
13bbf3fbbb
Track client connections
2018-02-15 13:59:00 -08:00
4243438661
Improve TLS cluster testing
2018-02-15 13:59:00 -08:00
ba5ecb8c1a
Dynamic RPC servers with context
2018-02-15 13:59:00 -08:00
288b3c0e05
Helper to populate RPC server endpoints
2018-02-15 13:59:00 -08:00
54b691f538
Merge pull request #3852 from hashicorp/autopilot-cleanup
...
Clean up some leftover autopilot differences from Consul
2018-02-14 10:42:32 -08:00
709b693d39
Clean up some leftover autopilot differences from Consul
2018-02-08 10:27:26 -08:00
8ac05d4462
Reuse default policy structs in api, and other code review feedback
2018-01-31 16:33:00 -06:00
2a5df68e9a
Change the default mode for client side restarts to fail from delay
2018-01-31 10:39:11 -06:00
8ecb6ca91b
Code review feedback and more test cases
2018-01-31 09:58:05 -06:00
28d2439810
Consider dead job status and modify unit test setup for correctness
2018-01-31 09:58:05 -06:00
4fd2691323
Use next alloc id being set, move outside structs package and other code review feedback
2018-01-31 09:58:05 -06:00
009df8b986
Unit test for alloc struct's GCEligible method
2018-01-31 09:58:05 -06:00
5a4c913879
Make garbage collection be aware of rescheduling info in allocations
2018-01-31 09:58:05 -06:00
4cad96a1c3
Remove unnecessary newlines
2018-01-31 09:58:05 -06:00
d016cbdf7b
Unit test for alloc struct's GCEligible method
2018-01-31 09:58:05 -06:00
dd91a2f5be
Make garbage collection be aware of rescheduling info in allocations
2018-01-31 09:58:05 -06:00
b7e59e8037
Fix logging levels per code review
2018-01-31 09:58:05 -06:00
ec1de50d01
replace err with warn
2018-01-31 09:58:05 -06:00
5f501f632b
s/assert/require/g
2018-01-31 09:58:05 -06:00
52a665836e
Remove extra fields set in client allocations during update
2018-01-31 09:58:05 -06:00
57e20b6399
Fix flaky test that fails when there is CPU contention
2018-01-31 09:56:53 -06:00
0c56a12a77
Add RescheduleTracker to allocations API struct
2018-01-31 09:56:53 -06:00
9c600c6d6c
Clean up comments, and one more unit test
2018-01-31 09:56:53 -06:00
f3eb343ffa
Reconcile against reschedule tracker api changes
2018-01-31 09:56:53 -06:00
2567b51c58
Edge trigger evaluation when allocations client status is failed
2018-01-31 09:56:53 -06:00
ea4a889e28
Address more code review feedback
2018-01-31 09:56:53 -06:00
031c566ada
Reschedule previous allocs and track their reschedule attempts
2018-01-31 09:56:53 -06:00
6fcd9f67a8
Named fields in unit test and one more test case
2018-01-31 09:56:53 -06:00
5ee3cdecc5
Clean up the copy method + unit test
2018-01-31 09:56:53 -06:00
8408835af8
Wrap reschedule events in another struct and other review feedback
2018-01-31 09:56:53 -06:00
0a39f213e3
Export RescheduleEligible method for accessibility from UpdateAlloc endpoint
2018-01-31 09:56:53 -06:00
e2eabffcbd
Add comment
2018-01-31 09:56:53 -06:00
28364331cc
New structs and methods for reschedule policy, reschedule tracking and unit tests
2018-01-31 09:56:53 -06:00
cb2321353c
Merge pull request #3812 from hashicorp/autopilot-config-change
...
Refactor redundancy_zone/upgrade_version out of client meta
2018-01-30 16:14:26 -08:00
0eb0acacdc
Fix remaining issues with autopilot change
2018-01-30 15:21:28 -08:00
2ccf565bf6
Refactor redundancy_zone/upgrade_version out of client meta
2018-01-29 20:03:38 -08:00
31e212f467
Merge pull request #3684 from jrasell/f_gh_3678
...
Update `node-status` verbose command to include node address.
2018-01-29 15:32:14 -08:00
288ff0b6f0
Add test case to verify setting next alloc id correctly
2018-01-24 17:55:29 -06:00
fd2fbefa4c
Add a field to track the next allocation during a replacement
2018-01-24 17:55:05 -06:00
a162b9ce14
Move server health loop into autopilot leader actions
2018-01-23 12:57:02 -08:00
d09cc2a69f
Merge pull request #3492 from hashicorp/f-client-tls-reload
...
Client/Server TLS dynamic reload
2018-01-23 05:51:32 -05:00
694b547a6b
Merge pull request #3682 from hashicorp/b-3681-always-set-driver-ip
...
Always advertise driver IP when in driver mode
2018-01-22 16:41:34 -08:00
7d3c240871
swap raft layer tls wrapper
2018-01-19 17:00:15 -05:00
8a0cf66822
Improve invalid port error message for services
...
Related to #3681
If a user specifies an invalid port *label* when using
address_mode=driver they'll get an error message about the label being
an invalid number which is very confusing.
I also added a bunch of testing around Service.AddressMode validation
since I was concerned by the linked issue that there were cases I was
missing. Unfortunately when address_mode=driver is used there's only so
much validation that can be done as structs/structs.go validation never
peeks into the driver config which would be needed to verify the port
labels/map.
2018-01-18 15:35:24 -08:00
8d41f4ad40
Formatting/test adjustments
2018-01-18 15:03:35 -08:00
12ff22ea70
Merge branch 'master' into autopilot
2018-01-18 13:29:25 -08:00
a8f655fbb3
allow for similar error messages for closed connections
2018-01-17 12:02:40 -05:00
35466a331a
fixing up raft reload tests
...
close second goroutine in raft-net
2018-01-17 10:29:15 -05:00
bc385bcc93
Fix comments/text referring to consul
2018-01-17 00:20:13 -08:00
7b980c42d8
Add raft remove by id endpoint/command
2018-01-16 13:35:32 -08:00
5f52e8e103
feedback from code review
2018-01-16 11:55:11 -05:00
649f86f094
refactor creating a new tls configuration
2018-01-16 08:02:39 -05:00
2e6af96eec
Use advertise addr not 'unique.network.ip' in verbose node-status
2018-01-11 07:17:58 +00:00
1bb1ab5069
fix typo
...
Priviledge -> privilege
2018-01-08 15:56:07 -05:00
214d128eb9
reload raft transport layer
...
fix up linting
2018-01-08 14:52:28 -05:00
0708d34135
call reload on agent, client, and server separately
2018-01-08 09:56:31 -05:00
3f34b59ee6
remove unnecessary nil checks; default case
...
add tests for TLSConfig object
2018-01-08 09:24:28 -05:00
d9ec538d6a
don't ignore error in http reloading
...
code review feedback
2018-01-08 09:21:06 -05:00
909bb0af07
refactor rpc listener methods, wait for proper shutdown
2018-01-08 09:21:06 -05:00
6a2432659a
code review fixups
2018-01-08 09:21:06 -05:00
9741097406
reloading tls config should be atomic for clients/servers
2018-01-08 09:21:06 -05:00
e7bd156ef2
check error on generating tls context
2018-01-08 09:21:06 -05:00
9b0a7a7f7c
remove code duplication
2018-01-08 09:21:06 -05:00
4e0dbd23cf
prevent races when reloading, fully shut down raft
2018-01-08 09:21:06 -05:00
ae7fc4695e
fixups from code review
...
Revert "close raft long-lived connections"
This reverts commit 3ffda28206fcb3d63ad117fd1d27ae6f832b6625.
reload raft connections on changing tls
2018-01-08 09:21:06 -05:00
dfb6a3d9a8
close raft long-lived connections
2018-01-08 09:21:06 -05:00
acd3d1b162
fix up downgrading client to plaintext
...
add locks around changing server configuration
2018-01-08 09:21:06 -05:00
c0ad9a4627
add ability to upgrade/downgrade nomad agents tls configurations via sighup
2018-01-08 09:21:06 -05:00
5847b3eb79
fix(minor typo)
2018-01-08 11:30:00 +00:00
fcded9ba61
Add a TODO comment around handling peer address for remove peer correctly for raft protocol 3
2018-01-05 14:22:45 -06:00
6b748fef9e
Remove consul log line
2018-01-04 15:08:12 -08:00
2f561609b7
Fix detection of successful batch allocations
...
This PR restores older behavior of detecting successful batch
allocations (04d86ffd1006fde9dfb2ca8c1237fe60b995b0e3). This has the
side effect that we correctly filter desired status stop but not
successful batch allocations and create their replacements.
2018-01-04 14:20:32 -08:00
8496cc8192
Merge pull request #3685 from filipochnik/abs-path
...
Prevent absolute URLs in checks paths
2018-01-04 10:55:36 -08:00
1712b03705
Merge branch 'master' into 0.8
2018-01-03 16:06:38 -06:00
f99aaa9134
revert change to increase min. CPU resource value from 20 to 100
...
In the commit 622d3ddb92ea7e656ef831641c02024cb5a5d6d1
"Fixed test and moved constants into standalone func" the minimum CPU
resource value for a job was increased from 100 to 20.
This can break the nomad setup for people that used lower CPU
values and are at the maximum MHz value of the available CPU on a
machine.
Change the minimum back to 20 MHz to ensure downwards compatibility.
2018-01-02 16:09:44 +01:00
fc99d3fc2d
Prevent absolute URLs in checks paths
2017-12-21 10:32:12 +01:00
45e8f977f7
Update `node-status` verbose command to include node address.
...
This change updates the `nomad node-status -verbose` command to
also include the addreess of the node. This is helpful for cluster
administrators to quickly discover information and access nodes
when required.
2017-12-21 08:58:35 +00:00
940bc59790
Fixes #3679
...
code review fixups; add changelog
2017-12-20 17:58:07 -05:00
24c56e3976
search endpoint forwarding
2017-12-20 17:57:28 -05:00
bfc62ae41c
bump version and remove generated structs
2017-12-19 17:10:52 -08:00
f0127afd93
generated files
2017-12-19 16:57:34 -08:00
5d65eba2e6
Strip mocked dynamic port for fsm test
2017-12-19 16:41:35 -08:00
714eb0b266
Services should not require a port
...
Fixes #3673
2017-12-19 15:50:23 -08:00
d788c0464c
Clean up error logging
2017-12-18 17:56:12 -06:00
1791cc3ca5
Handle upgrade path
2017-12-18 15:51:35 -08:00
1c07066064
Add autopilot functionality based on Consul's autopilot
2017-12-18 14:29:41 -08:00
40cb1d327c
Address some code review comments
2017-12-18 15:22:23 -06:00
51bd0b59c7
Return an error if evaluation doesn't exist in state store at plan apply time.
2017-12-18 14:55:36 -06:00
3c36abfe14
Update eval modify index as part of plan apply.
2017-12-18 10:03:55 -06:00
3b4d7ac2a3
Fix some typos
2017-12-14 13:29:27 -06:00
045f346293
Use region instead of datacenter for version checking
2017-12-12 10:17:16 -06:00
f088446d48
Add missing exist checks and doc line
2017-12-12 10:17:16 -06:00
b775fc7b33
Added support for v2 raft APIs and -raft-protocol option
2017-12-12 10:17:16 -06:00
d61ade8f02
remove generated structs
2017-12-11 17:51:41 -08:00
8e63d545c4
generated assets
2017-12-11 17:30:37 -08:00
5951222ccb
fix for rpc_upgrade_mode
2017-12-11 19:23:45 -05:00
86608124ca
Fix followers not creating periodic launch
...
Fix an issue in which periodic launches wouldn't be made on followers.
2017-12-11 13:55:17 -08:00
2dca0671b7
Lowercase service IDs to prevent eye bleeding
2017-12-08 15:54:04 -08:00
45494f7304
Fix port labels on mock Alloc/Job/Node
2017-12-08 14:50:06 -08:00
0d8995fb83
Improve validation and testing of service/check ports
2017-12-08 13:52:23 -08:00
d613e0aaf5
Move service hash logic to Service.Hash method
2017-12-08 12:03:43 -08:00
b71edf846f
Hash fields used in task service IDs
...
Fixes #3620
Previously we concatenated tags into task service IDs. This could break
deregistration of tag names that contained double //s like some Fabio
tags.
This change breaks service ID backward compatibility so on upgrade all
users services and checks will be removed and re-added with new IDs.
This change has the side effect of including all service fields in the
ID's hash, so we no longer have to track PortLabel and AddressMode
changes independently.
2017-12-08 12:03:43 -08:00
Michael Schurter