Nick Ethier
5b9013528e
drivers: add docker upgrade path and e2e test
2019-01-23 14:44:42 -05:00
Michael Schurter
1fa376cac6
Merge pull request #5211 from hashicorp/test-porting-08
...
Port some 0.8 TaskRunner tests
2019-01-22 14:05:53 -08:00
Michael Schurter
8ced0adb67
test: port TestTaskRunner_CheckWatcher_Restart
...
Added ability to adjust the number of events the TaskRunner keeps as
there's no way to observe all events otherwise.
Task events differ slightly from 0.8 because 0.9 emits Terminated every
time a task exits instead of only when it exits on its own (not due to
restart or kill).
0.9 does not emit Killing/Killed for restarts like 0.8 which seems fine
as `Restart Signaled/Terminated/Restarting` is more descriptive.
Original v0.8 events emitted:
```
expected := []string{
"Received",
"Task Setup",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Not Restarting",
}
```
2019-01-22 09:46:46 -08:00
Michael Schurter
1719752a9d
test: port RestartTask from 0.8
2019-01-22 08:08:08 -08:00
Michael Schurter
9edff19625
test: port SignalFailure test from 0.8
...
Also fix signal error handling in mock_driver.
2019-01-22 08:08:08 -08:00
Preetha Appan
299a5fc821
Rename TaskKillRequest/Response to TaskPreKillRequest/Response
2019-01-22 09:54:02 -06:00
Preetha Appan
5a5b9c5666
Fix log comments
2019-01-22 09:45:58 -06:00
Preetha Appan
06e15f8381
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:56 -06:00
Michael Schurter
3b02af9386
Fix comment
...
Co-Authored-By: preetapan <preetha@hashicorp.com>
2019-01-22 09:41:21 -06:00
Preetha Appan
09291c689b
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:21 -06:00
Mahmood Ali
a9b73e6b86
Merge pull request #5216 from hashicorp/b-fix-tests-20180118
...
tests: deflake client TestFS_Logs_TaskPending test
2019-01-21 09:54:15 -05:00
Mahmood Ali
d19ba5bd8e
tests: deflake client TestFS_Logs_TaskPending test
2019-01-18 21:26:48 -05:00
Nick Ethier
47127de671
ar: return error from hooks if occured
2019-01-18 18:31:02 -05:00
Nick Ethier
e3c6f89b9a
drivers: use consts for task handle version
2019-01-18 18:31:01 -05:00
Nick Ethier
6804450c69
cleanup code comments and small fixes from refactor
2019-01-18 18:31:01 -05:00
Nick Ethier
05bd369d1f
driver: add pre09 migration logic
2019-01-18 18:31:01 -05:00
Mahmood Ali
5df63fda7c
Merge pull request #5190 from hashicorp/f-memory-usage
...
Track Basic Memory Usage as reported by cgroups
2019-01-18 16:46:02 -05:00
Chris Baker
290c3f36ad
set TaskGroupName in task_runner
2019-01-18 20:25:11 +00:00
Chris Baker
8917961caa
documenting test for task runner failure to set TaskGroupName
2019-01-18 20:00:49 +00:00
Michael Schurter
cfadacfd95
Merge pull request #5203 from hashicorp/b-terminated
...
client: restore Terminated event on every exit
2019-01-18 08:54:15 -08:00
Danielle Tomlinson
bf21612e2b
Merge pull request #5174 from hashicorp/dani/windows
...
Some Windows fixes and CI
2019-01-18 11:21:53 +01:00
Preetha Appan
e0b68a19c6
Fix one more place that should be using taskResources
...
taskResources handles new resource fields in a backwards compatible way
2019-01-17 15:52:51 -06:00
Michael Schurter
a20ac7c1de
client: restore Terminated event on every exit
...
v0.9.0-dev started emitting a Terminated event every time a task process
exited. While this wasn't true in previous versions, it's a useful task
event because it's the only place for job operators to view the task's
exit code.
This behavior is asserted in the e2e/taskevents tests.
2019-01-17 10:02:25 -08:00
Danielle Tomlinson
11c733faa8
allocwatcher: Stat_t is unavailable on win
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
62e06eda56
chore: Cleanup formatting
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
580b8c5dda
client/fs: Skip delete-while-streaming test on win
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
4dbddd0620
client/fs: windows error message for not found
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
915bab2365
vaultclient: use require for error assertions
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
dc55d3e353
vaultclient: Update tests for vault 1.0
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
7a5d511349
fingerprinter: Use HCLogger for windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
a695b3562c
Merge pull request #5193 from hashicorp/dani/logmon-reattach
...
logmon: Reattach to existing loggers
2019-01-16 17:34:13 +01:00
Danielle Tomlinson
99da4c780d
logmon: Reattach to existing loggers
...
This commit prevents us from creating duplicate logmon hooks when
restoring allocations by persisting the logmon reattach config using
HookData.
2019-01-16 14:56:10 +01:00
Michael Schurter
daa7d029a1
test: porting TestTaskRunner_SimpleRun_Dispatch
...
Porting test from 0.8 to 0.9.
2019-01-15 15:22:13 -08:00
Michael Schurter
48afda786b
Merge pull request #5187 from hashicorp/test-consul
...
Port a bunch of pre-0.9 Consul tests to 0.9
2019-01-15 07:41:50 -08:00
Alex Dadgar
471fdb3ccf
Merge pull request #5173 from hashicorp/b-log-levels
...
Plugins use parent loggers
2019-01-14 16:14:30 -08:00
Mahmood Ali
9909d98bee
Track Basic Memory Usage as reported by cgroups
...
Track current memory usage, `memory.usage_in_bytes`, in addition to
`memory.max_memory_usage_in_bytes` and friends. This number is closer
what Docker reports.
Related to https://github.com/hashicorp/nomad/issues/5165 .
2019-01-14 18:47:52 -05:00
Nick Ethier
c619e70d39
Merge pull request #5018 from hashicorp/f-executor-stats
...
executor: streaming stats api
2019-01-14 15:02:35 -05:00
Michael Schurter
4e7ea460e8
test: port some pre-0.9 DeploymentHealth tests
...
Skipping a failing one as I need to move to some other work and don't
want to leave this work orphaned on my machine.
2019-01-14 09:56:53 -08:00
Michael Schurter
ff2f23f5f9
test: assert service interpolation behavior
...
Ported from pre-0.9 tests.
2019-01-14 09:56:53 -08:00
Michael Schurter
5746be5844
test: add some extra logging
2019-01-14 09:56:53 -08:00
Michael Schurter
e877bb6370
test: assert shutdown delay deregs first
...
Restore a pre-0.9 test that asserts Consul services are deregistered
before a task's shutdown delay.
2019-01-14 09:56:53 -08:00
Michael Schurter
1ca858fa92
Update client/allocrunner/taskrunner/stats_hook.go
...
Co-Authored-By: nickethier <ncethier@gmail.com>
2019-01-14 12:31:27 -05:00
Nick Ethier
fbd403df96
tr: stop stats collection on Exited hook
2019-01-14 12:30:14 -05:00
Nick Ethier
597b7b751d
tr: add retry /w backoff to stats_hook failure
2019-01-12 12:18:24 -05:00
Nick Ethier
7e306afde3
executor: fix failing stats related test
2019-01-12 12:18:23 -05:00
Nick Ethier
9fea54e0dc
executor: implement streaming stats API
...
plugins/driver: update driver interface to support streaming stats
client/tr: use streaming stats api
TODO:
* how to handle errors and closed channel during stats streaming
* prevent tight loop if Stats(ctx) returns an error
drivers: update drivers TaskStats RPC to handle streaming results
executor: better error handling in stats rpc
docker: better control and error handling of stats rpc
driver: allow stats to return a recoverable error
2019-01-12 12:18:22 -05:00
Preetha Appan
9e8dbf6a4b
linting fixes
2019-01-12 10:38:20 -06:00
Preetha Appan
c94179578d
Make unit test for allocrunner failure much nicer
2019-01-12 10:38:20 -06:00
Preetha Appan
da0d083b03
Add unit test to simulate alloc runner creation failure
2019-01-12 10:38:20 -06:00
Preetha Appan
e7b59ac08c
Only set deployment health if not already set
2019-01-12 10:38:20 -06:00