41e3fcf205
Because this code was doing pointer equality checks, it would work for the case of a failed attempted RPC because the objects are from the manager itself: https://github.com/hashicorp/consul/blob/v1.0.3/agent/consul/rpc.go#L283-L302 But the pointer check would always fail for events coming in from the Serf path because the server object is newly-created: https://github.com/hashicorp/consul/blob/v1.0.3/agent/router/serf_adapter.go#L14-L40 This means that we didn't proactively shift RPC traffic away from a failed server, we'd have to wait for an RPC to fail, which exposes the error to the calling client. By switching over to a name check vs. a pointer check we get the correct behavior. We added a DEBUG log as well to help observe this behavior during integrated testing. Related to #3863 since the fix here needed the same logic duplicated, owing to the complicated atomic stuff. /cc @dadgar for a heads up in case this also affects Nomad. |
||
---|---|---|
acl | ||
agent | ||
api | ||
bench | ||
command | ||
demo | ||
ipaddr | ||
lib | ||
logger | ||
scripts | ||
sentinel | ||
snapshot | ||
terraform | ||
test | ||
testrpc | ||
testutil | ||
tlsutil | ||
types | ||
ui | ||
vendor | ||
version | ||
watch | ||
website | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
CHANGELOG.md | ||
GNUmakefile | ||
ISSUE_TEMPLATE.md | ||
LICENSE | ||
README.md | ||
Vagrantfile | ||
main.go | ||
main_test.go |
README.md
Consul
- Website: https://www.consul.io
- Chat: Gitter
- Mailing list: Google Groups
Consul is a tool for service discovery and configuration. Consul is distributed, highly available, and extremely scalable.
Consul provides several key features:
-
Service Discovery - Consul makes it simple for services to register themselves and to discover other services via a DNS or HTTP interface. External services such as SaaS providers can be registered as well.
-
Health Checking - Health Checking enables Consul to quickly alert operators about any issues in a cluster. The integration with service discovery prevents routing traffic to unhealthy hosts and enables service level circuit breakers.
-
Key/Value Storage - A flexible key/value store enables storing dynamic configuration, feature flagging, coordination, leader election and more. The simple HTTP API makes it easy to use anywhere.
-
Multi-Datacenter - Consul is built to be datacenter aware, and can support any number of regions without complex configuration.
Consul runs on Linux, Mac OS X, FreeBSD, Solaris, and Windows. A commercial version called Consul Enterprise is also available.
Quick Start
An extensive quick start is viewable on the Consul website:
https://www.consul.io/intro/getting-started/install.html
Documentation
Full, comprehensive documentation is viewable on the Consul website:
Developing Consul
If you wish to work on Consul itself, you'll first need Go installed (version 1.9+ is required). Make sure you have Go properly installed, including setting up your GOPATH.
Next, clone this repository into $GOPATH/src/github.com/hashicorp/consul
and
then just type make
. In a few moments, you'll have a working consul
executable:
$ make
...
$ bin/consul
...
Note: make
will build all os/architecture combinations. Set the environment variable CONSUL_DEV=1
to build it just for your local machine's os/architecture, or use make dev
.
Note: make
will also place a copy of the binary in the first part of your $GOPATH
.
You can run tests by typing make test
. The test suite may fail if
over-parallelized, so if you are seeing stochastic failures try
GOTEST_FLAGS="-p 2 -parallel 2" make test
.
If you make any changes to the code, run make format
in order to automatically
format the code according to Go standards.
Vendoring
Consul currently uses govendor for
vendoring and vendorfmt for formatting
vendor.json
to a more merge-friendly "one line per package" format.