Commit Graph

7332 Commits

Author SHA1 Message Date
James Phillips 41e3fcf205
Makes server manager shift away from failed servers from Serf events.
Because this code was doing pointer equality checks, it would work for
the case of a failed attempted RPC because the objects are from the
manager itself:

https://github.com/hashicorp/consul/blob/v1.0.3/agent/consul/rpc.go#L283-L302

But the pointer check would always fail for events coming in from the
Serf path because the server object is newly-created:

https://github.com/hashicorp/consul/blob/v1.0.3/agent/router/serf_adapter.go#L14-L40

This means that we didn't proactively shift RPC traffic away from a
failed server, we'd have to wait for an RPC to fail, which exposes
the error to the calling client.

By switching over to a name check vs. a pointer check we get the correct
behavior. We added a DEBUG log as well to help observe this behavior during
integrated testing.

Related to #3863 since the fix here needed the same logic duplicated, owing
to the complicated atomic stuff.

/cc @dadgar for a heads up in case this also affects Nomad.
2018-02-05 17:56:00 -08:00
James Phillips 2bde02bd54
Updates the change log. 2018-02-05 16:21:06 -08:00
James Phillips c718459e49
Adds a before/after test for #3845. 2018-02-05 16:18:29 -08:00
James Phillips 5b245c0201
Merge pull request #3845 from 42wim/tagfix
Fix service tags not added to health check. Part two
2018-02-05 16:18:00 -08:00
Preetha c4a9b357d3
Moved DNS vendor update to security section 2018-02-05 17:52:27 -06:00
Preetha 6da63afea2
Update CHANGELOG.md 2018-02-05 17:35:46 -06:00
Preetha Appan dbf59640fe
Update CHANGELOG 2018-02-05 17:34:33 -06:00
Preetha c460537b2a
Patch dns vendor code for picking up a TCP DOS attack bugfix (#3861) 2018-02-05 17:27:45 -06:00
Kyle Havlovitz 4d92efeee6
Update CHANGELOG.md 2018-02-05 15:22:19 -08:00
Kyle Havlovitz 538722395c
Update CHANGELOG.md 2018-02-05 15:12:21 -08:00
Kyle Havlovitz 7f3a1c1175
Pull http config flag merge into public method 2018-02-05 15:00:04 -08:00
Kyle Havlovitz e6f84e783c
Merge pull request #3858 from hashicorp/enterprise-defaults
Add enterprise default config section
2018-02-05 13:38:16 -08:00
Kyle Havlovitz 46745eb89b
Add enterprise default config section 2018-02-05 13:33:59 -08:00
James Phillips 58354510cf
Updates the change log. 2018-02-02 17:59:35 -08:00
James Phillips 0aa05cc5f0
Merge pull request #3855 from hashicorp/pr-3782-slackpad
Adds support for gRPC health checks.
2018-02-02 17:57:27 -08:00
James Phillips 73b729d22b
Adds documentation for gRPC health checks. 2018-02-02 17:53:49 -08:00
James Phillips 1a08e8c0f1
Changes "TLS" to "GRPCUseTLS" since it only applies to GRPC checks. 2018-02-02 17:29:34 -08:00
James Phillips 498c62db06
Merge pull request #3840 from KosToZyB/master
remove golint warnings
2018-02-02 13:51:28 -08:00
Preetha 0f83e6840c
Clarification around locking (#3853) 2018-02-01 14:08:06 -06:00
Wim 5cc76cce09 Fix service tags not added to health check. Part two 2018-01-29 20:32:44 +01:00
Veselkov Konstantin c2395d9bd0 fix refactoring 2018-01-28 22:53:30 +04:00
Veselkov Konstantin c4ad54e057 fix refactoring 2018-01-28 22:48:21 +04:00
Veselkov Konstantin 05666113a4 remove golint warnings 2018-01-28 22:40:13 +04:00
James Phillips 4713921a4c
Merge pull request #3839 from yfouquet/change_jvm_httpclient
Adjust link to Java HTTP API
2018-01-26 08:45:13 -08:00
Yoann Fouquet 7edc742c39 Adjust link to Java HTTP API
OrbitzWorldwide/consul-client has moved to rickfast/consul-client.
2018-01-26 17:31:18 +01:00
James Phillips 443250c76c
Improves user lookup error message.
Closes #3188
Closes #3184
2018-01-26 07:56:44 -08:00
Kyle Havlovitz 32dbb51c3b
Remove nonvoter from metadata.Server 2018-01-25 17:08:03 -08:00
James Phillips 38f5b2e7ce
Gets rid of named return parameters.
This wasn't wrong before but we don't generally use this style in
Consul.
2018-01-25 14:29:50 -08:00
James Phillips 1acaaecbdd
Moves non-stdlib includes into their own section. 2018-01-25 14:26:15 -08:00
James Phillips 9c1a3a0753
Merge pull request #3819 from burdandrei/docker-compose-demo
docker-compose based demo
2018-01-25 13:32:49 -08:00
James Phillips e16f1032d4
Merge pull request #3833 from szemek/curl-binary
Documentation KV Create/upload key, upload binary data or file with line breaks via curl
2018-01-25 13:15:59 -08:00
James Phillips 65a19d0603
Updates the change log. 2018-01-24 10:15:02 -08:00
James Phillips 093cb5c931
Merge pull request #3837 from hashicorp/bump-go
Bumps Go version to 1.9.3.
2018-01-24 10:14:25 -08:00
James Phillips cc95297dcf
Bumps Go version to 1.9.3. 2018-01-24 10:14:14 -08:00
James Phillips bfbedd6c66
Bumps to latest middleman-hashicorp version. 2018-01-24 09:32:45 -08:00
James Phillips d844c1787c
Puts the tree into 1.0.4 dev mode. 2018-01-24 08:01:59 -08:00
James Phillips 2ec1d431ea
Bumps website Consul version to 1.0.3. 2018-01-24 07:20:00 -08:00
James Phillips 44309219b3
Release v1.0.3 2018-01-24 06:57:17 -08:00
James Phillips c2d82891b7
Puts the tree into 1.0.3 release mode. 2018-01-24 06:53:21 -08:00
James Phillips 5e798de202
Updates the change log. 2018-01-24 06:52:46 -08:00
Przemysław Dąbek 51a663eeca
Update kv.html.md 2018-01-24 11:55:17 +01:00
James Phillips f5f360acd4
Removes obsolete bash/zsh completion scripts.
Consul can now set this up for you, see
https://www.consul.io/docs/commands/index.html#autocompletion.
2018-01-23 20:13:39 -08:00
Kyle Havlovitz 0e76d62846
Reset clusterHealth when autopilot starts 2018-01-23 12:52:28 -08:00
James Phillips 504b55e370
Merge pull request #3831 from hashicorp/slackpad-patch-1
Adds a link to Consul Enterprise in the README.
2018-01-23 12:33:10 -08:00
James Phillips 1646fce2c3
Adds a link to Consul Enterprise in the README. 2018-01-23 12:32:54 -08:00
Kyle Havlovitz fbbb993c80
Merge pull request #3830 from hashicorp/autopilot-health-loop
Move autopilot health loop into leader operations
2018-01-23 11:34:32 -08:00
Kyle Havlovitz 6d1dbe6cc4
Move autopilot health loop into leader operations 2018-01-23 11:17:41 -08:00
James Phillips a4c3a3433c
Updates web assets to latest. 2018-01-22 14:46:07 -08:00
Kyle Havlovitz ae1c64544c
Update CHANGELOG.md 2018-01-22 12:33:38 -08:00
Kyle Havlovitz c4528a6110
Merge pull request #3821 from hashicorp/persist-file-handling
Add graceful handling of malformed persisted service/check files.
2018-01-22 12:31:33 -08:00