luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

agent: skip non-sensical TestCatalogRegister 

It is not clear what this test is supposed to verify.
This commit is contained in:
Frank Schroeder 2017-08-28 14:17:16 +02:00 committed by Frank Schröder
parent 2bef1d4d51
commit 3d10312cd6
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
agent/catalog_endpoint_test.go
View File

@ -13,6 +13,8 @@ import (
) )
func TestCatalogRegister(t *testing.T) { func TestCatalogRegister(t *testing.T) {
t.Skip("skipping since it is not clear what this test is supposed to verify")
t.Parallel() t.Parallel()
a := NewTestAgent(t.Name(), "") a := NewTestAgent(t.Name(), "")
defer a.Shutdown() defer a.Shutdown()
@ -27,28 +29,11 @@ func TestCatalogRegister(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("err: %v", err) t.Fatalf("err: %v", err)
} }
res := obj.(bool) res := obj.(bool)
if res != true { if res != true {
t.Fatalf("bad: %v", res) t.Fatalf("bad: %v", res)
} }
// todo(fs): data race
// func() {
// a.State.Lock()
// defer a.State.Unlock()
// // Service should be in sync
// if err := a.State.syncService("foo"); err != nil {
// t.Fatalf("err: %s", err)
// }
// if _, ok := a.State.serviceStatus["foo"]; !ok {
// t.Fatalf("bad: %#v", a.State.serviceStatus)
// }
// if !a.State.serviceStatus["foo"].inSync {
// t.Fatalf("should be in sync")
// }
// }()
if err := a.State.SyncChanges(); err != nil { if err := a.State.SyncChanges(); err != nil {
t.Fatal("sync failed: ", err) t.Fatal("sync failed: ", err)
} }