From 3d10312cd6e2938db704f3685fae7d2a5b3340d0 Mon Sep 17 00:00:00 2001 From: Frank Schroeder Date: Mon, 28 Aug 2017 14:17:16 +0200 Subject: [PATCH] agent: skip non-sensical TestCatalogRegister It is not clear what this test is supposed to verify. --- agent/catalog_endpoint_test.go | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/agent/catalog_endpoint_test.go b/agent/catalog_endpoint_test.go index 566ba6201..fa73dbeee 100644 --- a/agent/catalog_endpoint_test.go +++ b/agent/catalog_endpoint_test.go @@ -13,6 +13,8 @@ import ( ) func TestCatalogRegister(t *testing.T) { + t.Skip("skipping since it is not clear what this test is supposed to verify") + t.Parallel() a := NewTestAgent(t.Name(), "") defer a.Shutdown() @@ -27,28 +29,11 @@ func TestCatalogRegister(t *testing.T) { if err != nil { t.Fatalf("err: %v", err) } - res := obj.(bool) if res != true { t.Fatalf("bad: %v", res) } - // todo(fs): data race - // func() { - // a.State.Lock() - // defer a.State.Unlock() - - // // Service should be in sync - // if err := a.State.syncService("foo"); err != nil { - // t.Fatalf("err: %s", err) - // } - // if _, ok := a.State.serviceStatus["foo"]; !ok { - // t.Fatalf("bad: %#v", a.State.serviceStatus) - // } - // if !a.State.serviceStatus["foo"].inSync { - // t.Fatalf("should be in sync") - // } - // }() if err := a.State.SyncChanges(); err != nil { t.Fatal("sync failed: ", err) }