luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Move FIXME comment to the right call site

This commit is contained in:
Sean Chittenden 2016-03-28 13:49:55 -07:00
parent b38d3d71c8
commit 34a29a2107
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
consul/server_manager/server_manager.go
View File

@ -155,8 +155,6 @@ func (sc *serverConfig) cycleServer() (servers []*server_details.ServerDetails)
newServers = append(newServers, sc.servers[1:]...) newServers = append(newServers, sc.servers[1:]...)
newServers = append(newServers, sc.servers[0]) newServers = append(newServers, sc.servers[0])
// FIXME(sean@): Is it worth it to fire off a go routine and
// PingConsulServer?
return newServers return newServers
} }
@ -258,6 +256,8 @@ func (sm *ServerManager) NotifyFailedServer(server *server_details.ServerDetails
if len(sc.servers) > 1 && sc.servers[0] == server { if len(sc.servers) > 1 && sc.servers[0] == server {
sc.servers = sc.cycleServer() sc.servers = sc.cycleServer()
// FIXME(sean@): Is it worth it to fire off a go routine and
// PingConsulServer?
sm.saveServerConfig(sc) sm.saveServerConfig(sc)
} }
} }