From 34a29a2107fb2105c0ef67eef675f16b7b5cba73 Mon Sep 17 00:00:00 2001 From: Sean Chittenden Date: Mon, 28 Mar 2016 13:49:55 -0700 Subject: [PATCH] Move FIXME comment to the right call site --- consul/server_manager/server_manager.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/consul/server_manager/server_manager.go b/consul/server_manager/server_manager.go index 6ae73e050..8a11e764b 100644 --- a/consul/server_manager/server_manager.go +++ b/consul/server_manager/server_manager.go @@ -155,8 +155,6 @@ func (sc *serverConfig) cycleServer() (servers []*server_details.ServerDetails) newServers = append(newServers, sc.servers[1:]...) newServers = append(newServers, sc.servers[0]) - // FIXME(sean@): Is it worth it to fire off a go routine and - // PingConsulServer? return newServers } @@ -258,6 +256,8 @@ func (sm *ServerManager) NotifyFailedServer(server *server_details.ServerDetails if len(sc.servers) > 1 && sc.servers[0] == server { sc.servers = sc.cycleServer() + // FIXME(sean@): Is it worth it to fire off a go routine and + // PingConsulServer? sm.saveServerConfig(sc) } }