mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 22:41:48 +00:00
351d2fd2b6
Summary: In theory, there should be no danger in mutability, as table builders and readers work from copies of BlockBasedTableOptions. However, there is currently an unresolved read-write race that affecting SetOptions on BBTO fields. This should be generally acceptable for non-pointer options of 64 bits or less, but a fix is needed to make it mutability general here. See https://github.com/facebook/rocksdb/issues/10079 This change systematically sets all of those "simple" options (and future such options) as mutable. (Resurrecting this PR perhaps preferable to proposed https://github.com/facebook/rocksdb/issues/13063) Pull Request resolved: https://github.com/facebook/rocksdb/pull/10021 Test Plan: Some unit test updates. XXX comment added to stress test code Reviewed By: cbi42 Differential Revision: D64360967 Pulled By: pdillinger fbshipit-source-id: ff220fa778331852fe331b42b76ac4adfcd2d760 |
||
|---|---|---|
| .. | ||
| cache.cc | ||
| cache_bench.cc | ||
| cache_bench_tool.cc | ||
| cache_entry_roles.cc | ||
| cache_entry_roles.h | ||
| cache_entry_stats.h | ||
| cache_helpers.cc | ||
| cache_helpers.h | ||
| cache_key.cc | ||
| cache_key.h | ||
| cache_reservation_manager.cc | ||
| cache_reservation_manager.h | ||
| cache_reservation_manager_test.cc | ||
| cache_test.cc | ||
| charged_cache.cc | ||
| charged_cache.h | ||
| clock_cache.cc | ||
| clock_cache.h | ||
| compressed_secondary_cache.cc | ||
| compressed_secondary_cache.h | ||
| compressed_secondary_cache_test.cc | ||
| lru_cache.cc | ||
| lru_cache.h | ||
| lru_cache_test.cc | ||
| secondary_cache.cc | ||
| secondary_cache_adapter.cc | ||
| secondary_cache_adapter.h | ||
| sharded_cache.cc | ||
| sharded_cache.h | ||
| tiered_secondary_cache.cc | ||
| tiered_secondary_cache.h | ||
| tiered_secondary_cache_test.cc | ||
| typed_cache.h | ||