mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 22:41:48 +00:00
06e593376c
Summary: ## Context/Summary Similar to https://github.com/facebook/rocksdb/pull/11288, https://github.com/facebook/rocksdb/pull/11444, categorizing SST/blob file write according to different io activities allows more insight into the activity. For that, this PR does the following: - Tag different write IOs by passing down and converting WriteOptions to IOOptions - Add new SST_WRITE_MICROS histogram in WritableFileWriter::Append() and breakdown FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS Some related code refactory to make implementation cleaner: - Blob stats - Replace high-level write measurement with low-level WritableFileWriter::Append() measurement for BLOB_DB_BLOB_FILE_WRITE_MICROS. This is to make FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS include blob file. As a consequence, this introduces some behavioral changes on it, see HISTORY and db bench test plan below for more info. - Fix bugs where BLOB_DB_BLOB_FILE_SYNCED/BLOB_DB_BLOB_FILE_BYTES_WRITTEN include file failed to sync and bytes failed to write. - Refactor WriteOptions constructor for easier construction with io_activity and rate_limiter_priority - Refactor DBImpl::~DBImpl()/BlobDBImpl::Close() to bypass thread op verification - Build table - TableBuilderOptions now includes Read/WriteOpitons so BuildTable() do not need to take these two variables - Replace the io_priority passed into BuildTable() with TableBuilderOptions::WriteOpitons::rate_limiter_priority. Similar for BlobFileBuilder. This parameter is used for dynamically changing file io priority for flush, see https://github.com/facebook/rocksdb/pull/9988?fbclid=IwAR1DtKel6c-bRJAdesGo0jsbztRtciByNlvokbxkV6h_L-AE9MACzqRTT5s for more - Update ThreadStatus::FLUSH_BYTES_WRITTEN to use io_activity to track flush IO in flush job and db open instead of io_priority ## Test ### db bench Flush ``` ./db_bench --statistics=1 --benchmarks=fillseq --num=100000 --write_buffer_size=100 rocksdb.sst.write.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377 rocksdb.file.write.flush.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377 rocksdb.file.write.compaction.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 rocksdb.file.write.db.open.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 ``` compaction, db oopen ``` Setup: ./db_bench --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench Run:./db_bench --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1 rocksdb.sst.write.micros P50 : 2.675325 P95 : 9.578788 P99 : 18.780000 P100 : 314.000000 COUNT : 638 SUM : 3279 rocksdb.file.write.flush.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 rocksdb.file.write.compaction.micros P50 : 2.757353 P95 : 9.610687 P99 : 19.316667 P100 : 314.000000 COUNT : 615 SUM : 3213 rocksdb.file.write.db.open.micros P50 : 2.055556 P95 : 3.925000 P99 : 9.000000 P100 : 9.000000 COUNT : 23 SUM : 66 ``` blob stats - just to make sure they aren't broken by this PR ``` Integrated Blob DB Setup: ./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench Run:./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1 pre-PR: rocksdb.blobdb.blob.file.write.micros P50 : 7.298246 P95 : 9.771930 P99 : 9.991813 P100 : 16.000000 COUNT : 235 SUM : 1600 rocksdb.blobdb.blob.file.synced COUNT : 1 rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 post-PR: rocksdb.blobdb.blob.file.write.micros P50 : 2.000000 P95 : 2.829360 P99 : 2.993779 P100 : 9.000000 COUNT : 707 SUM : 1614 - COUNT is higher and values are smaller as it includes header and footer write - COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164 rocksdb.blobdb.blob.file.synced COUNT : 1 (stay the same) rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 (stay the same) ``` ``` Stacked Blob DB Run: ./db_bench --use_blob_db=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench pre-PR: rocksdb.blobdb.blob.file.write.micros P50 : 12.808042 P95 : 19.674497 P99 : 28.539683 P100 : 51.000000 COUNT : 10000 SUM : 140876 rocksdb.blobdb.blob.file.synced COUNT : 8 rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 post-PR: rocksdb.blobdb.blob.file.write.micros P50 : 1.657370 P95 : 2.952175 P99 : 3.877519 P100 : 24.000000 COUNT : 30001 SUM : 67924 - COUNT is higher and values are smaller as it includes header and footer write - COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164 rocksdb.blobdb.blob.file.synced COUNT : 8 (stay the same) rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 (stay the same) ``` ### Rehearsal CI stress test Trigger 3 full runs of all our CI stress tests ### Performance Flush ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=ManualFlush/key_num:524288/per_key_size:256 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark; enable_statistics = true Pre-pr: avg 507515519.3 ns 497686074,499444327,500862543,501389862,502994471,503744435,504142123,504224056,505724198,506610393,506837742,506955122,507695561,507929036,508307733,508312691,508999120,509963561,510142147,510698091,510743096,510769317,510957074,511053311,511371367,511409911,511432960,511642385,511691964,511730908, Post-pr: avg 511971266.5 ns, regressed 0.88% 502744835,506502498,507735420,507929724,508313335,509548582,509994942,510107257,510715603,511046955,511352639,511458478,512117521,512317380,512766303,512972652,513059586,513804934,513808980,514059409,514187369,514389494,514447762,514616464,514622882,514641763,514666265,514716377,514990179,515502408, ``` Compaction ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_{pre|post}_pr --benchmark_filter=ManualCompaction/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark Pre-pr: avg 495346098.30 ns 492118301,493203526,494201411,494336607,495269217,495404950,496402598,497012157,497358370,498153846 Post-pr: avg 504528077.20, regressed 1.85%. "ManualCompaction" include flush so the isolated regression for compaction should be around 1.85-0.88 = 0.97% 502465338,502485945,502541789,502909283,503438601,504143885,506113087,506629423,507160414,507393007 ``` Put with WAL (in case passing WriteOptions slows down this path even without collecting SST write stats) ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark Pre-pr: avg 3848.10 ns 3814,3838,3839,3848,3854,3854,3854,3860,3860,3860 Post-pr: avg 3874.20 ns, regressed 0.68% 3863,3867,3871,3874,3875,3877,3877,3877,3880,3881 ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/11910 Reviewed By: ajkr Differential Revision: D49788060 Pulled By: hx235 fbshipit-source-id: 79e73699cda5be3b66461687e5147c2484fc5eff
171 lines
5.7 KiB
C++
171 lines
5.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "util/file_checksum_helper.h"
|
|
|
|
#include <unordered_set>
|
|
|
|
#include "db/log_reader.h"
|
|
#include "db/version_edit.h"
|
|
#include "db/version_edit_handler.h"
|
|
#include "file/sequence_file_reader.h"
|
|
#include "rocksdb/utilities/customizable_util.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
void FileChecksumListImpl::reset() { checksum_map_.clear(); }
|
|
|
|
size_t FileChecksumListImpl::size() const { return checksum_map_.size(); }
|
|
|
|
Status FileChecksumListImpl::GetAllFileChecksums(
|
|
std::vector<uint64_t>* file_numbers, std::vector<std::string>* checksums,
|
|
std::vector<std::string>* checksum_func_names) {
|
|
if (file_numbers == nullptr || checksums == nullptr ||
|
|
checksum_func_names == nullptr) {
|
|
return Status::InvalidArgument("Pointer has not been initiated");
|
|
}
|
|
|
|
for (const auto& i : checksum_map_) {
|
|
file_numbers->push_back(i.first);
|
|
checksums->push_back(i.second.first);
|
|
checksum_func_names->push_back(i.second.second);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::SearchOneFileChecksum(
|
|
uint64_t file_number, std::string* checksum,
|
|
std::string* checksum_func_name) {
|
|
if (checksum == nullptr || checksum_func_name == nullptr) {
|
|
return Status::InvalidArgument("Pointer has not been initiated");
|
|
}
|
|
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
return Status::NotFound();
|
|
} else {
|
|
*checksum = it->second.first;
|
|
*checksum_func_name = it->second.second;
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::InsertOneFileChecksum(
|
|
uint64_t file_number, const std::string& checksum,
|
|
const std::string& checksum_func_name) {
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
checksum_map_.insert(std::make_pair(
|
|
file_number, std::make_pair(checksum, checksum_func_name)));
|
|
} else {
|
|
it->second.first = checksum;
|
|
it->second.second = checksum_func_name;
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::RemoveOneFileChecksum(uint64_t file_number) {
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
return Status::NotFound();
|
|
} else {
|
|
checksum_map_.erase(it);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
FileChecksumList* NewFileChecksumList() {
|
|
FileChecksumListImpl* checksum_list = new FileChecksumListImpl();
|
|
return checksum_list;
|
|
}
|
|
|
|
std::shared_ptr<FileChecksumGenFactory> GetFileChecksumGenCrc32cFactory() {
|
|
static std::shared_ptr<FileChecksumGenFactory> default_crc32c_gen_factory(
|
|
new FileChecksumGenCrc32cFactory());
|
|
return default_crc32c_gen_factory;
|
|
}
|
|
|
|
Status GetFileChecksumsFromManifest(Env* src_env, const std::string& abs_path,
|
|
uint64_t manifest_file_size,
|
|
FileChecksumList* checksum_list) {
|
|
if (checksum_list == nullptr) {
|
|
return Status::InvalidArgument("checksum_list is nullptr");
|
|
}
|
|
assert(checksum_list);
|
|
// TODO: plumb Env::IOActivity, Env::IOPriority
|
|
const ReadOptions read_options;
|
|
checksum_list->reset();
|
|
Status s;
|
|
|
|
std::unique_ptr<SequentialFileReader> file_reader;
|
|
{
|
|
std::unique_ptr<FSSequentialFile> file;
|
|
const std::shared_ptr<FileSystem>& fs = src_env->GetFileSystem();
|
|
s = fs->NewSequentialFile(abs_path,
|
|
fs->OptimizeForManifestRead(FileOptions()), &file,
|
|
nullptr /* dbg */);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
file_reader.reset(new SequentialFileReader(std::move(file), abs_path));
|
|
}
|
|
|
|
struct LogReporter : public log::Reader::Reporter {
|
|
Status* status_ptr;
|
|
virtual void Corruption(size_t /*bytes*/, const Status& st) override {
|
|
if (status_ptr->ok()) {
|
|
*status_ptr = st;
|
|
}
|
|
}
|
|
} reporter;
|
|
reporter.status_ptr = &s;
|
|
log::Reader reader(nullptr, std::move(file_reader), &reporter,
|
|
true /* checksum */, 0 /* log_number */);
|
|
FileChecksumRetriever retriever(read_options, manifest_file_size,
|
|
*checksum_list);
|
|
retriever.Iterate(reader, &s);
|
|
assert(!retriever.status().ok() ||
|
|
manifest_file_size == std::numeric_limits<uint64_t>::max() ||
|
|
reader.LastRecordEnd() == manifest_file_size);
|
|
|
|
return retriever.status();
|
|
}
|
|
|
|
namespace {
|
|
static int RegisterFileChecksumGenFactories(ObjectLibrary& library,
|
|
const std::string& /*arg*/) {
|
|
library.AddFactory<FileChecksumGenFactory>(
|
|
FileChecksumGenCrc32cFactory::kClassName(),
|
|
[](const std::string& /*uri*/,
|
|
std::unique_ptr<FileChecksumGenFactory>* guard,
|
|
std::string* /* errmsg */) {
|
|
guard->reset(new FileChecksumGenCrc32cFactory());
|
|
return guard->get();
|
|
});
|
|
return 1;
|
|
}
|
|
} // namespace
|
|
|
|
Status FileChecksumGenFactory::CreateFromString(
|
|
const ConfigOptions& options, const std::string& value,
|
|
std::shared_ptr<FileChecksumGenFactory>* result) {
|
|
static std::once_flag once;
|
|
std::call_once(once, [&]() {
|
|
RegisterFileChecksumGenFactories(*(ObjectLibrary::Default().get()), "");
|
|
});
|
|
if (value == FileChecksumGenCrc32cFactory::kClassName()) {
|
|
*result = GetFileChecksumGenCrc32cFactory();
|
|
return Status::OK();
|
|
} else {
|
|
Status s = LoadSharedObject<FileChecksumGenFactory>(options, value, result);
|
|
return s;
|
|
}
|
|
}
|
|
} // namespace ROCKSDB_NAMESPACE
|