From bd15f92a56d443c81003268993834d03646314bc Mon Sep 17 00:00:00 2001
From: David Hewitt <mail@davidhewitt.dev>
Date: Sun, 14 Apr 2024 22:38:40 +0100
Subject: [PATCH] Deprecate the `PySet::empty` gil-ref constructor (#4082)

* Deprecate the `PySet::empty` gil-ref constructor

* add newsfragment
---
 newsfragments/4082.changed.md | 1 +
 src/types/set.rs              | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 newsfragments/4082.changed.md

diff --git a/newsfragments/4082.changed.md b/newsfragments/4082.changed.md
new file mode 100644
index 00000000..231ea0ae
--- /dev/null
+++ b/newsfragments/4082.changed.md
@@ -0,0 +1 @@
+Deprecate the `PySet::empty()` gil-ref constructor.
diff --git a/src/types/set.rs b/src/types/set.rs
index 4f1fcf84..f648bc2b 100644
--- a/src/types/set.rs
+++ b/src/types/set.rs
@@ -58,7 +58,14 @@ impl PySet {
     }
 
     /// Deprecated form of [`PySet::empty_bound`].
-    pub fn empty(py: Python<'_>) -> PyResult<&'_ PySet> {
+    #[cfg_attr(
+        not(feature = "gil-refs"),
+        deprecated(
+            since = "0.21.2",
+            note = "`PySet::empty` will be replaced by `PySet::empty_bound` in a future PyO3 version"
+        )
+    )]
+    pub fn empty(py: Python<'_>) -> PyResult<&PySet> {
         Self::empty_bound(py).map(Bound::into_gil_ref)
     }