From ae8186523209a92d29aec8ecfa772f74ca933846 Mon Sep 17 00:00:00 2001 From: Yuji Kanagawa Date: Mon, 13 Apr 2020 10:38:06 +0900 Subject: [PATCH] Apply suggestions from David Co-Authored-By: David Hewitt <1939362+davidhewitt@users.noreply.github.com> --- CHANGELOG.md | 6 +++--- tests/test_compile_error.rs | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d4f99244..10de8e2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,8 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Changed * `PyObject` and `Py` reference counts are now decremented sooner after `drop()`. [#851](https://github.com/PyO3/pyo3/pull/851) -* When the GIL is held, the refcount is now decreased immediately on drop. (Previously would wait until just before releasing the GIL.) -* When the GIL is not held, the refcount is now decreased when the GIL is next acquired. (Previously would wait until next time the GIL was released.) + * When the GIL is held, the refcount is now decreased immediately on drop. (Previously would wait until just before releasing the GIL.) + * When the GIL is not held, the refcount is now decreased when the GIL is next acquired. (Previously would wait until next time the GIL was released.) ### Added * `_PyDict_NewPresized`. [#849](https://github.com/PyO3/pyo3/pull/849) @@ -20,7 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Fixed * `__radd__` and other `__r*__` methods now correctly work with operators. [#839](https://github.com/PyO3/pyo3/pull/839) * Garbage Collector causing random panics when traversing objects that were mutably borrowed. [#855](https://github.com/PyO3/pyo3/pull/855) -* `&'static Py~` is not allowed as arguments. [#869](https://github.com/PyO3/pyo3/pull/869) +* `&'static Py~` being allowed as arguments. [#869](https://github.com/PyO3/pyo3/pull/869) ## [0.9.2] diff --git a/tests/test_compile_error.rs b/tests/test_compile_error.rs index 8021bd33..e141853d 100644 --- a/tests/test_compile_error.rs +++ b/tests/test_compile_error.rs @@ -8,8 +8,8 @@ fn test_compile_errors() { t.compile_fail("tests/ui/missing_clone.rs"); t.compile_fail("tests/ui/reject_generics.rs"); // Since the current minimum nightly(2020-01-20) has a different error message, - // we skip a test. - // TODO(kngwyu): Remove this when we update minimum nightly. + // we skip this test. + // TODO(kngwyu): Remove this `if` when we update minimum nightly. if option_env!("TRAVIS_JOB_NAME") != Some("Minimum nightly") { t.compile_fail("tests/ui/static_ref.rs"); }