Always set `Py_SHARED` when building for Windows

Setting `PYO3_NO_PYTHON` results in an extension module built with
a different config feature set (on Windows).
Specifically, `Py_SHARED` config option gets omitted in this code path.

Maturin always sets `PYO3_NO_PYTHON` when cross-compiling abi3 extensions,
which creates a subtle configuration mismatch between `cargo build`
and `maturin build` artifacts.

Always set `Py_SHARED` when compiling abi3 extensions for Windows.
This commit is contained in:
Sergey Kvachonok 2021-03-25 10:45:58 +03:00
parent 93696889d3
commit a0d1c5509d
1 changed files with 9 additions and 5 deletions

View File

@ -886,13 +886,17 @@ fn abi3_without_interpreter() -> Result<()> {
println!("cargo:rustc-cfg=py_sys_config=\"WITH_THREAD\"");
println!("cargo:python_flags={}", flags);
// Unfortunately, on windows we can't build without at least providing
// python.lib to the linker. While maturin tells the linker the location
// of python.lib, we need to do the renaming here, otherwise cargo
// complains that the crate using pyo3 does not contains a `#[link(...)]`
// attribute with pythonXY.
if env::var("CARGO_CFG_TARGET_FAMILY")? == "windows" {
// Unfortunately, on windows we can't build without at least providing
// python.lib to the linker. While maturin tells the linker the location
// of python.lib, we need to do the renaming here, otherwise cargo
// complains that the crate using pyo3 does not contains a `#[link(...)]`
// attribute with pythonXY.
println!("cargo:rustc-link-lib=pythonXY:python3");
// Match `get_config_from_interpreter()` and `windows_hardcoded_cross_compile()`:
// assume "Py_ENABLE_SHARED" to be set on Windows.
println!("cargo:rustc-cfg=Py_SHARED");
}
Ok(())