luxolus
/
pyo3
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3798 from davidhewitt/beta-map-clone 

ci: fix beta clippy `map_clone` warning
This commit is contained in:
Bruno Kolenbrander 2024-02-05 08:48:14 +00:00 committed by GitHub
parent c9c6f928a1 de93d15eeb
commit 7938d4cadc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/instance.rs
View File

@ -1443,6 +1443,9 @@ where
{ {
/// Extracts `Self` from the source `PyObject`. /// Extracts `Self` from the source `PyObject`.
fn extract_bound(ob: &Bound<'py, PyAny>) -> PyResult<Self> { fn extract_bound(ob: &Bound<'py, PyAny>) -> PyResult<Self> {
// TODO update MSRV past 1.59 and use .cloned() to make
// clippy happy
#[allow(clippy::map_clone)]
ob.downcast().map(Clone::clone).map_err(Into::into) ob.downcast().map(Clone::clone).map_err(Into::into)
} }
} }

4
tests/test_proto_methods.rs
View File

@ -264,13 +264,13 @@ impl Sequence {
self.values.len() self.values.len()
} }
fn __getitem__(&self, index: SequenceIndex<'_>) -> PyResult<PyObject> { fn __getitem__(&self, index: SequenceIndex<'_>, py: Python<'_>) -> PyResult<PyObject> {
match index { match index {
SequenceIndex::Integer(index) => { SequenceIndex::Integer(index) => {
let uindex = self.usize_index(index)?; let uindex = self.usize_index(index)?;
self.values self.values
.get(uindex) .get(uindex)
.map(Clone::clone) .map(|o| o.clone_ref(py))
.ok_or_else(|| PyIndexError::new_err(index)) .ok_or_else(|| PyIndexError::new_err(index))
} }
// Just to prove that slicing can be implemented // Just to prove that slicing can be implemented