From 6bbf3d75950df41f22e414a1823b3f2756fff216 Mon Sep 17 00:00:00 2001 From: messense Date: Tue, 18 Jul 2017 09:33:27 +0800 Subject: [PATCH] Add rustc version check in build script (#47) * Add rustc version check in build script * Update rustc requirement in README.md --- Cargo.toml | 1 + README.md | 4 ++-- build.rs | 45 ++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 47 insertions(+), 3 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 9be30ddd..67c2d344 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -29,6 +29,7 @@ pyo3cls = { path = "pyo3cls" } [build-dependencies] regex = "0.2" +version_check = "0.1" [features] default = [] diff --git a/README.md b/README.md index d65e19f4..e3853c9d 100644 --- a/README.md +++ b/README.md @@ -17,8 +17,8 @@ Supported Python versions: Supported Rust version: -* Rust 1.19.0-nightly or later -* On Windows, we require rustc 1.19.0-nightly +* Rust 1.20.0-nightly or later +* On Windows, we require rustc 1.20.0-nightly ## Usage diff --git a/build.rs b/build.rs index 3b282f42..7e4b74a7 100644 --- a/build.rs +++ b/build.rs @@ -1,11 +1,18 @@ extern crate regex; +extern crate version_check; use std::process::Command; use std::collections::HashMap; use std::env; -use regex::Regex; use std::fmt; +use regex::Regex; +use version_check::{supports_features, is_min_version, is_min_date}; + +// Specifies the minimum nightly version needed to compile pyo3. +const MIN_DATE: &'static str = "2017-07-09"; +const MIN_VERSION: &'static str = "1.20.0-nightly"; + #[derive(Debug)] struct PythonVersion { major: u8, @@ -394,7 +401,43 @@ fn version_from_env() -> Result { feature must be enabled.".to_owned()) } +fn check_rustc_version() { + let ok_channel = supports_features(); + let ok_version = is_min_version(MIN_VERSION); + let ok_date = is_min_date(MIN_DATE); + + let print_version_err = |version: &str, date: &str| { + eprintln!("Installed version is: {} ({}). Minimum required: {} ({}).", + version, + date, + MIN_VERSION, + MIN_DATE); + }; + + match (ok_channel, ok_version, ok_date) { + (Some(ok_channel), Some((ok_version, version)), Some((ok_date, date))) => { + if !ok_channel { + eprintln!("Error: pyo3 requires a nightly or dev version of Rust."); + print_version_err(&*version, &*date); + panic!("Aborting compilation due to incompatible compiler.") + } + + if !ok_version || !ok_date { + eprintln!("Error: pyo3 requires a more recent version of rustc."); + eprintln!("Use `rustup update` or your preferred method to update Rust"); + print_version_err(&*version, &*date); + panic!("Aborting compilation due to incompatible compiler.") + } + }, + _ => { + println!("cargo:warning={}", "pyo3 was unable to check rustc compatibility."); + println!("cargo:warning={}", "Build may fail due to incompatible rustc version."); + } + } +} + fn main() { + check_rustc_version(); // 1. Setup cfg variables so we can do conditional compilation in this // library based on the python interpeter's compilation flags. This is // necessary for e.g. matching the right unicode and threading interfaces.