src/impl_: add ff unsafe-allow-subinterpreters

Allow the subinterpreter safeguards to be disabled, so that applications
like Ceph's manager can continue to use pyo3 modules without soft
crashing.

Enabling this feature should be done with caution, as any storage of Py
objects in rust statics can lead to undefined behavior.

However, not all consumers of pyo3 use global state, and thus a subset
of them (such as python-bcrypt) are safe to use in subinterpreter
contexts.

References: https://github.com/bazaah/aur-ceph/issues/20
References: https://github.com/PyO3/pyo3/pull/2523
References: https://github.com/pyca/cryptography/issues/9016
References: https://github.com/PyO3/pyo3/discussions/2346#discussioncomment-3246505
References: https://github.com/PyO3/pyo3/discussions/2346#discussioncomment-2911159
References: https://github.com/PyO3/pyo3/issues/3451
This commit is contained in:
Paul Stemmet 2024-03-16 16:10:56 +00:00
parent dcba984b51
commit 44d6919168
Signed by: Paul Stemmet
GPG Key ID: EDEA539F594E7E75
2 changed files with 4 additions and 1 deletions

View File

@ -109,6 +109,9 @@ gil-refs = []
# Optimizes PyObject to Vec conversion and so on.
nightly = []
# Disables the checks for use in subinterpreters.
unsafe-allow-subinterpreters = []
# Activates all additional features
# This is mostly intended for testing purposes - activating *all* of these isn't particularly useful.
full = [

View File

@ -85,7 +85,7 @@ impl ModuleDef {
// that static data is not reused across interpreters.
//
// PyPy does not have subinterpreters, so no need to check interpreter ID.
#[cfg(not(PyPy))]
#[cfg(not(any(PyPy, feature = "unsafe-allow-subinterpreters")))]
{
// PyInterpreterState_Get is only available on 3.9 and later, but is missing
// from python3.dll for Windows stable API on 3.9