From afa5ed3ba28ed5458808268d66d2263f5fbe940b Mon Sep 17 00:00:00 2001
From: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Date: Sat, 28 Nov 2020 19:44:29 +0000
Subject: [PATCH] Release notes for backported 0.12.4

---
 CHANGELOG.md                   | 7 ++++++-
 Cargo.toml                     | 4 ++--
 README.md                      | 4 ++--
 pyo3-derive-backend/Cargo.toml | 2 +-
 pyo3cls/Cargo.toml             | 4 ++--
 src/lib.rs                     | 4 ++--
 6 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 908a17da..7b17bc5b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -45,6 +45,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fix FFI definitions for `PyObject_Vectorcall` and `PyVectorcall_Call`. [#1287](https://github.com/PyO3/pyo3/pull/1285)
 - Fix building with Anaconda python inside a virtualenv. [#1290](https://github.com/PyO3/pyo3/pull/1290)
 
+## [0.12.4] - 2020-11-28
+### Fixed
+- Fix reference count bug in implementation of `From<Py<T>>` for `PyObject`, a regression introduced in PyO3 0.12. [#1297](https://github.com/PyO3/pyo3/pull/1297)
+
 ## [0.12.3] - 2020-10-12
 ### Fixed
 - Fix support for Rust versions 1.39 to 1.44, broken by an incorrect internal update to paste 1.0 which was done in PyO3 0.12.2. [#1234](https://github.com/PyO3/pyo3/pull/1234)
@@ -555,7 +559,8 @@ Yanked
 ### Added
 - Initial release
 
-[Unreleased]: https://github.com/pyo3/pyo3/compare/v0.12.3...HEAD
+[Unreleased]: https://github.com/pyo3/pyo3/compare/v0.12.4...HEAD
+[0.12.4]: https://github.com/pyo3/pyo3/compare/v0.12.3...v0.12.4
 [0.12.3]: https://github.com/pyo3/pyo3/compare/v0.12.2...v0.12.3
 [0.12.2]: https://github.com/pyo3/pyo3/compare/v0.12.1...v0.12.2
 [0.12.1]: https://github.com/pyo3/pyo3/compare/v0.12.0...v0.12.1
diff --git a/Cargo.toml b/Cargo.toml
index 9850271f..77c8355b 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pyo3"
-version = "0.12.3"
+version = "0.12.4"
 description = "Bindings to Python interpreter"
 authors = ["PyO3 Project and Contributors <https://github.com/PyO3>"]
 readme = "README.md"
@@ -24,7 +24,7 @@ parking_lot = "0.11.0"
 num-bigint = { version = "0.3", optional = true }
 num-complex = { version = "0.3", optional = true }
 paste = { version = "1.0.3", optional = true }
-pyo3cls = { path = "pyo3cls", version = "=0.12.3", optional = true }
+pyo3cls = { path = "pyo3cls", version = "=0.12.4", optional = true }
 unindent = { version = "0.1.4", optional = true }
 hashbrown = { version = "0.9", optional = true }
 
diff --git a/README.md b/README.md
index 40765ecb..3c0b8031 100644
--- a/README.md
+++ b/README.md
@@ -48,7 +48,7 @@ name = "string_sum"
 crate-type = ["cdylib"]
 
 [dependencies.pyo3]
-version = "0.12.3"
+version = "0.12.4"
 features = ["extension-module"]
 ```
 
@@ -99,7 +99,7 @@ use it to run Python code, add `pyo3` to your `Cargo.toml` like this:
 
 ```toml
 [dependencies]
-pyo3 = "0.12.3"
+pyo3 = "0.12.4"
 ```
 
 Example program displaying the value of `sys.version` and the current user name:
diff --git a/pyo3-derive-backend/Cargo.toml b/pyo3-derive-backend/Cargo.toml
index 92bfead9..e387137f 100644
--- a/pyo3-derive-backend/Cargo.toml
+++ b/pyo3-derive-backend/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pyo3-derive-backend"
-version = "0.12.3"
+version = "0.12.4"
 description = "Code generation for PyO3 package"
 authors = ["PyO3 Project and Contributors <https://github.com/PyO3>"]
 keywords = ["pyo3", "python", "cpython", "ffi"]
diff --git a/pyo3cls/Cargo.toml b/pyo3cls/Cargo.toml
index 23df9fdf..d2128e76 100644
--- a/pyo3cls/Cargo.toml
+++ b/pyo3cls/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pyo3cls"
-version = "0.12.3"
+version = "0.12.4"
 description = "Proc macros for PyO3 package"
 authors = ["PyO3 Project and Contributors <https://github.com/PyO3>"]
 keywords = ["pyo3", "python", "cpython", "ffi"]
@@ -16,4 +16,4 @@ proc-macro = true
 [dependencies]
 quote = "1"
 syn = { version = "1", features = ["full", "extra-traits"] }
-pyo3-derive-backend = { path = "../pyo3-derive-backend", version = "=0.12.3" }
+pyo3-derive-backend = { path = "../pyo3-derive-backend", version = "=0.12.4" }
diff --git a/src/lib.rs b/src/lib.rs
index 092d4ac8..be7502ce 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -52,7 +52,7 @@
 //! crate-type = ["cdylib"]
 //!
 //! [dependencies.pyo3]
-//! version = "0.12.3"
+//! version = "0.12.4"
 //! features = ["extension-module"]
 //! ```
 //!
@@ -109,7 +109,7 @@
 //!
 //! ```toml
 //! [dependencies]
-//! pyo3 = "0.12.3"
+//! pyo3 = "0.12.4"
 //! ```
 //!
 //! Example program displaying the value of `sys.version`: