luxolus
/
pyo3
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve comment in iterator.rs

This commit is contained in:
David Hewitt 2020-05-20 20:06:17 +01:00
parent c393d4ad9f
commit 01a74b2546
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/types/iterator.rs
View File

@ -42,7 +42,12 @@ impl<'p> PyIterator<'p> {
}
if ffi::PyIter_Check(ptr) != 0 {
// this is not right, but this cause of segfault check #71
// This looks suspicious, but is actually correct. Even though ptr is an owned
// reference, PyIterator takes ownership of the reference and decreases the count
// in its Drop implementation.
//
// Therefore we must use from_borrowed_ptr instead of from_owned_ptr so that the
// GILPool does not take ownership of the reference.
Ok(PyIterator(py.from_borrowed_ptr(ptr)))
} else {
Err(PyDowncastError)