luxolus/pyo3 - Stateless Git Forge

2 lines

80 B

Markdown

Raw Normal View History

Prevent dropping unsendable classes on other threads. We already have checks in place to avoid borrowing these classes on other threads but it was still possible to send them to another thread and drop them there (while holding the GIL). This change avoids running the `Drop` implementation in such a case even though Python will still free the underlying memory. This might leak resources owned by the object, but it avoids undefined behaviour due to access the unsendable type from another thread. This does assume that the object was not unsafely integrated into an intrusive data structures which still point to the now freed memory. In that case, the only recourse would be to abort the process as freeing the memory is unavoidable when the tp_dealloc slot is called. (And moving it elsewhere into a new allocation would still break any existing pointers.)

2023-05-22 07:26:07 +00:00

Avoid running the `Drop` implementations of unsendable classes on other threads