b6c05fae33
* enable registering backend muxed plugins in plugin catalog * set the sysview on the pluginconfig to allow enabling secrets/auth plugins * store backend instances in map * store single implementations in the instances map cleanup instance map and ensure we don't deadlock * fix system backend unit tests move GetMultiplexIDFromContext to pluginutil package fix pluginutil test fix dbplugin ut * return error(s) if we can't get the plugin client update comments * refactor/move GetMultiplexIDFromContext test * add changelog * remove unnecessary field on pluginClient * add unit tests to PluginCatalog for secrets/auth plugins * fix comment * return pluginClient from TestRunTestPlugin * add multiplexed backend test * honor metadatamode value in newbackend pluginconfig * check that connection exists on cleanup * add automtls to secrets/auth plugins * don't remove apiclientmeta parsing * use formatting directive for fmt.Errorf * fix ut: remove tls provider func * remove tlsproviderfunc from backend plugin tests * use env var to prevent test plugin from running as a unit test * WIP: remove lazy loading * move non lazy loaded backend to new package * use version wrapper for backend plugin factory * remove backendVersionWrapper type * implement getBackendPluginType for plugin catalog * handle backend plugin v4 registration * add plugin automtls env guard * modify plugin factory to determine the backend to use * remove old pluginsets from v5 and log pid in plugin catalog * add reload mechanism via context * readd v3 and v4 to pluginset * call cleanup from reload if non-muxed * move v5 backend code to new package * use context reload for for ErrPluginShutdown case * add wrapper on v5 backend * fix run config UTs * fix unit tests - use v4/v5 mapping for plugin versions - fix test build err - add reload method on fakePluginClient - add multiplexed cases for integration tests * remove comment and update AutoMTLS field in test * remove comment * remove errwrap and unused context * only support metadatamode false for v5 backend plugins * update plugin catalog errors * use const for env variables * rename locks and remove unused * remove unneeded nil check * improvements based on staticcheck recommendations * use const for single implementation string * use const for context key * use info default log level * move pid to pluginClient struct * remove v3 and v4 from multiplexed plugin set * return from reload when non-multiplexed * update automtls env string * combine getBackend and getBrokeredClient * update comments for plugin reload, Backend return val and log * revert Backend return type * allow non-muxed plugins to serve v5 * move v5 code to existing sdk plugin package * do next export sdk fields now that we have removed extra plugin pkg * set TLSProvider in ServeMultiplex for backwards compat * use bool to flag multiplexing support on grpc backend server * revert userpass main.go * refactor plugin sdk - update comments - make use of multiplexing boolean and single implementation ID const * update comment and use multierr * attempt v4 if dispense fails on getPluginTypeForUnknown * update comments on sdk plugin backend
278 lines
6.9 KiB
Go
278 lines
6.9 KiB
Go
package plugin
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
plugin "github.com/hashicorp/go-plugin"
|
|
"github.com/hashicorp/vault/sdk/helper/consts"
|
|
"github.com/hashicorp/vault/sdk/logical"
|
|
"github.com/hashicorp/vault/sdk/plugin/pb"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
func TestSystem_GRPC_GRPC_impl(t *testing.T) {
|
|
var _ logical.SystemView = new(gRPCSystemViewClient)
|
|
}
|
|
|
|
func TestSystem_GRPC_defaultLeaseTTL(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.DefaultLeaseTTL()
|
|
actual := testSystemView.DefaultLeaseTTL()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_maxLeaseTTL(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.MaxLeaseTTL()
|
|
actual := testSystemView.MaxLeaseTTL()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_tainted(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.TaintedVal = true
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.Tainted()
|
|
actual := testSystemView.Tainted()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_cachingDisabled(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.CachingDisabledVal = true
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.CachingDisabled()
|
|
actual := testSystemView.CachingDisabled()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_replicationState(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.ReplicationStateVal = consts.ReplicationPerformancePrimary
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.ReplicationState()
|
|
actual := testSystemView.ReplicationState()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_responseWrapData(t *testing.T) {
|
|
t.SkipNow()
|
|
}
|
|
|
|
func TestSystem_GRPC_lookupPlugin(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
if _, err := testSystemView.LookupPlugin(context.Background(), "foo", consts.PluginTypeDatabase); err == nil {
|
|
t.Fatal("LookPlugin(): expected error on due to unsupported call from plugin")
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_mlockEnabled(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.EnableMlock = true
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected := sys.MlockEnabled()
|
|
actual := testSystemView.MlockEnabled()
|
|
if !reflect.DeepEqual(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_entityInfo(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.EntityVal = &logical.Entity{
|
|
ID: "id",
|
|
Name: "name",
|
|
Metadata: map[string]string{
|
|
"foo": "bar",
|
|
},
|
|
Aliases: []*logical.Alias{
|
|
{
|
|
MountType: "logical",
|
|
MountAccessor: "accessor",
|
|
Name: "name",
|
|
Metadata: map[string]string{
|
|
"zip": "zap",
|
|
},
|
|
},
|
|
},
|
|
Disabled: true,
|
|
}
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
actual, err := testSystemView.EntityInfo("")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !proto.Equal(sys.EntityVal, actual) {
|
|
t.Fatalf("expected: %v, got: %v", sys.EntityVal, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_groupsForEntity(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.GroupsVal = []*logical.Group{
|
|
{
|
|
ID: "group1-id",
|
|
Name: "group1",
|
|
Metadata: map[string]string{
|
|
"group-metadata": "metadata-value",
|
|
},
|
|
},
|
|
}
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
actual, err := testSystemView.GroupsForEntity("")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !proto.Equal(sys.GroupsVal[0], actual[0]) {
|
|
t.Fatalf("expected: %v, got: %v", sys.GroupsVal, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_pluginEnv(t *testing.T) {
|
|
sys := logical.TestSystemView()
|
|
sys.PluginEnvironment = &logical.PluginEnvironment{
|
|
VaultVersion: "0.10.42",
|
|
VaultVersionPrerelease: "dev",
|
|
VaultVersionMetadata: "ent",
|
|
}
|
|
client, _ := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer client.Close()
|
|
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
expected, err := sys.PluginEnv(context.Background())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
actual, err := testSystemView.PluginEnv(context.Background())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if !proto.Equal(expected, actual) {
|
|
t.Fatalf("expected: %v, got: %v", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestSystem_GRPC_GeneratePasswordFromPolicy(t *testing.T) {
|
|
policyName := "testpolicy"
|
|
expectedPassword := "87354qtnjgrehiogd9u0t43"
|
|
passGen := func() (password string, err error) {
|
|
return expectedPassword, nil
|
|
}
|
|
sys := &logical.StaticSystemView{
|
|
PasswordPolicies: map[string]logical.PasswordGenerator{
|
|
policyName: passGen,
|
|
},
|
|
}
|
|
|
|
client, server := plugin.TestGRPCConn(t, func(s *grpc.Server) {
|
|
pb.RegisterSystemViewServer(s, &gRPCSystemViewServer{
|
|
impl: sys,
|
|
})
|
|
})
|
|
defer server.Stop()
|
|
defer client.Close()
|
|
|
|
testSystemView := newGRPCSystemView(client)
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
|
|
defer cancel()
|
|
|
|
password, err := testSystemView.GeneratePasswordFromPolicy(ctx, policyName)
|
|
if err != nil {
|
|
t.Fatalf("no error expected, got: %s", err)
|
|
}
|
|
|
|
if password != expectedPassword {
|
|
t.Fatalf("Actual password: %s\nExpected password: %s", password, expectedPassword)
|
|
}
|
|
}
|