a090caf2c3
Fixes #859
576 lines
16 KiB
Go
576 lines
16 KiB
Go
package physical
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"errors"
|
|
"net/url"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/armon/go-metrics"
|
|
"github.com/coreos/etcd/client"
|
|
"github.com/coreos/etcd/pkg/transport"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
const (
|
|
// Ideally, this prefix would match the "_" used in the file backend, but
|
|
// that prefix has special meaining in etcd. Specifically, it excludes those
|
|
// entries from directory listings.
|
|
EtcdNodeFilePrefix = "."
|
|
|
|
// The lock prefix can (and probably should) cause an entry to be excluded
|
|
// from diretory listings, so "_" works here.
|
|
EtcdNodeLockPrefix = "_"
|
|
|
|
// The delimiter is the same as the `-C` flag of etcdctl.
|
|
EtcdMachineDelimiter = ","
|
|
|
|
// The lock TTL matches the default that Consul API uses, 15 seconds.
|
|
EtcdLockTTL = 15 * time.Second
|
|
|
|
// The amount of time to wait between the semaphore key renewals
|
|
EtcdLockRenewInterval = 5 * time.Second
|
|
|
|
// The ammount of time to wait if a watch fails before trying again.
|
|
EtcdWatchRetryInterval = time.Second
|
|
|
|
// The number of times to re-try a failed watch before signaling that leadership is lost.
|
|
EtcdWatchRetryMax = 5
|
|
)
|
|
|
|
var (
|
|
EtcdSyncClusterError = errors.New("client setup failed: unable to sync etcd cluster")
|
|
EtcdAddressError = errors.New("client setup failed: address must be valid URL (ex. 'scheme://host:port')")
|
|
EtcdSemaphoreKeysEmptyError = errors.New("lock queue is empty")
|
|
EtcdLockHeldError = errors.New("lock already held")
|
|
EtcdLockNotHeldError = errors.New("lock not held")
|
|
EtcdSemaphoreKeyRemovedError = errors.New("semaphore key removed before lock aquisition")
|
|
)
|
|
|
|
// errorIsMissingKey returns true if the given error is an etcd error with an
|
|
// error code corresponding to a missing key.
|
|
func errorIsMissingKey(err error) bool {
|
|
etcdErr, ok := err.(client.Error)
|
|
return ok && etcdErr.Code == client.ErrorCodeKeyNotFound
|
|
}
|
|
|
|
// EtcdBackend is a physical backend that stores data at specific
|
|
// prefix within Etcd. It is used for most production situations as
|
|
// it allows Vault to run on multiple machines in a highly-available manner.
|
|
type EtcdBackend struct {
|
|
path string
|
|
kAPI client.KeysAPI
|
|
permitPool *PermitPool
|
|
}
|
|
|
|
// newEtcdBackend constructs a etcd backend using a given machine address.
|
|
func newEtcdBackend(conf map[string]string) (Backend, error) {
|
|
// Get the etcd path form the configuration.
|
|
path, ok := conf["path"]
|
|
if !ok {
|
|
path = "/vault"
|
|
}
|
|
|
|
// Ensure path is prefixed.
|
|
if !strings.HasPrefix(path, "/") {
|
|
path = "/" + path
|
|
}
|
|
|
|
// Set a default machines list and check for an overriding address value.
|
|
machines := "http://128.0.0.1:2379"
|
|
if address, ok := conf["address"]; ok {
|
|
machines = address
|
|
}
|
|
machinesParsed := strings.Split(machines, EtcdMachineDelimiter)
|
|
|
|
// Verify that the machines are valid URLs
|
|
for _, machine := range machinesParsed {
|
|
u, urlErr := url.Parse(machine)
|
|
if urlErr != nil || u.Scheme == "" {
|
|
return nil, EtcdAddressError
|
|
}
|
|
}
|
|
|
|
// Create a new client from the supplied address and attempt to sync with the
|
|
// cluster.
|
|
var cTransport client.CancelableTransport
|
|
cert, hasCert := conf["tls_cert_file"]
|
|
key, hasKey := conf["tls_key_file"]
|
|
ca, hasCa := conf["tls_ca_file"]
|
|
if (hasCert && hasKey) || hasCa {
|
|
var transportErr error
|
|
tls := transport.TLSInfo{
|
|
CAFile: ca,
|
|
CertFile: cert,
|
|
KeyFile: key,
|
|
}
|
|
cTransport, transportErr = transport.NewTransport(tls, 30 * time.Second)
|
|
|
|
if transportErr != nil {
|
|
return nil, transportErr
|
|
}
|
|
} else {
|
|
cTransport = client.DefaultTransport
|
|
}
|
|
|
|
cfg := client.Config{
|
|
Endpoints: machinesParsed,
|
|
Transport: cTransport,
|
|
}
|
|
|
|
// Set credentials.
|
|
username := os.Getenv("ETCD_USERNAME")
|
|
if username == "" {
|
|
username, _ = conf["username"]
|
|
}
|
|
|
|
password := os.Getenv("ETCD_PASSWORD")
|
|
if password == "" {
|
|
password, _ = conf["password"]
|
|
}
|
|
|
|
if username != "" && password != "" {
|
|
cfg.Username = username
|
|
cfg.Password = password
|
|
}
|
|
|
|
c, err := client.New(cfg)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), client.DefaultRequestTimeout)
|
|
syncErr := c.Sync(ctx)
|
|
cancel()
|
|
if syncErr != nil {
|
|
return nil, EtcdSyncClusterError
|
|
}
|
|
|
|
kAPI := client.NewKeysAPI(c)
|
|
|
|
// Setup the backend.
|
|
return &EtcdBackend{
|
|
path: path,
|
|
kAPI: kAPI,
|
|
permitPool: NewPermitPool(DefaultParallelOperations),
|
|
}, nil
|
|
}
|
|
|
|
// Put is used to insert or update an entry.
|
|
func (c *EtcdBackend) Put(entry *Entry) error {
|
|
defer metrics.MeasureSince([]string{"etcd", "put"}, time.Now())
|
|
value := base64.StdEncoding.EncodeToString(entry.Value)
|
|
|
|
c.permitPool.Acquire()
|
|
defer c.permitPool.Release()
|
|
|
|
_, err := c.kAPI.Set(context.Background(), c.nodePath(entry.Key), value, nil)
|
|
return err
|
|
}
|
|
|
|
// Get is used to fetch an entry.
|
|
func (c *EtcdBackend) Get(key string) (*Entry, error) {
|
|
defer metrics.MeasureSince([]string{"etcd", "get"}, time.Now())
|
|
|
|
c.permitPool.Acquire()
|
|
defer c.permitPool.Release()
|
|
|
|
getOpts := &client.GetOptions{
|
|
Recursive: false,
|
|
Sort: false,
|
|
}
|
|
response, err := c.kAPI.Get(context.Background(), c.nodePath(key), getOpts)
|
|
if err != nil {
|
|
if errorIsMissingKey(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
// Decode the stored value from base-64.
|
|
value, err := base64.StdEncoding.DecodeString(response.Node.Value)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Construct and return a new entry.
|
|
return &Entry{
|
|
Key: key,
|
|
Value: value,
|
|
}, nil
|
|
}
|
|
|
|
// Delete is used to permanently delete an entry.
|
|
func (c *EtcdBackend) Delete(key string) error {
|
|
defer metrics.MeasureSince([]string{"etcd", "delete"}, time.Now())
|
|
|
|
c.permitPool.Acquire()
|
|
defer c.permitPool.Release()
|
|
|
|
// Remove the key, non-recursively.
|
|
delOpts := &client.DeleteOptions{
|
|
Recursive: false,
|
|
}
|
|
_, err := c.kAPI.Delete(context.Background(), c.nodePath(key), delOpts)
|
|
if err != nil && !errorIsMissingKey(err) {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// List is used to list all the keys under a given prefix, up to the next
|
|
// prefix.
|
|
func (c *EtcdBackend) List(prefix string) ([]string, error) {
|
|
defer metrics.MeasureSince([]string{"etcd", "list"}, time.Now())
|
|
|
|
// Set a directory path from the given prefix.
|
|
path := c.nodePathDir(prefix)
|
|
|
|
c.permitPool.Acquire()
|
|
defer c.permitPool.Release()
|
|
|
|
// Get the directory, non-recursively, from etcd. If the directory is
|
|
// missing, we just return an empty list of contents.
|
|
getOpts := &client.GetOptions{
|
|
Recursive: false,
|
|
Sort: true,
|
|
}
|
|
response, err := c.kAPI.Get(context.Background(), path, getOpts)
|
|
if err != nil {
|
|
if errorIsMissingKey(err) {
|
|
return []string{}, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
out := make([]string, len(response.Node.Nodes))
|
|
for i, node := range response.Node.Nodes {
|
|
|
|
// etcd keys include the full path, so let's trim the prefix directory
|
|
// path.
|
|
name := strings.TrimPrefix(node.Key, path)
|
|
|
|
// Check if this node is itself a directory. If it is, add a trailing
|
|
// slash; if it isn't remove the node file prefix.
|
|
if node.Dir {
|
|
out[i] = name + "/"
|
|
} else {
|
|
out[i] = name[1:]
|
|
}
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// nodePath returns an etcd filepath based on the given key.
|
|
func (b *EtcdBackend) nodePath(key string) string {
|
|
return filepath.Join(b.path, filepath.Dir(key), EtcdNodeFilePrefix+filepath.Base(key))
|
|
}
|
|
|
|
// nodePathDir returns an etcd directory path based on the given key.
|
|
func (b *EtcdBackend) nodePathDir(key string) string {
|
|
return filepath.Join(b.path, key) + "/"
|
|
}
|
|
|
|
// nodePathLock returns an etcd directory path used specifically for semaphore
|
|
// indicies based on the given key.
|
|
func (b *EtcdBackend) nodePathLock(key string) string {
|
|
return filepath.Join(b.path, filepath.Dir(key), EtcdNodeLockPrefix+filepath.Base(key)+"/")
|
|
}
|
|
|
|
// Lock is used for mutual exclusion based on the given key.
|
|
func (c *EtcdBackend) LockWith(key, value string) (Lock, error) {
|
|
return &EtcdLock{
|
|
kAPI: c.kAPI,
|
|
value: value,
|
|
semaphoreDirKey: c.nodePathLock(key),
|
|
}, nil
|
|
}
|
|
|
|
// EtcdLock emplements a lock using and etcd backend.
|
|
type EtcdLock struct {
|
|
kAPI client.KeysAPI
|
|
value, semaphoreDirKey, semaphoreKey string
|
|
lock sync.Mutex
|
|
}
|
|
|
|
// addSemaphoreKey aquires a new ordered semaphore key.
|
|
func (c *EtcdLock) addSemaphoreKey() (string, uint64, error) {
|
|
// CreateInOrder is an atomic operation that can be used to enqueue a
|
|
// request onto a semaphore. In the rest of the comments, we refer to the
|
|
// resulting key as a "semaphore key".
|
|
// https://coreos.com/etcd/docs/2.0.8/api.html#atomically-creating-in-order-keys
|
|
opts := &client.CreateInOrderOptions{
|
|
TTL: EtcdLockTTL,
|
|
}
|
|
response, err := c.kAPI.CreateInOrder(context.Background(), c.semaphoreDirKey, c.value, opts)
|
|
if err != nil {
|
|
return "", 0, err
|
|
}
|
|
return response.Node.Key, response.Index, nil
|
|
}
|
|
|
|
// renewSemaphoreKey renews an existing semaphore key.
|
|
func (c *EtcdLock) renewSemaphoreKey() (string, uint64, error) {
|
|
setOpts := &client.SetOptions{
|
|
TTL: EtcdLockTTL,
|
|
PrevExist: client.PrevExist,
|
|
}
|
|
response, err := c.kAPI.Set(context.Background(), c.semaphoreKey, c.value, setOpts)
|
|
if err != nil {
|
|
return "", 0, err
|
|
}
|
|
return response.Node.Key, response.Index, nil
|
|
}
|
|
|
|
// getSemaphoreKey determines which semaphore key holder has aquired the lock
|
|
// and its value.
|
|
func (c *EtcdLock) getSemaphoreKey() (string, string, uint64, error) {
|
|
// Get the list of waiters in order to see if we are next.
|
|
getOpts := &client.GetOptions{
|
|
Recursive: false,
|
|
Sort: true,
|
|
}
|
|
response, err := c.kAPI.Get(context.Background(), c.semaphoreDirKey, getOpts)
|
|
if err != nil {
|
|
return "", "", 0, err
|
|
}
|
|
|
|
// Make sure the list isn't empty.
|
|
if response.Node.Nodes.Len() == 0 {
|
|
return "", "", response.Index, nil
|
|
}
|
|
return response.Node.Nodes[0].Key, response.Node.Nodes[0].Value, response.Index, nil
|
|
}
|
|
|
|
// isHeld determines if we are the current holders of the lock.
|
|
func (c *EtcdLock) isHeld() (bool, error) {
|
|
if c.semaphoreKey == "" {
|
|
return false, nil
|
|
}
|
|
|
|
// Get the key of the curren holder of the lock.
|
|
currentSemaphoreKey, _, _, err := c.getSemaphoreKey()
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return c.semaphoreKey == currentSemaphoreKey, nil
|
|
}
|
|
|
|
// assertHeld determines whether or not we are the current holders of the lock
|
|
// and returns an EtcdLockNotHeldError if we are not.
|
|
func (c *EtcdLock) assertHeld() error {
|
|
held, err := c.isHeld()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Check if we don't hold the lock.
|
|
if !held {
|
|
return EtcdLockNotHeldError
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// assertNotHeld determines whether or not we are the current holders of the
|
|
// lock and returns an EtcdLockHeldError if we are.
|
|
func (c *EtcdLock) assertNotHeld() error {
|
|
held, err := c.isHeld()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Check if we hold the lock.
|
|
if held {
|
|
return EtcdLockHeldError
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// periodically renew our semaphore key so that it doesn't expire
|
|
func (c *EtcdLock) periodicallyRenewSemaphoreKey(stopCh chan struct{}) {
|
|
for {
|
|
select {
|
|
case <-time.After(EtcdLockRenewInterval):
|
|
c.renewSemaphoreKey()
|
|
case <-stopCh:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// watchForKeyRemoval continuously watches a single non-directory key starting
|
|
// from the provided etcd index and closes the provided channel when it's
|
|
// deleted, expires, or appears to be missing.
|
|
func (c *EtcdLock) watchForKeyRemoval(key string, etcdIndex uint64, closeCh chan struct{}) {
|
|
retries := EtcdWatchRetryMax
|
|
|
|
for {
|
|
// Start a non-recursive watch of the given key.
|
|
w := c.kAPI.Watcher(key, &client.WatcherOptions{AfterIndex: etcdIndex, Recursive: false})
|
|
response, err := w.Next(context.TODO())
|
|
if err != nil {
|
|
|
|
// If the key is just missing, we can exit the loop.
|
|
if errorIsMissingKey(err) {
|
|
break
|
|
}
|
|
|
|
// If the error is something else, there's nothing we can do but retry
|
|
// the watch. Check that we still have retries left.
|
|
retries -= 1
|
|
if retries == 0 {
|
|
break
|
|
}
|
|
|
|
// Sleep for a period of time to avoid slamming etcd.
|
|
time.Sleep(EtcdWatchRetryInterval)
|
|
continue
|
|
}
|
|
|
|
// Check if the key we are concerned with has been removed. If it has, we
|
|
// can exit the loop.
|
|
if response.Node.Key == key &&
|
|
(response.Action == "delete" || response.Action == "expire") {
|
|
break
|
|
}
|
|
|
|
// Update the etcd index.
|
|
etcdIndex = response.Index + 1
|
|
}
|
|
|
|
// Regardless of what happened, we need to close the close channel.
|
|
close(closeCh)
|
|
}
|
|
|
|
// Lock attempts to aquire the lock by waiting for a new semaphore key in etcd
|
|
// to become the first in the queue and will block until it is successful or
|
|
// it recieves a signal on the provided channel. The returned channel will be
|
|
// closed when the lock is lost, either by an explicit call to Unlock or by
|
|
// the associated semaphore key in etcd otherwise being deleted or expiring.
|
|
//
|
|
// If the lock is currently held by this instance of EtcdLock, Lock will
|
|
// return an EtcdLockHeldError error.
|
|
func (c *EtcdLock) Lock(stopCh <-chan struct{}) (doneCh <-chan struct{}, retErr error) {
|
|
// Get the local lock before interacting with etcd.
|
|
c.lock.Lock()
|
|
defer c.lock.Unlock()
|
|
|
|
// Check if the lock is already held.
|
|
if err := c.assertNotHeld(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Add a new semaphore key that we will track.
|
|
semaphoreKey, _, err := c.addSemaphoreKey()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
c.semaphoreKey = semaphoreKey
|
|
|
|
// Get the current semaphore key.
|
|
currentSemaphoreKey, _, currentEtcdIndex, err := c.getSemaphoreKey()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Create an etcd-compatible boolean stop channel from the provided
|
|
// interface stop channel.
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
go func() {
|
|
<-stopCh
|
|
cancel()
|
|
}()
|
|
defer cancel()
|
|
|
|
// Create a channel to signal when we lose the semaphore key.
|
|
done := make(chan struct{})
|
|
defer func() {
|
|
if retErr != nil {
|
|
close(done)
|
|
}
|
|
}()
|
|
|
|
go c.periodicallyRenewSemaphoreKey(done)
|
|
|
|
// Loop until the we current semaphore key matches ours.
|
|
for semaphoreKey != currentSemaphoreKey {
|
|
var err error
|
|
|
|
// Start a watch of the entire lock directory
|
|
w := c.kAPI.Watcher(c.semaphoreDirKey, &client.WatcherOptions{AfterIndex: currentEtcdIndex, Recursive: true})
|
|
response, err := w.Next(ctx)
|
|
if err != nil {
|
|
|
|
// If the error is not an etcd error, we can assume it's a notification
|
|
// of the stop channel having closed. In this scenario, we also want to
|
|
// remove our semaphore key as we are no longer waiting to aquire the
|
|
// lock.
|
|
if _, ok := err.(*client.Error); !ok {
|
|
delOpts := &client.DeleteOptions{
|
|
Recursive: false,
|
|
}
|
|
_, err = c.kAPI.Delete(context.Background(), c.semaphoreKey, delOpts)
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
// Make sure the index we are waiting for has not been removed. If it has,
|
|
// this is an error and nothing else needs to be done.
|
|
if response.Node.Key == semaphoreKey &&
|
|
(response.Action == "delete" || response.Action == "expire") {
|
|
return nil, EtcdSemaphoreKeyRemovedError
|
|
}
|
|
|
|
// Get the current semaphore key and etcd index.
|
|
currentSemaphoreKey, _, currentEtcdIndex, err = c.getSemaphoreKey()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
go c.watchForKeyRemoval(c.semaphoreKey, currentEtcdIndex, done)
|
|
return done, nil
|
|
}
|
|
|
|
// Unlock releases the lock by deleting the associated semaphore key in etcd.
|
|
//
|
|
// If the lock is not currently held by this instance of EtcdLock, Unlock will
|
|
// return an EtcdLockNotHeldError error.
|
|
func (c *EtcdLock) Unlock() error {
|
|
// Get the local lock before interacting with etcd.
|
|
c.lock.Lock()
|
|
defer c.lock.Unlock()
|
|
|
|
// Check that the lock is held.
|
|
if err := c.assertHeld(); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Delete our semaphore key.
|
|
delOpts := &client.DeleteOptions{
|
|
Recursive: false,
|
|
}
|
|
if _, err := c.kAPI.Delete(context.Background(), c.semaphoreKey, delOpts); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Value checks whether or not the lock is held by any instance of EtcdLock,
|
|
// including this one, and returns the current value.
|
|
func (c *EtcdLock) Value() (bool, string, error) {
|
|
semaphoreKey, semaphoreValue, _, err := c.getSemaphoreKey()
|
|
if err != nil {
|
|
return false, "", err
|
|
}
|
|
|
|
if semaphoreKey == "" {
|
|
return false, "", nil
|
|
}
|
|
return true, semaphoreValue, nil
|
|
}
|