45af65da81
* backport of commit dc104898f700447f7764919445c7559baeb7e987 (#21853) * fix multiline * shellcheck, and success message for builds * add full path * cat the summary * fix and faster * fix if condition * base64 in a separate step * echo * check against empty string * add echo * only use matrix ids * only id * echo matrix * remove wrapping array * tojson * try echo again * use jq to get packages * don't quote * only run binary tests once * only run binary tests once * test what's wrong with the binary * separate file * use matrix file * failed test * update comment on success * correct variable name * bae64 fix * output to file * use multiline * fix * fix formatting * fix newline * fix whitespace * correct body, remove comma * small fixes * shellcheck * another shellcheck fix * fix deprecation checker * only run comments for prs * Update .github/workflows/test-go.yml Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com> * Update .github/workflows/test-go.yml Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com> * fixes --------- Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com> * backport of commit 3b00dde1ba4d479fbd67b1d0767e421e495d8cce (#21936) * limit test comments * remove unecessary tee * fix go test condition * fix * fail test * remove ailways entirely * fix columns * make a bunch of tests fail * separate line * include Failures: * remove test fails * fix whitespace * backport of commit 245430215c00d80a38283020fca114bade022e0f (#21973) * only add binary tests if they exist * shellcheck --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com> Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
396 lines
16 KiB
YAML
396 lines
16 KiB
YAML
name: CI
|
|
on:
|
|
pull_request:
|
|
# The default types for pull_request are [ opened, synchronize, reopened ].
|
|
# This is insufficient for our needs, since we're skipping stuff on PRs in
|
|
# draft mode. By adding the ready_for_review type, when a draft pr is marked
|
|
# ready, we run everything, including the stuff we'd have skipped up until now.
|
|
types: [opened, synchronize, reopened, ready_for_review]
|
|
push:
|
|
branches:
|
|
- main
|
|
- release/**
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: ${{ github.head_ref || github.run_id }}-ci
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
setup:
|
|
name: Setup
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
compute-tiny: ${{ steps.setup-outputs.outputs.compute-tiny }}
|
|
compute-standard: ${{ steps.setup-outputs.outputs.compute-standard }}
|
|
compute-larger: ${{ steps.setup-outputs.outputs.compute-larger }}
|
|
compute-huge: ${{ steps.setup-outputs.outputs.compute-huge }}
|
|
enterprise: ${{ steps.setup-outputs.outputs.enterprise }}
|
|
go-tags: ${{ steps.setup-outputs.outputs.go-tags }}
|
|
steps:
|
|
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
|
|
- id: setup-outputs
|
|
name: Setup outputs
|
|
run: |
|
|
github_repository="${{ github.repository }}"
|
|
|
|
if [ "${github_repository##*/}" == "vault-enterprise" ] ; then
|
|
# shellcheck disable=SC2129
|
|
echo 'compute-tiny=["self-hosted","ondemand","linux","type=m5.large"]' >> "$GITHUB_OUTPUT"
|
|
echo 'compute-standard=["self-hosted","ondemand","linux","type=m5.xlarge"]' >> "$GITHUB_OUTPUT"
|
|
echo 'compute-larger=["self-hosted","ondemand","linux","type=m5.2xlarge"]' >> "$GITHUB_OUTPUT"
|
|
echo 'compute-huge=["self-hosted","ondemand","linux","type=m5.4xlarge"]' >> "$GITHUB_OUTPUT"
|
|
echo 'enterprise=1' >> "$GITHUB_OUTPUT"
|
|
echo 'go-tags=ent,enterprise' >> "$GITHUB_OUTPUT"
|
|
else
|
|
# shellcheck disable=SC2129
|
|
echo 'compute-tiny="ubuntu-latest"' >> "$GITHUB_OUTPUT" # 2 cores, 7 GB RAM, 14 GB SSD
|
|
echo 'compute-standard="custom-linux-small-vault-latest"' >> "$GITHUB_OUTPUT" # 8 cores, 32 GB RAM, 300 GB SSD
|
|
echo 'compute-larger="custom-linux-medium-vault-latest"' >> "$GITHUB_OUTPUT" # 16 cores, 64 GB RAM, 600 GB SSD
|
|
echo 'compute-huge="custom-linux-xl-vault-latest"' >> "$GITHUB_OUTPUT" # 32-cores, 128 GB RAM, 1200 GB SSD
|
|
echo 'enterprise=' >> "$GITHUB_OUTPUT"
|
|
echo 'go-tags=' >> "$GITHUB_OUTPUT"
|
|
fi
|
|
- name: Ensure Go modules are cached
|
|
uses: ./.github/actions/set-up-go
|
|
with:
|
|
github-token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
|
|
no-restore: true # don't download them on a cache hit
|
|
|
|
diff-oss-ci:
|
|
name: Diff OSS
|
|
needs:
|
|
- setup
|
|
if: ${{ needs.setup.outputs.enterprise != '' && github.base_ref != '' }}
|
|
runs-on: ${{ fromJSON(needs.setup.outputs.compute-tiny) }}
|
|
steps:
|
|
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
|
|
with:
|
|
fetch-depth: 0
|
|
- id: determine-branch
|
|
run: |
|
|
branch="${{ github.base_ref }}"
|
|
|
|
if [[ $branch = release/* ]] ; then
|
|
branch=${branch%%+ent}
|
|
|
|
# Add OSS remote
|
|
git config --global user.email "github-team-secret-vault-core@hashicorp.com"
|
|
git config --global user.name "hc-github-team-secret-vault-core"
|
|
git remote add oss https://github.com/hashicorp/vault.git
|
|
git fetch oss "$branch"
|
|
|
|
branch="oss/$branch"
|
|
else
|
|
branch="origin/$branch"
|
|
fi
|
|
|
|
echo "BRANCH=$branch" >> "$GITHUB_OUTPUT"
|
|
- id: diff
|
|
run: |
|
|
./.github/scripts/oss-diff.sh ${{ steps.determine-branch.outputs.BRANCH }} HEAD
|
|
|
|
test-go:
|
|
name: Run Go tests
|
|
needs:
|
|
- setup
|
|
# Don't run this job for PR branches starting with:
|
|
# 'ui/', 'backport/ui/', 'docs/', or 'backport/docs/'
|
|
# OR
|
|
# the 'docs' label is present
|
|
if: |
|
|
!startsWith(github.head_ref, 'ui/') &&
|
|
!startsWith(github.head_ref, 'backport/ui/') &&
|
|
!startsWith(github.head_ref, 'docs/') &&
|
|
!startsWith(github.head_ref, 'backport/docs/') &&
|
|
!contains(github.event.pull_request.labels.*.name, 'docs')
|
|
uses: ./.github/workflows/test-go.yml
|
|
with:
|
|
# The regular Go tests use an extra runner to execute the
|
|
# binary-dependent tests. We isolate them there so that the
|
|
# other tests aren't slowed down waiting for a binary build.
|
|
binary-tests: true
|
|
total-runners: 16
|
|
go-arch: amd64
|
|
go-tags: '${{ needs.setup.outputs.go-tags }},deadlock'
|
|
runs-on: ${{ needs.setup.outputs.compute-larger }}
|
|
enterprise: ${{ needs.setup.outputs.enterprise }}
|
|
secrets: inherit
|
|
|
|
test-go-race:
|
|
name: Run Go tests with data race detection
|
|
needs:
|
|
- setup
|
|
# Don't run this job for PR branches starting with:
|
|
# 'ui/', 'backport/ui/', 'docs/', or 'backport/docs/'
|
|
# OR
|
|
# the 'docs' label is present
|
|
if: |
|
|
github.event.pull_request.draft == false &&
|
|
!startsWith(github.head_ref, 'ui/') &&
|
|
!startsWith(github.head_ref, 'backport/ui/') &&
|
|
!startsWith(github.head_ref, 'docs/') &&
|
|
!startsWith(github.head_ref, 'backport/docs/') &&
|
|
!contains(github.event.pull_request.labels.*.name, 'docs')
|
|
uses: ./.github/workflows/test-go.yml
|
|
with:
|
|
total-runners: 16
|
|
env-vars: |
|
|
{
|
|
"VAULT_CI_GO_TEST_RACE": 1
|
|
}
|
|
extra-flags: '-race'
|
|
go-arch: amd64
|
|
go-tags: ${{ needs.setup.outputs.go-tags }}
|
|
runs-on: ${{ needs.setup.outputs.compute-huge }}
|
|
enterprise: ${{ needs.setup.outputs.enterprise }}
|
|
name: "race"
|
|
secrets: inherit
|
|
|
|
test-go-fips:
|
|
name: Run Go tests with FIPS configuration
|
|
# Only run this job for the enterprise repo if the PR branch doesn't start with:
|
|
# 'ui/', 'backport/ui/', 'docs/', or 'backport/docs/'
|
|
# OR
|
|
# the 'docs' label is not present
|
|
if: |
|
|
github.event.pull_request.draft == false &&
|
|
needs.setup.outputs.enterprise == 1 &&
|
|
!startsWith(github.head_ref, 'ui/') &&
|
|
!startsWith(github.head_ref, 'backport/ui/') &&
|
|
!startsWith(github.head_ref, 'docs/') &&
|
|
!startsWith(github.head_ref, 'backport/docs/') &&
|
|
!contains(github.event.pull_request.labels.*.name, 'docs')
|
|
needs:
|
|
- setup
|
|
uses: ./.github/workflows/test-go.yml
|
|
with:
|
|
total-runners: 16
|
|
env-vars: |
|
|
{
|
|
"GOEXPERIMENT": "boringcrypto"
|
|
}
|
|
go-arch: amd64
|
|
go-tags: '${{ needs.setup.outputs.go-tags }},deadlock,cgo,fips,fips_140_2'
|
|
runs-on: ${{ needs.setup.outputs.compute-larger }}
|
|
enterprise: ${{ needs.setup.outputs.enterprise }}
|
|
name: "fips"
|
|
secrets: inherit
|
|
|
|
test-ui:
|
|
name: Test UI
|
|
# The test-ui job is only run on:
|
|
# - pushes to main and branches starting with "release/"
|
|
# - PRs where the branch starts with "ui/", "backport/ui/", "merge", or when base branch starts with "release/"
|
|
# - PRs with the "ui" label on GitHub
|
|
if: |
|
|
github.ref_name == 'main' ||
|
|
startsWith(github.ref_name, 'release/') ||
|
|
startsWith(github.head_ref, 'ui/') ||
|
|
startsWith(github.head_ref, 'backport/ui/') ||
|
|
startsWith(github.head_ref, 'merge') ||
|
|
contains(github.event.pull_request.labels.*.name, 'ui')
|
|
needs:
|
|
- setup
|
|
permissions:
|
|
id-token: write
|
|
contents: read
|
|
runs-on: ${{ fromJSON(needs.setup.outputs.compute-larger) }}
|
|
steps:
|
|
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
|
|
- uses: ./.github/actions/set-up-go
|
|
with:
|
|
github-token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
|
|
# Setup node.js without caching to allow running npm install -g yarn (next step)
|
|
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
|
|
with:
|
|
node-version-file: './ui/package.json'
|
|
- id: install-yarn
|
|
run: |
|
|
npm install -g yarn
|
|
# Setup node.js with caching using the yarn.lock file
|
|
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
|
|
with:
|
|
node-version-file: './ui/package.json'
|
|
cache: yarn
|
|
cache-dependency-path: ui/yarn.lock
|
|
- id: install-browser
|
|
uses: browser-actions/setup-chrome@c485fa3bab6be59dce18dbc18ef6ab7cbc8ff5f1 # v1.2.0
|
|
- id: ui-dependencies
|
|
name: ui-dependencies
|
|
working-directory: ./ui
|
|
run: |
|
|
yarn install --frozen-lockfile
|
|
npm rebuild node-sass
|
|
- id: vault-auth
|
|
name: Authenticate to Vault
|
|
if: github.repository == 'hashicorp/vault-enterprise'
|
|
run: vault-auth
|
|
- id: secrets
|
|
name: Fetch secrets
|
|
if: github.repository == 'hashicorp/vault-enterprise'
|
|
uses: hashicorp/vault-action@130d1f5f4fe645bb6c83e4225c04d64cfb62de6e
|
|
with:
|
|
url: ${{ steps.vault-auth.outputs.addr }}
|
|
caCertificate: ${{ steps.vault-auth.outputs.ca_certificate }}
|
|
token: ${{ steps.vault-auth.outputs.token }}
|
|
secrets: |
|
|
kv/data/github/hashicorp/vault-enterprise/github-token token | PRIVATE_REPO_GITHUB_TOKEN;
|
|
kv/data/github/hashicorp/vault-enterprise/license license_1 | VAULT_LICENSE;
|
|
- id: setup-git
|
|
name: Setup Git
|
|
if: github.repository == 'hashicorp/vault-enterprise'
|
|
run: |
|
|
git config --global url."https://${{ steps.secrets.outputs.PRIVATE_REPO_GITHUB_TOKEN }}@github.com".insteadOf https://github.com
|
|
- id: build-go-dev
|
|
name: build-go-dev
|
|
run: |
|
|
rm -rf ./pkg
|
|
mkdir ./pkg
|
|
|
|
make ci-bootstrap dev
|
|
- id: test-ui
|
|
name: test-ui
|
|
env:
|
|
VAULT_LICENSE: ${{ steps.secrets.outputs.VAULT_LICENSE }}
|
|
run: |
|
|
export PATH="${PWD}/bin:${PATH}"
|
|
|
|
if [ "${{ github.repository }}" == 'hashicorp/vault' ] ; then
|
|
export VAULT_LICENSE="${{ secrets.VAULT_LICENSE }}"
|
|
fi
|
|
|
|
# Run Ember tests
|
|
cd ui
|
|
mkdir -p test-results/qunit
|
|
yarn test:oss
|
|
- uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
|
|
with:
|
|
name: test-results-ui
|
|
path: ui/test-results
|
|
if: success() || failure()
|
|
- uses: test-summary/action@62bc5c68de2a6a0d02039763b8c754569df99e3f # TSCCR: no entry for repository "test-summary/action"
|
|
with:
|
|
paths: "ui/test-results/qunit/results.xml"
|
|
show: "fail"
|
|
if: always()
|
|
|
|
tests-completed:
|
|
needs:
|
|
- setup
|
|
- test-go
|
|
- test-ui
|
|
if: always()
|
|
runs-on: ${{ fromJSON(needs.setup.outputs.compute-tiny) }}
|
|
steps:
|
|
- run: |
|
|
tr -d '\n' <<< '${{ toJSON(needs.*.result) }}' | grep -q -v -E '(failure|cancelled)'
|
|
|
|
notify-tests-completed-failures-oss:
|
|
if: ${{ always() && github.repository == 'hashicorp/vault' && needs.tests-completed.result == 'failure' && (github.ref_name == 'main' || startsWith(github.ref_name, 'release/')) }}
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
id-token: write
|
|
contents: read
|
|
strategy:
|
|
fail-fast: false
|
|
needs:
|
|
- tests-completed
|
|
steps:
|
|
- name: send-notification
|
|
uses: slackapi/slack-github-action@e28cf165c92ffef168d23c5c9000cffc8a25e117 # v1.24.0
|
|
# We intentionally aren't using the following here since it's from an internal repo
|
|
# uses: hashicorp/cloud-gha-slack-notifier@730a033037b8e603adf99ebd3085f0fdfe75e2f4 #v1
|
|
env:
|
|
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
|
|
with:
|
|
channel-id: "C05AABYEA9Y" # sent to #feed-vault-ci-official
|
|
payload: |
|
|
{"text":"OSS test failures on ${{ github.ref_name }}","blocks":[{"type":"header","text":{"type":"plain_text","text":":rotating_light: OSS test failures :rotating_light:","emoji":true}},{"type":"divider"},{"type":"section","text":{"type":"mrkdwn","text":"test(s) failed on ${{ github.ref_name }}"},"accessory":{"type":"button","text":{"type":"plain_text","text":"View Failing Workflow","emoji":true},"url":"${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}}]}
|
|
|
|
notify-tests-completed-failures-ent:
|
|
if: ${{ always() && github.repository == 'hashicorp/vault-enterprise' && needs.tests-completed.result == 'failure' && (github.ref_name == 'main' || startsWith(github.ref_name, 'release/')) }}
|
|
runs-on: ['self-hosted', 'linux', 'small']
|
|
permissions:
|
|
id-token: write
|
|
contents: read
|
|
strategy:
|
|
fail-fast: false
|
|
needs:
|
|
- tests-completed
|
|
steps:
|
|
- id: vault-auth
|
|
name: Vault Authenticate
|
|
run: vault-auth
|
|
- id: secrets
|
|
name: Fetch Vault Secrets
|
|
uses: hashicorp/vault-action@130d1f5f4fe645bb6c83e4225c04d64cfb62de6e
|
|
with:
|
|
url: ${{ steps.vault-auth.outputs.addr }}
|
|
caCertificate: ${{ steps.vault-auth.outputs.ca_certificate }}
|
|
token: ${{ steps.vault-auth.outputs.token }}
|
|
secrets: |
|
|
kv/data/github/${{ github.repository }}/github_actions_notifications_bot token | SLACK_BOT_TOKEN;
|
|
- name: send-notification
|
|
uses: hashicorp/cloud-gha-slack-notifier@730a033037b8e603adf99ebd3085f0fdfe75e2f4 #v1
|
|
with:
|
|
channel-id: "C05AABYEA9Y" # sent to #feed-vault-ci-official
|
|
slack-bot-token: ${{ steps.secrets.outputs.SLACK_BOT_TOKEN }}
|
|
payload: |
|
|
{"text":"Enterprise test failures on ${{ github.ref_name }}","blocks":[{"type":"header","text":{"type":"plain_text","text":":rotating_light: Enterprise test failures :rotating_light:","emoji":true}},{"type":"divider"},{"type":"section","text":{"type":"mrkdwn","text":"test(s) failed on ${{ github.ref_name }}"},"accessory":{"type":"button","text":{"type":"plain_text","text":"View Failing Workflow","emoji":true},"url":"${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}}]}
|
|
|
|
test-summary:
|
|
name: Go test failures
|
|
runs-on: ubuntu-latest
|
|
if: |
|
|
always() &&
|
|
(needs.test-go.result == 'success' ||
|
|
needs.test-go.result == 'failure' ||
|
|
needs.test-go-fips.result == 'success' ||
|
|
needs.test-go-fips.result == 'failure' ||
|
|
needs.test-go-race.result == 'success' ||
|
|
needs.test-go-race.result == 'failure')
|
|
needs:
|
|
- test-go
|
|
- test-go-fips
|
|
- test-go-race
|
|
steps:
|
|
- name: Download failure summary
|
|
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
|
|
with:
|
|
name: failure-summary
|
|
- name: Prepare failure summary
|
|
run: |
|
|
# Sort all of the summary table rows and push them to a temp file.
|
|
temp_file_name=temp-$(date +%s)
|
|
cat failure-summary-*.md | sort >> "$temp_file_name"
|
|
|
|
# If there are test failures, present them in a format of a GitHub Markdown table.
|
|
if [ -s "$temp_file_name" ]; then
|
|
# shellcheck disable=SC2129
|
|
# Here we create the headings for the summary table
|
|
echo "| Test Type | Package | Test | Elapsed | Runner Index | Logs |" >> "$GITHUB_STEP_SUMMARY"
|
|
echo "| --------- | ------- | ---- | ------- | ------------ | ---- |" >> "$GITHUB_STEP_SUMMARY"
|
|
# shellcheck disable=SC2002
|
|
cat "$temp_file_name" >> "$GITHUB_STEP_SUMMARY"
|
|
else
|
|
echo "### All Go tests passed! :white_check_mark:" >> "$GITHUB_STEP_SUMMARY"
|
|
fi
|
|
|
|
# the random EOF is needed for a multiline environment variable
|
|
EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
|
|
# shellcheck disable=SC2129
|
|
echo "TABLE_TEST_RESULTS<<$EOF" >> "$GITHUB_ENV"
|
|
cat "$temp_file_name" >> "$GITHUB_ENV"
|
|
echo "$EOF" >> "$GITHUB_ENV"
|
|
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
|
|
- name: Create comment
|
|
if: github.head_ref != ''
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
RUN_ID: ${{ github.run_id }}
|
|
REPO: ${{ github.event.repository.name }}
|
|
TABLE_DATA: ${{ env.TABLE_TEST_RESULTS }}
|
|
run: ./.github/scripts/report_failed_tests.sh
|