af802275bd
This takes place in two parts, since working on this exposed an issue with response wrapping when there is a raw body set. The changes are (in diff order): * A CurrentWrappingLookupFunc has been added to return the current value. This is necessary for the lookahead call since we don't want the lookahead call to be wrapped. * Support for unwrapping < 0.6.2 tokens via the API/CLI has been removed, because we now have backends returning 404s with data and can't rely on the 404 trick. These can still be read manually via cubbyhole/response. * KV preflight version request now ensures that its calls is not wrapped, and restores any given function after. * When responding with a raw body, instead of always base64-decoding a string value and erroring on failure, on failure we assume that it simply wasn't a base64-encoded value and use it as is. * A test that fails on master and works now that ensures that raw body responses that are wrapped and then unwrapped return the expected values. * A flag for response data that indicates to the wrapping handling that the data contained therein is already JSON decoded (more later). * RespondWithStatusCode now defaults to a string so that the value is HMAC'd during audit. The function always JSON encodes the body, so before now it was always returning []byte which would skip HMACing. We don't know what's in the data, so this is a "better safe than sorry" issue. If different behavior is needed, backends can always manually populate the data instead of relying on the helper function. * We now check unwrapped data after unwrapping to see if there were raw flags. If so, we try to detect whether the value can be unbase64'd. The reason is that if it can it was probably originally a []byte and shouldn't be audit HMAC'd; if not, it was probably originally a string and should be. In either case, we then set the value as the raw body and hit the flag indicating that it's already been JSON decoded so not to try again before auditing. Doing it this way ensures the right typing. * There is now a check to see if the data coming from unwrapping is already JSON decoded and if so the decoding is skipped before setting the audit response. |
||
|---|---|---|
| .. | ||
| auth_token_test.go | ||
| cors.go | ||
| forwarded_for_test.go | ||
| forwarding_test.go | ||
| handler.go | ||
| handler_test.go | ||
| help.go | ||
| help_test.go | ||
| http_test.go | ||
| logical.go | ||
| logical_test.go | ||
| plugin_test.go | ||
| stub_assets.go | ||
| sys_audit_test.go | ||
| sys_auth_test.go | ||
| sys_config_cors_test.go | ||
| sys_generate_root.go | ||
| sys_generate_root_test.go | ||
| sys_health.go | ||
| sys_health_test.go | ||
| sys_init.go | ||
| sys_init_test.go | ||
| sys_internal_test.go | ||
| sys_leader.go | ||
| sys_leader_test.go | ||
| sys_lease_test.go | ||
| sys_mount_test.go | ||
| sys_mounts_test.go | ||
| sys_policy_test.go | ||
| sys_rekey.go | ||
| sys_rekey_test.go | ||
| sys_rotate_test.go | ||
| sys_seal.go | ||
| sys_seal_test.go | ||
| sys_wrapping_test.go | ||
| testing.go | ||
| unwrapping_raw_body_test.go | ||