60732577f5
* Use Colored UI if stdout is a tty * Add format options to operator unseal * Add format test on operator unseal * Add -no-color output flag, and use BasicUi if no-color flag is provided * Move seal status formatting logic to OutputSealStatus * Apply no-color to warnings from DeprecatedCommands as well * Add OutputWithFormat to support arbitrary data, add format option to auth list * Add ability to output arbitrary list data on TableFormatter * Clear up switch logic on format * Add format option for list-related commands * Add format option to rest of commands that returns a client API response * Remove initOutputYAML and initOutputJSON, and use OutputWithFormat instead * Remove outputAsYAML and outputAsJSON, and use OutputWithFormat instead * Remove -no-color flag, use env var exclusively to toggle colored output * Fix compile * Remove -no-color flag in main.go * Add missing FlagSetOutputFormat * Fix generate-root/decode test * Migrate init functions to main.go * Add no-color flag back as hidden * Handle non-supported data types for TableFormatter.OutputList * Pull formatting much further up to remove the need to use c.flagFormat (#3950) * Pull formatting much further up to remove the need to use c.flagFormat Also remove OutputWithFormat as the logic can cause issues. * Use const for env var * Minor updates * Remove unnecessary check * Fix SSH output and some tests * Fix tests * Make race detector not run on generate root since it kills Travis these days * Update docs * Update docs * Address review feedback * Handle --format as well as -format
161 lines
3.2 KiB
Go
161 lines
3.2 KiB
Go
package command
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/vault/api"
|
|
"github.com/mitchellh/cli"
|
|
)
|
|
|
|
func testUnwrapCommand(tb testing.TB) (*cli.MockUi, *UnwrapCommand) {
|
|
tb.Helper()
|
|
|
|
ui := cli.NewMockUi()
|
|
return ui, &UnwrapCommand{
|
|
BaseCommand: &BaseCommand{
|
|
UI: ui,
|
|
},
|
|
}
|
|
}
|
|
|
|
func testUnwrapWrappedToken(tb testing.TB, client *api.Client, data map[string]interface{}) string {
|
|
tb.Helper()
|
|
|
|
wrapped, err := client.Logical().Write("sys/wrapping/wrap", data)
|
|
if err != nil {
|
|
tb.Fatal(err)
|
|
}
|
|
if wrapped == nil || wrapped.WrapInfo == nil || wrapped.WrapInfo.Token == "" {
|
|
tb.Fatalf("missing wrap info: %v", wrapped)
|
|
}
|
|
return wrapped.WrapInfo.Token
|
|
}
|
|
|
|
func TestUnwrapCommand_Run(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
name string
|
|
args []string
|
|
out string
|
|
code int
|
|
}{
|
|
{
|
|
"too_many_args",
|
|
[]string{"foo", "bar"},
|
|
"Too many arguments",
|
|
1,
|
|
},
|
|
{
|
|
"default",
|
|
nil, // Token comes in the test func
|
|
"bar",
|
|
0,
|
|
},
|
|
{
|
|
"field",
|
|
[]string{"-field", "foo"},
|
|
"bar",
|
|
0,
|
|
},
|
|
{
|
|
"field_not_found",
|
|
[]string{"-field", "not-a-real-field"},
|
|
"not present in secret",
|
|
1,
|
|
},
|
|
}
|
|
|
|
t.Run("validations", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, tc := range cases {
|
|
tc := tc
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, closer := testVaultServer(t)
|
|
defer closer()
|
|
|
|
wrappedToken := testUnwrapWrappedToken(t, client, map[string]interface{}{
|
|
"foo": "bar",
|
|
})
|
|
|
|
ui, cmd := testUnwrapCommand(t)
|
|
cmd.client = client
|
|
|
|
tc.args = append(tc.args, wrappedToken)
|
|
code := cmd.Run(tc.args)
|
|
if code != tc.code {
|
|
t.Errorf("expected %d to be %d", code, tc.code)
|
|
}
|
|
|
|
combined := ui.OutputWriter.String() + ui.ErrorWriter.String()
|
|
if !strings.Contains(combined, tc.out) {
|
|
t.Errorf("expected %q to contain %q", combined, tc.out)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
|
|
t.Run("communication_failure", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, closer := testVaultServerBad(t)
|
|
defer closer()
|
|
|
|
ui, cmd := testUnwrapCommand(t)
|
|
cmd.client = client
|
|
|
|
code := cmd.Run([]string{
|
|
"foo",
|
|
})
|
|
if exp := 2; code != exp {
|
|
t.Errorf("expected %d to be %d", code, exp)
|
|
}
|
|
|
|
expected := "Error unwrapping: "
|
|
combined := ui.OutputWriter.String() + ui.ErrorWriter.String()
|
|
if !strings.Contains(combined, expected) {
|
|
t.Errorf("expected %q to contain %q", combined, expected)
|
|
}
|
|
})
|
|
|
|
// This test needs its own client and server because it modifies the client
|
|
// to the wrapping token
|
|
t.Run("local_token", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, closer := testVaultServer(t)
|
|
defer closer()
|
|
|
|
wrappedToken := testUnwrapWrappedToken(t, client, map[string]interface{}{
|
|
"foo": "bar",
|
|
})
|
|
|
|
ui, cmd := testUnwrapCommand(t)
|
|
cmd.client = client
|
|
cmd.client.SetToken(wrappedToken)
|
|
|
|
// Intentionally don't pass the token here - it shoudl use the local token
|
|
code := cmd.Run([]string{})
|
|
if exp := 0; code != exp {
|
|
t.Errorf("expected %d to be %d", code, exp)
|
|
}
|
|
|
|
combined := ui.OutputWriter.String() + ui.ErrorWriter.String()
|
|
if !strings.Contains(combined, "bar") {
|
|
t.Errorf("expected %q to contain %q", combined, "bar")
|
|
}
|
|
})
|
|
|
|
t.Run("no_tabs", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
_, cmd := testUnwrapCommand(t)
|
|
assertNoTabs(t, cmd)
|
|
})
|
|
}
|