be632db682
* runs ember-cli-update to 4.4.0 * updates yarn.lock * updates dependencies causing runtime errors (#17135) * Inject Store Service When Accessed Implicitly (#17345) * adds codemod for injecting store service * adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms * updates inject-store-service codemod to only look for .extend object expressions and adds recast options * runs inject-store-service codemod on js files * replace query-params helper with hash (#17404) * Updates/removes dependencies throwing errors in Ember 4.4 (#17396) * updates ember-responsive to latest * updates ember-composable-helpers to latest and uses includes helper since contains was removed * updates ember-concurrency to latest * updates ember-cli-clipboard to latest * temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo * adds missing store injection to auth configure route * fixes issue with string-list component throwing error for accessing prop in same computation * fixes non-iterable query params issue in mfa methods controller * refactors field-to-attrs to handle belongsTo rather than fragments * converts mount-config fragment to belongsTo on auth-method model * removes ember-api-actions and adds tune method to auth-method adapter * converts cluster replication attributes from fragment to relationship * updates ember-data, removes ember-data-fragments and updates yarn to latest * removes fragments from secret-engine model * removes fragment from test-form-model * removes commented out code * minor change to inject-store-service codemod and runs again on js files * Remove LinkTo positional params (#17421) * updates ember-cli-page-object to latest version * update toolbar-link to support link-to args and not positional params * adds replace arg to toolbar-link component * Clean up js lint errors (#17426) * replaces assert.equal to assert.strictEqual * update eslint no-console to error and disables invididual intended uses of console * cleans up hbs lint warnings (#17432) * Upgrade bug and test fixes (#17500) * updates inject-service codemod to take arg for service name and runs for flashMessages service * fixes hbs lint error after merging main * fixes flash messages * updates more deps * bug fixes * test fixes * updates ember-cli-content-security-policy and prevents default form submission throwing errors * more bug and test fixes * removes commented out code * fixes issue with code-mirror modifier sending change event on setup causing same computation error * Upgrade Clean Up (#17543) * updates deprecation workflow and filter * cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest * fixes control groups test that was skipped after upgrade * updates control group service tests * addresses review feedback * updates control group service handleError method to use router.currentURL rather that transition.intent.url * adds changelog entry
251 lines
8.3 KiB
JavaScript
251 lines
8.3 KiB
JavaScript
import { set } from '@ember/object';
|
|
import Service from '@ember/service';
|
|
import { module, test } from 'qunit';
|
|
import { setupTest } from 'ember-qunit';
|
|
import sinon from 'sinon';
|
|
|
|
import { storageKey, CONTROL_GROUP_PREFIX, TOKEN_SEPARATOR } from 'vault/services/control-group';
|
|
|
|
let versionStub = Service.extend();
|
|
|
|
function storage() {
|
|
return {
|
|
items: {},
|
|
getItem(key) {
|
|
var item = this.items[key];
|
|
return item && JSON.parse(item);
|
|
},
|
|
|
|
setItem(key, val) {
|
|
return (this.items[key] = JSON.stringify(val));
|
|
},
|
|
|
|
removeItem(key) {
|
|
delete this.items[key];
|
|
},
|
|
|
|
keys() {
|
|
return Object.keys(this.items);
|
|
},
|
|
};
|
|
}
|
|
|
|
module('Unit | Service | control group', function (hooks) {
|
|
setupTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
this.owner.register('service:version', versionStub);
|
|
this.version = this.owner.lookup('service:version');
|
|
this.router = this.owner.lookup('service:router');
|
|
this.router.reopen({
|
|
transitionTo: sinon.stub(),
|
|
urlFor: sinon.stub().returns('/ui/vault/foo'),
|
|
currentURL: '/vault/secrets/kv/show/foo',
|
|
});
|
|
});
|
|
|
|
hooks.afterEach(function () {});
|
|
|
|
let isOSS = (context) => set(context, 'version.isOSS', true);
|
|
let isEnt = (context) => set(context, 'version.isOSS', false);
|
|
let resolvesArgs = (assert, result, expectedArgs) => {
|
|
return result.then((...args) => {
|
|
return assert.deepEqual(args, expectedArgs, 'resolves with the passed args');
|
|
});
|
|
};
|
|
|
|
[
|
|
[
|
|
'it resolves isOSS:true, wrapTTL: true, response: has wrap_info',
|
|
isOSS,
|
|
[[{ one: 'two', three: 'four' }], { wrap_info: { token: 'foo', accessor: 'bar' } }, true],
|
|
(assert, result) => resolvesArgs(assert, result, [{ one: 'two', three: 'four' }]),
|
|
],
|
|
[
|
|
'it resolves isOSS:true, wrapTTL: false, response: has no wrap_info',
|
|
isOSS,
|
|
[[{ one: 'two', three: 'four' }], { wrap_info: null }, false],
|
|
(assert, result) => resolvesArgs(assert, result, [{ one: 'two', three: 'four' }]),
|
|
],
|
|
[
|
|
'it resolves isOSS: false and wrapTTL:true response: has wrap_info',
|
|
isEnt,
|
|
[[{ one: 'two', three: 'four' }], { wrap_info: { token: 'foo', accessor: 'bar' } }, true],
|
|
(assert, result) => resolvesArgs(assert, result, [{ one: 'two', three: 'four' }]),
|
|
],
|
|
[
|
|
'it resolves isOSS: false and wrapTTL:false response: has no wrap_info',
|
|
isEnt,
|
|
[[{ one: 'two', three: 'four' }], { wrap_info: null }, false],
|
|
(assert, result) => resolvesArgs(assert, result, [{ one: 'two', three: 'four' }]),
|
|
],
|
|
[
|
|
'it rejects isOSS: false, wrapTTL:false, response: has wrap_info',
|
|
isEnt,
|
|
[
|
|
[{ one: 'two', three: 'four' }],
|
|
{ foo: 'bar', wrap_info: { token: 'secret', accessor: 'lookup' } },
|
|
false,
|
|
],
|
|
(assert, result) => {
|
|
// ensure failure if we ever don't reject
|
|
assert.expect(2);
|
|
|
|
return result.then(
|
|
() => {},
|
|
(err) => {
|
|
assert.strictEqual(err.token, 'secret');
|
|
assert.strictEqual(err.accessor, 'lookup');
|
|
}
|
|
);
|
|
},
|
|
],
|
|
].forEach(function ([name, setup, args, expectation]) {
|
|
test(`checkForControlGroup: ${name}`, function (assert) {
|
|
const assertCount = name === 'it rejects isOSS: false, wrapTTL:false, response: has wrap_info' ? 2 : 1;
|
|
assert.expect(assertCount);
|
|
if (setup) {
|
|
setup(this);
|
|
}
|
|
let service = this.owner.lookup('service:control-group');
|
|
let result = service.checkForControlGroup(...args);
|
|
return expectation(assert, result);
|
|
});
|
|
});
|
|
|
|
test(`handleError: transitions to accessor and stores control group token`, function (assert) {
|
|
const error = {
|
|
accessor: '12345',
|
|
token: 'token',
|
|
creation_path: 'kv/',
|
|
creation_time: new Date().toISOString(),
|
|
ttl: 400,
|
|
};
|
|
const expected = { ...error, uiParams: { url: '/vault/secrets/kv/show/foo' } };
|
|
const service = this.owner.factoryFor('service:control-group').create({
|
|
storeControlGroupToken: sinon.spy(),
|
|
});
|
|
service.handleError(error);
|
|
assert.ok(service.storeControlGroupToken.calledWith(expected), 'calls storeControlGroupToken');
|
|
assert.ok(
|
|
this.router.transitionTo.calledWith('vault.cluster.access.control-group-accessor', '12345'),
|
|
'calls router transitionTo'
|
|
);
|
|
});
|
|
|
|
test(`logFromError: returns correct content string`, function (assert) {
|
|
let error = {
|
|
accessor: '12345',
|
|
token: 'token',
|
|
creation_path: 'kv/',
|
|
creation_time: new Date().toISOString(),
|
|
ttl: 400,
|
|
};
|
|
let service = this.owner.factoryFor('service:control-group').create({
|
|
storeControlGroupToken: sinon.spy(),
|
|
});
|
|
let contentString = service.logFromError(error);
|
|
assert.ok(
|
|
this.router.urlFor.calledWith('vault.cluster.access.control-group-accessor', '12345'),
|
|
'calls urlFor with accessor'
|
|
);
|
|
assert.ok(service.storeControlGroupToken.calledWith(error), 'calls storeControlGroupToken');
|
|
assert.ok(contentString.content.includes('12345'), 'contains accessor');
|
|
assert.ok(contentString.content.includes('kv/'), 'contains creation path');
|
|
assert.ok(contentString.content.includes('token'), 'contains token');
|
|
});
|
|
|
|
test('storageKey', function (assert) {
|
|
let accessor = '12345';
|
|
let path = 'kv/foo/bar';
|
|
let expectedKey = `${CONTROL_GROUP_PREFIX}${accessor}${TOKEN_SEPARATOR}${path}`;
|
|
assert.strictEqual(storageKey(accessor, path), expectedKey, 'uses expected key');
|
|
});
|
|
|
|
test('keyFromAccessor', function (assert) {
|
|
let store = storage();
|
|
let accessor = '12345';
|
|
let path = 'kv/foo/bar';
|
|
let data = { foo: 'bar' };
|
|
let expectedKey = `${CONTROL_GROUP_PREFIX}${accessor}${TOKEN_SEPARATOR}${path}`;
|
|
let subject = this.owner.factoryFor('service:control-group').create({
|
|
storage() {
|
|
return store;
|
|
},
|
|
});
|
|
|
|
store.setItem(expectedKey, data);
|
|
store.setItem(`${CONTROL_GROUP_PREFIX}2345${TOKEN_SEPARATOR}${path}`, 'ok');
|
|
|
|
assert.strictEqual(subject.keyFromAccessor(accessor), expectedKey, 'finds key given the accessor');
|
|
assert.strictEqual(subject.keyFromAccessor('foo'), null, 'returns null if no key was found');
|
|
});
|
|
|
|
test('storeControlGroupToken', function (assert) {
|
|
let store = storage();
|
|
let subject = this.owner.factoryFor('service:control-group').create({
|
|
storage() {
|
|
return store;
|
|
},
|
|
});
|
|
let info = {
|
|
accessor: '12345',
|
|
creation_path: 'foo/',
|
|
creation_time: new Date().toISOString(),
|
|
ttl: 300,
|
|
};
|
|
let key = `${CONTROL_GROUP_PREFIX}${info.accessor}${TOKEN_SEPARATOR}${info.creation_path}`;
|
|
|
|
subject.storeControlGroupToken(info);
|
|
assert.deepEqual(store.items[key], JSON.stringify(info), 'stores the whole info object');
|
|
});
|
|
|
|
test('deleteControlGroupToken', function (assert) {
|
|
let store = storage();
|
|
let subject = this.owner.factoryFor('service:control-group').create({
|
|
storage() {
|
|
return store;
|
|
},
|
|
});
|
|
let accessor = 'foo';
|
|
let path = 'kv/one';
|
|
|
|
let expectedKey = `${CONTROL_GROUP_PREFIX}${accessor}${TOKEN_SEPARATOR}${path}`;
|
|
store.setItem(expectedKey, { one: '2' });
|
|
subject.deleteControlGroupToken(accessor);
|
|
assert.strictEqual(Object.keys(store.items).length, 0, 'there are no keys stored in storage');
|
|
});
|
|
|
|
test('deleteTokens', function (assert) {
|
|
let store = storage();
|
|
let subject = this.owner.factoryFor('service:control-group').create({
|
|
storage() {
|
|
return store;
|
|
},
|
|
});
|
|
|
|
let keyOne = `${CONTROL_GROUP_PREFIX}foo`;
|
|
let keyTwo = `${CONTROL_GROUP_PREFIX}bar`;
|
|
store.setItem(keyOne, { one: '2' });
|
|
store.setItem(keyTwo, { two: '2' });
|
|
store.setItem('value', 'one');
|
|
assert.strictEqual(Object.keys(store.items).length, 3, 'stores 3 values');
|
|
subject.deleteTokens();
|
|
assert.strictEqual(Object.keys(store.items).length, 1, 'removes tokens with control group prefix');
|
|
assert.strictEqual(store.getItem('value'), 'one', 'keeps the non-prefixed value');
|
|
});
|
|
|
|
test('wrapInfoForAccessor', function (assert) {
|
|
let store = storage();
|
|
let subject = this.owner.factoryFor('service:control-group').create({
|
|
storage() {
|
|
return store;
|
|
},
|
|
});
|
|
|
|
let keyOne = `${CONTROL_GROUP_PREFIX}foo`;
|
|
store.setItem(keyOne, { one: '2' });
|
|
assert.deepEqual(subject.wrapInfoForAccessor('foo'), { one: '2' });
|
|
});
|
|
});
|