open-vault/ui
Angel Garbarino 081db3a240
Ember-cli upgrade from ~3.8 to ~3.20 (#9972)
* Update ember-cli to ~3.20

* Remove bad optional-feature

* Remove ember-fetch dep

* re-install ember-fetch

* update model fragments pr

* update ember model fragments correct package name

* update ember composable helpers to solve array helper error

* update ember-concurrency

* add back engine dependencies, automatically removed during ember-cli-upgrade

* make author-form-options component js file otherwise error

* for now comment out withTestWaiter

* add eslint-node and fix if not with unless in templates

* fix linting for tab index of false is now -1 and add type button to all buttons without types

* fix href errors for linting, likely have to come back and fix

* using eslint fix flag to fix all this.gets

* ember modules codemode removed files that had module twice, will fix in next commit

* finish codemode ember-data-codemod needed to rename const model

* more this.get removal codemode did not work

* cont. removal of this.get

* stop mixin rules until figure out how to reconfig them all

* smaller eslint ignores

* get codemode

* testing app small fixes to bring it back after all the changes

* small changes to eslint

* test removal of getProperties

* fix issue with baseKey because value could be unknown needed to add a question mark in nested get

* smaller linting fixes

* get nested fixes

* small linting error fixes

* small linting changes

* working through more small linting changes

* another round of linting modifications

* liniting fixes

* ember module codemod

* quinit dom codemod

* angle bracket codemod

* discovered that components must have js files

* ran all codemods this is all that's left

* small changes to fix get needs two object, should not have been using get.

* fix issue with one input in form field

* fun times with set and onChange from oninput

* fix issue with model not being passed through on secret-edit-display

* fix issue with yarn run test not working, revert without npm run all

* linting and small fix when loading without a selectAuthBackend

* fix failing test with ui-wizard issue

* fix test failure due to model not being asked for correctly with new changes, probably run into this more.

* fix issue with component helper and at props specific to wizard

* rename log to clilog due to conflict with new eslint rule

* small changes for test failures

* component helper at fixes

* Revert to old component style something with new one broke this and can't figure it out for now

* small fishy smelling test fixes will revisit

* small test changes

* more small test changes, appears upgrade treats spaces differently

* comment out code and test that no longer seems relevant but confirm

* clean run on component test though still some potential timing issues on ui-console test

* fixing one auth test issue and timing issue on enable-test

* small mods

* fix this conditional check from upgrade

* linting fixes after master merge

* package updates using yarn upgrade-interactive

* update libraries that did not effect any of the test failures.

* update ember truth helpers library

* settling tests

* Fix ui-panel control group output

* fix features selection test failures

* Fix auth tests (x-vault-token)

* fix shared test

* fix issue with data null on backend

* Revert "Fix auth tests (x-vault-token)"

This reverts commit 89cb174b2f1998efa56d9604d14131415ae65d6f.

* Fix auth tests (x-vault-token) without updating this.set

* Update redirect-to tests

* fix wrapped token test

* skip some flaky test

* fix issue with href and a tags vs buttons

* fix linting

* updates to get tests running (#10409)

* yarn isntall

* increasing resource_class

* whoops

* trying large

* back to xlarge

* Fix param issue on transform item routes

* test fixes

* settle on policies (old) test

* fix browserstack test warning and skips of test confirmed worked

* Fix redirect-to test

* skips

* fix transformation test and skip some kmip

* Skip tests

* Add meep marker to remaining failing tests

* Skip test with failing component

* rever skip on secret-create test

* Skip piece of test that fails due to navigation-input

* fix settings test where can and skip in others after confirming

* fix circle ci test failures

* ssh role settle

* Fix navigate-input and add settled to test

* Remove extra import

* secret cubbyhole and alicloud

* Add settled to gcpkms test

* settles on redirect to test

* Bump browserstack test resource to large

* Update browserstack resource size to xlarge

* update todos

* add back in withTestWaiter

* try and fix credentials conditional action added comment instead

* Update volatile computed properies to get functions

* this step was never reached and we never defined secretType anywhere so I removed

* add settled to policy old test

* Fix navigate-input on policies and leases

* replace ssh test with no var hoping that helps and add settled to other failing tests, unskip console tests

* kmip, transit, role test remove a skip and add in settled

* fix hover copy button, had to remove some testing functionality

* Remove private router service

* remove skip on control ssh and ui panel, fix search select by restructuring how to read the error

* final bit of working through skipped test

* Replace clearNonGlobalModels by linking directly to namespace with href-to

* Remove unused var

* Fix role-ssh id bug by updating form-field-from-model to form-field-group-loop

* Fix transit create id would not update

* Update option toggle selector for ssh-role

* Fix ssh selector

* cleanup pt1

* small clean up

* cleanup part2

* Fix computed on pricing-metrics-form

* small cleanup based on chelseas comments.

Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
Co-authored-by: Sarah Thompson <sthompson@hashicorp.com>
2020-12-03 16:00:22 -07:00
..
.storybook upgrade storybook and babel deps (#9371) 2020-07-01 16:28:16 -07:00
.yarn/releases embed yarn (#7740) 2019-10-25 16:00:45 -05:00
app Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
blueprints Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
config Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
lib Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
mirage Ui/test metrics mirage (#10341) 2020-11-09 09:41:19 -06:00
public Fix robots.txt to disallow indexing of all paths (#10150) 2020-10-14 14:55:49 -06:00
scripts Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
stories remove http-requests components and re: files (#10360) 2020-11-10 12:00:05 -07:00
tests Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
vendor UI: ember-auto-import (#4933) 2018-07-18 09:13:39 -05:00
.editorconfig Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
.ember-cli Moving UI assets to OSS 2018-04-03 09:16:57 -05:00
.env Add storybook (#6496) 2019-04-03 14:06:20 -07:00
.eslintignore Ui/transit key actions textareas (#8462) 2020-03-04 11:36:37 -06:00
.eslintrc.js Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
.gitignore UI: Redesign transit UX (#8304) 2020-02-14 11:20:44 -06:00
.nvmrc update to node v10 for all of the things (#6218) 2019-02-13 09:34:38 -05:00
.prettierrc ui: use prettier with eslint 2018-11-01 14:45:23 -07:00
.template-lintrc.js Ember update (#5386) 2018-09-25 11:28:26 -05:00
.watchmanconfig Moving UI assets to OSS 2018-04-03 09:16:57 -05:00
.yarnrc embed yarn (#7740) 2019-10-25 16:00:45 -05:00
MODULE_REPORT.md Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
README.md Ui/replication status discoverability (#8705) 2020-06-18 14:52:43 -07:00
ember-cli-build.js Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
package.json Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
testem.browserstack.js test ie11 on windows 8.1 instead of windows 10 (#7775) 2019-11-01 10:10:05 -07:00
testem.js Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00
yarn.lock Ember-cli upgrade from ~3.8 to ~3.20 (#9972) 2020-12-03 16:00:22 -07:00

README.md

Table of Contents

Vault UI

This README outlines the details of collaborating on this Ember application.

Prerequisites

You will need the following things properly installed on your computer.

* lint-staged is an optional dependency - running yarn will install it. If don't want optional dependencies installed you can run yarn --ignore-optional. If you've ignored the optional deps previously and want to install them, you have to tell yarn to refetch all deps by running yarn --force.

In order to enforce the same version of yarn across installs, the yarn binary is included in the repo in the .yarn/releases folder. To update to a different version of yarn, use the yarn policies set-version VERSION command. For more information on this, see the documentation.

Running / Development

To get all of the JavaScript dependencies installed, run this in the ui directory:

  • yarn

If you want to run Vault UI and proxy back to a Vault server running on the default port, 8200, run the following in the ui directory:

  • yarn start

This will start an Ember CLI server that proxies requests to port 8200, and enable live rebuilding of the application as you change the UI application code. Visit your app at http://localhost:4200.

If your Vault server is running on a different port you can use the long-form version of the npm script:

ember server --proxy=http://localhost:PORT

Code Generators

Make use of the many generators for code, try ember help generate for more details. If you're using a component that can be widely-used, consider making it an addon component instead (see this PR for more details)

eg. a reusable component named foo that you'd like in the core engine

  • ember g component foo --in lib/core
  • echo "export { default } from 'core/components/foo';" > lib/core/app/components/foo.js

Running Tests

Running tests will spin up a Vault dev server on port 9200 via a pretest script that testem (the test runner) executes. All of the acceptance tests then run, proxing requests back to that server.

  • yarn run test:oss
  • yarn run test:oss -s to keep the test server running after the initial run.
  • yarn run test -f="policies" to filter the tests that are run. -f gets passed into QUnit's filter config
  • yarn run test:browserstack to run the kv acceptance tests in Browserstack

Automated Cross-Browser Testing

Vault uses Browserstack Automate to run all the kv acceptance tests on various browsers. You can view the list of browsers we test by viewing testem.browserstack.js.

Running Browserstack Locally

To run the Browserstack tests locally you will need to add your BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY to your environment. Then run yarn run test:browserstack. You can view the currently running tests at localhost:7357 or log in to Browserstack Automate to view a previous build.

To run the tests locally in a browser other than IE11, swap out launch_in_ci: ['BS_IE_11'] inside testem.browserstack.js.

Linting

  • yarn lint:hbs
  • yarn lint:js
  • yarn lint:js -- --fix

Building Vault UI into a Vault Binary

We use go-bindata-assetfs to build the static assets of the Ember application into a Vault binary.

This can be done by running these commands from the root directory run: make static-dist make dev-ui

This will result in a Vault binary that has the UI built-in - though in a non-dev setup it will still need to be enabled via the ui config or setting VAULT_UI environment variable.

Vault Storybook

The Vault UI uses Storybook to catalog all of its components. Below are details for running and contributing to Storybook.

Storybook Commands at a Glance

Command Description
yarn storybook run storybook
ember generate story [name-of-component] generate a new story
ember generate story [name-of-component] -ir [name-of-engine-or-addon] generate a new story in the specified engine or addon
yarn gen-story-md [name-of-component] update a story notes file
yarn gen-story-md [name-of-component] [name-of-engine-or-addon] update a story notes file in the specified engine or addon

Writing Stories

Each component in vault/ui/app/components should have a corresponding [component-name].stories.js and [component-name].md files within vault/ui/stories. Components in the core addon located at vault/ui/lib/core/addon/components have corresponding stories and markdown files in vault/ui/lib/core/stories.

Adding a new story

  1. Make sure the component is well-documented using jsdoc. This documentation should at minimum include the module name, an example of usage, and the params passed into the handlebars template. For example, here is how we document the ToggleButton Component:
/**
 * @module ToggleButton
 * `ToggleButton` components are used to expand and collapse content with a toggle.
 *
 * @example
 * ```js
 *   <ToggleButton @openLabel="Encrypt Output with PGP" @closedLabel="Encrypt Output with PGP" @toggleTarget={{this}} @toggleAttr="showOptions"/>
 *  {{#if showOptions}}
 *     <div>
 *       <p>
 *         I will be toggled!
 *       </p>
 *     </div>
 *   {{/if}}
 * ```
 *
 * @param {String} toggleAttr=null - The attribute upon which to toggle.
 * @param {Object} attrTarget=null - The target upon which the event handler should be added.
 * @param {String} [openLabel=Hide options] - The message to display when the toggle is open. //optional params are denoted by square brackets
 * @param {String} [closedLabel=More options] - The message to display when the toggle is closed.
 */

Note that placing a param inside brackets (e.g. [closedLabel=More options] indicates it is optional and has a default value of 'More options'.)

  1. Generate a new story with ember generate story [name-of-component]
  2. Inside the newly generated stories file, add at least one example of the component. If the component should be interactive, enable the Storybook Knobs addon.
  3. Generate the notes file for the component with yarn gen-story-md [name-of-component] [name-of-engine-or-addon] (e.g. yarn gen-md alert-banner core). This will generate markdown documentation of the component and place it at vault/ui/stories/[name-of-component].md. If your component is a template-only component, you will need to manually create the markdown file.

See the Storybook Docs for more information on writing stories.

Code Generators

It is important to add all new components into Storybook and to keep the story and notes files up to date. To ease the process of creating and updating stories please use the code generators using the commands listed above.

Storybook Deployment

A Netlify integration deploys a static Storybook build for any PR on the Vault GitHub repo. A preview link will show up in the PR checks. Once items are merged, the auto-deployed integration will publish that build making it available at https://vault-storybook.netlify.com. Currently the Netlify integration will cd into the ui/ directory and then run yarn deploy:storybook so troubleshooting any issues can be done locally by running this same command. The logs for this build are public and will be linked from the PR checks.