3dfa30acb4
* Path globbing * Add glob support at the beginning * Ensure when evaluating an ACL that our path never has a leading slash. This already happens in the normal request path but not in tests; putting it here provides it for tests and extra safety in case the request path changes * Simplify the algorithm, we don't really need to validate the prefix first as glob won't apply if it doesn't * Add path segment wildcarding * Disable path globbing for now * Remove now-unneeded test * Remove commented out globbing bits * Remove more holdover glob bits * Rename k var to something more clear
472 lines
13 KiB
Go
472 lines
13 KiB
Go
package vault
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/hashicorp/errwrap"
|
|
multierror "github.com/hashicorp/go-multierror"
|
|
"github.com/hashicorp/hcl"
|
|
"github.com/hashicorp/hcl/hcl/ast"
|
|
"github.com/hashicorp/vault/helper/hclutil"
|
|
"github.com/hashicorp/vault/helper/identity"
|
|
"github.com/hashicorp/vault/helper/namespace"
|
|
"github.com/hashicorp/vault/helper/parseutil"
|
|
"github.com/mitchellh/copystructure"
|
|
)
|
|
|
|
const (
|
|
DenyCapability = "deny"
|
|
CreateCapability = "create"
|
|
ReadCapability = "read"
|
|
UpdateCapability = "update"
|
|
DeleteCapability = "delete"
|
|
ListCapability = "list"
|
|
SudoCapability = "sudo"
|
|
RootCapability = "root"
|
|
|
|
// Backwards compatibility
|
|
OldDenyPathPolicy = "deny"
|
|
OldReadPathPolicy = "read"
|
|
OldWritePathPolicy = "write"
|
|
OldSudoPathPolicy = "sudo"
|
|
)
|
|
|
|
const (
|
|
DenyCapabilityInt uint32 = 1 << iota
|
|
CreateCapabilityInt
|
|
ReadCapabilityInt
|
|
UpdateCapabilityInt
|
|
DeleteCapabilityInt
|
|
ListCapabilityInt
|
|
SudoCapabilityInt
|
|
)
|
|
|
|
type PolicyType uint32
|
|
|
|
const (
|
|
PolicyTypeACL PolicyType = iota
|
|
PolicyTypeRGP
|
|
PolicyTypeEGP
|
|
|
|
// Triggers a lookup in the map to figure out if ACL or RGP
|
|
PolicyTypeToken
|
|
)
|
|
|
|
func (p PolicyType) String() string {
|
|
switch p {
|
|
case PolicyTypeACL:
|
|
return "acl"
|
|
case PolicyTypeRGP:
|
|
return "rgp"
|
|
case PolicyTypeEGP:
|
|
return "egp"
|
|
}
|
|
|
|
return ""
|
|
}
|
|
|
|
var (
|
|
cap2Int = map[string]uint32{
|
|
DenyCapability: DenyCapabilityInt,
|
|
CreateCapability: CreateCapabilityInt,
|
|
ReadCapability: ReadCapabilityInt,
|
|
UpdateCapability: UpdateCapabilityInt,
|
|
DeleteCapability: DeleteCapabilityInt,
|
|
ListCapability: ListCapabilityInt,
|
|
SudoCapability: SudoCapabilityInt,
|
|
}
|
|
)
|
|
|
|
type egpPath struct {
|
|
Path string `json:"path"`
|
|
Glob bool `json:"glob"`
|
|
}
|
|
|
|
// Policy is used to represent the policy specified by an ACL configuration.
|
|
type Policy struct {
|
|
sentinelPolicy
|
|
Name string `hcl:"name"`
|
|
Paths []*PathRules `hcl:"-"`
|
|
Raw string
|
|
Type PolicyType
|
|
Templated bool
|
|
namespace *namespace.Namespace
|
|
}
|
|
|
|
// ShallowClone returns a shallow clone of the policy. This should not be used
|
|
// if any of the reference-typed fields are going to be modified
|
|
func (p *Policy) ShallowClone() *Policy {
|
|
return &Policy{
|
|
sentinelPolicy: p.sentinelPolicy,
|
|
Name: p.Name,
|
|
Paths: p.Paths,
|
|
Raw: p.Raw,
|
|
Type: p.Type,
|
|
Templated: p.Templated,
|
|
namespace: p.namespace,
|
|
}
|
|
}
|
|
|
|
// PathRules represents a policy for a path in the namespace.
|
|
type PathRules struct {
|
|
Path string
|
|
Policy string
|
|
Permissions *ACLPermissions
|
|
IsPrefix bool
|
|
HasSegmentWildcards bool
|
|
Capabilities []string
|
|
|
|
// These keys are used at the top level to make the HCL nicer; we store in
|
|
// the ACLPermissions object though
|
|
MinWrappingTTLHCL interface{} `hcl:"min_wrapping_ttl"`
|
|
MaxWrappingTTLHCL interface{} `hcl:"max_wrapping_ttl"`
|
|
AllowedParametersHCL map[string][]interface{} `hcl:"allowed_parameters"`
|
|
DeniedParametersHCL map[string][]interface{} `hcl:"denied_parameters"`
|
|
RequiredParametersHCL []string `hcl:"required_parameters"`
|
|
MFAMethodsHCL []string `hcl:"mfa_methods"`
|
|
ControlGroupHCL *ControlGroupHCL `hcl:"control_group"`
|
|
}
|
|
|
|
type ControlGroupHCL struct {
|
|
TTL interface{} `hcl:"ttl"`
|
|
Factors map[string]*ControlGroupFactor `hcl:"factor"`
|
|
}
|
|
|
|
type ControlGroup struct {
|
|
TTL time.Duration
|
|
Factors []*ControlGroupFactor
|
|
}
|
|
|
|
type ControlGroupFactor struct {
|
|
Name string
|
|
Identity *IdentityFactor `hcl:"identity"`
|
|
}
|
|
|
|
type IdentityFactor struct {
|
|
GroupIDs []string `hcl:"group_ids"`
|
|
GroupNames []string `hcl:"group_names"`
|
|
ApprovalsRequired int `hcl:"approvals"`
|
|
}
|
|
|
|
type ACLPermissions struct {
|
|
CapabilitiesBitmap uint32
|
|
MinWrappingTTL time.Duration
|
|
MaxWrappingTTL time.Duration
|
|
AllowedParameters map[string][]interface{}
|
|
DeniedParameters map[string][]interface{}
|
|
RequiredParameters []string
|
|
MFAMethods []string
|
|
ControlGroup *ControlGroup
|
|
}
|
|
|
|
func (p *ACLPermissions) Clone() (*ACLPermissions, error) {
|
|
ret := &ACLPermissions{
|
|
CapabilitiesBitmap: p.CapabilitiesBitmap,
|
|
MinWrappingTTL: p.MinWrappingTTL,
|
|
MaxWrappingTTL: p.MaxWrappingTTL,
|
|
RequiredParameters: p.RequiredParameters[:],
|
|
}
|
|
|
|
switch {
|
|
case p.AllowedParameters == nil:
|
|
case len(p.AllowedParameters) == 0:
|
|
ret.AllowedParameters = make(map[string][]interface{})
|
|
default:
|
|
clonedAllowed, err := copystructure.Copy(p.AllowedParameters)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ret.AllowedParameters = clonedAllowed.(map[string][]interface{})
|
|
}
|
|
|
|
switch {
|
|
case p.DeniedParameters == nil:
|
|
case len(p.DeniedParameters) == 0:
|
|
ret.DeniedParameters = make(map[string][]interface{})
|
|
default:
|
|
clonedDenied, err := copystructure.Copy(p.DeniedParameters)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ret.DeniedParameters = clonedDenied.(map[string][]interface{})
|
|
}
|
|
|
|
switch {
|
|
case p.MFAMethods == nil:
|
|
case len(p.MFAMethods) == 0:
|
|
ret.MFAMethods = []string{}
|
|
default:
|
|
clonedMFAMethods, err := copystructure.Copy(p.MFAMethods)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ret.MFAMethods = clonedMFAMethods.([]string)
|
|
}
|
|
|
|
switch {
|
|
case p.ControlGroup == nil:
|
|
default:
|
|
clonedControlGroup, err := copystructure.Copy(p.ControlGroup)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ret.ControlGroup = clonedControlGroup.(*ControlGroup)
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
// ParseACLPolicy is used to parse the specified ACL rules into an
|
|
// intermediary set of policies, before being compiled into
|
|
// the ACL
|
|
func ParseACLPolicy(ns *namespace.Namespace, rules string) (*Policy, error) {
|
|
return parseACLPolicyWithTemplating(ns, rules, false, nil, nil)
|
|
}
|
|
|
|
// parseACLPolicyWithTemplating performs the actual work and checks whether we
|
|
// should perform substitutions. If performTemplating is true we know that it
|
|
// is templated so we don't check again, otherwise we check to see if it's a
|
|
// templated policy.
|
|
func parseACLPolicyWithTemplating(ns *namespace.Namespace, rules string, performTemplating bool, entity *identity.Entity, groups []*identity.Group) (*Policy, error) {
|
|
// Parse the rules
|
|
root, err := hcl.Parse(rules)
|
|
if err != nil {
|
|
return nil, errwrap.Wrapf("failed to parse policy: {{err}}", err)
|
|
}
|
|
|
|
// Top-level item should be the object list
|
|
list, ok := root.Node.(*ast.ObjectList)
|
|
if !ok {
|
|
return nil, fmt.Errorf("failed to parse policy: does not contain a root object")
|
|
}
|
|
|
|
// Check for invalid top-level keys
|
|
valid := []string{
|
|
"name",
|
|
"path",
|
|
}
|
|
if err := hclutil.CheckHCLKeys(list, valid); err != nil {
|
|
return nil, errwrap.Wrapf("failed to parse policy: {{err}}", err)
|
|
}
|
|
|
|
// Create the initial policy and store the raw text of the rules
|
|
p := Policy{
|
|
Raw: rules,
|
|
Type: PolicyTypeACL,
|
|
namespace: ns,
|
|
}
|
|
if err := hcl.DecodeObject(&p, list); err != nil {
|
|
return nil, errwrap.Wrapf("failed to parse policy: {{err}}", err)
|
|
}
|
|
|
|
if o := list.Filter("path"); len(o.Items) > 0 {
|
|
if err := parsePaths(&p, o, performTemplating, entity, groups); err != nil {
|
|
return nil, errwrap.Wrapf("failed to parse policy: {{err}}", err)
|
|
}
|
|
}
|
|
|
|
return &p, nil
|
|
}
|
|
|
|
func parsePaths(result *Policy, list *ast.ObjectList, performTemplating bool, entity *identity.Entity, groups []*identity.Group) error {
|
|
paths := make([]*PathRules, 0, len(list.Items))
|
|
for _, item := range list.Items {
|
|
key := "path"
|
|
if len(item.Keys) > 0 {
|
|
key = item.Keys[0].Token.Value().(string)
|
|
}
|
|
|
|
// Check the path
|
|
if performTemplating {
|
|
_, templated, err := identity.PopulateString(&identity.PopulateStringInput{
|
|
String: key,
|
|
Entity: entity,
|
|
Groups: groups,
|
|
Namespace: result.namespace,
|
|
})
|
|
if err != nil {
|
|
continue
|
|
}
|
|
key = templated
|
|
} else {
|
|
hasTemplating, _, err := identity.PopulateString(&identity.PopulateStringInput{
|
|
ValidityCheckOnly: true,
|
|
String: key,
|
|
})
|
|
if err != nil {
|
|
return errwrap.Wrapf("failed to validate policy templating: {{err}}", err)
|
|
}
|
|
if hasTemplating {
|
|
result.Templated = true
|
|
}
|
|
}
|
|
|
|
valid := []string{
|
|
"comment",
|
|
"policy",
|
|
"capabilities",
|
|
"allowed_parameters",
|
|
"denied_parameters",
|
|
"required_parameters",
|
|
"min_wrapping_ttl",
|
|
"max_wrapping_ttl",
|
|
"mfa_methods",
|
|
"control_group",
|
|
}
|
|
if err := hclutil.CheckHCLKeys(item.Val, valid); err != nil {
|
|
return multierror.Prefix(err, fmt.Sprintf("path %q:", key))
|
|
}
|
|
|
|
var pc PathRules
|
|
|
|
// allocate memory so that DecodeObject can initialize the ACLPermissions struct
|
|
pc.Permissions = new(ACLPermissions)
|
|
|
|
pc.Path = key
|
|
|
|
if err := hcl.DecodeObject(&pc, item.Val); err != nil {
|
|
return multierror.Prefix(err, fmt.Sprintf("path %q:", key))
|
|
}
|
|
|
|
// Strip a leading '/' as paths in Vault start after the / in the API path
|
|
if len(pc.Path) > 0 && pc.Path[0] == '/' {
|
|
pc.Path = pc.Path[1:]
|
|
}
|
|
|
|
// Ensure we are using the full request path internally
|
|
pc.Path = result.namespace.Path + pc.Path
|
|
|
|
if strings.Count(pc.Path, "/+") > 0 || strings.HasPrefix(pc.Path, "+/") {
|
|
pc.HasSegmentWildcards = true
|
|
}
|
|
|
|
if strings.HasSuffix(pc.Path, "*") {
|
|
// If there are segment wildcards, don't actually strip the
|
|
// trailing asterisk, but don't want to hit the default case
|
|
if !pc.HasSegmentWildcards {
|
|
// Strip the glob character if found
|
|
pc.Path = strings.TrimSuffix(pc.Path, "*")
|
|
pc.IsPrefix = true
|
|
}
|
|
}
|
|
|
|
// Map old-style policies into capabilities
|
|
if len(pc.Policy) > 0 {
|
|
switch pc.Policy {
|
|
case OldDenyPathPolicy:
|
|
pc.Capabilities = []string{DenyCapability}
|
|
case OldReadPathPolicy:
|
|
pc.Capabilities = append(pc.Capabilities, []string{ReadCapability, ListCapability}...)
|
|
case OldWritePathPolicy:
|
|
pc.Capabilities = append(pc.Capabilities, []string{CreateCapability, ReadCapability, UpdateCapability, DeleteCapability, ListCapability}...)
|
|
case OldSudoPathPolicy:
|
|
pc.Capabilities = append(pc.Capabilities, []string{CreateCapability, ReadCapability, UpdateCapability, DeleteCapability, ListCapability, SudoCapability}...)
|
|
default:
|
|
return fmt.Errorf("path %q: invalid policy %q", key, pc.Policy)
|
|
}
|
|
}
|
|
|
|
// Initialize the map
|
|
pc.Permissions.CapabilitiesBitmap = 0
|
|
for _, cap := range pc.Capabilities {
|
|
switch cap {
|
|
// If it's deny, don't include any other capability
|
|
case DenyCapability:
|
|
pc.Capabilities = []string{DenyCapability}
|
|
pc.Permissions.CapabilitiesBitmap = DenyCapabilityInt
|
|
goto PathFinished
|
|
case CreateCapability, ReadCapability, UpdateCapability, DeleteCapability, ListCapability, SudoCapability:
|
|
pc.Permissions.CapabilitiesBitmap |= cap2Int[cap]
|
|
default:
|
|
return fmt.Errorf("path %q: invalid capability %q", key, cap)
|
|
}
|
|
}
|
|
|
|
if pc.AllowedParametersHCL != nil {
|
|
pc.Permissions.AllowedParameters = make(map[string][]interface{}, len(pc.AllowedParametersHCL))
|
|
for key, val := range pc.AllowedParametersHCL {
|
|
pc.Permissions.AllowedParameters[strings.ToLower(key)] = val
|
|
}
|
|
}
|
|
if pc.DeniedParametersHCL != nil {
|
|
pc.Permissions.DeniedParameters = make(map[string][]interface{}, len(pc.DeniedParametersHCL))
|
|
|
|
for key, val := range pc.DeniedParametersHCL {
|
|
pc.Permissions.DeniedParameters[strings.ToLower(key)] = val
|
|
}
|
|
}
|
|
if pc.MinWrappingTTLHCL != nil {
|
|
dur, err := parseutil.ParseDurationSecond(pc.MinWrappingTTLHCL)
|
|
if err != nil {
|
|
return errwrap.Wrapf("error parsing min_wrapping_ttl: {{err}}", err)
|
|
}
|
|
pc.Permissions.MinWrappingTTL = dur
|
|
}
|
|
if pc.MaxWrappingTTLHCL != nil {
|
|
dur, err := parseutil.ParseDurationSecond(pc.MaxWrappingTTLHCL)
|
|
if err != nil {
|
|
return errwrap.Wrapf("error parsing max_wrapping_ttl: {{err}}", err)
|
|
}
|
|
pc.Permissions.MaxWrappingTTL = dur
|
|
}
|
|
if pc.MFAMethodsHCL != nil {
|
|
pc.Permissions.MFAMethods = make([]string, len(pc.MFAMethodsHCL))
|
|
for idx, item := range pc.MFAMethodsHCL {
|
|
pc.Permissions.MFAMethods[idx] = item
|
|
}
|
|
}
|
|
if pc.ControlGroupHCL != nil {
|
|
pc.Permissions.ControlGroup = new(ControlGroup)
|
|
if pc.ControlGroupHCL.TTL != nil {
|
|
dur, err := parseutil.ParseDurationSecond(pc.ControlGroupHCL.TTL)
|
|
if err != nil {
|
|
return errwrap.Wrapf("error parsing control group max ttl: {{err}}", err)
|
|
}
|
|
pc.Permissions.ControlGroup.TTL = dur
|
|
}
|
|
|
|
var factors []*ControlGroupFactor
|
|
if pc.ControlGroupHCL.Factors != nil {
|
|
for key, factor := range pc.ControlGroupHCL.Factors {
|
|
// Although we only have one factor here, we need to check to make sure there is at least
|
|
// one factor defined in this factor block.
|
|
if factor.Identity == nil {
|
|
return errors.New("no control_group factor provided")
|
|
}
|
|
|
|
if factor.Identity.ApprovalsRequired <= 0 ||
|
|
(len(factor.Identity.GroupIDs) == 0 && len(factor.Identity.GroupNames) == 0) {
|
|
return errors.New("must provide more than one identity group and approvals > 0")
|
|
}
|
|
|
|
factors = append(factors, &ControlGroupFactor{
|
|
Name: key,
|
|
Identity: factor.Identity,
|
|
})
|
|
}
|
|
}
|
|
if len(factors) == 0 {
|
|
return errors.New("no control group factors provided")
|
|
}
|
|
pc.Permissions.ControlGroup.Factors = factors
|
|
}
|
|
if pc.Permissions.MinWrappingTTL != 0 &&
|
|
pc.Permissions.MaxWrappingTTL != 0 &&
|
|
pc.Permissions.MaxWrappingTTL < pc.Permissions.MinWrappingTTL {
|
|
return errors.New("max_wrapping_ttl cannot be less than min_wrapping_ttl")
|
|
}
|
|
if len(pc.RequiredParametersHCL) > 0 {
|
|
pc.Permissions.RequiredParameters = pc.RequiredParametersHCL[:]
|
|
}
|
|
|
|
PathFinished:
|
|
paths = append(paths, &pc)
|
|
}
|
|
|
|
result.Paths = paths
|
|
return nil
|
|
}
|