7e170e7d87
* use automtls for v5 secrets/auth plugins * add automtls env guard * start backend without metadata mode * use PluginClientConfig for backend's NewPluginClient param refactor * - fix pluginutil test - do not expect plugin to be unloaded in UT - fix pluginutil tests --need new env var - use require in UT - fix lazy load test * add changelog * prioritize automtls; improve comments * user multierror; refactor pluginSet for v4 unit test * add test cases for v4 and v5 plugin versions * remove unnecessary call to AutoMTLSSupported * update comment on pluginSets * use runconfig directly in sdk newpluginclient * use automtls without metadatamode for v5 backend plugin registration * use multierror for plugin runconfig calls * remove some unnecessary code
291 lines
7.6 KiB
Go
291 lines
7.6 KiB
Go
package plugin
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/rpc"
|
|
"reflect"
|
|
"sync"
|
|
|
|
log "github.com/hashicorp/go-hclog"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
uuid "github.com/hashicorp/go-uuid"
|
|
"github.com/hashicorp/vault/sdk/framework"
|
|
"github.com/hashicorp/vault/sdk/helper/consts"
|
|
"github.com/hashicorp/vault/sdk/logical"
|
|
bplugin "github.com/hashicorp/vault/sdk/plugin"
|
|
)
|
|
|
|
var (
|
|
ErrMismatchType = fmt.Errorf("mismatch on mounted backend and plugin backend type")
|
|
ErrMismatchPaths = fmt.Errorf("mismatch on mounted backend and plugin backend special paths")
|
|
)
|
|
|
|
// Factory returns a configured plugin logical.Backend.
|
|
func Factory(ctx context.Context, conf *logical.BackendConfig) (logical.Backend, error) {
|
|
_, ok := conf.Config["plugin_name"]
|
|
if !ok {
|
|
return nil, fmt.Errorf("plugin_name not provided")
|
|
}
|
|
b, err := Backend(ctx, conf)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err := b.Setup(ctx, conf); err != nil {
|
|
return nil, err
|
|
}
|
|
return b, nil
|
|
}
|
|
|
|
// Backend returns an instance of the backend, either as a plugin if external
|
|
// or as a concrete implementation if builtin, casted as logical.Backend.
|
|
func Backend(ctx context.Context, conf *logical.BackendConfig) (*PluginBackend, error) {
|
|
var b PluginBackend
|
|
|
|
name := conf.Config["plugin_name"]
|
|
pluginType, err := consts.ParsePluginType(conf.Config["plugin_type"])
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
sys := conf.System
|
|
|
|
merr := &multierror.Error{}
|
|
// NewBackend with isMetadataMode set to false
|
|
raw, err := bplugin.NewBackend(ctx, name, pluginType, sys, conf, false, true)
|
|
if err != nil {
|
|
merr = multierror.Append(merr, err)
|
|
// NewBackend with isMetadataMode set to true
|
|
raw, err = bplugin.NewBackend(ctx, name, pluginType, sys, conf, true, false)
|
|
if err != nil {
|
|
merr = multierror.Append(merr, err)
|
|
return nil, merr
|
|
}
|
|
} else {
|
|
b.Backend = raw
|
|
b.config = conf
|
|
b.loaded = true
|
|
b.autoMTLSSupported = true
|
|
|
|
return &b, nil
|
|
}
|
|
|
|
// Setup the backend so we can inspect the SpecialPaths and Type
|
|
err = raw.Setup(ctx, conf)
|
|
if err != nil {
|
|
raw.Cleanup(ctx)
|
|
return nil, err
|
|
}
|
|
paths := raw.SpecialPaths()
|
|
btype := raw.Type()
|
|
|
|
// Cleanup meta plugin backend
|
|
raw.Cleanup(ctx)
|
|
|
|
// Initialize b.Backend with dummy backend since plugin
|
|
// backends will need to be lazy loaded.
|
|
b.Backend = &framework.Backend{
|
|
PathsSpecial: paths,
|
|
BackendType: btype,
|
|
}
|
|
|
|
b.config = conf
|
|
|
|
return &b, nil
|
|
}
|
|
|
|
// PluginBackend is a thin wrapper around plugin.BackendPluginClient
|
|
type PluginBackend struct {
|
|
Backend logical.Backend
|
|
sync.RWMutex
|
|
|
|
autoMTLSSupported bool
|
|
config *logical.BackendConfig
|
|
|
|
// Used to detect if we already reloaded
|
|
canary string
|
|
|
|
// Used to detect if plugin is set
|
|
loaded bool
|
|
}
|
|
|
|
// startBackend starts a plugin backend
|
|
func (b *PluginBackend) startBackend(ctx context.Context, storage logical.Storage) error {
|
|
pluginName := b.config.Config["plugin_name"]
|
|
pluginType, err := consts.ParsePluginType(b.config.Config["plugin_type"])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Ensure proper cleanup of the backend (i.e. call client.Kill())
|
|
b.Backend.Cleanup(ctx)
|
|
|
|
nb, err := bplugin.NewBackend(ctx, pluginName, pluginType, b.config.System, b.config, false, b.autoMTLSSupported)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = nb.Setup(ctx, b.config)
|
|
if err != nil {
|
|
nb.Cleanup(ctx)
|
|
return err
|
|
}
|
|
|
|
// If the backend has not been loaded (i.e. still in metadata mode),
|
|
// check if type and special paths still matches
|
|
if !b.loaded {
|
|
if b.Backend.Type() != nb.Type() {
|
|
nb.Cleanup(ctx)
|
|
b.Backend.Logger().Warn("failed to start plugin process", "plugin", b.config.Config["plugin_name"], "error", ErrMismatchType)
|
|
return ErrMismatchType
|
|
}
|
|
if !reflect.DeepEqual(b.Backend.SpecialPaths(), nb.SpecialPaths()) {
|
|
nb.Cleanup(ctx)
|
|
b.Backend.Logger().Warn("failed to start plugin process", "plugin", b.config.Config["plugin_name"], "error", ErrMismatchPaths)
|
|
return ErrMismatchPaths
|
|
}
|
|
}
|
|
|
|
b.Backend = nb
|
|
b.loaded = true
|
|
|
|
// call Initialize() explicitly here.
|
|
return b.Backend.Initialize(ctx, &logical.InitializationRequest{
|
|
Storage: storage,
|
|
})
|
|
}
|
|
|
|
// lazyLoad lazy-loads the backend before running a method
|
|
func (b *PluginBackend) lazyLoadBackend(ctx context.Context, storage logical.Storage, methodWrapper func() error) error {
|
|
b.RLock()
|
|
canary := b.canary
|
|
|
|
// Lazy-load backend
|
|
if !b.loaded {
|
|
// Upgrade lock
|
|
b.RUnlock()
|
|
b.Lock()
|
|
// Check once more after lock swap
|
|
if !b.loaded {
|
|
err := b.startBackend(ctx, storage)
|
|
if err != nil {
|
|
b.Unlock()
|
|
return err
|
|
}
|
|
}
|
|
b.Unlock()
|
|
b.RLock()
|
|
}
|
|
|
|
err := methodWrapper()
|
|
b.RUnlock()
|
|
|
|
// Need to compare string value for case were err comes from plugin RPC
|
|
// and is returned as plugin.BasicError type.
|
|
if err != nil &&
|
|
(err.Error() == rpc.ErrShutdown.Error() || err == bplugin.ErrPluginShutdown) {
|
|
// Reload plugin if it's an rpc.ErrShutdown
|
|
b.Lock()
|
|
if b.canary == canary {
|
|
b.Backend.Logger().Debug("reloading plugin backend", "plugin", b.config.Config["plugin_name"])
|
|
err := b.startBackend(ctx, storage)
|
|
if err != nil {
|
|
b.Unlock()
|
|
return err
|
|
}
|
|
b.canary, err = uuid.GenerateUUID()
|
|
if err != nil {
|
|
b.Unlock()
|
|
return err
|
|
}
|
|
}
|
|
b.Unlock()
|
|
|
|
// Try once more
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return methodWrapper()
|
|
}
|
|
return err
|
|
}
|
|
|
|
// HandleRequest is a thin wrapper implementation of HandleRequest that includes
|
|
// automatic plugin reload.
|
|
func (b *PluginBackend) HandleRequest(ctx context.Context, req *logical.Request) (resp *logical.Response, err error) {
|
|
err = b.lazyLoadBackend(ctx, req.Storage, func() error {
|
|
var merr error
|
|
resp, merr = b.Backend.HandleRequest(ctx, req)
|
|
return merr
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
// HandleExistenceCheck is a thin wrapper implementation of HandleExistenceCheck
|
|
// that includes automatic plugin reload.
|
|
func (b *PluginBackend) HandleExistenceCheck(ctx context.Context, req *logical.Request) (checkFound bool, exists bool, err error) {
|
|
err = b.lazyLoadBackend(ctx, req.Storage, func() error {
|
|
var merr error
|
|
checkFound, exists, merr = b.Backend.HandleExistenceCheck(ctx, req)
|
|
return merr
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
// Initialize is intentionally a no-op here, the backend will instead be
|
|
// initialized when it is lazily loaded.
|
|
func (b *PluginBackend) Initialize(ctx context.Context, req *logical.InitializationRequest) error {
|
|
return nil
|
|
}
|
|
|
|
// SpecialPaths is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) SpecialPaths() *logical.Paths {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return b.Backend.SpecialPaths()
|
|
}
|
|
|
|
// System is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) System() logical.SystemView {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return b.Backend.System()
|
|
}
|
|
|
|
// Logger is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) Logger() log.Logger {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return b.Backend.Logger()
|
|
}
|
|
|
|
// Cleanup is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) Cleanup(ctx context.Context) {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
b.Backend.Cleanup(ctx)
|
|
}
|
|
|
|
// InvalidateKey is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) InvalidateKey(ctx context.Context, key string) {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
b.Backend.InvalidateKey(ctx, key)
|
|
}
|
|
|
|
// Setup is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) Setup(ctx context.Context, config *logical.BackendConfig) error {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return b.Backend.Setup(ctx, config)
|
|
}
|
|
|
|
// Type is a thin wrapper used to ensure we grab the lock for race purposes
|
|
func (b *PluginBackend) Type() logical.BackendType {
|
|
b.RLock()
|
|
defer b.RUnlock()
|
|
return b.Backend.Type()
|
|
}
|